@fresh-editor/fresh-editor 0.3.4 → 0.3.6

package/CHANGELOG.md

@@ -1,5 +1,77 @@
 # Release Notes
 
+## 0.3.6
+
+This version includes a major internal refactoring to support multiple windows in a single Fresh process. The work will be used to add a multi-window orchestrator in a future version.
+
+### Features
+
+* **Go to line with selection** (#1764, thanks @PavelLoparev!): New action extends the selection from cursor to target line. Supports absolute and relative (`+10`) jumps.
+
+* **File explorer "follow active buffer"** (#1569, #1803, thanks @ko3n1g!): New `file_explorer.follow_active_buffer` setting (default off). When on, switching tabs expands and highlights the corresponding file without stealing focus.
+
+* **Live Diff**: Near-identical lines now render as modified lines, with new words decorated as underline (instead of two separate add/remove rows). Deletion virtual lines get gutter markers. Fixed live diff colors in `terminal` theme.
+
+* **Auto-start `vi_mode`** (#1086, reported by @jmcblane): Vi mode plugin now exposes `toggle / enable / disable` so `init.ts` can flip vi mode at startup. Add this to your `init.ts` to enable: `editor.getPluginApi("vi-mode")?.enable();`.
+
+In the future I plan to add a way for plugins to register custom config sections in the Settings UI, and then enabling vi-mode auto-start will be available through the UI.
+
+### Improvements
+
+* **openSUSE install instructions** (#1897, thanks @ilmanzo!) added to the README.
+
+* **Quick Open ranking**: Matches at the start of a path segment now beat arbitrary substring hits — `ts` surfaces `tsconfig.json` and `tsc/...` before random `.ts` files.
+
+* **Search & Replace no longer freezes** on result sets in the thousands.
+
+* **Rust code actions** (#1915): `rust-analyzer` now returns `WorkspaceEdit`-based assists like "Fill struct fields" instead of "No code actions available" — Fresh wasn't advertising the capability.
+
+* **Status-bar indicator menus**: Clicking another indicator's icon dismisses the currently-open menu instead of stacking a second one on top.
+
+* **LSP-Servers popup is extensible**: Plugins (starting with the bundled `rust-lsp`) can contribute their own rows.
+
+* **`terminal` built-in theme** (#1914): Diff backgrounds no longer collide with syntax foregrounds, so keywords on deletion lines and strings on addition lines stay readable on terminals (e.g. xfce-terminal) where each ANSI palette index renders identically for fg and bg.
+
+* **Dashboard** matches the editor background and no longer slides in.
+
+* **AppImage install script** has error handling and a `/tmp` fallback so it no longer silently fails when the target directory isn't writable.
+
+### Bug Fixes
+
+* **Crash on startup from a corrupt workspace** (#1939, reported by @zdooder): Restoring a session whose persisted split pointed at a buffer no longer in the buffer map crashed in `render.rs`. The active-buffer pointer is now validated and falls back to a live buffer if it's stale.
+
+* **Completion popup + multicursor** (#1901, reported by @dtwilliamson): Typing a word character or `Backspace` while the popup was open only edited the primary cursor — secondary cursors silently went out of sync after the first keystroke. Accepting a completion now also applies at every cursor.
+
+* **LSP indicator click** (#1941): Bugs fixed: plugin popup stacked under the built-in one; plugin popup ignored the active theme's `popup_bg`; state stayed stale after the LSP process was killed externally; "Disable LSP" didn't actually stop the running server; repeated clicks stacked further popups.
+
+* **Scrollbar theme overrides** (#1554, reported by @klonuo): User themes setting `ui.scrollbar_track_fg`, `ui.scrollbar_track_hover_fg`, or `ui.scrollbar_thumb_hover_fg` had their overrides silently dropped.
+
+* **Utility dock routing** (#1932): `Ctrl+P` → filename now opens the file in the editor area instead of inside the bottom dock when the dock has focus. The split tab-bar `□` button now maximizes the split you clicked, not the active one.
+
+* **Tab drag**: Dropping a tab onto a fresh split (e.g. a Search & Replace result row) no longer panics on the next keystroke.
+
+* **File explorer**: A directory whose `.gitignore` filters out all its contents (e.g. `build/` with `*` inside) stays visible when expanded.
+
+* **Live Diff visual-line motion**: `Down`/`Up` no longer freezes when traversing a deletion block that starts with a blank line.
+
+* **`S-Tab` plugin bindings** now register correctly (terminals deliver Shift+Tab as `BackTab`).
+
+## 0.3.5
+
+### Improvements
+
+* **Live Grep overlay polish**: Surrounding editor is now visibly dimmed; shortcut hints and the active provider moved into a toolbar row with plainer labels; match cap raised from 100 to 1000 (with a `1000+ matches` indicator); provider errors render as a disabled result entry instead of a silent "0 matches"; `ripgrep` provider renamed to `rg`.
+
+### Bug Fixes
+
+* **Live Grep on Windows returned no results**: `git grep` outputs `\r\n`; splitting on `\n` left a trailing `\r` that broke the result regex. Split on `\r?\n` instead.
+
+* **Plain `grep` provider was broken**: `--column` is a ripgrep-only flag and was being passed unconditionally. Removed.
+
+### Under the Hood
+
+* **Plugin API: `setPromptTitle` takes styled segments** (`{ text, style? }[]`) instead of a single string, so plugins control hint colouring directly instead of the renderer guessing structure from punctuation.
+
 ## 0.3.4
 
 ### Features

package/README.md

@@ -65,7 +65,8 @@ Or, pick your preferred method:
 | Windows | [winget](#windows-winget) |
 | Arch Linux | [AUR](#arch-linux-aur) |
 | Debian/Ubuntu | [.deb](#debianubuntu-deb) |
-| Fedora/RHEL | [.rpm](#fedorarhelopensuse-rpm), [Terra](https://terra.fyralabs.com/) |
+| Fedora/RHEL | [.rpm](#fedorarhel-rpm), [Terra](https://terra.fyralabs.com/) |
+| OpenSUSE | [zypper](#opensuse-zypper), [.rpm](#fedorarhel-rpm) |
 | FreeBSD | [ports / pkg](https://www.freshports.org/editors/fresh) |
 | Gentoo | [GURU](#gentoo-guru) |
 | Linux (any distro) | [AppImage](#appimage), [Flatpak](#flatpak) |
@@ -133,7 +134,7 @@ curl -sL $(curl -s https://api.github.com/repos/sinelaw/fresh/releases/latest |
 
 Or download the `.deb` file manually from the [releases page](https://github.com/sinelaw/fresh/releases).
 
-### Fedora/RHEL/openSUSE (.rpm)
+### Fedora/RHEL (.rpm)
 
 Download and install the latest release:
 
@@ -143,6 +144,12 @@ curl -sL $(curl -s https://api.github.com/repos/sinelaw/fresh/releases/latest |
 
 Or download the `.rpm` file manually from the [releases page](https://github.com/sinelaw/fresh/releases).
 
+### OpenSUSE (zypper)
+
+```bash
+zypper install fresh-editor
+```
+
 ### Gentoo ([GURU](https://wiki.gentoo.org/wiki/Project:GURU))
 
 Enable the repository as read in [Project:GURU/Information for End Users](https://wiki.gentoo.org/wiki/Project:GURU/Information_for_End_Users) then emerge the package:

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@fresh-editor/fresh-editor",
-  "version": "0.3.4",
+  "version": "0.3.6",
   "description": "A modern terminal-based text editor with plugin support",
   "repository": {
     "type": "git",

package/plugins/config-schema.json

@@ -133,7 +133,8 @@
         "width": "30%",
         "preview_tabs": true,
         "side": "left",
-        "auto_open_on_last_buffer_close": true
+        "auto_open_on_last_buffer_close": true,
+        "follow_active_buffer": false
       }
     },
     "file_browser": {
@@ -952,6 +953,11 @@
           "description": "Automatically focus the file explorer when the last buffer is\nclosed. Set to `false` for a \"blank workspace\" workflow where\nnothing opens automatically and the user explicitly invokes the\nfile explorer (e.g. via keybinding or command palette).\nDefault: true",
           "type": "boolean",
           "default": true
+        },
+        "follow_active_buffer": {
+          "description": "When the file explorer sidebar is open, automatically expand the\ntree and highlight the file that corresponds to the active buffer\nwhenever you switch tabs. Set to `true` to keep the explorer\nselection in sync with the active tab.\nDefault: false",
+          "type": "boolean",
+          "default": false
         }
       }
     },

package/plugins/dashboard.ts

@@ -201,11 +201,6 @@ type RegisteredSection = {
 let dashboardBufferId: number | null = null;
 let fetchToken = 0; // bumped each open; late fetches from a prior open no-op.
 
-// Id of the in-flight slide-in, so we can cancel it when starting a
-// new one (on content change) or when the dashboard is closed
-// mid-slide. Null once the animation settles or is cleared.
-let activeAnimationId: number | null = null;
-
 // Hash of all entries at the last paint (post-focus-highlight too —
 // it's what ultimately lands in the virtual buffer). Used to decide
 // whether setVirtualBufferContent needs to run at all: identical
@@ -213,43 +208,11 @@ let activeAnimationId: number | null = null;
 // round-trip entirely.
 let lastPaintedFullKey: string | null = null;
 
-// Hash of the entries with the clock stamp stripped. Animations only
-// fire when THIS hash changes, so the 1 Hz clock tick on the top
-// frame updates in place without re-sliding the whole dashboard.
-// Keyboard focus changes don't move this hash either (the hash is
-// taken before the focus overlay is laid on top), so Tab/Shift-Tab
-// pan the highlight without re-animating.
-let lastPaintedStructuralKey: string | null = null;
-
 // focusedIndex the last successful setVirtualBufferContent ran with.
-// Paired with the keys above so we can tell "focus moved but section
-// data is the same" (update VB for the highlight, no animation).
+// Paired with the key above so we can tell "focus moved but content
+// is the same" and still update VB for the highlight.
 let lastPaintedFocusedIndex = -1;
 
-// Matches an HH:MM:SS clock stamp. Anything shaped like that is
-// stripped from the structural hash so clock ticks don't animate.
-// The frame renderer is the only dashboard author that emits such a
-// string; if a third-party section happens to show a value in the
-// same shape, the worst case is "we don't re-animate when that
-// value changes" — acceptable noise floor.
-const CLOCK_RE = /\d\d:\d\d:\d\d/g;
-
-// Edge the slide-in enters from. Maps 1:1 to the plugin API's `from`
-// field and is resolved from config (plugins.dashboard.slide_from) on
-// each paint() so hot-reload of the setting Just Works. Defaults to
-// "right" (new content pushes in from the right, old exits left).
-type SlideFrom = "top" | "bottom" | "left" | "right";
-function resolveSlideFrom(): SlideFrom {
-    const config = editor.getConfig() as Record<string, unknown> | null;
-    const plugins = config?.plugins as Record<string, unknown> | undefined;
-    const dashCfg = plugins?.dashboard as Record<string, unknown> | undefined;
-    const raw = dashCfg?.slide_from;
-    if (raw === "top" || raw === "bottom" || raw === "left" || raw === "right") {
-        return raw;
-    }
-    return "right";
-}
-
 // Registered sections, in render order. Built-ins are registered at
 // plugin load (see the bottom of this file); third-party plugins
 // append via the exported `registerSection` API.
@@ -735,6 +698,13 @@ function paint(dims?: { width: number; height: number }) {
     const entries: TextPropertyEntry[] = [];
     for (let i = 0; i < topPad; i++) entries.push({ text: "\n" });
     for (const e of drawToEntries(drawn)) entries.push(e);
+    // Pad below the frame so the buffer covers the full viewport height.
+    // Without this, rows past the last frame line render with
+    // `editor.after_eof_bg` (a deliberate shade off from `editor.bg` to mark
+    // end-of-file in code buffers) and show up as a different-colored strip
+    // at the bottom of the dashboard.
+    const bottomPad = Math.max(0, height - topPad - frameHeight);
+    for (let i = 0; i < bottomPad; i++) entries.push({ text: "\n" });
 
     // Translate frame-relative row actions to absolute buffer rows by
     // shifting by the vertical padding we just prepended. Columns are
@@ -775,32 +745,15 @@ function paint(dims?: { width: number; height: number }) {
             ((focusedIndex % targets.length) + targets.length) % targets.length;
     }
 
-    // Two hashes, taken BEFORE the focus highlight goes on top:
-    //   fullKey      — everything including the clock. Drives the
-    //                  setVirtualBufferContent skip check, so the
-    //                  clock still redraws in place every second.
-    //   structuralKey — clock stamps stripped. Drives the animation.
-    //                  A clock tick alone does not flip this, so it
-    //                  updates silently; a real section data change
-    //                  does, and the slide fires.
+    // Taken BEFORE the focus highlight goes on top — fullKey captures
+    // everything (including the clock) that ultimately lands in the
+    // virtual buffer. Drives the setVirtualBufferContent skip check,
+    // so the clock still redraws in place every second.
     const fullKey = JSON.stringify(entries);
-    const structuralKey = fullKey.replace(CLOCK_RE, "##:##:##");
     const fullChanged = fullKey !== lastPaintedFullKey;
-    const structuralChanged = structuralKey !== lastPaintedStructuralKey;
     const focusChanged = focusedIndex !== lastPaintedFocusedIndex;
-    // A resize / viewport-shape change reshapes frame padding, dash
-    // runs, and centering, which flips the structural hash even when
-    // section data is unchanged. We repaint so the new layout takes
-    // effect but skip the slide — nothing NEW showed up, the user is
-    // just resizing a window. openDashboard clears lastPaintedW/H to
-    // -1 so the first paint after open doesn't trip this guard.
-    const dimsChanged =
-        lastPaintedW !== -1 &&
-        lastPaintedH !== -1 &&
-        (width !== lastPaintedW || height !== lastPaintedH);
-
-    // Identical render → short-circuit. Nothing to push to the
-    // buffer, nothing to animate.
+
+    // Identical render → short-circuit. Nothing to push to the buffer.
     if (!fullChanged && !focusChanged) {
         return;
     }
@@ -838,25 +791,7 @@ function paint(dims?: { width: number; height: number }) {
     lastPaintedW = width;
     lastPaintedH = height;
     lastPaintedFullKey = fullKey;
-    lastPaintedStructuralKey = structuralKey;
     lastPaintedFocusedIndex = focusedIndex;
-
-    // Structural-change-driven re-animation: fire only when the
-    // section payload actually differs AND the dashboard isn't just
-    // reshaping in place (clock tick, focus move, and resize all
-    // land here without animating). Cancel any in-flight slide
-    // first so the new one snapshots the fresh content.
-    if (structuralChanged && !dimsChanged) {
-        if (activeAnimationId !== null) {
-            editor.cancelAnimation(activeAnimationId);
-        }
-        activeAnimationId = editor.animateVirtualBuffer(bufferId, {
-            kind: "slideIn",
-            from: resolveSlideFrom(),
-            durationMs: 520,
-            delayMs: 0,
-        });
-    }
 }
 
 // Open a URL in the user's browser via the platform's "open" helper.
@@ -1613,12 +1548,8 @@ async function openDashboard() {
     }
 
     // Clear the content/focus keys and dims so the first paint after
-    // open is treated as a content change and the slide-in fires.
-    // Dim reset is needed because open is the one case where we DO
-    // want the animation despite "dims changed" (there was no prior
-    // dimension, so the change is really "buffer just appeared").
+    // open is treated as a content change.
     lastPaintedFullKey = null;
-    lastPaintedStructuralKey = null;
     lastPaintedFocusedIndex = -1;
     lastPaintedW = -1;
     lastPaintedH = -1;
@@ -1694,10 +1625,6 @@ registerHandler(
         // If the dashboard itself was closed, clear our handle so we'll
         // re-open on the next "last tab closed" event.
         if (dashboardBufferId !== null && e.buffer_id === dashboardBufferId) {
-            if (activeAnimationId !== null) {
-                editor.cancelAnimation(activeAnimationId);
-                activeAnimationId = null;
-            }
             dashboardBufferId = null;
             return;
         }
@@ -1717,10 +1644,6 @@ registerHandler(
     "dashboardOnAfterFileOpen",
     (_e: { buffer_id: number; path: string }) => {
         if (dashboardBufferId === null) return;
-        if (activeAnimationId !== null) {
-            editor.cancelAnimation(activeAnimationId);
-            activeAnimationId = null;
-        }
         editor.closeBuffer(dashboardBufferId);
         dashboardBufferId = null;
     },

package/plugins/git_grep.ts

@@ -48,8 +48,10 @@ async function searchWithGitGrep(query: string): Promise<GrepMatch[]> {
   );
 
   if (result.exit_code === 0) {
-    return parseGrepOutput(result.stdout, 100) as GrepMatch[];
+    return parseGrepOutput(result.stdout, 100, (msg) => editor.debug(msg)) as GrepMatch[];
   }
+  editor.error(`[git_grep] process exited with code ${result.exit_code}: ${result.stderr}`);
+  editor.setStatus(`git grep failed (exit ${result.exit_code})`);
   return [];
 }