@fresh-editor/fresh-editor 0.1.86 → 0.1.87

package/CHANGELOG.md

@@ -1,5 +1,24 @@
 # Release Notes
 
+## 0.1.87
+
+### Features
+
+* **Language Support**: Added LSP configurations and syntax highlighting for Zig, Java, LaTeX, Markdown, and Templ.
+* **Git File Highlighting**: Syntax highlighting for git-related files (.gitignore, .gitattributes, .gitmodules).
+* **Plugin Type Safety**: TypeScript type definitions for plugin API with compile-time validation.
+
+### Bug Fixes
+
+* **Hover Popup**: Fixed scrolling to bottom, dismiss on click outside, block clicks inside popup.
+* **Settings UI**: Fixed overwriting manual config.json edits when saving from Settings UI (#806).
+* **Windows Terminal**: Fixed truecolor detection and 256-color grayscale conversion overflow.
+* **Composite Buffers**: Fixed mouse click sync, deserialization errors, and cursor positioning.
+* **Plugin Stability**: Plugin thread panics now propagate to main thread for proper error handling.
+* **Review Diff Plugin**: Fixed side-by-side diff commands not appearing in command palette.
+
+---
+
 ## 0.1.86
 
 ### Features

package/README.md

@@ -241,6 +241,10 @@ Thanks for contributing!
 
 7. **LSP**: Ensure LSP interactions follow the correct lifecycle (e.g., `didOpen` must always precede other requests to avoid server-side errors). Use the appropriate existing helpers for this pattern.
 
+8. **Regenerate plugin types**: After modifying the plugin API, run `cargo test -p fresh-plugin-runtime write_fresh_dts_file -- --ignored`
+
+9. **Type check plugins**: Run `crates/fresh-editor/plugins/check-types.sh` (requires `tsc`)
+
 **Tip**: You can use tmux + send-keys + render-pane to script ad-hoc tests on the UI, for example when trying to reproduce an issue.
 
 ## Privacy

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@fresh-editor/fresh-editor",
-  "version": "0.1.86",
+  "version": "0.1.87",
   "description": "A modern terminal-based text editor with plugin support",
   "repository": {
     "type": "git",

package/plugins/README.md

@@ -69,3 +69,4 @@ For plugin development guides, see:
 - **API Reference:** [`docs/plugin-api.md`](../docs/plugin-api.md)
 - **Examples:** [`examples/README.md`](examples/README.md)
 - **Clangd Plugin:** [`clangd_support.md`](clangd_support.md)
+

package/plugins/audit_mode.ts

@@ -551,7 +551,7 @@ async function renderReviewStream(): Promise<{ entries: TextPropertyEntry[], hig
  * Updates the buffer UI (text and highlights) based on current state.hunks
  */
 async function updateReviewUI() {
-  if (state.reviewBufferId !== null) {
+  if (state.reviewBufferId != null) {
     const { entries, highlights } = await renderReviewStream();
     editor.setVirtualBufferContent(state.reviewBufferId, entries);
     
@@ -677,12 +677,12 @@ globalThis.on_viewport_changed = (data: any) => {
 
     const { oldSplitId, newSplitId, oldLineByteOffsets, newLineByteOffsets } = activeSideBySideState;
 
-    if (data.split_id === oldSplitId && newLineByteOffsets.length > 0) {
+    if (data.splitId === oldSplitId && newLineByteOffsets.length > 0) {
         // OLD pane scrolled - find which line it's on and sync NEW pane to same line
         const lineNum = findLineForByte(oldLineByteOffsets, data.top_byte);
         const targetByte = newLineByteOffsets[Math.min(lineNum, newLineByteOffsets.length - 1)];
         (editor as any).setSplitScroll(newSplitId, targetByte);
-    } else if (data.split_id === newSplitId && oldLineByteOffsets.length > 0) {
+    } else if (data.splitId === newSplitId && oldLineByteOffsets.length > 0) {
         // NEW pane scrolled - find which line it's on and sync OLD pane to same line
         const lineNum = findLineForByte(newLineByteOffsets, data.top_byte);
         const targetByte = oldLineByteOffsets[Math.min(lineNum, oldLineByteOffsets.length - 1)];
@@ -1100,7 +1100,7 @@ globalThis.review_drill_down = async () => {
         }));
 
         // Create source buffers (hidden from tabs, used by composite)
-        const oldBufferId = await editor.createVirtualBuffer({
+        const oldResult = await editor.createVirtualBuffer({
             name: `*OLD:${h.file}*`,
             mode: "normal",
             readOnly: true,
@@ -1109,8 +1109,9 @@ globalThis.review_drill_down = async () => {
             editingDisabled: true,
             hiddenFromTabs: true
         });
+        const oldBufferId = oldResult.bufferId;
 
-        const newBufferId = await editor.createVirtualBuffer({
+        const newResult = await editor.createVirtualBuffer({
             name: `*NEW:${h.file}*`,
             mode: "normal",
             readOnly: true,
@@ -1119,6 +1120,7 @@ globalThis.review_drill_down = async () => {
             editingDisabled: true,
             hiddenFromTabs: true
         });
+        const newBufferId = newResult.bufferId;
 
         // Convert hunks to composite buffer format (parse counts from git diff)
         const compositeHunks: TsCompositeHunk[] = fileHunks.map(fh => {
@@ -1130,10 +1132,10 @@ globalThis.review_drill_down = async () => {
                 else if (line.startsWith(' ')) { oldCount++; newCount++; }
             }
             return {
-                old_start: fh.oldRange.start - 1,  // Convert to 0-indexed
-                old_count: oldCount || 1,
-                new_start: fh.range.start - 1,     // Convert to 0-indexed
-                new_count: newCount || 1
+                oldStart: fh.oldRange.start - 1,  // Convert to 0-indexed
+                oldCount: oldCount || 1,
+                newStart: fh.range.start - 1,     // Convert to 0-indexed
+                newCount: newCount || 1
             };
         });
 
@@ -1142,27 +1144,27 @@ globalThis.review_drill_down = async () => {
             name: `*Diff: ${h.file}*`,
             mode: "diff-view",
             layout: {
-                layout_type: "side-by-side",
+                type: "side-by-side",
                 ratios: [0.5, 0.5],
-                show_separator: true
+                showSeparator: true
             },
             sources: [
                 {
-                    buffer_id: oldBufferId,
+                    bufferId: oldBufferId,
                     label: "OLD (HEAD)",
                     editable: false,
                     style: {
-                        remove_bg: [80, 40, 40],
-                        gutter_style: "diff-markers"
+                        removeBg: [80, 40, 40],
+                        gutterStyle: "diff-markers"
                     }
                 },
                 {
-                    buffer_id: newBufferId,
+                    bufferId: newBufferId,
                     label: "NEW (Working)",
                     editable: false,
                     style: {
-                        add_bg: [40, 80, 40],
-                        gutter_style: "diff-markers"
+                        addBg: [40, 80, 40],
+                        gutterStyle: "diff-markers"
                     }
                 }
             ],
@@ -1518,7 +1520,7 @@ globalThis.on_review_buffer_activated = (data: any) => {
 };
 
 globalThis.on_review_buffer_closed = (data: any) => {
-    if (data.buffer_id === state.reviewBufferId) stop_review_diff();
+    if (data.buffer_id === state.reviewBufferId) globalThis.stop_review_diff();
 };
 
 // Side-by-side diff for current file using composite buffers
@@ -1663,7 +1665,7 @@ globalThis.side_by_side_diff_current_file = async () => {
     }));
 
     // Create source buffers (hidden from tabs, used by composite)
-    const oldBufferId = await editor.createVirtualBuffer({
+    const oldResult = await editor.createVirtualBuffer({
         name: `*OLD:${filePath}*`,
         mode: "normal",
         readOnly: true,
@@ -1672,8 +1674,9 @@ globalThis.side_by_side_diff_current_file = async () => {
         editingDisabled: true,
         hiddenFromTabs: true
     });
+    const oldBufferId = oldResult.bufferId;
 
-    const newBufferId = await editor.createVirtualBuffer({
+    const newResult = await editor.createVirtualBuffer({
         name: `*NEW:${filePath}*`,
         mode: "normal",
         readOnly: true,
@@ -1682,13 +1685,14 @@ globalThis.side_by_side_diff_current_file = async () => {
         editingDisabled: true,
         hiddenFromTabs: true
     });
+    const newBufferId = newResult.bufferId;
 
     // Convert hunks to composite buffer format
     const compositeHunks: TsCompositeHunk[] = fileHunks.map(h => ({
-        old_start: h.oldRange.start - 1,  // Convert to 0-indexed
-        old_count: h.oldRange.end - h.oldRange.start + 1,
-        new_start: h.range.start - 1,     // Convert to 0-indexed
-        new_count: h.range.end - h.range.start + 1
+        oldStart: h.oldRange.start - 1,  // Convert to 0-indexed
+        oldCount: h.oldRange.end - h.oldRange.start + 1,
+        newStart: h.range.start - 1,     // Convert to 0-indexed
+        newCount: h.range.end - h.range.start + 1
     }));
 
     // Create composite buffer with side-by-side layout
@@ -1696,27 +1700,27 @@ globalThis.side_by_side_diff_current_file = async () => {
         name: `*Diff: ${filePath}*`,
         mode: "diff-view",
         layout: {
-            layout_type: "side-by-side",
+            type: "side-by-side",
             ratios: [0.5, 0.5],
-            show_separator: true
+            showSeparator: true
         },
         sources: [
             {
-                buffer_id: oldBufferId,
+                bufferId: oldBufferId,
                 label: "OLD (HEAD)",
                 editable: false,
                 style: {
-                    remove_bg: [80, 40, 40],
-                    gutter_style: "diff-markers"
+                    removeBg: [80, 40, 40],
+                    gutterStyle: "diff-markers"
                 }
             },
             {
-                buffer_id: newBufferId,
+                bufferId: newBufferId,
                 label: "NEW (Working)",
                 editable: false,
                 style: {
-                    add_bg: [40, 80, 40],
-                    gutter_style: "diff-markers"
+                    addBg: [40, 80, 40],
+                    gutterStyle: "diff-markers"
                 }
             }
         ],
@@ -1746,10 +1750,10 @@ globalThis.side_by_side_diff_current_file = async () => {
 };
 
 // Register Modes and Commands
-editor.registerCommand("%cmd.review_diff", "%cmd.review_diff_desc", "start_review_diff", "global");
+editor.registerCommand("%cmd.review_diff", "%cmd.review_diff_desc", "start_review_diff", null);
 editor.registerCommand("%cmd.stop_review_diff", "%cmd.stop_review_diff_desc", "stop_review_diff", "review-mode");
 editor.registerCommand("%cmd.refresh_review_diff", "%cmd.refresh_review_diff_desc", "review_refresh", "review-mode");
-editor.registerCommand("%cmd.side_by_side_diff", "%cmd.side_by_side_diff_desc", "side_by_side_diff_current_file", "global");
+editor.registerCommand("%cmd.side_by_side_diff", "%cmd.side_by_side_diff_desc", "side_by_side_diff_current_file", null);
 
 // Review Comment Commands
 editor.registerCommand("%cmd.add_comment", "%cmd.add_comment_desc", "review_add_comment", "review-mode");

package/plugins/calculator.ts

@@ -711,16 +711,16 @@ globalThis.calculator_open = async function (): Promise<void> {
 
   const entries = renderCalculator();
 
-  state.bufferId = await editor.createVirtualBuffer({
+  const result = await editor.createVirtualBuffer({
     name: "*Calculator*",
     mode: "calculator",
-    read_only: true,
+    readOnly: true,
     entries,
-    show_line_numbers: false,
-    show_cursors: false,
-    editing_disabled: true,
+    showLineNumbers: false,
+    showCursors: false,
+    editingDisabled: true,
   });
-
+  state.bufferId = result.bufferId;
   state.splitId = editor.getActiveSplitId();
 
   editor.setStatus(editor.t("status.opened"));

package/plugins/examples/virtual_buffer_demo.ts

@@ -97,12 +97,12 @@ globalThis.show_virtual_buffer_demo = async () => {
     const bufferId = await editor.createVirtualBufferInSplit({
       name: "*Demo Diagnostics*",
       mode: "demo-list",
-      read_only: true,
+      readOnly: true,
       entries: entries,
       ratio: 0.7, // Original pane takes 70%, demo buffer takes 30%
-      panel_id: "demo-diagnostics",
-      show_line_numbers: false,
-      show_cursors: true,
+      panelId: "demo-diagnostics",
+      showLineNumbers: false,
+      showCursors: true,
     });
 
     editor.setStatus(`Created demo virtual buffer (ID: ${bufferId}) with ${entries.length} items - Press RET to jump to location`);

package/plugins/git_blame.ts

@@ -478,7 +478,7 @@ globalThis.show_git_blame = async function(): Promise<void> {
   }
 
   // Create virtual buffer with the file content
-  const bufferId = await editor.createVirtualBufferInExistingSplit({
+  const result = await editor.createVirtualBufferInExistingSplit({
     name: bufferName,
     mode: "git-blame",
     readOnly: true,
@@ -489,9 +489,9 @@ globalThis.show_git_blame = async function(): Promise<void> {
     editingDisabled: true,
   });
 
-  if (bufferId !== null) {
+  if (result !== null) {
     blameState.isOpen = true;
-    blameState.bufferId = bufferId;
+    blameState.bufferId = result.bufferId;
 
     // Add virtual lines for blame headers (persistent state model)
     addBlameHeaders();

package/plugins/git_explorer.ts

@@ -1,4 +1,4 @@
-/// <reference path="../types/fresh.d.ts" />
+/// <reference path="./lib/fresh.d.ts" />
 const editor = getEditor();
 
 /**
@@ -133,8 +133,9 @@ async function refreshGitExplorerDecorations() {
     } else {
       editor.setFileExplorerDecorations(NAMESPACE, decorations);
     }
-  } catch (_err) {
+  } catch (err) {
     editor.clearFileExplorerDecorations(NAMESPACE);
+    throw err;
   } finally {
     refreshInFlight = false;
   }

package/plugins/git_log.ts

@@ -763,7 +763,7 @@ globalThis.show_git_log = async function(): Promise<void> {
   gitLogState.cachedContent = entriesToContent(entries);
 
   // Create virtual buffer in the current split (replacing current buffer)
-  const bufferId = await editor.createVirtualBufferInExistingSplit({
+  const result = await editor.createVirtualBufferInExistingSplit({
     name: "*Git Log*",
     mode: "git-log",
     readOnly: true,
@@ -774,9 +774,9 @@ globalThis.show_git_log = async function(): Promise<void> {
     editingDisabled: true,
   });
 
-  if (bufferId !== null) {
+  if (result !== null) {
     gitLogState.isOpen = true;
-    gitLogState.bufferId = bufferId;
+    gitLogState.bufferId = result.bufferId;
 
     // Apply syntax highlighting
     applyGitLogHighlighting();
@@ -897,7 +897,7 @@ globalThis.git_log_show_commit = async function(): Promise<void> {
   commitDetailState.cachedContent = entriesToContent(entries);
 
   // Create virtual buffer in the current split (replacing git log view)
-  const bufferId = await editor.createVirtualBufferInExistingSplit({
+  const result = await editor.createVirtualBufferInExistingSplit({
     name: `*Commit: ${commit.shortHash}*`,
     mode: "git-commit-detail",
     readOnly: true,
@@ -908,9 +908,9 @@ globalThis.git_log_show_commit = async function(): Promise<void> {
     editingDisabled: true,
   });
 
-  if (bufferId !== null) {
+  if (result !== null) {
     commitDetailState.isOpen = true;
-    commitDetailState.bufferId = bufferId;
+    commitDetailState.bufferId = result.bufferId;
     commitDetailState.splitId = gitLogState.splitId;
     commitDetailState.commit = commit;
 
@@ -1210,7 +1210,7 @@ globalThis.git_commit_detail_open_file = async function(): Promise<void> {
       }
 
       // Create a read-only virtual buffer with the file content
-      const bufferId = await editor.createVirtualBufferInExistingSplit({
+      const result = await editor.createVirtualBufferInExistingSplit({
         name: `${file} @ ${commit.shortHash}`,
         mode: "git-file-view",
         readOnly: true,
@@ -1221,16 +1221,16 @@ globalThis.git_commit_detail_open_file = async function(): Promise<void> {
         editingDisabled: true,
       });
 
-      if (bufferId !== null) {
+      if (result !== null) {
         // Track file view state so we can navigate back
         fileViewState.isOpen = true;
-        fileViewState.bufferId = bufferId;
+        fileViewState.bufferId = result.bufferId;
         fileViewState.splitId = commitDetailState.splitId;
         fileViewState.filePath = file;
         fileViewState.commitHash = commit.hash;
 
         // Apply syntax highlighting based on file type
-        applyFileViewHighlighting(bufferId, content, file);
+        applyFileViewHighlighting(result.bufferId, content, file);
 
         const targetLine = line || 1;
         editor.setStatus(editor.t("status.file_view_ready", { file, hash: commit.shortHash, line: String(targetLine) }));

package/plugins/java-lsp.ts

@@ -0,0 +1,65 @@
+/// <reference path="./lib/fresh.d.ts" />
+// Provides installation help when jdtls (Java LSP) is not found
+const editor = getEditor();
+
+interface LspServerErrorData {
+  language: string;
+  server_command: string;
+  error_type: string;
+  message: string;
+}
+
+interface LspStatusClickedData {
+  language: string;
+  has_error: boolean;
+}
+
+interface ActionPopupResultData {
+  popup_id: string;
+  action_id: string;
+}
+
+const INSTALL_URL = "https://github.com/eclipse-jdtls/eclipse.jdt.ls#installation";
+let javaLspError: { serverCommand: string; message: string } | null = null;
+
+globalThis.on_java_lsp_server_error = function (data: LspServerErrorData): void {
+  if (data.language !== "java") return;
+  javaLspError = { serverCommand: data.server_command, message: data.message };
+  if (data.error_type === "not_found") {
+    editor.setStatus(`Java LSP '${data.server_command}' not found. Click status bar for help.`);
+  } else {
+    editor.setStatus(`Java LSP error: ${data.message}`);
+  }
+};
+editor.on("lsp_server_error", "on_java_lsp_server_error");
+
+globalThis.on_java_lsp_status_clicked = function (data: LspStatusClickedData): void {
+  if (data.language !== "java" || !javaLspError) return;
+  editor.showActionPopup({
+    id: "java-lsp-help",
+    title: "Java Language Server Not Found",
+    message: `Install jdtls for code completion and diagnostics. Visit ${INSTALL_URL}`,
+    actions: [
+      { id: "copy_url", label: "Copy install URL" },
+      { id: "disable", label: "Disable Java LSP" },
+      { id: "dismiss", label: "Dismiss (ESC)" },
+    ],
+  });
+};
+editor.on("lsp_status_clicked", "on_java_lsp_status_clicked");
+
+globalThis.on_java_lsp_action_result = function (data: ActionPopupResultData): void {
+  if (data.popup_id !== "java-lsp-help") return;
+  switch (data.action_id) {
+    case "copy_url":
+      editor.setClipboard(INSTALL_URL);
+      editor.setStatus("Copied: " + INSTALL_URL);
+      break;
+    case "disable":
+      editor.disableLspForLanguage("java");
+      editor.setStatus("Java LSP disabled");
+      javaLspError = null;
+      break;
+  }
+};
+editor.on("action_popup_result", "on_java_lsp_action_result");

package/plugins/latex-lsp.ts

@@ -0,0 +1,65 @@
+/// <reference path="./lib/fresh.d.ts" />
+// Provides installation help when texlab (LaTeX LSP) is not found
+const editor = getEditor();
+
+interface LspServerErrorData {
+  language: string;
+  server_command: string;
+  error_type: string;
+  message: string;
+}
+
+interface LspStatusClickedData {
+  language: string;
+  has_error: boolean;
+}
+
+interface ActionPopupResultData {
+  popup_id: string;
+  action_id: string;
+}
+
+const INSTALL_URL = "https://github.com/latex-lsp/texlab#installation";
+let latexLspError: { serverCommand: string; message: string } | null = null;
+
+globalThis.on_latex_lsp_server_error = function (data: LspServerErrorData): void {
+  if (data.language !== "latex") return;
+  latexLspError = { serverCommand: data.server_command, message: data.message };
+  if (data.error_type === "not_found") {
+    editor.setStatus(`LaTeX LSP '${data.server_command}' not found. Click status bar for help.`);
+  } else {
+    editor.setStatus(`LaTeX LSP error: ${data.message}`);
+  }
+};
+editor.on("lsp_server_error", "on_latex_lsp_server_error");
+
+globalThis.on_latex_lsp_status_clicked = function (data: LspStatusClickedData): void {
+  if (data.language !== "latex" || !latexLspError) return;
+  editor.showActionPopup({
+    id: "latex-lsp-help",
+    title: "LaTeX Language Server Not Found",
+    message: `Install texlab for code completion and diagnostics. Visit ${INSTALL_URL}`,
+    actions: [
+      { id: "copy_url", label: "Copy install URL" },
+      { id: "disable", label: "Disable LaTeX LSP" },
+      { id: "dismiss", label: "Dismiss (ESC)" },
+    ],
+  });
+};
+editor.on("lsp_status_clicked", "on_latex_lsp_status_clicked");
+
+globalThis.on_latex_lsp_action_result = function (data: ActionPopupResultData): void {
+  if (data.popup_id !== "latex-lsp-help") return;
+  switch (data.action_id) {
+    case "copy_url":
+      editor.setClipboard(INSTALL_URL);
+      editor.setStatus("Copied: " + INSTALL_URL);
+      break;
+    case "disable":
+      editor.disableLspForLanguage("latex");
+      editor.setStatus("LaTeX LSP disabled");
+      latexLspError = null;
+      break;
+  }
+};
+editor.on("action_popup_result", "on_latex_lsp_action_result");