@fresh-editor/fresh-editor 0.1.76 → 0.1.83

package/CHANGELOG.md

@@ -1,5 +1,62 @@
 # Release Notes
 
+## 0.1.83
+
+### Breaking Changes
+
+* **QuickJS Plugin Runtime**: Replaced Deno with QuickJS for the plugin system. Each plugin now runs in its own isolated context.
+
+### Features
+
+* **Cargo Workspace Architecture**: Refactored into modular crates (fresh-core, fresh-editor, fresh-languages, fresh-parser-js, fresh-plugin-runtime, fresh-plugin-api-macros).
+
+### Bug Fixes
+
+* **Toggle Comment YAML**: Fixed toggle comment not working for YAML files by falling back to config-based language detection (#774).
+* **Undo History Panic**: Fixed panic when undoing past a save point and making new edits caused out-of-bounds slice access (#776).
+* **Sudo Save Prompt**: Fixed permission denied crash when saving files owned by another user; now shows sudo prompt correctly (#775).
+* **Musl Plugin Support**: Plugins now work on musl target builds (x86_64/aarch64-unknown-linux-musl).
+* **LSP Server Requests**: Fixed LSP server-to-client request handling not being dispatched to plugins.
+* **Git Find File Selection**: Fixed race condition causing wrong file selection when pressing Enter quickly.
+* **Plugin Cache**: Embedded plugins now cached in XDG cache dir instead of leaking temp directories.
+
+### Internal
+
+* Improved compile times via LLVM optimization flag.
+* Cross-platform path handling fixes for Windows.
+* Test reliability improvements.
+
+---
+
+## 0.1.77
+
+### Documentation
+
+* **macOS Terminal Tips**: Added keyboard enhancement flags configuration guide.
+
+### Features
+
+* **LSP Semantic Highlighting** (@Asuka-Minato).
+* **macOS Keybinding Display**: Native symbols (⌃, ⌥, ⇧) instead of Ctrl+/Alt+/Shift+.
+* **Odin Language Support**: Syntax highlighting (sublime-syntax from @Tetralux) and OLS LSP configuration (@xoxorwr).
+* **File Explorer Git Indicators**: Shows modified/added status for files and folders via new plugin (#526) (@Asuka-Minato).
+* **Keyboard Enhancement Flags Config**: New config options for more granular control over kitty protocol usage (`keyboard_disambiguate_escape_codes`, `keyboard_report_event_types`, `keyboard_report_alternate_keys`, `keyboard_report_all_keys_as_escape_codes`).
+
+### Bug Fixes
+
+* **Menu Keybinding Display**: Consistent keybinding symbols in menus on macOS (#703).
+* **Git Find File Popup**: Smart path truncation preserving filename (#707).
+* **File Owner Preservation**: Preserve owner when saving files with group write privileges (#743).
+
+### Internal
+
+* Telemetry and update checks now debounce to once per day.
+* Terminal mode handling refactored into dedicated module.
+* Resolved ~300+ clippy warnings.
+* Bumped url (2.5.8), libc (0.2.180) (@dependabot).
+
+---
+
 ## 0.1.76
 
 ### Features

package/README.md

@@ -71,6 +71,8 @@ Or, pick your preferred method:
 
 On macOS and some linux distros (Bazzite/Bluefin/Aurora):
 
+> **Note:** On macOS, see [macOS Terminal Tips](docs/USER_GUIDE.md#macos-terminal-tips) for recommended terminal configuration.
+
 ```bash
 brew tap sinelaw/fresh
 brew install fresh-editor

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@fresh-editor/fresh-editor",
-  "version": "0.1.76",
+  "version": "0.1.83",
   "description": "A modern terminal-based text editor with plugin support",
   "repository": {
     "type": "git",

package/plugins/audit_mode.ts

@@ -1103,21 +1103,21 @@ globalThis.review_drill_down = async () => {
         const oldBufferId = await editor.createVirtualBuffer({
             name: `*OLD:${h.file}*`,
             mode: "normal",
-            read_only: true,
+            readOnly: true,
             entries: oldEntries,
-            show_line_numbers: true,
-            editing_disabled: true,
-            hidden_from_tabs: true
+            showLineNumbers: true,
+            editingDisabled: true,
+            hiddenFromTabs: true
         });
 
         const newBufferId = await editor.createVirtualBuffer({
             name: `*NEW:${h.file}*`,
             mode: "normal",
-            read_only: true,
+            readOnly: true,
             entries: newEntries,
-            show_line_numbers: true,
-            editing_disabled: true,
-            hidden_from_tabs: true
+            showLineNumbers: true,
+            editingDisabled: true,
+            hiddenFromTabs: true
         });
 
         // Convert hunks to composite buffer format (parse counts from git diff)
@@ -1493,7 +1493,7 @@ globalThis.start_review_diff = async () => {
     state.comments = []; // Reset comments for new session
 
     const bufferId = await VirtualBufferFactory.create({
-        name: "*Review Diff*", mode: "review-mode", read_only: true,
+        name: "*Review Diff*", mode: "review-mode", readOnly: true,
         entries: (await renderReviewStream()).entries, showLineNumbers: false
     });
     state.reviewBufferId = bufferId;
@@ -1666,21 +1666,21 @@ globalThis.side_by_side_diff_current_file = async () => {
     const oldBufferId = await editor.createVirtualBuffer({
         name: `*OLD:${filePath}*`,
         mode: "normal",
-        read_only: true,
+        readOnly: true,
         entries: oldEntries,
-        show_line_numbers: true,
-        editing_disabled: true,
-        hidden_from_tabs: true
+        showLineNumbers: true,
+        editingDisabled: true,
+        hiddenFromTabs: true
     });
 
     const newBufferId = await editor.createVirtualBuffer({
         name: `*NEW:${filePath}*`,
         mode: "normal",
-        read_only: true,
+        readOnly: true,
         entries: newEntries,
-        show_line_numbers: true,
-        editing_disabled: true,
-        hidden_from_tabs: true
+        showLineNumbers: true,
+        editingDisabled: true,
+        hiddenFromTabs: true
     });
 
     // Convert hunks to composite buffer format

package/plugins/calculator.ts

@@ -765,6 +765,6 @@ editor.on("mouse_click", "onCalculatorMouseClick");
 editor.on("mouse_move", "onCalculatorMouseMove");
 
 // Register main command
-editor.registerCommand("%cmd.calculator", "%cmd.calculator_desc", "calculator_open", "normal");
+editor.registerCommand("%cmd.calculator", "%cmd.calculator_desc", "calculator_open", null);
 
 editor.setStatus(editor.t("status.loaded"));

package/plugins/config-schema.json

@@ -42,6 +42,7 @@
         "large_file_threshold_bytes": 1048576,
         "estimated_line_length": 80,
         "enable_inlay_hints": true,
+        "enable_semantic_tokens_full": false,
         "recovery_enabled": true,
         "auto_save_interval_secs": 2,
         "highlight_context_bytes": 10000,
@@ -52,6 +53,10 @@
         "file_tree_poll_interval_ms": 3000,
         "default_line_ending": "lf",
         "cursor_style": "default",
+        "keyboard_disambiguate_escape_codes": true,
+        "keyboard_report_event_types": false,
+        "keyboard_report_alternate_keys": true,
+        "keyboard_report_all_keys_as_escape_codes": false,
         "quick_suggestions": true,
         "show_menu_bar": true,
         "show_tab_bar": true
@@ -225,7 +230,7 @@
           "default": 100
         },
         "large_file_threshold_bytes": {
-          "description": "File size threshold in bytes for \"large file\" behavior\nFiles larger than this will:\n- Skip LSP features\n- Use constant-size scrollbar thumb (1 char)\nFiles smaller will count actual lines for accurate scrollbar rendering",
+          "description": "File size threshold in bytes for \"large file\" behavior\nFiles larger than this will:\n- Skip LSP features\n- Use constant-size scrollbar thumb (1 char)\n\nFiles smaller will count actual lines for accurate scrollbar rendering",
           "type": "integer",
           "format": "uint64",
           "minimum": 0,
@@ -243,6 +248,11 @@
           "type": "boolean",
           "default": true
         },
+        "enable_semantic_tokens_full": {
+          "description": "Whether to request full-document LSP semantic tokens.\nRange requests are still used when supported.\nDefault: false (range-only to avoid heavy full refreshes).",
+          "type": "boolean",
+          "default": false
+        },
         "recovery_enabled": {
           "description": "Whether to enable file recovery (Emacs-style auto-save)\nWhen enabled, buffers are periodically saved to recovery files\nso they can be recovered if the editor crashes.",
           "type": "boolean",
@@ -305,6 +315,26 @@
           "$ref": "#/$defs/CursorStyle",
           "default": "default"
         },
+        "keyboard_disambiguate_escape_codes": {
+          "description": "Enable keyboard enhancement: disambiguate escape codes using CSI-u sequences.\nThis allows unambiguous reading of Escape and modified keys.\nRequires terminal support (kitty keyboard protocol).\nDefault: true",
+          "type": "boolean",
+          "default": true
+        },
+        "keyboard_report_event_types": {
+          "description": "Enable keyboard enhancement: report key event types (repeat/release).\nAdds extra events when keys are autorepeated or released.\nRequires terminal support (kitty keyboard protocol).\nDefault: false",
+          "type": "boolean",
+          "default": false
+        },
+        "keyboard_report_alternate_keys": {
+          "description": "Enable keyboard enhancement: report alternate keycodes.\nSends alternate keycodes in addition to the base keycode.\nRequires terminal support (kitty keyboard protocol).\nDefault: true",
+          "type": "boolean",
+          "default": true
+        },
+        "keyboard_report_all_keys_as_escape_codes": {
+          "description": "Enable keyboard enhancement: report all keys as escape codes.\nRepresents all keyboard events as CSI-u sequences.\nRequired for repeat/release events on plain-text keys.\nRequires terminal support (kitty keyboard protocol).\nDefault: false",
+          "type": "boolean",
+          "default": false
+        },
         "quick_suggestions": {
           "description": "Enable quick suggestions (VS Code-like behavior).\nWhen enabled, completion suggestions appear automatically while typing,\nnot just on trigger characters (like `.` or `::`).\nDefault: true",
           "type": "boolean",
@@ -787,7 +817,7 @@
       }
     },
     "PluginConfig": {
-      "description": "Configuration for an individual plugin",
+      "description": "Configuration for a single plugin",
       "type": "object",
       "properties": {
         "enabled": {

package/plugins/git_blame.ts

@@ -481,12 +481,12 @@ globalThis.show_git_blame = async function(): Promise<void> {
   const bufferId = await editor.createVirtualBufferInExistingSplit({
     name: bufferName,
     mode: "git-blame",
-    read_only: true,
+    readOnly: true,
     entries: entries,
-    split_id: blameState.splitId!,
-    show_line_numbers: true,  // We DO want line numbers (headers won't have them due to source_offset: null)
-    show_cursors: true,
-    editing_disabled: true,
+    splitId: blameState.splitId!,
+    showLineNumbers: true,  // We DO want line numbers (headers won't have them due to source_offset: null)
+    showCursors: true,
+    editingDisabled: true,
   });
 
   if (bufferId !== null) {

package/plugins/git_explorer.ts

@@ -0,0 +1,159 @@
+/// <reference path="../types/fresh.d.ts" />
+const editor = getEditor();
+
+/**
+ * Git Explorer Decorations
+ *
+ * Adds VS Code-style status badges (M/A/U/D/...) to the file explorer.
+ */
+
+const NAMESPACE = "git-explorer";
+
+const COLORS = {
+  added: [80, 250, 123] as [number, number, number],
+  modified: [255, 184, 108] as [number, number, number],
+  deleted: [255, 85, 85] as [number, number, number],
+  renamed: [139, 233, 253] as [number, number, number],
+  untracked: [241, 250, 140] as [number, number, number],
+  conflicted: [255, 121, 198] as [number, number, number],
+};
+
+const PRIORITY = {
+  conflicted: 90,
+  deleted: 80,
+  added: 60,
+  modified: 50,
+  renamed: 40,
+  untracked: 30,
+};
+
+let refreshInFlight = false;
+
+function statusToDecoration(status: string, staged: boolean) {
+  switch (status) {
+    case "A":
+      return { symbol: "A", color: COLORS.added, priority: PRIORITY.added };
+    case "M":
+      return {
+        symbol: "M",
+        color: staged ? COLORS.added : COLORS.modified,
+        priority: PRIORITY.modified + (staged ? 2 : 0),
+      };
+    case "D":
+      return { symbol: "D", color: COLORS.deleted, priority: PRIORITY.deleted };
+    case "R":
+      return { symbol: "R", color: COLORS.renamed, priority: PRIORITY.renamed };
+    case "C":
+      return { symbol: "C", color: COLORS.renamed, priority: PRIORITY.renamed };
+    case "U":
+      return { symbol: "!", color: COLORS.conflicted, priority: PRIORITY.conflicted };
+    default:
+      return null;
+  }
+}
+
+function parseStatusOutput(output: string, repoRoot: string) {
+  const separator = output.includes("\0") ? "\0" : "\n";
+  const entries = output
+    .split(separator)
+    .map((entry) => entry.replace(/\r$/, ""))
+    .filter((entry) => entry.length > 0);
+  const byPath = new Map<string, { path: string; symbol: string; color: [number, number, number]; priority: number }>();
+
+  for (let i = 0; i < entries.length; i++) {
+    const entry = entries[i];
+    if (entry.length < 3) {
+      continue;
+    }
+    const x = entry[0];
+    const y = entry[1];
+    let path = entry.slice(3);
+
+    if ((x === "R" || x === "C") && separator === "\0" && i + 1 < entries.length) {
+      i += 1;
+      path = entries[i];
+    } else if (entry.includes(" -> ") && (x === "R" || x === "C" || y === "R" || y === "C")) {
+      path = entry.split(" -> ").pop() ?? path;
+    }
+
+    let decoration = null;
+    if (x === "?" && y === "?") {
+      decoration = { symbol: "U", color: COLORS.untracked, priority: PRIORITY.untracked };
+    } else if (x !== " " && x !== "?") {
+      decoration = statusToDecoration(x, true);
+    } else if (y !== " ") {
+      decoration = statusToDecoration(y, false);
+    }
+
+    if (!decoration) {
+      continue;
+    }
+
+    const absolutePath = editor.pathJoin(repoRoot, path);
+    const existing = byPath.get(absolutePath);
+    if (!existing || decoration.priority >= existing.priority) {
+      byPath.set(absolutePath, { path: absolutePath, ...decoration });
+    }
+  }
+
+  return Array.from(byPath.values());
+}
+
+async function refreshGitExplorerDecorations() {
+  if (refreshInFlight) {
+    return;
+  }
+  refreshInFlight = true;
+  try {
+    const cwd = editor.getCwd();
+    const rootResult = await editor.spawnProcess("git", ["rev-parse", "--show-toplevel"], cwd);
+    if (rootResult.exit_code !== 0) {
+      editor.clearFileExplorerDecorations(NAMESPACE);
+      return;
+    }
+    const repoRoot = rootResult.stdout.trim();
+    if (!repoRoot) {
+      editor.clearFileExplorerDecorations(NAMESPACE);
+      return;
+    }
+
+    const statusResult = await editor.spawnProcess(
+      "git",
+      ["status", "--porcelain"],
+      repoRoot
+    );
+    if (statusResult.exit_code !== 0) {
+      editor.clearFileExplorerDecorations(NAMESPACE);
+      return;
+    }
+
+    const decorations = parseStatusOutput(statusResult.stdout, repoRoot);
+    if (decorations.length === 0) {
+      editor.clearFileExplorerDecorations(NAMESPACE);
+    } else {
+      editor.setFileExplorerDecorations(NAMESPACE, decorations);
+    }
+  } catch (_err) {
+    editor.clearFileExplorerDecorations(NAMESPACE);
+  } finally {
+    refreshInFlight = false;
+  }
+}
+
+globalThis.onGitExplorerAfterFileOpen = () => {
+  refreshGitExplorerDecorations();
+};
+
+globalThis.onGitExplorerAfterFileSave = () => {
+  refreshGitExplorerDecorations();
+};
+
+globalThis.onGitExplorerEditorInitialized = () => {
+  refreshGitExplorerDecorations();
+};
+
+editor.on("after_file_open", "onGitExplorerAfterFileOpen");
+editor.on("after_file_save", "onGitExplorerAfterFileSave");
+editor.on("editor_initialized", "onGitExplorerEditorInitialized");
+
+refreshGitExplorerDecorations();

package/plugins/git_find_file.ts

@@ -27,7 +27,11 @@ async function loadGitFiles(): Promise<string[]> {
   const result = await editor.spawnProcess("git", ["ls-files"]);
 
   if (result.exit_code === 0) {
-    return result.stdout.split("\n").filter((line) => line.trim() !== "");
+    // Split by newline and trim each line to handle \r\n on Windows
+    return result.stdout
+      .split("\n")
+      .map((line) => line.trim())
+      .filter((line) => line !== "");
   }
 
   editor.debug(`Failed to load git files: ${result.stderr}`);
@@ -58,14 +62,14 @@ editor.registerCommand(
   "%cmd.find",
   "%cmd.find_desc",
   "start_git_find_file",
-  "normal"
+  null
 );
 
 editor.registerCommand(
   "%cmd.reload",
   "%cmd.reload_desc",
   "git_reload_files",
-  "normal"
+  null
 );
 
 editor.debug("Git Find File plugin loaded (using Finder abstraction)");

package/plugins/git_grep.ts

@@ -67,7 +67,7 @@ globalThis.start_git_grep = function (): void {
 };
 
 // Register command
-editor.registerCommand("%cmd.grep", "%cmd.grep_desc", "start_git_grep", "normal");
+editor.registerCommand("%cmd.grep", "%cmd.grep_desc", "start_git_grep", null);
 
 // Log that plugin loaded successfully
 editor.debug("Git Grep plugin loaded (using Finder abstraction)");

package/plugins/git_log.ts

@@ -766,12 +766,12 @@ globalThis.show_git_log = async function(): Promise<void> {
   const bufferId = await editor.createVirtualBufferInExistingSplit({
     name: "*Git Log*",
     mode: "git-log",
-    read_only: true,
+    readOnly: true,
     entries: entries,
-    split_id: gitLogState.splitId!,
-    show_line_numbers: false,
-    show_cursors: true,
-    editing_disabled: true,
+    splitId: gitLogState.splitId!,
+    showLineNumbers: false,
+    showCursors: true,
+    editingDisabled: true,
   });
 
   if (bufferId !== null) {
@@ -900,12 +900,12 @@ globalThis.git_log_show_commit = async function(): Promise<void> {
   const bufferId = await editor.createVirtualBufferInExistingSplit({
     name: `*Commit: ${commit.shortHash}*`,
     mode: "git-commit-detail",
-    read_only: true,
+    readOnly: true,
     entries: entries,
-    split_id: gitLogState.splitId!,
-    show_line_numbers: false, // Disable line numbers for cleaner diff view
-    show_cursors: true,
-    editing_disabled: true,
+    splitId: gitLogState.splitId!,
+    showLineNumbers: false, // Disable line numbers for cleaner diff view
+    showCursors: true,
+    editingDisabled: true,
   });
 
   if (bufferId !== null) {
@@ -1213,12 +1213,12 @@ globalThis.git_commit_detail_open_file = async function(): Promise<void> {
       const bufferId = await editor.createVirtualBufferInExistingSplit({
         name: `${file} @ ${commit.shortHash}`,
         mode: "git-file-view",
-        read_only: true,
+        readOnly: true,
         entries: entries,
-        split_id: commitDetailState.splitId!,
-        show_line_numbers: true,
-        show_cursors: true,
-        editing_disabled: true,
+        splitId: commitDetailState.splitId!,
+        showLineNumbers: true,
+        showCursors: true,
+        editingDisabled: true,
       });
 
       if (bufferId !== null) {

package/plugins/lib/finder.ts

@@ -465,7 +465,9 @@ export class Finder<T> {
         options.initialQuery
       );
     } else {
-      this.editor.startPrompt(options.title, this.config.id);
+      this.editor.debug(`[Finder] calling startPrompt with title="${options.title}", id="${this.config.id}"`);
+      const result = this.editor.startPrompt(options.title, this.config.id);
+      this.editor.debug(`[Finder] startPrompt returned: ${result}`);
     }
     this.editor.setStatus("Type to search...");
   }
@@ -951,11 +953,11 @@ export class Finder<T> {
   }
 
   private closePreview(): void {
-    if (this.previewState.bufferId !== null) {
+    if (this.previewState.bufferId || this.previewState.bufferId == 0) {
       this.editor.closeBuffer(this.previewState.bufferId);
       this.previewState.bufferId = null;
     }
-    if (this.previewState.splitId !== null) {
+    if (this.previewState.splitId || this.previewState.splitId == 0) {
       this.editor.closeSplit(this.previewState.splitId);
       this.previewState.splitId = null;
     }