@frenchtoastman/oh-my-groundcontrol 0.0.15 → 0.0.17

package/dist/cli/index.js

@@ -13769,6 +13769,9 @@ var SessionExportConfigSchema = exports_external.object({
 var HashlineEditConfigSchema = exports_external.object({
   enabled: exports_external.boolean().default(true)
 });
+var DoubleConfirmationConfigSchema = exports_external.object({
+  enabled: exports_external.boolean().default(false)
+});
 var PluginConfigSchema = exports_external.object({
   preset: exports_external.string().optional(),
   scoringEngineVersion: exports_external.enum(["v1", "v2-shadow", "v2"]).optional(),
@@ -13782,7 +13785,8 @@ var PluginConfigSchema = exports_external.object({
   fallback: FailoverConfigSchema.optional(),
   allowedProviders: exports_external.array(exports_external.string()).optional(),
   sessionExport: SessionExportConfigSchema.optional(),
-  hashline_edit: HashlineEditConfigSchema.optional()
+  hashline_edit: HashlineEditConfigSchema.optional(),
+  double_confirmation: DoubleConfirmationConfigSchema.optional()
 });
 // src/config/agent-mcps.ts
 var DEFAULT_AGENT_MCPS = {
@@ -13818,6 +13822,12 @@ var CUSTOM_SKILLS = [
     description: "Repository understanding and hierarchical codemap generation",
     allowedAgents: ["orchestrator", "explorer"],
     sourcePath: "src/skills/cartography"
+  },
+  {
+    name: "analyze",
+    description: "Code review and analysis for uncommitted changes, commits, branches, PRs, or specific files.",
+    allowedAgents: ["*"],
+    sourcePath: "src/skills/analyze"
   }
 ];
 function getCustomSkillsDir() {
@@ -15685,10 +15695,6 @@ function buildDynamicModelPlan(catalog, config2, externalSignals, options) {
     }
   };
 }
-// src/utils/logger.ts
-import * as os from "os";
-import * as path from "path";
-var logFile = path.join(os.tmpdir(), "oh-my-groundcontrol.log");
 // src/utils/env.ts
 function getEnv(name) {
   const bunValue = globalThis.Bun?.env?.[name];
@@ -15941,8 +15947,8 @@ async function getOpenCodeVersion() {
   return null;
 }
 function getOpenCodePath() {
-  const path2 = resolveOpenCodePath();
-  return path2 === "opencode" ? null : path2;
+  const path = resolveOpenCodePath();
+  return path === "opencode" ? null : path;
 }
 
 // src/cli/opencode-models.ts
@@ -16180,9 +16186,9 @@ async function checkOpenCodeInstalled() {
     return { ok: false };
   }
   const version2 = await getOpenCodeVersion();
-  const path2 = getOpenCodePath();
-  printSuccess(`OpenCode ${version2 ?? ""} detected${path2 ? ` (${DIM}${path2}${RESET})` : ""}`);
-  return { ok: true, version: version2 ?? undefined, path: path2 ?? undefined };
+  const path = getOpenCodePath();
+  printSuccess(`OpenCode ${version2 ?? ""} detected${path ? ` (${DIM}${path}${RESET})` : ""}`);
+  return { ok: true, version: version2 ?? undefined, path: path ?? undefined };
 }
 function handleStepResult(result, successMsg) {
   if (!result.success) {

package/dist/config/schema.d.ts

@@ -161,6 +161,10 @@ export declare const HashlineEditConfigSchema: z.ZodObject<{
     enabled: z.ZodDefault<z.ZodBoolean>;
 }, z.core.$strip>;
 export type HashlineEditConfig = z.infer<typeof HashlineEditConfigSchema>;
+export declare const DoubleConfirmationConfigSchema: z.ZodObject<{
+    enabled: z.ZodDefault<z.ZodBoolean>;
+}, z.core.$strip>;
+export type DoubleConfirmationConfig = z.infer<typeof DoubleConfirmationConfigSchema>;
 export declare const PluginConfigSchema: z.ZodObject<{
     preset: z.ZodOptional<z.ZodString>;
     scoringEngineVersion: z.ZodOptional<z.ZodEnum<{
@@ -291,6 +295,9 @@ export declare const PluginConfigSchema: z.ZodObject<{
     hashline_edit: z.ZodOptional<z.ZodObject<{
         enabled: z.ZodDefault<z.ZodBoolean>;
     }, z.core.$strip>>;
+    double_confirmation: z.ZodOptional<z.ZodObject<{
+        enabled: z.ZodDefault<z.ZodBoolean>;
+    }, z.core.$strip>>;
 }, z.core.$strip>;
 export type PluginConfig = z.infer<typeof PluginConfigSchema>;
 export type { AgentName } from './constants';

package/dist/hooks/double-confirmation/index.d.ts

@@ -0,0 +1,24 @@
+import type { DoubleConfirmationConfig } from '../../config/schema';
+interface ToolExecuteAfterInput {
+    tool: string;
+    sessionID?: string;
+    callID?: string;
+}
+interface ToolExecuteAfterOutput {
+    title: string;
+    output: unknown;
+    metadata: unknown;
+}
+/**
+ * Creates the double-confirmation hook.
+ *
+ * Meta-Harness principle: prevent premature task completion by
+ * appending a verification nudge when background/delegated tasks
+ * return results. Only fires once per unique call (tracked by callID).
+ *
+ * Ships disabled by default — enable via config.double_confirmation.enabled.
+ */
+export declare function createDoubleConfirmationHook(config?: DoubleConfirmationConfig): {
+    'tool.execute.after': (input: ToolExecuteAfterInput, output: ToolExecuteAfterOutput) => Promise<void>;
+};
+export {};

package/dist/hooks/index.d.ts

@@ -1,6 +1,7 @@
 export type { AutoUpdateCheckerOptions } from './auto-update-checker';
 export { createAutoUpdateCheckerHook } from './auto-update-checker';
 export { createDelegateTaskRetryHook } from './delegate-task-retry';
+export { createDoubleConfirmationHook } from './double-confirmation';
 export { createEditErrorRecoveryHook } from './edit-error-recovery';
 export { createHashlineReadEnhancerHook } from './hashline-read-enhancer';
 export { createJsonErrorRecoveryHook } from './json-error-recovery';

package/dist/index.js

@@ -3284,6 +3284,12 @@ var CUSTOM_SKILLS = [
     description: "Repository understanding and hierarchical codemap generation",
     allowedAgents: ["orchestrator", "explorer"],
     sourcePath: "src/skills/cartography"
+  },
+  {
+    name: "analyze",
+    description: "Code review and analysis for uncommitted changes, commits, branches, PRs, or specific files.",
+    allowedAgents: ["*"],
+    sourcePath: "src/skills/analyze"
   }
 ];
 
@@ -17101,6 +17107,9 @@ var SessionExportConfigSchema = exports_external.object({
 var HashlineEditConfigSchema = exports_external.object({
   enabled: exports_external.boolean().default(true)
 });
+var DoubleConfirmationConfigSchema = exports_external.object({
+  enabled: exports_external.boolean().default(false)
+});
 var PluginConfigSchema = exports_external.object({
   preset: exports_external.string().optional(),
   scoringEngineVersion: exports_external.enum(["v1", "v2-shadow", "v2"]).optional(),
@@ -17114,7 +17123,8 @@ var PluginConfigSchema = exports_external.object({
   fallback: FailoverConfigSchema.optional(),
   allowedProviders: exports_external.array(exports_external.string()).optional(),
   sessionExport: SessionExportConfigSchema.optional(),
-  hashline_edit: HashlineEditConfigSchema.optional()
+  hashline_edit: HashlineEditConfigSchema.optional(),
+  double_confirmation: DoubleConfirmationConfigSchema.optional()
 });
 
 // src/config/loader.ts
@@ -21290,13 +21300,13 @@ function getAgentConfigs(config2) {
 import * as fs2 from "fs";
 import * as os2 from "os";
 import * as path2 from "path";
-var logFile = path2.join(os2.tmpdir(), "oh-my-groundcontrol.log");
+var getLogFile = () => process.env.GROUNDCONTROL_LOG_FILE || path2.join(os2.tmpdir(), "oh-my-groundcontrol.log");
 function log(message, data) {
   try {
     const timestamp = new Date().toISOString();
     const logEntry = `[${timestamp}] ${message} ${data ? JSON.stringify(data) : ""}
 `;
-    fs2.appendFileSync(logFile, logEntry);
+    fs2.appendFileSync(getLogFile(), logEntry);
   } catch {}
 }
 
@@ -22745,6 +22755,34 @@ ${buildRetryGuidance(detected)}`;
     }
   };
 }
+// src/hooks/double-confirmation/index.ts
+var CONFIRMATION_TOOLS = new Set(["background_task", "task"]);
+var CONFIRMATION_NUDGE = `
+
+---
+[Verification Required] Before accepting this result, confirm:
+- Does the result fully address the original request?
+- Are there any loose ends or incomplete aspects?
+- Would you request any changes if reviewing this?
+If satisfied, proceed. If not, re-examine the result.`;
+function createDoubleConfirmationHook(config2) {
+  const enabled = config2?.enabled ?? false;
+  const confirmedCalls = new Set;
+  return {
+    "tool.execute.after": async (input, output) => {
+      if (!enabled)
+        return;
+      if (!CONFIRMATION_TOOLS.has(input.tool))
+        return;
+      const callKey = input.callID ?? input.sessionID ?? "";
+      if (!callKey || confirmedCalls.has(callKey))
+        return;
+      confirmedCalls.add(callKey);
+      const outputStr = String(output.output ?? "");
+      output.output = outputStr + CONFIRMATION_NUDGE;
+    }
+  };
+}
 // src/hooks/edit-error-recovery/index.ts
 var EDIT_ERROR_PATTERNS = [
   "oldString and newString must be different",
@@ -22950,7 +22988,9 @@ ${JSON_ERROR_REMINDER}`;
 }
 // src/hooks/phase-reminder/index.ts
 var PHASE_REMINDER = `<reminder>Recall Workflow Rules:
-Understand \u2192 find the best path (delegate based on rules and parallelize independent work) \u2192 execute \u2192 verify.
+Before acting: <think> \u2014 analyze what you see, what's been accomplished, what still needs to be done.
+Before executing: <plan> \u2014 describe your next steps and what you expect each to accomplish.
+Then: execute your plan, verify results, delegate based on rules, parallelize independent work.
 If delegating, launch the specialist in the same turn you mention it.</reminder>`;
 function createPhaseReminderHook() {
   return {
@@ -39159,6 +39199,7 @@ var OhMyOpenCodeLite = async (ctx) => {
   const jsonErrorRecoveryHook = createJsonErrorRecoveryHook(ctx);
   const hashlineReadEnhancerHook = createHashlineReadEnhancerHook(config3.hashline_edit);
   const editErrorRecoveryHook = createEditErrorRecoveryHook();
+  const doubleConfirmationHook = createDoubleConfirmationHook(config3.double_confirmation);
   const hashlineEditEnabled = config3.hashline_edit?.enabled !== false;
   const hashlineEditTool = hashlineEditEnabled ? createHashlineEditTool() : undefined;
   return {
@@ -39268,6 +39309,7 @@ var OhMyOpenCodeLite = async (ctx) => {
       await editErrorRecoveryHook["tool.execute.after"](input, output);
       await hashlineReadEnhancerHook["tool.execute.after"](input, output);
       await postReadNudgeHook["tool.execute.after"](input, output);
+      await doubleConfirmationHook["tool.execute.after"](input, output);
     }
   };
 };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@frenchtoastman/oh-my-groundcontrol",
-  "version": "0.0.15",
+  "version": "0.0.17",
   "description": "An OpenCode plugin for multi-agent orchestration for structured planning with NASA-style guardrails.",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",

package/src/skills/analyze/SKILL.md

@@ -0,0 +1,116 @@
+---
+name: analyze
+description: Code review and analysis for uncommitted changes, commits, branches, PRs, or specific files.
+---
+
+You are a code reviewer. Your job is to review code changes and provide actionable feedback.
+
+---
+
+Input: $ARGUMENTS
+
+---
+
+## Determining What to Review
+
+Based on the input provided, determine which type of review to perform:
+
+1. **No arguments (default)**: Review all uncommitted changes
+   - Run: `git diff` for unstaged changes
+   - Run: `git diff --cached` for staged changes
+   - Run: `git status --short` to identify untracked (net new) files
+
+2. **Commit hash** (40-char SHA or short hash): Review that specific commit
+   - Run: `git show $ARGUMENTS`
+
+3. **Branch name**: Compare current branch to the specified branch
+   - Run: `git diff $ARGUMENTS...HEAD`
+
+4. **PR URL or number** (contains "github.com" or "pull" or looks like a PR number): Review the pull request
+   - Run: `gh pr view $ARGUMENTS` to get PR context
+   - Run: `gh pr diff $ARGUMENTS` to get the diff
+
+5. **File path**: Review a specific file and its recent changes
+   - Verify the file exists and is a regular file (not a directory or binary)
+   - Read the full file contents
+   - Run: `git log --oneline -10 "$ARGUMENTS"` to see recent history
+   - Run: `git diff HEAD~5 -- "$ARGUMENTS"` to get recent changes (adjust range based on log output)
+   - Review the recent changes in context of the full file
+
+   If the file does not exist: "File not found: `<path>`. Please check the path and try again."
+   If the argument is a directory: "Cannot review a directory. Please provide a specific file path."
+
+Use best judgement when processing input.
+
+---
+
+## Gathering Context
+
+**Diffs alone are not enough.** After getting the diff, read the entire file(s) being modified to understand the full context. Code that looks wrong in isolation may be correct given surrounding logic—and vice versa.
+
+- Use the diff to identify which files changed
+- Use `git status --short` to identify untracked files, then read their full contents
+- Read the full file to understand existing patterns, control flow, and error handling
+- Check for existing style guide or conventions files (CONVENTIONS.md, AGENTS.md, .editorconfig, etc.)
+
+---
+
+## What to Look For
+
+**Bugs** - Your primary focus.
+- Logic errors, off-by-one mistakes, incorrect conditionals
+- If-else guards: missing guards, incorrect branching, unreachable code paths
+- Edge cases: null/empty/undefined inputs, error conditions, race conditions
+- Security issues: injection, auth bypass, data exposure
+- Broken error handling that swallows failures, throws unexpectedly or returns error types that are not caught.
+
+**Structure** - Does the code fit the codebase?
+- Does it follow existing patterns and conventions?
+- Are there established abstractions it should use but doesn't?
+- Excessive nesting that could be flattened with early returns or extraction
+
+**Performance** - Only flag if obviously problematic.
+- O(n^2) on unbounded data, N+1 queries, blocking I/O on hot paths
+
+**Behavior Changes** - If a behavioral change is introduced, raise it (especially if it's possibly unintentional).
+
+---
+
+## Before You Flag Something
+
+**Be certain.** If you're going to call something a bug, you need to be confident it actually is one.
+
+- Only review the changes - do not review pre-existing code that wasn't modified
+- Don't flag something as a bug if you're unsure - investigate first
+- Don't invent hypothetical problems - if an edge case matters, explain the realistic scenario where it breaks
+- If you need more context to be sure, use the tools below to get it
+
+**Don't be a zealot about style.** When checking code against conventions:
+
+- Verify the code is *actually* in violation. Don't complain about else statements if early returns are already being used correctly.
+- Some "violations" are acceptable when they're the simplest option. A `let` statement is fine if the alternative is convoluted.
+- Excessive nesting is a legitimate concern regardless of other style choices.
+- Don't flag style preferences as issues unless they clearly violate established project conventions.
+
+---
+
+## Tools
+
+Use these to inform your review:
+
+- **@explorer** - Find how existing code handles similar problems. Check patterns, conventions, and prior art before claiming something doesn't fit.
+- **@librarian** - Verify correct usage of libraries/APIs before flagging something as wrong. Research best practices if you're unsure about a pattern.
+- **@oracle** - Consult on complex architectural decisions, design pattern trade-offs, or systemic concerns that go beyond the immediate diff.
+
+If you're uncertain about something and can't verify it with these tools, say "I'm not sure about X" rather than flagging it as a definite issue.
+
+---
+
+## Output
+
+1. If there is a bug, be direct and clear about why it is a bug.
+2. Clearly communicate severity of issues. Do not overstate severity.
+3. Critiques should clearly and explicitly communicate the scenarios, environments, or inputs that are necessary for the bug to arise. The comment should immediately indicate that the issue's severity depends on these factors.
+4. Your tone should be matter-of-fact and not accusatory or overly positive. It should read as a helpful AI assistant suggestion without sounding too much like a human reviewer.
+5. Write so the reader can quickly understand the issue without reading too closely.
+6. AVOID flattery, do not give any comments that are not helpful to the reader. Avoid phrasing like "Great job ...", "Thanks for ...".