@freelancercom/phabricator-mcp 2.0.16 → 2.0.18

package/dist/tools/maniphest.js

@@ -1,5 +1,63 @@
 import { z } from 'zod';
 import { jsonCoerce } from './coerce.js';
+/**
+ * Resolve revision identifiers (e.g. "D223125", "PHID-DREV-xxx") to PHIDs.
+ * Accepts a mix of D-prefixed IDs and raw PHIDs.
+ */
+async function resolveRevisionPHIDs(client, ids) {
+    const phids = [];
+    const namesToLookup = [];
+    for (const id of ids) {
+        if (id.startsWith('PHID-')) {
+            phids.push(id);
+        }
+        else {
+            // Normalize to D-prefixed format if just a number
+            const name = /^\d+$/.test(id) ? `D${id}` : id;
+            namesToLookup.push(name);
+        }
+    }
+    if (namesToLookup.length > 0) {
+        const lookupResult = await client.call('phid.lookup', { names: namesToLookup });
+        for (const name of namesToLookup) {
+            const entry = lookupResult[name];
+            if (entry) {
+                phids.push(entry.phid);
+            }
+            else {
+                throw new Error(`Could not resolve revision identifier: ${name}`);
+            }
+        }
+    }
+    return phids;
+}
+/**
+ * Link or unlink revisions to/from a task by calling differential.revision.edit
+ * with tasks.add / tasks.remove transactions.
+ */
+async function linkRevisionsToTask(client, taskIdentifier, revisionPHIDs, action) {
+    // Resolve the task identifier to a PHID if it's a T-prefixed ID
+    let taskPHID = taskIdentifier;
+    if (!taskIdentifier.startsWith('PHID-')) {
+        const lookupResult = await client.call('phid.lookup', { names: [taskIdentifier] });
+        const entry = lookupResult[taskIdentifier];
+        if (entry) {
+            taskPHID = entry.phid;
+        }
+        else {
+            throw new Error(`Could not resolve task identifier: ${taskIdentifier}`);
+        }
+    }
+    const results = [];
+    for (const revPHID of revisionPHIDs) {
+        const result = await client.call('differential.revision.edit', {
+            objectIdentifier: revPHID,
+            transactions: [{ type: `tasks.${action}`, value: [taskPHID] }],
+        });
+        results.push(result);
+    }
+    return results;
+}
 export function registerManiphestTools(server, client) {
     // Search tasks
     server.tool('phabricator_task_search', 'Search Maniphest tasks with optional filters', {
@@ -54,7 +112,8 @@ export function registerManiphestTools(server, client) {
         subtype: z.string().optional().describe('Task subtype (e.g. "default", "incident")'),
         parentPHIDs: z.array(z.string()).optional().describe('Parent task PHIDs'),
         subtaskPHIDs: z.array(z.string()).optional().describe('Subtask PHIDs'),
-        commitPHIDs: z.array(z.string()).optional().describe('Commit PHIDs to associate'),
+        commitPHIDs: z.array(z.string()).optional().describe('Commit PHIDs to associate (for actual commits only, not revisions)'),
+        revisionIDs: z.array(z.string()).optional().describe('Differential revision IDs to link (e.g. ["D223125"] or ["PHID-DREV-xxx"]). Creates a bidirectional link between the revision and the task.'),
         points: z.coerce.number().nullable().optional().describe('Story points value (if points are enabled on this instance)'),
         space: z.string().optional().describe('Space PHID to place the task in (for multi-space installations)'),
         comment: z.string().optional().describe('Initial comment on the task (supports Remarkup)'),
@@ -102,13 +161,32 @@ export function registerManiphestTools(server, client) {
         if (params.comment !== undefined) {
             transactions.push({ type: 'comment', value: params.comment });
         }
+        const result = await client.call('maniphest.edit', { transactions });
+        const extras = {};
+        // Custom fields are applied in a second call because Phabricator validates
+        // transaction types against the default subtype during creation. Subtype-specific
+        // custom fields (e.g. incident fields) are only available after the task exists
+        // with the correct subtype.
         if (params.customFields !== undefined) {
+            const customTransactions = [];
             for (const [key, value] of Object.entries(params.customFields)) {
-                transactions.push({ type: key, value });
+                customTransactions.push({ type: key, value });
+            }
+            if (customTransactions.length > 0) {
+                extras.customFields = await client.call('maniphest.edit', {
+                    objectIdentifier: result.object.phid,
+                    transactions: customTransactions,
+                });
             }
         }
-        const result = await client.call('maniphest.edit', { transactions });
-        return { content: [{ type: 'text', text: JSON.stringify(result, null, 2) }] };
+        // Link revisions to the newly created task via differential.revision.edit
+        if (params.revisionIDs !== undefined && params.revisionIDs.length > 0) {
+            const revPHIDs = await resolveRevisionPHIDs(client, params.revisionIDs);
+            const taskId = `T${result.object.id}`;
+            extras.linkedRevisions = await linkRevisionsToTask(client, taskId, revPHIDs, 'add');
+        }
+        const output = Object.keys(extras).length > 0 ? { ...result, ...extras } : result;
+        return { content: [{ type: 'text', text: JSON.stringify(output, null, 2) }] };
     });
     // Edit task
     server.tool('phabricator_task_edit', 'Edit an existing Maniphest task', {
@@ -127,8 +205,10 @@ export function registerManiphestTools(server, client) {
         removeParentPHIDs: z.array(z.string()).optional().describe('Parent task PHIDs to remove'),
         addSubtaskPHIDs: z.array(z.string()).optional().describe('Subtask PHIDs to add'),
         removeSubtaskPHIDs: z.array(z.string()).optional().describe('Subtask PHIDs to remove'),
-        addCommitPHIDs: z.array(z.string()).optional().describe('Commit PHIDs to associate'),
-        removeCommitPHIDs: z.array(z.string()).optional().describe('Commit PHIDs to disassociate'),
+        addCommitPHIDs: z.array(z.string()).optional().describe('Commit PHIDs to associate (for actual commits only, not revisions)'),
+        removeCommitPHIDs: z.array(z.string()).optional().describe('Commit PHIDs to disassociate (for actual commits only, not revisions)'),
+        addRevisionIDs: z.array(z.string()).optional().describe('Differential revision IDs to link (e.g. ["D223125"] or ["PHID-DREV-xxx"]). Creates a bidirectional link between the revision and the task.'),
+        removeRevisionIDs: z.array(z.string()).optional().describe('Differential revision IDs to unlink (e.g. ["D223125"] or ["PHID-DREV-xxx"]).'),
         points: z.coerce.number().nullable().optional().describe('Story points value (null to clear)'),
         columnPHID: z.string().optional().describe('Move to workboard column'),
         space: z.string().optional().describe('Space PHID to move the task to (for multi-space installations)'),
@@ -201,14 +281,32 @@ export function registerManiphestTools(server, client) {
                 transactions.push({ type: key, value });
             }
         }
-        if (transactions.length === 0) {
+        const hasRevisionChanges = (params.addRevisionIDs !== undefined && params.addRevisionIDs.length > 0) ||
+            (params.removeRevisionIDs !== undefined && params.removeRevisionIDs.length > 0);
+        if (transactions.length === 0 && !hasRevisionChanges) {
             return { content: [{ type: 'text', text: 'No changes specified' }] };
         }
-        const result = await client.call('maniphest.edit', {
-            objectIdentifier: params.objectIdentifier,
-            transactions,
-        });
-        return { content: [{ type: 'text', text: JSON.stringify(result, null, 2) }] };
+        let result = undefined;
+        if (transactions.length > 0) {
+            result = await client.call('maniphest.edit', {
+                objectIdentifier: params.objectIdentifier,
+                transactions,
+            });
+        }
+        // Link/unlink revisions via differential.revision.edit
+        const revisionResults = {};
+        if (params.addRevisionIDs !== undefined && params.addRevisionIDs.length > 0) {
+            const revPHIDs = await resolveRevisionPHIDs(client, params.addRevisionIDs);
+            revisionResults.added = await linkRevisionsToTask(client, params.objectIdentifier, revPHIDs, 'add');
+        }
+        if (params.removeRevisionIDs !== undefined && params.removeRevisionIDs.length > 0) {
+            const revPHIDs = await resolveRevisionPHIDs(client, params.removeRevisionIDs);
+            revisionResults.removed = await linkRevisionsToTask(client, params.objectIdentifier, revPHIDs, 'remove');
+        }
+        const output = hasRevisionChanges
+            ? { ...(result !== undefined ? { task: result } : {}), linkedRevisions: revisionResults }
+            : result;
+        return { content: [{ type: 'text', text: JSON.stringify(output, null, 2) }] };
     });
     // Add comment to task
     server.tool('phabricator_task_add_comment', 'Add a comment to a Maniphest task', {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@freelancercom/phabricator-mcp",
-  "version": "2.0.16",
+  "version": "2.0.18",
   "description": "MCP server for Phabricator Conduit API - manage tasks, code reviews, repositories, and more",
   "type": "module",
   "main": "dist/index.js",