@franzzemen/brokenstock-shell 0.9.4 → 0.9.5

package/fesm2022/franzzemen-brokenstock-shell.mjs

@@ -2606,21 +2606,59 @@ const WINDOW_KEY = 'shell.commandTerminalVisible.window';
  * caller could `set()` it — and whether that got remembered depended on an
  * effect firing somewhere else. Persisting inside the one mutator makes it
  * impossible to change this without persisting it.
+ *
+ * ⚠ A SCREEN CAN HIDE IT WITHOUT TOUCHING THE CHOICE (projects review-defects-2026-10.prd.md E21;
+ * live-trading OT-19). The Trading screen hides the terminal on a phone. It used to do that with
+ * `toggle()`, which saved "hidden" as the default for every new window, and put it back when the
+ * screen closed. Closing the TAB never closes the screen, so the put-back never ran and the next
+ * window started hidden. `hideForScreen()` hides it in this window's memory only — nothing is
+ * written, so nothing outlives the tab — and returns the release. The person's ☰ still wins:
+ * a toggle while a screen has it hidden shows it again, and saves nothing, because the saved
+ * choice was "visible" all along.
  */
 class TerminalVisibilityService {
     constructor() {
-        this.#visible = signal(this.#readInitial(), /* @ts-ignore */
-        ...(ngDevMode ? [{ debugName: "#visible" }] : /* istanbul ignore next */ []));
+        /** The person's choice — the one that is saved. */
+        this.#choice = signal(this.#readInitial(), /* @ts-ignore */
+        ...(ngDevMode ? [{ debugName: "#choice" }] : /* istanbul ignore next */ []));
+        /** Screens currently hiding the terminal. Memory only, never saved. */
+        this.#screenHides = signal(new Set(), /* @ts-ignore */
+        ...(ngDevMode ? [{ debugName: "#screenHides" }] : /* istanbul ignore next */ []));
         /** Read-only on purpose — see the header. */
-        this.visible = this.#visible.asReadonly();
+        this.visible = computed(() => this.#choice() && this.#screenHides().size === 0, /* @ts-ignore */
+        ...(ngDevMode ? [{ debugName: "visible" }] : /* istanbul ignore next */ []));
     }
-    #visible;
+    /** The person's choice — the one that is saved. */
+    #choice;
+    /** Screens currently hiding the terminal. Memory only, never saved. */
+    #screenHides;
     toggle() {
-        const next = !this.#visible();
-        this.#visible.set(next);
+        if (this.#choice() && this.#screenHides().size > 0) {
+            // Hidden by a screen, not by the person: ☰ shows it, and the saved choice stays "visible".
+            this.#screenHides.set(new Set());
+            return;
+        }
+        const next = !this.#choice();
+        this.#choice.set(next);
         this.#write(sessionStorage, WINDOW_KEY, next);
         this.#write(localStorage, DEFAULT_KEY, next);
     }
+    /**
+     * Hides the terminal while a screen needs the room, without changing what is saved. Returns the
+     * release; call it when the screen no longer needs it hidden (and on destroy). Releasing twice,
+     * or after ☰ already showed it, does nothing.
+     */
+    hideForScreen() {
+        const token = Symbol('screen-hide');
+        this.#screenHides.update(s => new Set(s).add(token));
+        return () => this.#screenHides.update(s => {
+            if (!s.has(token))
+                return s;
+            const next = new Set(s);
+            next.delete(token);
+            return next;
+        });
+    }
     /**
      * This window's own choice wins; otherwise the last choice made anywhere;
      * otherwise visible.