@franzzemen/brokenstock-shell 0.9.3 → 0.9.5

package/README.md

@@ -15,5 +15,6 @@ Shared Angular shell library for Brokenstock web applications. Provides the foun
 - **Injection token configuration:** `SHELL_APP_NAME`, `SHELL_AUTH_URLS`, `SHELL_MENU_ITEMS`, `SHELL_COMMANDS`
 - **Content projection:** App-specific status bar items projected through `<shell-root>` into the status bar
 - **Command pattern:** `@Injectable` classes implementing `CommandDefinition`, registered via `SHELL_COMMANDS` token
+- **Questions and screen keys:** `CommandService.ask` leaves a question open in the terminal (the next line answers it, Esc cancels); `ScreenKeysService` gives a screen keys of its own on its routes (Ctrl allowed, live in the terminal) — see the guide
 - **Signal-based state:** All services use Angular signals; no RxJS in public APIs
 - **Peer dependencies:** Angular 21, Material, CDK, @franzzemen/identity, @franzzemen/utility, zod, rxjs

package/fesm2022/franzzemen-brokenstock-shell.mjs

@@ -13,7 +13,7 @@ import { gfmHeadingId } from 'marked-gfm-heading-id';
 import fm from 'front-matter';
 import { NgClass, CommonModule, DOCUMENT, isPlatformBrowser, DatePipe } from '@angular/common';
 import { Title, Meta } from '@angular/platform-browser';
-import { z } from 'zod/v4';
+import { array, string } from 'zod/v4';
 import * as i1 from '@angular/material/icon';
 import { MatIconModule } from '@angular/material/icon';
 import * as i2 from '@angular/material/tooltip';
@@ -2606,21 +2606,59 @@ const WINDOW_KEY = 'shell.commandTerminalVisible.window';
  * caller could `set()` it — and whether that got remembered depended on an
  * effect firing somewhere else. Persisting inside the one mutator makes it
  * impossible to change this without persisting it.
+ *
+ * ⚠ A SCREEN CAN HIDE IT WITHOUT TOUCHING THE CHOICE (projects review-defects-2026-10.prd.md E21;
+ * live-trading OT-19). The Trading screen hides the terminal on a phone. It used to do that with
+ * `toggle()`, which saved "hidden" as the default for every new window, and put it back when the
+ * screen closed. Closing the TAB never closes the screen, so the put-back never ran and the next
+ * window started hidden. `hideForScreen()` hides it in this window's memory only — nothing is
+ * written, so nothing outlives the tab — and returns the release. The person's ☰ still wins:
+ * a toggle while a screen has it hidden shows it again, and saves nothing, because the saved
+ * choice was "visible" all along.
  */
 class TerminalVisibilityService {
     constructor() {
-        this.#visible = signal(this.#readInitial(), /* @ts-ignore */
-        ...(ngDevMode ? [{ debugName: "#visible" }] : /* istanbul ignore next */ []));
+        /** The person's choice — the one that is saved. */
+        this.#choice = signal(this.#readInitial(), /* @ts-ignore */
+        ...(ngDevMode ? [{ debugName: "#choice" }] : /* istanbul ignore next */ []));
+        /** Screens currently hiding the terminal. Memory only, never saved. */
+        this.#screenHides = signal(new Set(), /* @ts-ignore */
+        ...(ngDevMode ? [{ debugName: "#screenHides" }] : /* istanbul ignore next */ []));
         /** Read-only on purpose — see the header. */
-        this.visible = this.#visible.asReadonly();
+        this.visible = computed(() => this.#choice() && this.#screenHides().size === 0, /* @ts-ignore */
+        ...(ngDevMode ? [{ debugName: "visible" }] : /* istanbul ignore next */ []));
     }
-    #visible;
+    /** The person's choice — the one that is saved. */
+    #choice;
+    /** Screens currently hiding the terminal. Memory only, never saved. */
+    #screenHides;
     toggle() {
-        const next = !this.#visible();
-        this.#visible.set(next);
+        if (this.#choice() && this.#screenHides().size > 0) {
+            // Hidden by a screen, not by the person: ☰ shows it, and the saved choice stays "visible".
+            this.#screenHides.set(new Set());
+            return;
+        }
+        const next = !this.#choice();
+        this.#choice.set(next);
         this.#write(sessionStorage, WINDOW_KEY, next);
         this.#write(localStorage, DEFAULT_KEY, next);
     }
+    /**
+     * Hides the terminal while a screen needs the room, without changing what is saved. Returns the
+     * release; call it when the screen no longer needs it hidden (and on destroy). Releasing twice,
+     * or after ☰ already showed it, does nothing.
+     */
+    hideForScreen() {
+        const token = Symbol('screen-hide');
+        this.#screenHides.update(s => new Set(s).add(token));
+        return () => this.#screenHides.update(s => {
+            if (!s.has(token))
+                return s;
+            const next = new Set(s);
+            next.delete(token);
+            return next;
+        });
+    }
     /**
      * This window's own choice wins; otherwise the last choice made anywhere;
      * otherwise visible.
@@ -2936,6 +2974,19 @@ i0.ɵɵngDeclareClassMetadata({ minVersion: "12.0.0", version: "22.1.2", ngImpor
             args: [{ providedIn: 'root' }]
         }], ctorParameters: () => [] });
 
+/*
+ * The only door to zod in the shell (projects review-defects-2026-10.prd.md E20, D25).
+ *
+ * Library files import `* as z` from HERE, never from 'zod', so call sites read as before
+ * (`z.array(z.string())`) but the app's bundler sees a module re-exporting two functions and can
+ * drop the rest. Importing `{z}` from 'zod/v4' hands it the whole library as one object instead:
+ * 454 kB in the browser's first download in a measured test bundle, against 79 kB this way.
+ *
+ * A command needing another zod function adds it below; the compiler refuses anything not listed.
+ * `zod-door.spec.ts` fails if any other library file imports zod directly. Specs are exempt: they
+ * never reach a bundle.
+ */
+
 const FAQ_USAGE = 'faq\n' +
     'faq <key>\n' +
     'faq search <term>\n' +
@@ -2956,7 +3007,7 @@ class FaqCommand {
         this.usage = FAQ_USAGE;
         this.requiresAuth = false;
         this.scope = 'global';
-        this.argsSchema = z.array(z.string()).max(50);
+        this.argsSchema = array(string()).max(50);
     }
     execute(args) {
         const ts = () => new Date();
@@ -3157,7 +3208,7 @@ class PendingPromptState {
     }
 }
 
-const CommandInputSchema = z.string().trim().min(1, 'Command cannot be empty');
+const CommandInputSchema = string().trim().min(1, 'Command cannot be empty');
 class CommandService {
     #prompts;
     /**