@franzzemen/brokenstock-shell 0.4.4 → 0.4.5

package/fesm2022/franzzemen-brokenstock-shell.mjs

@@ -233,8 +233,17 @@ path here is bounded regardless.
 fall back to running uncoordinated — today's behaviour — never throw. A missing
 API must not be the reason nobody can sign in.
 */
-const LOCKS_AVAILABLE = typeof navigator !== 'undefined'
-    && typeof navigator.locks?.request === 'function';
+/**
+ * Checked at CALL time, not once at module load.
+ *
+ * Module-level would be evaluated during import — before `navigator` exists at
+ * all under prerendering, and before a test can arrange anything — permanently
+ * fixing the answer to "no" for the life of the process. Found by writing the
+ * test for the fallback path, which could not be reached any other way.
+ */
+function locksAvailable() {
+    return typeof navigator !== 'undefined' && typeof navigator.locks?.request === 'function';
+}
 /**
  * Runs `work` if this window can take the lock right now.
  *
@@ -246,7 +255,7 @@ const LOCKS_AVAILABLE = typeof navigator !== 'undefined'
  * deliberate degradation to today's behaviour rather than a refusal.
  */
 async function runExclusive(name, work) {
-    if (!LOCKS_AVAILABLE) {
+    if (!locksAvailable()) {
         console.warn(`[shell] navigator.locks unavailable; "${name}" runs without cross-window coordination`);
         return { ran: true, value: await work() };
     }
@@ -281,6 +290,40 @@ async function awaitChange(read, unchanged, timeoutMs, pollMs = 100) {
     }
 }
 
+/*
+Created by Franz Zemen 2026-08-29
+License Type: UNLICENSED
+
+What a window should do once it can act on a session renewal
+(multiple-windows PRD D5).
+
+WHY THIS IS A NAMED FUNCTION RATHER THAN THREE `if`s INSIDE THE SERVICE. The
+rule was originally written as "retry with a token different from the one you
+failed with", which is not a well-defined instruction: the in-window
+single-flight already collapses requests that were sent with DIFFERENT tokens,
+so "the one you failed with" is not a single value. Pulling the decision out
+forces the three cases to be named, and lets them be tested without mocking a
+network call — which is what they deserve, because getting this wrong shows up
+hours later as "a window signed me out" with nothing linking cause to effect.
+*/
+/**
+ * @param before  the token this window held immediately BEFORE asking for the lock
+ * @param current the token in shared storage now that this window can act
+ */
+function decideRenewal(before, current) {
+    // Gone. Retrying would present nothing and 401 again; worse, it would look
+    // like a transient failure when it is a definite answer.
+    if (before && !current)
+        return 'sign-out';
+    // Someone else's fresh token. Rotating again would invalidate the token every
+    // OTHER window just adopted — turning one window's recovery into everyone
+    // else's sign-out.
+    if (current && current !== before)
+        return 'adopt';
+    // Unchanged, or nothing stored to begin with.
+    return 'renew';
+}
+
 /** Name of the cross-window renewal lock (PRD D5). */
 const RENEWAL_LOCK = 'brokenstock.session.renew';
 /** How long a window waits for the renewing window to publish a token (PRD D5). */
@@ -547,17 +590,15 @@ class AuthenticationService {
      */
     async #renewOrAdopt(before) {
         const current = this.#store.read();
-        // Gone: whoever held the lock before us renewed and then failed permanently,
-        // or signed out. Retrying would present nothing and 401 again.
-        if (before && !current)
-            return false;
-        // Someone renewed while we queued. Adopt their work; do not rotate again —
-        // a second rotation would invalidate the token every other window just took.
-        if (current && current !== before) {
-            this.#auth = current;
-            return true;
+        switch (decideRenewal(before, current)) {
+            case 'sign-out':
+                return false;
+            case 'adopt':
+                this.#auth = current;
+                return true;
+            case 'renew':
+                return this.#renew();
         }
-        return this.#renew();
     }
     /**
      * The renewal request itself.
@@ -3165,5 +3206,5 @@ i0.ɵɵngDeclareClassMetadata({ minVersion: "12.0.0", version: "22.1.2", ngImpor
  * Generated bundle index. Do not edit.
  */
 
-export { AuthenticationService, CLEAR_USAGE, CommandRegistryService, CommandService, CommandTerminal, ConfirmDialog, FAQ_CONTENT_LOADER, FAQ_DEV_EDITOR, FAQ_DEV_MODE, FAQ_DEV_WORKSPACE_ROOT, FAQ_PUBLIC_PUBLISHER, FAQ_PUBLIC_SITE_BASE_URL, FaqAuthoringPanel, FaqHistoryService, FaqMarkdownRendererService, FaqModal, FaqService, HELP_USAGE, HttpFaqContentLoader, KeyboardShortcutService, Login, MainContent, PublicFaqIndex, PublicFaqPage, PublicFaqToc, RegexValidatorDirective, SESSION_TOKEN_KEY, SHELL_APP_NAME, SHELL_AUTH_URLS, SHELL_COMMANDS, SHELL_MENU_ITEMS, SHELL_POST_LOGIN_ROUTE, SHELL_SHARED_SESSION, SessionTokenStore, Shell, SideMenu, StatusBar, TerminalFocusService, TerminalVisibilityService, ThemeService, ThinkingService, audienceAllowed, authGuard, authInterceptor, buildFallbackChain, guestGuard, provideShellConfig, tokenize };
+export { AuthenticationService, CLEAR_USAGE, CommandRegistryService, CommandService, CommandTerminal, ConfirmDialog, FAQ_CONTENT_LOADER, FAQ_DEV_EDITOR, FAQ_DEV_MODE, FAQ_DEV_WORKSPACE_ROOT, FAQ_PUBLIC_PUBLISHER, FAQ_PUBLIC_SITE_BASE_URL, FaqAuthoringPanel, FaqHistoryService, FaqMarkdownRendererService, FaqModal, FaqService, HELP_USAGE, HttpFaqContentLoader, KeyboardShortcutService, Login, MainContent, PublicFaqIndex, PublicFaqPage, PublicFaqToc, RegexValidatorDirective, SESSION_TOKEN_KEY, SHELL_APP_NAME, SHELL_AUTH_URLS, SHELL_COMMANDS, SHELL_MENU_ITEMS, SHELL_POST_LOGIN_ROUTE, SHELL_SHARED_SESSION, SessionTokenStore, Shell, SideMenu, StatusBar, TerminalFocusService, TerminalVisibilityService, ThemeService, ThinkingService, audienceAllowed, authGuard, authInterceptor, buildFallbackChain, decideRenewal, guestGuard, provideShellConfig, tokenize };
 //# sourceMappingURL=franzzemen-brokenstock-shell.mjs.map