@franzzemen/brokenstock-shell 0.4.2 → 0.4.3

package/fesm2022/franzzemen-brokenstock-shell.mjs

@@ -1913,11 +1913,30 @@ class KeyboardShortcutService {
             this.#document.addEventListener('keydown', (event) => {
                 this.#handleKeydown(event);
             });
-            // Focus moves are what change `suppressed`, and they are frequent — kept
-            // out of the zone, with the signal written directly. A signal write marks
-            // its consumers dirty on its own; it does not need a change-detection pass
-            // of its own to be scheduled here.
-            const refresh = () => this.suppressed.set(this.#isSuppressed());
+            // ⚠ THE WRITE IS DEFERRED, AND THAT IS NOT AN OPTIMISATION.
+            //
+            // `element.focus()` dispatches `focusin` SYNCHRONOUSLY. Angular calls
+            // `.focus()` from template-driven code — an autofocused input, the shell's
+            // terminal reclaiming focus — so this listener can run in the middle of a
+            // render, and a signal write there throws NG0600, "writing to signals is
+            // not allowed while Angular renders the template".
+            //
+            // That throw shipped: it aborted the login transition, so the sign-in POST
+            // returned 200 and the app still showed "not logged in", with every
+            // authenticated request that followed answering 401. Nothing in the failure
+            // pointed at the keyboard.
+            //
+            // A microtask runs after the render completes, which is soon enough for an
+            // indicator a human reads and late enough to be outside the reactive
+            // context. The value is compared first so an unchanged focus move writes
+            // nothing at all.
+            const refresh = () => {
+                queueMicrotask(() => {
+                    const next = this.#isSuppressed();
+                    if (next !== this.suppressed())
+                        this.suppressed.set(next);
+                });
+            };
             this.#document.addEventListener('focusin', refresh, true);
             this.#document.addEventListener('focusout', refresh, true);
         });
@@ -1925,7 +1944,13 @@ class KeyboardShortcutService {
     registerGroup(groupId, shortcuts) {
         this.#groups.set(groupId, shortcuts);
         this.#activeGroupId.set(groupId);
-        this.suppressed.set(this.#isSuppressed());
+        // Same hazard as the focus listener above: a screen registers from
+        // `ngOnInit`, which Angular may run inside a render.
+        queueMicrotask(() => {
+            const next = this.#isSuppressed();
+            if (next !== this.suppressed())
+                this.suppressed.set(next);
+        });
     }
     unregisterGroup(groupId) {
         this.#groups.delete(groupId);