@frankieai/core 0.2.1 → 0.2.2

package/dist/index.js

@@ -97,10 +97,16 @@ var modelConfigSchema = z2.object({
    */
   provider: z2.string().min(1).default("fireworks"),
   /**
-   * Model id within that provider. The default is Kimi K2.7 on Fireworks,
-   * which serves a native Anthropic-Messages endpoint and a 262K window.
+   * Model id within that provider. The default is Kimi K3 on Fireworks, served
+   * over the OpenAI-completions API. Crucially for an embedded chat widget, that
+   * endpoint returns the model's reasoning in a separate `reasoning_content`
+   * field (surfaced as a thinking stream the client gates off), rather than
+   * inlining it in the visible text channel — so the model's private planning
+   * never leaks into the user-facing reply. The earlier Anthropic-Messages Kimi
+   * builds emitted that reasoning as plain text on Fireworks, which no marker or
+   * prompt reliably suppressed.
    */
-  model: z2.string().default("accounts/fireworks/models/kimi-k2p7-code"),
+  model: z2.string().default("accounts/fireworks/models/kimi-k3"),
   /** Env var holding the provider key. Never put the key in config itself. */
   apiKeyEnv: z2.string().default("FIREWORKS_API_KEY"),
   /** Override the provider's base URL (self-hosted gateways, tests). */
@@ -174,7 +180,16 @@ var apiCapabilitySchema = z2.object({
   operationId: z2.string().min(1),
   method: z2.enum(["GET", "POST", "PUT", "PATCH", "DELETE"]),
   path: z2.string().min(1),
-  summary: z2.string().optional()
+  summary: z2.string().optional(),
+  /**
+   * True when this is a write operation the spec requires auth for, but the
+   * source has no way to authorize it as the specific calling user — no
+   * forwarded user token or claim, only (at best) a static/shared credential.
+   * A configured `security` credential never clears this on its own: it
+   * authorizes every call the same way regardless of who is chatting, which
+   * is a backend gap to flag, not something a spec or credential change fixes.
+   */
+  authGap: z2.boolean().default(false)
 });
 var apiSourceSchema = z2.object({
   name: z2.string().min(1).regex(/^[a-z0-9][a-z0-9_-]*$/i, "API source names must be alphanumeric with - or _"),
@@ -213,6 +228,17 @@ var apiSourceSchema = z2.object({
   forwardUserTokenAs: z2.string().optional(),
   /** Extra claims from the user token to forward as `x-frankie-<claim>`. */
   forwardUserClaims: z2.array(z2.string()).default([]),
+  /**
+   * Credentials for the spec's own `components.securitySchemes`, keyed by
+   * scheme name. Frankie applies each per-operation `security` requirement at
+   * the location and with the prefix the scheme declares (an `apiKey` scheme
+   * goes to its named header/query/cookie; an `http` `bearer` or `oauth2`
+   * scheme becomes an `Authorization: Bearer` header; `http` `basic` takes a
+   * `user:pass` value and is base64-encoded automatically). Without this, a
+   * spec with per-operation auth falls back to the source's static `headers`
+   * for every operation, which is often wrong for at least some of them.
+   */
+  security: z2.record(z2.string(), z2.string()).default({}),
   /** Per-call timeout. */
   timeoutMs: z2.number().int().positive().default(3e4),
   /** Response bodies longer than this are truncated before the model sees them. */
@@ -298,8 +324,16 @@ var frankieConfigSchema = z2.object({
   /** Opt-in end-user chat capabilities (attachments, model picker). */
   features: featuresConfigSchema
 });
+var LEAKY_MODEL_MIGRATION = {
+  "accounts/fireworks/models/kimi-k2p7-code": "accounts/fireworks/models/kimi-k3"
+};
 function parseFrankieConfig(input) {
-  return frankieConfigSchema.parse(input);
+  const config = frankieConfigSchema.parse(input);
+  if (config.model.provider === "fireworks") {
+    const migrated = LEAKY_MODEL_MIGRATION[config.model.model];
+    if (migrated) config.model.model = migrated;
+  }
+  return config;
 }
 function defineFrankieConfig(config) {
   return config;
@@ -444,20 +478,24 @@ export async function POST() {
     } catch {
     }
   }
+  const middlewareMatchers = nextMiddlewareMatchers(files, sourceRoot, root);
   const paths = {};
+  let withheld = 0;
   for (const [file, content] of Object.entries(files)) {
     if (/\.(test|spec)\.[tj]sx?$/.test(file)) continue;
     const nextRoute = file.match(/(?:^|\/)app(\/.*)\/route\.[tj]s$/);
     if (nextRoute) {
       const path = nextRoute[1].replace(/\/\([^/]+\)/g, "").replace(/\[([^\]]+)\]/g, "{$1}");
       if (path.includes("...") || /\/(?:auth|frankie)(?:\/|$)/.test(path)) continue;
+      const guarded = matchesAnyMatcher(middlewareMatchers, path);
       for (const method of ["GET", "POST", "PUT", "PATCH", "DELETE"]) {
-        if (new RegExp("export\\s+(?:(?:async\\s+)?function\\s+" + method + "\\b|(?:const|let)\\s+" + method + "\\s*=)").test(content))
-          addInstallOperation(paths, method, path, file);
+        if (new RegExp("export\\s+(?:(?:async\\s+)?function\\s+" + method + "\\b|(?:const|let)\\s+" + method + "\\s*=)").test(content)) {
+          if (!addInstallOperation(paths, method, path, file, guarded)) withheld += 1;
+        }
       }
     } else if (/\.[tj]s$/.test(file) && /(?:routes?|api)\//.test(file)) {
-      for (const match of content.matchAll(/\b(?:app|router|fastify)\.(get|post|put|patch|delete)(?:\s*<[^;]{1,1600}?>)?\s*\(\s*["']([^"']+)["']/g))
-        addInstallOperation(paths, match[1].toUpperCase(), match[2].replace(/:([A-Za-z0-9_]+)/g, "{$1}"), file);
+      for (const match of content.matchAll(/\b(?:app|router|fastify)\.(get|post|put|patch|delete)(?:\s*<[^;]{1,1600}?>)?\s*\(\s*["']([^"']+)["'](\s*,\s*[A-Za-z_$][\w$]*\s*,)?/g))
+        if (!addInstallOperation(paths, match[1].toUpperCase(), match[2].replace(/:([A-Za-z0-9_]+)/g, "{$1}"), file, Boolean(match[3]))) withheld += 1;
     }
   }
   doc ??= { openapi: "3.0.3", info: { title: workspace.name + " API", version: "1.0.0", description: "Generated route inventory. Review schemas, authorization, and the deployed origin before enabling tools." }, paths };
@@ -466,6 +504,7 @@ export async function POST() {
   const operationCount = Object.values(doc.paths).reduce((n, item) => n + Object.keys(item).filter((m) => /^(get|post|put|patch|delete)$/.test(m)).length, 0);
   out.set(specPath, JSON.stringify(doc, null, 2) + "\n");
   if (!operationCount) notes.push("No supported API routes detected. The OpenAPI draft has no operations; add the real schema before connecting tools.");
+  if (withheld) notes.push(`Withheld ${withheld} newly discovered write operation(s) with no detected authorization guard (an Express/Fastify middleware argument, or a Next.js middleware.ts matcher covering the route). Add them to the spec yourself once they're protected.`);
   notes.push("Generated OpenAPI includes read and write routes. Review schemas before approving tools; new connections still default to GET-only access.");
   notes.push("Verify the public spec URL is reachable without dashboard authentication before connecting it.");
   notes.push("The token endpoint issues a signed user JWT, but your product API must validate it and enforce user/resource permissions before exposing tools.");
@@ -492,8 +531,10 @@ ${notes.map((n) => "- " + n).join("\n")}
   assertNoCommittedFrankieKeys(planned);
   return { files: planned, root, chatPath, specPath, operationCount, needsAuthSetup, notes };
 }
-function addInstallOperation(paths, method, path, file) {
-  if (path.includes("*") || !path.startsWith("/") || /\/(?:auth|frankie)(?:\/|$)/.test(path)) return;
+var WRITE_METHODS = /* @__PURE__ */ new Set(["post", "put", "patch", "delete"]);
+function addInstallOperation(paths, method, path, file, guarded) {
+  if (path.includes("*") || !path.startsWith("/") || /\/(?:auth|frankie)(?:\/|$)/.test(path)) return true;
+  if (WRITE_METHODS.has(method.toLowerCase()) && !guarded) return false;
   (paths[path] ??= {})[method.toLowerCase()] = {
     operationId: (method.toLowerCase() + "_" + path).replace(/[^a-zA-Z0-9_]+/g, "_"),
     summary: method + " " + path,
@@ -502,6 +543,32 @@ function addInstallOperation(paths, method, path, file) {
     responses: { "200": { description: "Successful response" } },
     "x-frankie-review-required": true
   };
+  return true;
+}
+function nextMiddlewareMatchers(files, sourceRoot, root) {
+  const candidates = [.../* @__PURE__ */ new Set([sourceRoot + "middleware.ts", sourceRoot + "middleware.js", root + "middleware.ts", root + "middleware.js"])];
+  for (const candidate of candidates) {
+    const content = files[candidate];
+    if (typeof content !== "string") continue;
+    const config = content.match(/export\s+const\s+config\s*=\s*\{([^}]*)\}/);
+    if (!config) continue;
+    const matcher = config[1].match(/matcher\s*:\s*(\[[^\]]*\]|["'`][^"'`]*["'`])/);
+    if (!matcher) return [];
+    const raw = matcher[1];
+    return raw.startsWith("[") ? [...raw.matchAll(/["'`]([^"'`]+)["'`]/g)].map((m) => m[1]) : [raw.slice(1, -1)];
+  }
+  return [];
+}
+function matchesAnyMatcher(matchers, path) {
+  return matchers.some((pattern) => {
+    if (/[()|]/.test(pattern)) return false;
+    const glob = pattern.replace(/:[A-Za-z0-9_]+\*/g, "**").replace(/:[A-Za-z0-9_]+\+?/g, "*");
+    const escaped = glob.replace(/[.+^${}()|[\]\\]/g, "\\$&");
+    const trailingDeep = escaped.endsWith("/**");
+    const body = trailingDeep ? escaped.slice(0, -3) : escaped;
+    const regexBody = body.split("**").map((chunk) => chunk.replace(/\*/g, "[^/]*")).join(".*") + (trailingDeep ? "(?:/.*)?" : "");
+    return new RegExp(`^${regexBody}$`).test(path);
+  });
 }
 
 // src/sdk-updates.ts
@@ -528,20 +595,20 @@ jobs:
     outputs:
       base: $GH steps.base.outputs.sha }}
     steps:
-      - uses: actions/checkout@11d5960a326750d5838078e36cf38b85af677262
+      - uses: actions/checkout@fbc6f3992d24b796d5a048ff273f7fcc4a7b6c09
         with:
           persist-credentials: false
       - id: base
         run: echo "sha=$(git rev-parse HEAD)" >> "$GITHUB_OUTPUT"
-      - uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020
+      - uses: actions/setup-node@a0853c24544627f65ddf259abe73b1d18a591444
         with:
-          node-version: 22
+          node-version: 24
       - name: Install pinned pnpm
         run: npm install --global --ignore-scripts pnpm@10.33.0
       - name: Prepare SDK and lockfile together
         run: |
           test -f pnpm-lock.yaml
-          pnpm --recursive --include-workspace-root update '@frankieai/react@latest' '@frankieai/core@latest' '@frankieai/cli@latest' '@frankieai/server@latest' --lockfile-only --ignore-scripts --ignore-pnpmfile
+          pnpm --recursive --include-workspace-root update '@frankieai/react@latest' '@frankieai/core@latest' '@frankieai/cli@latest' '@frankieai/server@latest' --lockfile-only --ignore-scripts --ignore-pnpmfile --config.manage-package-manager-versions=false --config.package-manager-strict-version=false
       - name: Package allowlisted changes
         run: |
           node --input-type=module <<'NODE'
@@ -557,7 +624,7 @@ jobs:
           mkdirSync('frankie-update-artifact', {recursive:true});
           writeFileSync('frankie-update-artifact/changes.json', JSON.stringify(files));
           NODE
-      - uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02
+      - uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a
         with:
           name: frankie-sdk-update
           path: frankie-update-artifact/changes.json
@@ -571,11 +638,11 @@ jobs:
       pull-requests: write
     steps:
       # Separate runner: no checkout, repository hooks, install scripts, or builds.
-      - uses: actions/download-artifact@d3f86a106a0bac45b974a628896c90dbdf5c8093
+      - uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c
         with:
           name: frankie-sdk-update
           path: artifact
-      - uses: actions/github-script@f28e40c7f34bde8b3046d885e986cb6290c5673b
+      - uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd
         env:
           BASE_SHA: $GH needs.prepare.outputs.base }}
         with:
@@ -592,6 +659,7 @@ jobs:
             if (current.data.object.sha !== base) throw Error('Default branch changed. Run the updater again.');
             const existing = await github.paginate(github.rest.pulls.list, {owner,repo,state:'open',per_page:100});
             if (existing.some(pr => pr.head.repo?.full_name === owner + '/' + repo && pr.head.ref.startsWith('frankie/sdk-update-'))) { core.notice('An SDK update PR already exists; review it first.'); return; }
+            const canonical = value => Array.isArray(value) ? '[' + value.map(canonical).join(',') + ']' : value && typeof value === 'object' ? '{' + Object.keys(value).sort().map(key => JSON.stringify(key) + ':' + canonical(value[key])).join(',') + '}' : JSON.stringify(value);
             const clean = value => {
               const copy = JSON.parse(JSON.stringify(value));
               for (const group of ['dependencies','devDependencies','optionalDependencies']) {
@@ -599,6 +667,7 @@ jobs:
               }
               return copy;
             };
+            let sdkChanged = false;
             const seen = new Set();
             for (const file of files) {
               if (!file || typeof file.path !== 'string' || typeof file.content !== 'string' || seen.has(file.path)) throw Error('Invalid update file');
@@ -609,14 +678,16 @@ jobs:
                 const original = await github.rest.repos.getContent({owner,repo,path:file.path,ref:base});
                 const before = JSON.parse(Buffer.from(original.data.content, 'base64').toString());
                 const after = JSON.parse(file.content);
-                if (JSON.stringify(clean(before)) !== JSON.stringify(clean(after))) throw Error('Non-SDK manifest change');
+                if (canonical(clean(before)) !== canonical(clean(after))) throw Error('Non-SDK manifest change in ' + file.path);
                 for (const group of ['dependencies','devDependencies','optionalDependencies']) {
                   const sdkKeys = value => Object.keys(value[group] || {}).filter(key => key.startsWith('@frankieai/')).sort();
                   if (JSON.stringify(sdkKeys(before)) !== JSON.stringify(sdkKeys(after))) throw Error('SDK dependency added or removed');
+                  if (sdkKeys(after).some(key => before[group][key] !== after[group][key])) sdkChanged = true;
                   for (const [key, value] of Object.entries(after[group] || {})) if (key.startsWith('@frankieai/') && !/^[~^]?\d+\.\d+\.\d+$/.test(value)) throw Error('Only stable SDK releases are supported');
                 }
               }
             }
+            if (!sdkChanged) { core.notice('Frankie SDK versions are unchanged; no formatting-only update PR is needed.'); return; }
             if (!seen.has('pnpm-lock.yaml')) throw Error('SDK update must include the lockfile');
             const parent = await github.rest.git.getCommit({owner,repo,commit_sha:base});
             const tree = await github.rest.git.createTree({owner,repo,base_tree:parent.data.tree.sha,tree:files.map(f => ({...f,mode:'100644',type:'blob'}))});
@@ -664,15 +735,71 @@ function validateApiDocument(value) {
 function operationId(method, path, op) {
   return typeof op.operationId === "string" ? op.operationId : `${method}_${path.replace(/[{}]/g, "").replace(/[^a-zA-Z0-9]+/g, "_").replace(/^_|_$/g, "")}`;
 }
+function resolvePointer(doc, ref) {
+  let current = doc;
+  for (const segment of ref.slice(2).split("/")) {
+    if (!current || typeof current !== "object") return void 0;
+    current = current[segment.replace(/~1/g, "/").replace(/~0/g, "~")];
+  }
+  return current;
+}
+function reachableDefinitions(doc, roots) {
+  const resolved = {};
+  const visit = (node) => {
+    if (Array.isArray(node)) {
+      for (const entry of node) visit(entry);
+      return;
+    }
+    if (!node || typeof node !== "object") return;
+    for (const [key, value] of Object.entries(node)) {
+      if (key === "$ref" && typeof value === "string") {
+        if (value in resolved) continue;
+        const target = resolvePointer(doc, value);
+        resolved[value] = target ?? null;
+        visit(target);
+        continue;
+      }
+      visit(value);
+    }
+  };
+  for (const root of roots) visit(root);
+  return resolved;
+}
 function apiOperations(doc) {
   const operations = /* @__PURE__ */ new Map();
-  const { paths, info: _info, "x-frankie-review": _review, ...shared } = doc;
-  for (const [path, item] of Object.entries(paths)) {
+  for (const [path, item] of Object.entries(doc.paths)) {
     const parameters = Object.fromEntries(Object.entries(item).filter(([key]) => !apiMethods.includes(key)));
-    for (const method of apiMethods) if (item[method]) operations.set(method.toUpperCase() + " " + path, { id: operationId(method, path, item[method]), fingerprint: canonicalJson({ shared, parameters, operation: item[method] }) });
+    for (const method of apiMethods) {
+      const operation = item[method];
+      if (!operation) continue;
+      operations.set(method.toUpperCase() + " " + path, {
+        id: operationId(method, path, operation),
+        // Fingerprint what the operation's contract actually depends on: itself,
+        // the path item's shared fields, the definitions it reaches by `$ref`, and
+        // the document-level `security` that applies only where it declares none.
+        // Folding in the whole document instead meant one unrelated schema — or an
+        // `openapi` version bump — revoked every approval on the source.
+        // Document-level `servers` stays out deliberately: a refresh whose servers
+        // moved is already rejected unless the operator pinned an explicit baseUrl,
+        // and that override wins over the spec anyway (see agent/openapi.ts).
+        fingerprint: canonicalJson({
+          operation,
+          parameters,
+          security: operation["security"] === void 0 ? doc.security ?? null : null,
+          definitions: reachableDefinitions(doc, [operation, parameters])
+        })
+      });
+    }
   }
   return operations;
 }
+function matchPath(glob, path) {
+  const escaped = glob.replace(/[.+^${}()|[\]\\]/g, "\\$&");
+  const trailingDeep = escaped.endsWith("/**");
+  const body = trailingDeep ? escaped.slice(0, -3) : escaped;
+  const pattern = body.split("**").map((chunk) => chunk.replace(/\*/g, "[^/]*")).join(".*") + (trailingDeep ? "(?:/.*)?" : "");
+  return new RegExp(`^${pattern}$`).test(path);
+}
 function compareApiDocuments(before, after) {
   const old = apiOperations(before), next = apiOperations(after);
   return {
@@ -702,6 +829,7 @@ export {
   featuresConfigSchema,
   frankieConfigSchema,
   limitsConfigSchema,
+  matchPath,
   mcpServerSchema,
   modelChoiceSchema,
   modelConfigSchema,