@fradser/pi-agent-teams 0.6.0 → 0.8.0

package/src/picker-keys.ts

@@ -0,0 +1,30 @@
+/**
+ * Keystroke routing for the teammate-model picker. Pure mapping from raw
+ * terminal input to picker actions so the collision-prone decision table is
+ * unit-testable without a TUI: every printable character (letters included)
+ * must route to typing, never to a shortcut.
+ */
+
+import { Key, matchesKey } from "@earendil-works/pi-tui";
+
+export type PickerKeyAction =
+  | { kind: "type"; text: string }
+  | { kind: "backspace" }
+  | { kind: "up" }
+  | { kind: "down" }
+  | { kind: "confirm" }
+  | { kind: "cancel" };
+
+/** Map one raw input event to a picker action, or undefined when the event
+ *  is not a picker key (multi-byte pastes, unhandled control sequences). */
+export function mapPickerKey(data: string): PickerKeyAction | undefined {
+  if (matchesKey(data, Key.escape)) return { kind: "cancel" };
+  if (matchesKey(data, Key.enter)) return { kind: "confirm" };
+  if (matchesKey(data, Key.up)) return { kind: "up" };
+  if (matchesKey(data, Key.down)) return { kind: "down" };
+  if (matchesKey(data, Key.backspace) || matchesKey(data, Key.delete)) return { kind: "backspace" };
+  // Printable characters are always search text — letters like "c" must
+  // never double as shortcuts in a type-to-filter list.
+  if (data.length === 1 && data >= " ") return { kind: "type", text: data };
+  return undefined;
+}

package/src/state.ts

@@ -13,6 +13,7 @@ import {
   type TeamState,
   type WorkerReportEvent,
 } from "./types.ts";
+import { nonEmpty } from "@fradser/pi-kit";
 
 export const MAX_LEADER_MAILBOX_MESSAGES = 4096;
 /** FIFO cap of remembered peer message ids per inbox (dedup guard). */
@@ -22,10 +23,9 @@ export const MAX_TASK_DEPENDENCIES = 32;
 function emptyState(): TeamState {
   return {
     teammates: {},
-    tasks: {},
+    tasks: emptyTaskMap(),
     leaderMailbox: [],
     messageCounter: 0,
-    taskCounter: 0,
     workerEventOffsets: {},
     workerEventIds: {},
     peerInboxOffsets: {},
@@ -58,11 +58,30 @@ function nextMessageId(): string {
   return `msg_${++state.messageCounter}`;
 }
 
+/** Task maps must not inherit Object.prototype: slug ids like "constructor"
+ *  are legal task ids and must never alias inherited properties. */
+function emptyTaskMap(): Record<string, BoardTask> {
+  return Object.create(null);
+}
+
 export function resetState(): void {
   state = emptyState();
   markStateDirty();
 }
 
+// ── Team default model ──────────────────────────────────────
+
+/** The unified teammate model for this session, or undefined when Pi picks. */
+export function getTeamDefaultModel(): string | undefined {
+  return state.defaultModel;
+}
+
+/** Set (or clear with undefined) the unified teammate model for later spawns. */
+export function setTeamDefaultModel(ref: string | undefined): void {
+  state.defaultModel = nonEmpty(ref);
+  markStateDirty();
+}
+
 // ── Roster queries ────────────────────────────────────────────────
 
 const NAME_PATTERN = /^[a-z][a-z0-9._-]{0,63}$/i;
@@ -204,6 +223,26 @@ export function setPeerInboxOffset(inboxName: string, offset: number): void {
 
 // ── Board: creation and queries ───────────────────────────────────
 
+/** Maximum characters in a generated slug task id (suffix included). */
+const MAX_TASK_ID_LENGTH = 48;
+
+/** A readable, filesystem-safe id derived from the subject:
+ *  "Polish login flow" -> "polish-login-flow"; duplicates get -2, -3, ... */
+export function taskIdFromSubject(subject: string, taken: ReadonlySet<string>): string {
+  const base = subject
+    .toLowerCase()
+    .replace(/[^\p{L}\p{N}]+/gu, "-")
+    .replace(/^-+|-+$/g, "")
+    .slice(0, MAX_TASK_ID_LENGTH)
+    .replace(/-+$/g, "") || "task";
+  let id = base;
+  for (let n = 2; taken.has(id); n++) {
+    const suffix = `-${n}`;
+    id = base.slice(0, Math.max(1, MAX_TASK_ID_LENGTH - suffix.length)).replace(/-+$/g, "") + suffix;
+  }
+  return id;
+}
+
 export function createTask(input: {
   subject: string;
   description?: string;
@@ -219,7 +258,7 @@ export function createTask(input: {
   for (const dep of dependsOn) {
     if (!state.tasks[dep]) return { ok: false, error: `Task depends on unknown task "${dep}".` };
   }
-  const id = `t_${++state.taskCounter}`;
+  const id = taskIdFromSubject(subject, new Set(Object.keys(state.tasks)));
   const task: BoardTask = {
     id,
     subject,
@@ -350,8 +389,6 @@ export function loadBoard(tasks: Record<string, BoardTask>): number {
       updatedAt: Date.now(),
     };
     state.tasks[restored.id] = restored;
-    const numeric = Number(restored.id.slice(2));
-    if (Number.isFinite(numeric)) state.taskCounter = Math.max(state.taskCounter, numeric);
     reloaded++;
   }
   if (reloaded > 0) markStateDirty();