@forwardimpact/svcllm 0.1.96 → 0.1.97

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@forwardimpact/svcllm",
-  "version": "0.1.96",
+  "version": "0.1.97",
   "description": "Language model service providing embeddings and completions for Guide",
   "license": "Apache-2.0",
   "author": "D. Olsson <hi@senzilla.io>",
@@ -23,5 +23,11 @@
   },
   "devDependencies": {
     "@forwardimpact/libharness": "^0.1.5"
+  },
+  "files": [
+    "proto/"
+  ],
+  "publishConfig": {
+    "access": "public"
   }
 }

package/proto/llm.proto

@@ -0,0 +1,32 @@
+syntax = "proto3";
+
+package llm;
+
+import "common.proto";
+import "tool.proto";
+
+service Llm {
+  rpc CreateEmbeddings(EmbeddingsRequest) returns (common.Embeddings);
+  rpc CreateCompletions(CompletionsRequest) returns (CompletionsResponse);
+}
+
+message EmbeddingsRequest {
+  repeated string input = 1;
+  string llm_token = 2;
+  optional string model = 3;
+}
+
+message CompletionsRequest {
+  string resource_id = 1;
+  string llm_token = 4;
+  optional string model = 5;
+}
+
+message CompletionsResponse {
+  string id = 1;
+  string object = 2;
+  int64 created = 3;
+  string model = 4;
+  repeated common.Choice choices = 5;
+  common.Usage usage = 6;
+}

package/server.js

@@ -1,20 +0,0 @@
-import { Server, createClient } from "@forwardimpact/librpc";
-import { createServiceConfig } from "@forwardimpact/libconfig";
-import { createTracer } from "@forwardimpact/librpc";
-import { createLogger } from "@forwardimpact/libtelemetry";
-
-import { LlmService } from "./index.js";
-
-const config = await createServiceConfig("llm");
-
-// Initialize observability
-const logger = createLogger("llm");
-const tracer = await createTracer("llm");
-
-// Create memory client for fetching windows
-const memoryClient = await createClient("memory", logger, tracer);
-
-const service = new LlmService(config, memoryClient);
-const server = new Server(service, config, logger, tracer);
-
-await server.start();

package/test/llm.test.js

@@ -1,170 +0,0 @@
-import { test, describe, beforeEach } from "node:test";
-import assert from "node:assert";
-
-// Module under test
-import { LlmService } from "../index.js";
-import {
-  createMockConfig,
-  createMockMemoryClient,
-} from "@forwardimpact/libharness";
-
-describe("llm service", () => {
-  describe("LlmService", () => {
-    test("exports LlmService class", () => {
-      assert.strictEqual(typeof LlmService, "function");
-      assert.ok(LlmService.prototype);
-    });
-
-    test("LlmService has CreateCompletions method", () => {
-      assert.strictEqual(
-        typeof LlmService.prototype.CreateCompletions,
-        "function",
-      );
-    });
-
-    test("LlmService has CreateEmbeddings method", () => {
-      assert.strictEqual(
-        typeof LlmService.prototype.CreateEmbeddings,
-        "function",
-      );
-    });
-
-    test("LlmService has proper method signatures", () => {
-      const methods = Object.getOwnPropertyNames(LlmService.prototype);
-      assert(methods.includes("CreateCompletions"));
-      assert(methods.includes("CreateEmbeddings"));
-      assert(methods.includes("constructor"));
-    });
-  });
-
-  describe("LlmService business logic", () => {
-    let mockConfig;
-    let mockMemoryClient;
-    let mockLlmFactory;
-    let mockCopilot;
-
-    beforeEach(() => {
-      mockConfig = createMockConfig("llm", {
-        model: "gpt-4o",
-        llmBaseUrl: () => "https://test.api.com",
-        embeddingBaseUrl: () => "http://localhost:8090",
-      });
-
-      mockMemoryClient = createMockMemoryClient();
-
-      mockCopilot = {
-        createCompletions: async () => ({
-          id: "test-completion",
-          choices: [
-            { message: { role: "assistant", content: "Test response" } },
-          ],
-          usage: { total_tokens: 100 },
-        }),
-        createEmbeddings: async () => ({
-          data: [{ index: 0, embedding: [0.1, 0.2, 0.3] }],
-        }),
-      };
-
-      mockLlmFactory = (
-        token,
-        model,
-        _baseUrl,
-        _embeddingBaseUrl,
-        _temperature,
-      ) => {
-        assert.strictEqual(model, mockConfig.model);
-        return mockCopilot;
-      };
-    });
-
-    test("constructor stores llmFactory and memoryClient", () => {
-      const service = new LlmService(
-        mockConfig,
-        mockMemoryClient,
-        mockLlmFactory,
-      );
-
-      // Test that constructor succeeds - actual validation happens at usage time
-      assert.ok(service);
-      assert.strictEqual(service.config, mockConfig);
-    });
-
-    test("creates service instance with valid parameters", () => {
-      const service = new LlmService(
-        mockConfig,
-        mockMemoryClient,
-        mockLlmFactory,
-      );
-
-      assert.ok(service);
-      assert.strictEqual(service.config, mockConfig);
-    });
-
-    test("CreateCompletions requires resource_id", async () => {
-      const service = new LlmService(
-        mockConfig,
-        mockMemoryClient,
-        mockLlmFactory,
-      );
-
-      await assert.rejects(
-        async () => {
-          await service.CreateCompletions({
-            llm_token: "test-token",
-            messages: [{ role: "user", content: "Hello" }],
-            tools: [],
-          });
-        },
-        { message: "resource_id is required for CreateCompletions" },
-      );
-    });
-
-    test("CreateCompletions fetches memory window when resource_id provided", async () => {
-      let memoryWindowCalled = false;
-      const mockMemoryClientWithTracking = {
-        GetWindow: async (req) => {
-          memoryWindowCalled = true;
-          assert.ok(req.resource_id);
-          assert.ok(req.model);
-          return {
-            messages: [{ role: "system", content: "You are an assistant" }],
-            tools: [],
-            temperature: "0.7",
-          };
-        },
-      };
-
-      const service = new LlmService(
-        mockConfig,
-        mockMemoryClientWithTracking,
-        mockLlmFactory,
-      );
-
-      const result = await service.CreateCompletions({
-        llm_token: "test-token",
-        resource_id: "test-conversation-id",
-      });
-
-      assert.ok(result);
-      assert.ok(memoryWindowCalled, "Memory window should be fetched");
-    });
-
-    test("CreateEmbeddings processes chunks correctly", async () => {
-      const service = new LlmService(
-        mockConfig,
-        mockMemoryClient,
-        mockLlmFactory,
-      );
-
-      const result = await service.CreateEmbeddings({
-        llm_token: "test-token",
-        input: ["test chunk"],
-      });
-
-      assert.ok(result);
-      assert.ok(result.data);
-      assert.strictEqual(result.data.length, 1);
-      assert.deepStrictEqual(result.data[0].embedding, [0.1, 0.2, 0.3]);
-    });
-  });
-});