@forthtilliath/eslint-config 0.4.1 → 0.5.0

package/README.md

@@ -31,6 +31,17 @@ there's nothing else to install per variant.
 
 ## Usage
 
+Quick reference — pick the row matching the package, in its `eslint.config.ts`:
+
+| Variant             | Subpath         | Use for                    | Extends       |
+| ------------------- | --------------- | -------------------------- | ------------- |
+| `baseConfig`        | `.` (root)      | A plain TypeScript library | —             |
+| `reactConfig`       | `/react`        | A React library            | `baseConfig`  |
+| `nextJsConfig`      | `/nextjs`       | A Next.js app              | `reactConfig` |
+| `storybookConfig`   | `/storybook`    | A Storybook app            | `reactConfig` |
+| `reactNativeConfig` | `/react-native` | A React Native / Expo app  | `reactConfig` |
+| `angularConfig`     | `/angular`      | An Angular app/library     | `baseConfig`  |
+
 Pick the variant that matches the package, in its `eslint.config.ts`:
 
 ```ts
@@ -111,13 +122,16 @@ export default createBaseConfig({ strict: false, turbo: false });
 Options are forwarded down the chain, so `createNextJsConfig({ prettier: false })`
 also disables Prettier in the `reactConfig`/`baseConfig` layers it builds on.
 
-`createReactNativeConfig` also always adds `eslint-plugin-react-native`
-(`split-platform-components`, `no-raw-text`) and the RN/Metro-injected
-`__DEV__` global — these aren't behind an option, unlike the toggles above.
-`no-inline-styles` and `sort-styles` stay off (stylistic, not correctness);
-`no-unused-styles` and `no-single-element-style-arrays` also stay off —
-`eslint-plugin-react-native@5.0.0` crashes running them under ESLint 10
-(`context.getSourceCode is not a function`, an API ESLint 10 removed).
+`createReactNativeConfig` also always adds `eslint-plugin-react-native`'s
+`no-raw-text` rule and the RN/Metro-injected `__DEV__` global — these aren't
+behind an option, unlike the toggles above. Every other rule of the plugin
+stays off: `no-inline-styles`/`sort-styles` are stylistic rather than
+correctness checks, and `no-unused-styles`, `no-single-element-style-arrays`,
+`split-platform-components`, and `no-color-literals` all crash outright under
+ESLint 10 — `eslint-plugin-react-native@5.0.0` still calls
+`context.getSourceCode()`/`context.getFilename()`, APIs ESLint 10 removed.
+`no-raw-text` is the only one that doesn't. Re-enable the others once the
+plugin ships a fix.
 
 ```ts
 // Full i18n project (next-intl, react-intl...): forbid hardcoded JSX strings
@@ -141,6 +155,23 @@ Rules that need type information (`consistent-type-exports`,
 from linting entirely — none of them belong to a package's own `tsconfig`
 project, so type-aware rules crash on them otherwise.
 
+### Angular import order
+
+`angularConfig` overrides `simple-import-sort/imports` on `**/*.ts` so
+`@angular/core`/`rxjs` sort before every other package, ahead of the generic
+"third-party packages, alphabetically" group `baseConfig` uses everywhere
+else — the conventional Angular reading order (framework, then everything
+else, then app code).
+
+## Testing this package
+
+Unlike the other five variants — each already exercised by whatever
+package/app in this monorepo lints under them — `angularConfig` has no real
+consumer here yet, so `src/angular.test.js` lints small fixture files under
+`src/__fixtures__/angular/` through ESLint's Node API directly, standing in
+for that. Extend it (or add a sibling `<variant>.test.js`) whenever a variant
+changes without a real consumer to catch a regression.
+
 ## Scripts
 
 ```bash
@@ -148,6 +179,8 @@ pnpm run build        # tsc -> dist/ (consumers import the built output)
 pnpm run dev           # tsc --watch
 pnpm run check-types   # tsc --noEmit
 pnpm run lint          # eslint (lints its own src/)
+pnpm run test          # vitest run
+pnpm run test:watch    # vitest
 ```
 
 Run `pnpm run build` after editing `src/*.js` — consuming packages resolve

package/dist/angular.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"angular.d.ts","sourceRoot":"","sources":["../src/angular.js"],"names":[],"mappings":"AAMA;;;;;;;;;;GAUG;AACH,8CAHW,OAAO,WAAW,EAAE,iBAAiB,GACnC,OAAO,QAAQ,EAAE,MAAM,CAAC,MAAM,EAAE,CA2C5C;AAED;;;;8CAI8C;AAC9C,4BADU,OAAO,QAAQ,EAAE,MAAM,CAAC,MAAM,EAAE,CACS"}
+{"version":3,"file":"angular.d.ts","sourceRoot":"","sources":["../src/angular.js"],"names":[],"mappings":"AAMA;;;;;;;;;;GAUG;AACH,8CAHW,OAAO,WAAW,EAAE,iBAAiB,GACnC,OAAO,QAAQ,EAAE,MAAM,CAAC,MAAM,EAAE,CA+D5C;AAED;;;;8CAI8C;AAC9C,4BADU,OAAO,QAAQ,EAAE,MAAM,CAAC,MAAM,EAAE,CACS"}

package/dist/angular.js

@@ -1,7 +1,7 @@
 import angular from "angular-eslint";
 import { defineConfig } from "eslint/config";
 import tseslint from "typescript-eslint";
-import { createBaseConfig } from "./base.js";
+import { createBaseConfig, NODE_BUILTIN_IMPORT_GROUP } from "./base.js";
 /**
  * A custom ESLint configuration for Angular applications/libraries.
  *
@@ -38,6 +38,26 @@ export function createAngularConfig(options) {
                 // Un composant/page Angular sans logique propre (juste un template +
                 // decorateur) est un corps de classe legitimement vide, pas du code mort.
                 "@typescript-eslint/no-extraneous-class": "off",
+                // Convention Angular : le framework (et RxJS, quasi-systematiquement
+                // utilise a ses cotes) se lit avant le reste — packages tiers, puis
+                // imports internes de l'app. baseConfig's generic "^@?\\w" group
+                // sorts every third-party package alphabetically together, which
+                // would interleave "@angular/core" with unrelated libs instead.
+                "simple-import-sort/imports": [
+                    "error",
+                    {
+                        groups: [
+                            NODE_BUILTIN_IMPORT_GROUP,
+                            ["^@angular", "^rxjs"],
+                            ["^@?\\w"],
+                            ["^(@forthtilliath)(/.*|$)"],
+                            ["^(@|@ui|components|utils|config)(/.*|$)"],
+                            ["^\\u0000"],
+                            ["^\\.\\.(?!/?$)", "^\\.\\./?$"],
+                            ["^\\./(?=.*/)(?!/?$)", "^\\.(?!/?$)", "^\\./?$"],
+                        ],
+                    },
+                ],
             },
         },
         {

package/dist/base.d.ts

@@ -19,6 +19,14 @@
  * @returns {import("eslint").Linter.Config[]}
  */
 export function createBaseConfig({ prettier, strict, turbo, }?: BaseConfigOptions): import("eslint").Linter.Config[];
+/**
+ * Node.js builtins without the `node:` prefix, as the first
+ * `simple-import-sort/imports` group. Exported so other variants (e.g.
+ * angular.js, which overrides this rule with Angular-specific groups) don't
+ * have to duplicate the list to keep builtins sorted first too.
+ * @type {string[]}
+ */
+export const NODE_BUILTIN_IMPORT_GROUP: string[];
 /**
  * A shared ESLint configuration for the repository, with the default options.
  * Use `createBaseConfig(options)` instead to customize it.

package/dist/base.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"base.d.ts","sourceRoot":"","sources":["../src/base.js"],"names":[],"mappings":"AAQA;;;;;;;;;;;;;GAaG;AAEH;;;;;GAKG;AACH,gEAHW,iBAAiB,GACf,OAAO,QAAQ,EAAE,MAAM,CAAC,MAAM,EAAE,CAyI5C;AAED;;;;;KAKK;AACL,yBAFU,OAAO,QAAQ,EAAE,MAAM,CAAC,MAAM,EAAE,CAEG"}
+{"version":3,"file":"base.d.ts","sourceRoot":"","sources":["../src/base.js"],"names":[],"mappings":"AAuBA;;;;;;;;;;;;;GAaG;AAEH;;;;;GAKG;AACH,gEAHW,iBAAiB,GACf,OAAO,QAAQ,EAAE,MAAM,CAAC,MAAM,EAAE,CAoI5C;AAtKD;;;;;;GAMG;AACH,wCAFU,MAAM,EAAE,CAQhB;AA2JF;;;;;KAKK;AACL,yBAFU,OAAO,QAAQ,EAAE,MAAM,CAAC,MAAM,EAAE,CAEG"}

package/dist/base.js

@@ -5,6 +5,20 @@ import simpleImportSortPlugin from "eslint-plugin-simple-import-sort";
 import turboPlugin from "eslint-plugin-turbo";
 import globals from "globals";
 import tseslint from "typescript-eslint";
+/**
+ * Node.js builtins without the `node:` prefix, as the first
+ * `simple-import-sort/imports` group. Exported so other variants (e.g.
+ * angular.js, which overrides this rule with Angular-specific groups) don't
+ * have to duplicate the list to keep builtins sorted first too.
+ * @type {string[]}
+ */
+export const NODE_BUILTIN_IMPORT_GROUP = [
+    // Node.js builtins. You could also generate this regex if you use a `.js` config.
+    // For example: `^(${require("module").builtinModules.join("|")})(/|$)`
+    // Note that if you use the `node:` prefix for Node.js builtins,
+    // you can avoid this complexity: You can simply use "^node:".
+    "^(assert|buffer|child_process|cluster|console|constants|crypto|dgram|dns|domain|events|fs|http|https|module|net|os|path|punycode|querystring|readline|repl|stream|string_decoder|sys|timers|tls|tty|url|util|vm|zlib|freelist|v8|process|async_hooks|http2|perf_hooks)(/.*|$)",
+];
 /**
  * @typedef {object} BaseConfigOptions
  * @property {boolean} [prettier=true] - Append eslint-config-prettier at the
@@ -33,6 +47,7 @@ export function createBaseConfig({ prettier = true, strict = true, turbo = true,
         {
             ignores: [
                 "dist/**",
+                "coverage/**",
                 "storybook-static/**",
                 "postcss.config.cjs",
                 "postcss.config.mjs",
@@ -72,13 +87,7 @@ export function createBaseConfig({ prettier = true, strict = true, turbo = true,
                     "error",
                     {
                         groups: [
-                            // Node.js builtins. You could also generate this regex if you use a `.js` config.
-                            // For example: `^(${require("module").builtinModules.join("|")})(/|$)`
-                            // Note that if you use the `node:` prefix for Node.js builtins,
-                            // you can avoid this complexity: You can simply use "^node:".
-                            [
-                                "^(assert|buffer|child_process|cluster|console|constants|crypto|dgram|dns|domain|events|fs|http|https|module|net|os|path|punycode|querystring|readline|repl|stream|string_decoder|sys|timers|tls|tty|url|util|vm|zlib|freelist|v8|process|async_hooks|http2|perf_hooks)(/.*|$)",
-                            ],
+                            NODE_BUILTIN_IMPORT_GROUP,
                             // Packages. `react` related packages come first.
                             ["^react", "^@?\\w"],
                             // Internal packages.

package/dist/react-native.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"react-native.d.ts","sourceRoot":"","sources":["../src/react-native.js"],"names":[],"mappings":"AAKA;;;;;GAKG;AAEH;;;;iDAIiD;AACjD,+DAFW,OAAO,WAAW,EAAE,iBAAiB,GAAG,OAAO,YAAY,EAAE,kBAAkB,GAC7E,OAAO,QAAQ,EAAE,MAAM,CAAC,MAAM,EAAE,CAoC5C;AAED;;;;;8CAK8C;AAC9C,gCADU,OAAO,QAAQ,EAAE,MAAM,CAAC,MAAM,EAAE,CACiB"}
+{"version":3,"file":"react-native.d.ts","sourceRoot":"","sources":["../src/react-native.js"],"names":[],"mappings":"AAKA;;;;;GAKG;AAEH;;;;iDAIiD;AACjD,+DAFW,OAAO,WAAW,EAAE,iBAAiB,GAAG,OAAO,YAAY,EAAE,kBAAkB,GAC7E,OAAO,QAAQ,EAAE,MAAM,CAAC,MAAM,EAAE,CAwC5C;AAED;;;;;8CAK8C;AAC9C,gCADU,OAAO,QAAQ,EAAE,MAAM,CAAC,MAAM,EAAE,CACiB"}

package/dist/react-native.js

@@ -29,21 +29,25 @@ export function createReactNativeConfig({ a11y = false, ...options } = {}) {
                 "react-native": pluginReactNative,
             },
             rules: {
-                "react-native/split-platform-components": "error",
+                // The only rule of the plugin that doesn't crash under ESLint 10 (see
+                // below) — real, useful signal (raw text outside a <Text>).
                 "react-native/no-raw-text": "error",
-                // Off by default: both are stylistic preferences rather than
-                // correctness checks, and inline styles in particular are a common,
-                // legitimate RN pattern (one-off layout tweaks) that Prettier already
-                // keeps readable.
+                // Off by default: stylistic preference rather than a correctness
+                // check, and a common, legitimate RN pattern (one-off layout tweaks)
+                // that Prettier already keeps readable.
                 "react-native/no-inline-styles": "off",
-                // Off: crashes outright under ESLint 10 ("context.getSourceCode is
-                // not a function") — eslint-plugin-react-native@5.0.0 still calls the
-                // API ESLint 10 removed, in the util shared by no-unused-styles/
-                // no-color-literals and in sort-styles/no-single-element-style-arrays
-                // directly. Re-enable once the plugin ships a fix.
+                // Off: every other rule crashes outright under ESLint 10
+                // ("context.getSourceCode/getFilename is not a function") —
+                // eslint-plugin-react-native@5.0.0 still calls APIs ESLint 10
+                // removed, either directly (sort-styles,
+                // no-single-element-style-arrays, split-platform-components) or via
+                // the util shared with no-unused-styles/no-color-literals. Re-enable
+                // each once the plugin ships a fix.
                 "react-native/no-unused-styles": "off",
                 "react-native/no-single-element-style-arrays": "off",
                 "react-native/sort-styles": "off",
+                "react-native/split-platform-components": "off",
+                "react-native/no-color-literals": "off",
             },
         },
     ]);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@forthtilliath/eslint-config",
-  "version": "0.4.1",
+  "version": "0.5.0",
   "type": "module",
   "license": "MIT",
   "publishConfig": {
@@ -45,15 +45,20 @@
     "typescript": ">=5.0.0"
   },
   "devDependencies": {
+    "@angular/core": "^21.0.0",
     "eslint": "10.7.0",
+    "rxjs": "^7.8.0",
     "typescript": "^5.9.3",
+    "vitest": "^4.1.10",
     "@forthtilliath/typescript-config": "0.0.0"
   },
   "scripts": {
-    "dev": "tsc --watch",
-    "build": "tsc",
+    "dev": "tsc --watch -p tsconfig.build.json",
+    "build": "tsc -p tsconfig.build.json",
     "clean": "rm -rf dist",
     "check-types": "tsc --noEmit",
-    "lint": "eslint . --max-warnings 0"
+    "lint": "eslint . --max-warnings 0",
+    "test": "vitest run",
+    "test:watch": "vitest"
   }
 }