@forsakringskassan/eslint-config 13.0.2 → 13.0.4

package/index.mjs

@@ -11,6 +11,7 @@ export { default as globals } from "globals";
 
 /**
  * @typedef {import("eslint").Linter.Config} Config
+ * @typedef {import("eslint").Linter.RulesRecord} RulesRecord
  */
 
 /**
@@ -36,6 +37,17 @@ function merge(result, it) {
     };
 }
 
+/**
+ * @param {RulesRecord} rules
+ * @param {(rule: string) => boolean} predicate
+ * @returns {RulesRecord}
+ */
+function filterRules(rules, predicate) {
+    return Object.fromEntries(
+        Object.entries(rules).filter(([key]) => predicate(key)),
+    );
+}
+
 export default [
     defineConfig({
         ...js.configs.recommended,
@@ -59,7 +71,27 @@ export default [
             },
         },
         rules: {
-            ...prettierConfig.rules,
+            ...filterRules(prettierConfig.rules, (rule) => {
+                if (rule.startsWith("@stylistic/")) {
+                    return false;
+                }
+                if (rule.startsWith("@babel/") || rule.startsWith("babel/")) {
+                    return false;
+                }
+                if (rule.startsWith("flowtype/")) {
+                    return false;
+                }
+                if (rule.startsWith("react/")) {
+                    return false;
+                }
+                if (rule.startsWith("standard/")) {
+                    return false;
+                }
+                if (rule.startsWith("unicorn/")) {
+                    return false;
+                }
+                return true;
+            }),
             ...prettierPlugin.configs.recommended.rules,
             ...importPlugin.configs.errors.rules,
             ...eslintCommentsPlugin.configs.recommended.rules,
@@ -86,6 +118,7 @@ export default [
             "no-unused-vars": "error",
             "no-var": "error",
             "no-warning-comments": "error",
+            "object-shorthand": "error",
             "prefer-const": "error",
             "prefer-rest-params": "error",
             "prefer-spread": "error",
@@ -125,8 +158,10 @@ export default [
             "sonarjs/no-duplicate-string": "off",
 
             "sonarjs/argument-type": "off", // handled by typescript (and this rule is sometimes wrong)
+            "sonarjs/arguments-order": "off", // another slow rule, would be nice to have enabled thought
             "sonarjs/deprecation": "off", // covered by @typescript-eslint/no-deprecated (and this rule crashes on .svelte files)
             "sonarjs/function-return-type": "off", // overly broad and opinionated, let typescript deal with this
+            "sonarjs/no-commented-code": "off", // neat rule but is very very slow (over 50% of the total linting time)
             "sonarjs/no-control-regex": "off", // covered by no-control-regexp
             "sonarjs/no-empty-test-file": "off", // could be useful but it does not handle it.each or similar constructs thus yields more false positives than its worth */
             "sonarjs/no-selector-parameter": "off", // not always possible (e.g. watcher handler in vue)
@@ -141,6 +176,27 @@ export default [
             "sonarjs/unused-named-groups": "off", // named groups can help readability even if not used
             "sonarjs/use-type-alias": "off", // overly broad, lets leave this to the discretion of the author
 
+            /* disable sonarjs aws related rules as we dont use aws */
+            "sonarjs/aws-apigateway-public-api": "off",
+            "sonarjs/aws-ec2-rds-dms-public": "off",
+            "sonarjs/aws-ec2-unencrypted-ebs-volume": "off",
+            "sonarjs/aws-efs-unencrypted": "off",
+            "sonarjs/aws-iam-all-privileges": "off",
+            "sonarjs/aws-iam-all-resources-accessible": "off",
+            "sonarjs/aws-iam-privilege-escalation": "off",
+            "sonarjs/aws-iam-public-access": "off",
+            "sonarjs/aws-opensearchservice-domain": "off",
+            "sonarjs/aws-rds-unencrypted-databases": "off",
+            "sonarjs/aws-restricted-ip-admin-access": "off",
+            "sonarjs/aws-s3-bucket-granted-access": "off",
+            "sonarjs/aws-s3-bucket-insecure-http": "off",
+            "sonarjs/aws-s3-bucket-public-access": "off",
+            "sonarjs/aws-s3-bucket-server-encryption": "off",
+            "sonarjs/aws-s3-bucket-versioning": "off",
+            "sonarjs/aws-sagemaker-unencrypted-notebook": "off",
+            "sonarjs/aws-sns-unencrypted-topics": "off",
+            "sonarjs/aws-sqs-unencrypted-queue": "off",
+
             /* Lower some errors to warnings, these are allowed on local builds (to
              * not prevent builds during development where code is unfinished and
              * might contain debugging code) but is disallowed when building from
@@ -148,7 +204,6 @@ export default [
             "no-console": "warn",
             "no-debugger": "warn",
             "prettier/prettier": "warn",
-            "sonarjs/no-commented-code": "warn",
 
             "import/default": "off",
             "import/extensions": [
@@ -263,6 +318,13 @@ export default [
     },
 ];
 
+const defaultAppConfig = defineConfig({
+    name: "@forsakringskassan/eslint-config/app",
+    rules: {
+        "sonarjs/no-commented-code": "warn",
+    },
+});
+
 const defaultDocsConfig = defineConfig({
     name: "@forsakringskassan/eslint-config/docs-app",
     files: ["docs/src/*.{js,ts}"],
@@ -297,6 +359,14 @@ const defaultSandboxConfig = {
     },
 };
 
+/**
+ * @param {Config} [override]
+ * @returns {Config}
+ */
+export function appConfig(override) {
+    return merge(defaultAppConfig, override ?? {});
+}
+
 /**
  * @param {Config} [override]
  * @returns {Config}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@forsakringskassan/eslint-config",
-  "version": "13.0.2",
+  "version": "13.0.4",
   "description": "Försäkringskassans eslint shareable config",
   "keywords": [
     "eslint"
@@ -41,5 +41,5 @@
   "engines": {
     "node": ">= 22.0"
   },
-  "gitHead": "99ad23a49dac0b99b44be7190639b0dfb5d27355"
+  "gitHead": "82cae99b10877e69524cfa2d74c977cab719cf09"
 }