@forsakringskassan/eslint-config 12.2.0 → 12.2.2

package/flat.d.mts

@@ -0,0 +1,6 @@
+import { Linter } from "eslint";
+
+declare const config: Linter.Config[];
+export const globals: typeof import("globals");
+
+export default config;

package/flat.mjs

@@ -1,8 +1,11 @@
 import { fileURLToPath } from "node:url";
-import path from "node:path";
-import { FlatCompat } from "@eslint/eslintrc";
 import js from "@eslint/js";
-import legacyConfig from "./index.cjs";
+import prettierConfig from "eslint-config-prettier";
+import importPlugin from "eslint-plugin-import";
+import eslintCommentsPlugin from "eslint-plugin-eslint-comments";
+import prettierPlugin from "eslint-plugin-prettier";
+import sonarjsPlugin from "eslint-plugin-sonarjs";
+import globals from "globals";
 
 export { default as globals } from "globals";
 
@@ -18,36 +21,164 @@ function defineConfig(config) {
     return config;
 }
 
-const __filename = fileURLToPath(import.meta.url);
-const __dirname = path.dirname(__filename);
-
-const compat = new FlatCompat({
-    baseDirectory: __dirname,
-    resolvePluginsRelativeTo: __dirname,
-    recommendedConfig: js.configs.recommended,
-});
-
-const migrated = compat.config(legacyConfig);
-
-for (const ruleset of migrated) {
-    if (!ruleset.languageOptions) {
-        continue;
-    }
-    delete ruleset.languageOptions.ecmaVersion;
-    delete ruleset.languageOptions.sourceType;
-    if (Object.keys(ruleset.languageOptions).length === 0) {
-        delete ruleset.languageOptions;
-    }
-}
-
 export default [
-    ...migrated,
+    defineConfig({
+        ...js.configs.recommended,
+    }),
+
+    defineConfig({
+        plugins: {
+            prettier: prettierPlugin,
+            import: importPlugin,
+            "eslint-comments": eslintCommentsPlugin,
+            sonarjs: sonarjsPlugin,
+        },
+        settings: {
+            "import/resolver": {
+                [fileURLToPath(
+                    import.meta.resolve("eslint-import-resolver-node"),
+                )]: true,
+                [fileURLToPath(
+                    import.meta.resolve("eslint-import-resolver-typescript"),
+                )]: true,
+            },
+        },
+        rules: {
+            ...prettierConfig.rules,
+            ...prettierPlugin.configs.recommended.rules,
+            ...importPlugin.configs.errors.rules,
+            ...eslintCommentsPlugin.configs.recommended.rules,
+            ...sonarjsPlugin.configs.recommended.rules,
+        },
+    }),
+
+    defineConfig({
+        name: "@forsakringskassan/eslint-config/rules",
+        rules: {
+            camelcase: "error",
+            complexity: ["error", 20],
+            "consistent-return": "error",
+            curly: "error",
+            eqeqeq: "error",
+            "max-depth": ["error", 3],
+            "max-params": ["error", { max: 5 }],
+            "no-eval": "error",
+            "no-implied-eval": "error",
+            "no-loop-func": "error",
+            "no-new": "error",
+            "no-new-func": "error",
+            "no-unreachable": "error",
+            "no-unused-vars": "error",
+            "no-var": "error",
+            "no-warning-comments": "error",
+            "prefer-const": "error",
+            "prefer-rest-params": "error",
+            "prefer-spread": "error",
+            "prefer-template": "error",
+            radix: "error",
+            yoda: "error",
+
+            "eslint-comments/disable-enable-pair": [
+                "error",
+                { allowWholeFile: true },
+            ],
+            "eslint-comments/require-description": [
+                "error",
+                {
+                    ignore: [
+                        "eslint-enable",
+                        "eslint-env",
+                        "exported",
+                        "global",
+                        "globals",
+                    ],
+                },
+            ],
+            "eslint-comments/no-unused-disable": "error",
+
+            /* Use eslint native complexity rule instead */
+            "sonarjs/cognitive-complexity": "off",
+
+            /* Prefer to use multiple returns even for booleans (looks better and
+             * can yield performance increase), see example of this in
+             * "example.js". */
+            "sonarjs/prefer-single-boolean-return": "off",
+
+            /* This rule is deemed to provide more trouble than actual value.
+             * Especially because of the prevalence of translations, i.e., text
+             * keys. */
+            "sonarjs/no-duplicate-string": "off",
+
+            /* Lower some errors to warnings, these are allowed on local builds (to
+             * not prevent builds during development where code is unfinished and
+             * might contain debugging code) but is disallowed when building from
+             * Jenkins (via `--max-warnings 0`) */
+            "no-console": "warn",
+            "no-debugger": "warn",
+            "prettier/prettier": "warn",
+
+            "import/default": "off",
+            "import/extensions": [
+                "error",
+                "never",
+                {
+                    css: "always",
+                    json: "always",
+                },
+            ],
+            "import/newline-after-import": "error",
+            "import/no-absolute-path": "error",
+            "import/no-deprecated": "error",
+            "import/no-duplicates": "error",
+            "import/no-dynamic-require": "error",
+            "import/no-extraneous-dependencies": "error",
+            "import/no-mutable-exports": "error",
+            "import/no-named-as-default": "error",
+            "import/no-named-as-default-member": "error",
+            "import/no-named-default": "error",
+            "import/no-unresolved": [
+                "error",
+                {
+                    /* neither of the resolvers will handle @ alias */
+                    ignore: ["^@"],
+                },
+            ],
+            "import/no-useless-path-segments": "error",
+            "import/order": [
+                "error",
+                {
+                    pathGroups: [
+                        {
+                            pattern: "@/**",
+                            group: "parent",
+                            position: "before",
+                        },
+                    ],
+                },
+            ],
+        },
+    }),
+
+    defineConfig({
+        name: "@forsakringskassan/eslint-config/globals",
+        languageOptions: {
+            globals: {
+                ...globals.es6,
+                ...globals.node,
+            },
+        },
+    }),
 
     defineConfig({
         name: "@forsakringskassan/eslint-config/ecma-version",
         languageOptions: {
             ecmaVersion: 2024,
             sourceType: "module",
+            parserOptions: {
+                ecmaFeatures: {
+                    globalReturn: true,
+                },
+            },
         },
     }),
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@forsakringskassan/eslint-config",
-  "version": "12.2.0",
+  "version": "12.2.2",
   "description": "Försäkringskassans eslint shareable config",
   "keywords": [
     "eslint"
@@ -22,11 +22,11 @@
     "patch",
     "eslint.js",
     "flat.mjs",
+    "flat.d.mts",
     "index.cjs"
   ],
   "dependencies": {
-    "@eslint/eslintrc": "3.3.1",
-    "@eslint/js": "9.34.0",
+    "@eslint/js": "9.35.0",
     "@rushstack/eslint-patch": "1.12.0",
     "eslint": "8.57.1",
     "eslint-config-prettier": "10.1.8",
@@ -44,5 +44,5 @@
   "engines": {
     "node": ">= 20.19"
   },
-  "gitHead": "e134180ff6dad9c342175a1ebc774f105a63c5dd"
+  "gitHead": "ada50dccddcd01d906f764576493c5a1ebbe4253"
 }