@formio/js 5.0.0-dev.5923.b428b7b → 5.0.0-dev.5932.9b8cb6d

package/lib/cjs/WebformBuilder.js

@@ -901,13 +901,16 @@ class WebformBuilder extends Component_1.default {
             keyboardActionsEnabled = keyboardActionsEnabled === 'true';
         }
         this.keyboardActionsEnabled = keyboardActionsEnabled;
-        const isSubmitButton = (comp) => {
-            return (comp.type === 'button') && ((comp.action === 'submit') || !comp.action);
-        };
-        const isShowSubmitButton = !this.options.noDefaultSubmitButton
-            && (!form.components.length || !form.components.find(comp => isSubmitButton(comp)));
+        const { display, noAddSubmitButton, noDefaultSubmitButton } = this.options;
+        const { _id, components } = form;
+        const isSubmitButton = ({ type, action }) => type === 'button' && (action === 'submit' || !action);
+        const hasSubmitButton = components.some(isSubmitButton);
+        // Add submit button if form display was switched from wizard
+        // Don't add if there is noAddSubmitButton flag passed, or the form has id, or the form has a submit button already
+        const shouldAddSubmitButton = (display === 'wizard' && !hasSubmitButton) ||
+            (!noAddSubmitButton && !_id && !hasSubmitButton);
         // Ensure there is at least a submit button.
-        if (isShowSubmitButton) {
+        if (!noDefaultSubmitButton && shouldAddSubmitButton) {
             form.components.push({
                 type: 'button',
                 label: 'Submit',
@@ -1082,6 +1085,12 @@ class WebformBuilder extends Component_1.default {
                     parentComponent.tabs[tabIndex].splice(index, 1, newComp);
                     newComp.checkValidity = () => true;
                     newComp.build(defaultValueComponent.element);
+                    if (this.preview && !this.preview.defaultChanged) {
+                        const defaultValue = lodash_1.default.get(this.preview._data, this.editForm._data.key);
+                        if (lodash_1.default.isObject(defaultValue) && !lodash_1.default.isArray(defaultValue)) {
+                            this.editForm._data.defaultValue = defaultValue;
+                        }
+                    }
                 }
             }
             else {
@@ -1092,6 +1101,7 @@ class WebformBuilder extends Component_1.default {
                     path.unshift(component.key);
                     dataPath = (0, utils_1.getStringFromComponentPath)(path);
                 }
+                this.preview.defaultChanged = true;
                 lodash_1.default.set(this.preview._data, dataPath, changed.value);
                 lodash_1.default.set(this.webform._data, dataPath, changed.value);
             }

package/lib/cjs/Wizard.d.ts

@@ -105,7 +105,6 @@ declare class Wizard extends Webform {
     pageId(page: any): any;
     onChange(flags: any, changed: any, modified: any, changes: any): void;
     checkValidity(data: any, dirty: any, row: any, currentPageOnly: any, childErrors?: any[]): any;
-    showErrors(errors: any, triggerEvent: any): void | any[];
     focusOnComponent(key: any): void | Promise<void>;
 }
 declare namespace Wizard {

package/lib/cjs/Wizard.js

@@ -720,9 +720,10 @@ class Wizard extends Webform_1.default {
         }
     }
     validateCurrentPage(flags = {}) {
-        var _a;
+        var _a, _b;
+        const components = (_a = this.currentPage) === null || _a === void 0 ? void 0 : _a.components.map((component) => component.component);
         // Accessing the parent ensures the right instance (whether it's the parent Wizard or a nested Wizard) performs its validation
-        return (_a = this.currentPage) === null || _a === void 0 ? void 0 : _a.parent.validateComponents(this.currentPage.component.components, this.currentPage.parent.data, flags);
+        return (_b = this.currentPage) === null || _b === void 0 ? void 0 : _b.parent.validateComponents(components, this.currentPage.parent.data, flags);
     }
     emitPrevPage() {
         this.emit('prevPage', { page: this.page, submission: this.submission });
@@ -864,7 +865,8 @@ class Wizard extends Webform_1.default {
     onChange(flags, changed, modified, changes) {
         var _a, _b;
         super.onChange(flags, changed, modified, changes);
-        const errors = this.validate(this.localData, { dirty: false });
+        // The onChange loop doesn't need all components for wizards
+        const errors = this.submitted ? this.validate(this.localData, { dirty: true }) : this.validateCurrentPage();
         if (this.alert) {
             this.showErrors(errors, true, true);
         }
@@ -924,17 +926,6 @@ class Wizard extends Webform_1.default {
         }
         return super.errors;
     }
-    showErrors(errors, triggerEvent) {
-        if (this.hasExtraPages) {
-            this.subWizards.forEach((subWizard) => {
-                if (Array.isArray(subWizard.errors)) {
-                    errors = [...errors, ...subWizard.errors];
-                }
-            });
-        }
-        ;
-        return super.showErrors(errors, triggerEvent);
-    }
     focusOnComponent(key) {
         const component = this.getComponent(key);
         if (component) {

package/lib/cjs/components/form/Form.js

@@ -476,7 +476,7 @@ class FormComponent extends Component_1.default {
     checkComponentValidity(data, dirty, row, options, errors = []) {
         options = options || {};
         const silentCheck = options.silentCheck || false;
-        if (this.subForm && !this.isNestedWizard) {
+        if (this.subForm) {
             return this.subForm.checkValidity(this.subFormData, dirty, null, silentCheck, errors);
         }
         return super.checkComponentValidity(data, dirty, row, options, errors);

package/lib/cjs/components/selectboxes/SelectBoxes.js

@@ -139,6 +139,14 @@ class SelectBoxesComponent extends Radio_1.default {
             checkedValues.forEach((value) => selectData.push(this.templateData[value]));
             lodash_1.default.set(submission.metadata.selectData, this.path, selectData);
         }
+        // Ensure that for dataSrc == 'values' that there are not any other superfluous values.
+        if (this.component.dataSrc === 'values') {
+            for (const key in value) {
+                if (!this.component.values.find((val) => val.value === key)) {
+                    delete value[key];
+                }
+            }
+        }
         return value;
     }
     /**

package/lib/mjs/WebformBuilder.js

@@ -885,13 +885,16 @@ export default class WebformBuilder extends Component {
             keyboardActionsEnabled = keyboardActionsEnabled === 'true';
         }
         this.keyboardActionsEnabled = keyboardActionsEnabled;
-        const isSubmitButton = (comp) => {
-            return (comp.type === 'button') && ((comp.action === 'submit') || !comp.action);
-        };
-        const isShowSubmitButton = !this.options.noDefaultSubmitButton
-            && (!form.components.length || !form.components.find(comp => isSubmitButton(comp)));
+        const { display, noAddSubmitButton, noDefaultSubmitButton } = this.options;
+        const { _id, components } = form;
+        const isSubmitButton = ({ type, action }) => type === 'button' && (action === 'submit' || !action);
+        const hasSubmitButton = components.some(isSubmitButton);
+        // Add submit button if form display was switched from wizard
+        // Don't add if there is noAddSubmitButton flag passed, or the form has id, or the form has a submit button already
+        const shouldAddSubmitButton = (display === 'wizard' && !hasSubmitButton) ||
+            (!noAddSubmitButton && !_id && !hasSubmitButton);
         // Ensure there is at least a submit button.
-        if (isShowSubmitButton) {
+        if (!noDefaultSubmitButton && shouldAddSubmitButton) {
             form.components.push({
                 type: 'button',
                 label: 'Submit',
@@ -1066,6 +1069,12 @@ export default class WebformBuilder extends Component {
                     parentComponent.tabs[tabIndex].splice(index, 1, newComp);
                     newComp.checkValidity = () => true;
                     newComp.build(defaultValueComponent.element);
+                    if (this.preview && !this.preview.defaultChanged) {
+                        const defaultValue = _.get(this.preview._data, this.editForm._data.key);
+                        if (_.isObject(defaultValue) && !_.isArray(defaultValue)) {
+                            this.editForm._data.defaultValue = defaultValue;
+                        }
+                    }
                 }
             }
             else {
@@ -1076,6 +1085,7 @@ export default class WebformBuilder extends Component {
                     path.unshift(component.key);
                     dataPath = getStringFromComponentPath(path);
                 }
+                this.preview.defaultChanged = true;
                 _.set(this.preview._data, dataPath, changed.value);
                 _.set(this.webform._data, dataPath, changed.value);
             }

package/lib/mjs/Wizard.d.ts

@@ -105,7 +105,6 @@ declare class Wizard extends Webform {
     pageId(page: any): any;
     onChange(flags: any, changed: any, modified: any, changes: any): void;
     checkValidity(data: any, dirty: any, row: any, currentPageOnly: any, childErrors?: any[]): any;
-    showErrors(errors: any, triggerEvent: any): void | any[];
     focusOnComponent(key: any): void | Promise<void>;
 }
 declare namespace Wizard {

package/lib/mjs/Wizard.js

@@ -710,8 +710,9 @@ export default class Wizard extends Webform {
         }
     }
     validateCurrentPage(flags = {}) {
+        const components = this.currentPage?.components.map((component) => component.component);
         // Accessing the parent ensures the right instance (whether it's the parent Wizard or a nested Wizard) performs its validation
-        return this.currentPage?.parent.validateComponents(this.currentPage.component.components, this.currentPage.parent.data, flags);
+        return this.currentPage?.parent.validateComponents(components, this.currentPage.parent.data, flags);
     }
     emitPrevPage() {
         this.emit('prevPage', { page: this.page, submission: this.submission });
@@ -852,7 +853,8 @@ export default class Wizard extends Webform {
     }
     onChange(flags, changed, modified, changes) {
         super.onChange(flags, changed, modified, changes);
-        const errors = this.validate(this.localData, { dirty: false });
+        // The onChange loop doesn't need all components for wizards
+        const errors = this.submitted ? this.validate(this.localData, { dirty: true }) : this.validateCurrentPage();
         if (this.alert) {
             this.showErrors(errors, true, true);
         }
@@ -911,17 +913,6 @@ export default class Wizard extends Webform {
         }
         return super.errors;
     }
-    showErrors(errors, triggerEvent) {
-        if (this.hasExtraPages) {
-            this.subWizards.forEach((subWizard) => {
-                if (Array.isArray(subWizard.errors)) {
-                    errors = [...errors, ...subWizard.errors];
-                }
-            });
-        }
-        ;
-        return super.showErrors(errors, triggerEvent);
-    }
     focusOnComponent(key) {
         const component = this.getComponent(key);
         if (component) {

package/lib/mjs/components/form/Form.js

@@ -470,7 +470,7 @@ export default class FormComponent extends Component {
     checkComponentValidity(data, dirty, row, options, errors = []) {
         options = options || {};
         const silentCheck = options.silentCheck || false;
-        if (this.subForm && !this.isNestedWizard) {
+        if (this.subForm) {
             return this.subForm.checkValidity(this.subFormData, dirty, null, silentCheck, errors);
         }
         return super.checkComponentValidity(data, dirty, row, options, errors);

package/lib/mjs/components/selectboxes/SelectBoxes.js

@@ -141,6 +141,14 @@ export default class SelectBoxesComponent extends RadioComponent {
             checkedValues.forEach((value) => selectData.push(this.templateData[value]));
             _.set(submission.metadata.selectData, this.path, selectData);
         }
+        // Ensure that for dataSrc == 'values' that there are not any other superfluous values.
+        if (this.component.dataSrc === 'values') {
+            for (const key in value) {
+                if (!this.component.values.find((val) => val.value === key)) {
+                    delete value[key];
+                }
+            }
+        }
         return value;
     }
     /**

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@formio/js",
-  "version": "5.0.0-dev.5923.b428b7b",
+  "version": "5.0.0-dev.5932.9b8cb6d",
   "description": "JavaScript powered Forms with JSON Form Builder",
   "main": "lib/cjs/index.js",
   "exports": {