@formio/js 5.0.0-dev.5919.408636c → 5.0.0-dev.5920.f58ae24

package/lib/cjs/WebformBuilder.js

@@ -901,16 +901,13 @@ class WebformBuilder extends Component_1.default {
             keyboardActionsEnabled = keyboardActionsEnabled === 'true';
         }
         this.keyboardActionsEnabled = keyboardActionsEnabled;
-        const { display, noAddSubmitButton, noDefaultSubmitButton } = this.options;
-        const { _id, components } = form;
-        const isSubmitButton = ({ type, action }) => type === 'button' && (action === 'submit' || !action);
-        const hasSubmitButton = components.some(isSubmitButton);
-        // Add submit button if form display was switched from wizard
-        // Don't add if there is noAddSubmitButton flag passed, or the form has id, or the form has a submit button already
-        const shouldAddSubmitButton = (display === 'wizard' && !hasSubmitButton) ||
-            (!noAddSubmitButton && !_id && !hasSubmitButton);
+        const isSubmitButton = (comp) => {
+            return (comp.type === 'button') && ((comp.action === 'submit') || !comp.action);
+        };
+        const isShowSubmitButton = !this.options.noDefaultSubmitButton
+            && (!form.components.length || !form.components.find(comp => isSubmitButton(comp)));
         // Ensure there is at least a submit button.
-        if (!noDefaultSubmitButton && shouldAddSubmitButton) {
+        if (isShowSubmitButton) {
             form.components.push({
                 type: 'button',
                 label: 'Submit',

package/lib/cjs/Wizard.js

@@ -720,9 +720,10 @@ class Wizard extends Webform_1.default {
         }
     }
     validateCurrentPage(flags = {}) {
-        var _a;
+        var _a, _b;
+        const components = (_a = this.currentPage) === null || _a === void 0 ? void 0 : _a.components.map((component) => component.component);
         // Accessing the parent ensures the right instance (whether it's the parent Wizard or a nested Wizard) performs its validation
-        return (_a = this.currentPage) === null || _a === void 0 ? void 0 : _a.parent.validateComponents(this.currentPage.component.components, this.currentPage.parent.data, flags);
+        return (_b = this.currentPage) === null || _b === void 0 ? void 0 : _b.parent.validateComponents(components, this.currentPage.parent.data, flags);
     }
     emitPrevPage() {
         this.emit('prevPage', { page: this.page, submission: this.submission });
@@ -864,7 +865,8 @@ class Wizard extends Webform_1.default {
     onChange(flags, changed, modified, changes) {
         var _a, _b;
         super.onChange(flags, changed, modified, changes);
-        const errors = this.validate(this.localData, { dirty: false });
+        // The onChange loop doesn't need all components for wizards
+        const errors = this.submitted ? this.validate(this.localData, { dirty: false }) : this.validateCurrentPage();
         if (this.alert) {
             this.showErrors(errors, true, true);
         }
@@ -925,14 +927,13 @@ class Wizard extends Webform_1.default {
         return super.errors;
     }
     showErrors(errors, triggerEvent) {
-        if (this.hasExtraPages) {
-            this.subWizards.forEach((subWizard) => {
-                if (Array.isArray(subWizard.errors)) {
-                    errors = [...errors, ...subWizard.errors];
-                }
-            });
-        }
-        ;
+        // if (this.hasExtraPages) {
+        //   this.subWizards.forEach((subWizard) => {
+        //     if(Array.isArray(subWizard.errors)) {
+        //       errors = [...errors, ...subWizard.errors]
+        //     }
+        //   })
+        // }
         return super.showErrors(errors, triggerEvent);
     }
     focusOnComponent(key) {

package/lib/cjs/components/form/Form.js

@@ -476,7 +476,7 @@ class FormComponent extends Component_1.default {
     checkComponentValidity(data, dirty, row, options, errors = []) {
         options = options || {};
         const silentCheck = options.silentCheck || false;
-        if (this.subForm && !this.isNestedWizard) {
+        if (this.subForm) {
             return this.subForm.checkValidity(this.subFormData, dirty, null, silentCheck, errors);
         }
         return super.checkComponentValidity(data, dirty, row, options, errors);

package/lib/mjs/WebformBuilder.js

@@ -885,16 +885,13 @@ export default class WebformBuilder extends Component {
             keyboardActionsEnabled = keyboardActionsEnabled === 'true';
         }
         this.keyboardActionsEnabled = keyboardActionsEnabled;
-        const { display, noAddSubmitButton, noDefaultSubmitButton } = this.options;
-        const { _id, components } = form;
-        const isSubmitButton = ({ type, action }) => type === 'button' && (action === 'submit' || !action);
-        const hasSubmitButton = components.some(isSubmitButton);
-        // Add submit button if form display was switched from wizard
-        // Don't add if there is noAddSubmitButton flag passed, or the form has id, or the form has a submit button already
-        const shouldAddSubmitButton = (display === 'wizard' && !hasSubmitButton) ||
-            (!noAddSubmitButton && !_id && !hasSubmitButton);
+        const isSubmitButton = (comp) => {
+            return (comp.type === 'button') && ((comp.action === 'submit') || !comp.action);
+        };
+        const isShowSubmitButton = !this.options.noDefaultSubmitButton
+            && (!form.components.length || !form.components.find(comp => isSubmitButton(comp)));
         // Ensure there is at least a submit button.
-        if (!noDefaultSubmitButton && shouldAddSubmitButton) {
+        if (isShowSubmitButton) {
             form.components.push({
                 type: 'button',
                 label: 'Submit',

package/lib/mjs/Wizard.js

@@ -710,8 +710,9 @@ export default class Wizard extends Webform {
         }
     }
     validateCurrentPage(flags = {}) {
+        const components = this.currentPage?.components.map((component) => component.component);
         // Accessing the parent ensures the right instance (whether it's the parent Wizard or a nested Wizard) performs its validation
-        return this.currentPage?.parent.validateComponents(this.currentPage.component.components, this.currentPage.parent.data, flags);
+        return this.currentPage?.parent.validateComponents(components, this.currentPage.parent.data, flags);
     }
     emitPrevPage() {
         this.emit('prevPage', { page: this.page, submission: this.submission });
@@ -852,7 +853,8 @@ export default class Wizard extends Webform {
     }
     onChange(flags, changed, modified, changes) {
         super.onChange(flags, changed, modified, changes);
-        const errors = this.validate(this.localData, { dirty: false });
+        // The onChange loop doesn't need all components for wizards
+        const errors = this.submitted ? this.validate(this.localData, { dirty: false }) : this.validateCurrentPage();
         if (this.alert) {
             this.showErrors(errors, true, true);
         }
@@ -912,14 +914,13 @@ export default class Wizard extends Webform {
         return super.errors;
     }
     showErrors(errors, triggerEvent) {
-        if (this.hasExtraPages) {
-            this.subWizards.forEach((subWizard) => {
-                if (Array.isArray(subWizard.errors)) {
-                    errors = [...errors, ...subWizard.errors];
-                }
-            });
-        }
-        ;
+        // if (this.hasExtraPages) {
+        //   this.subWizards.forEach((subWizard) => {
+        //     if(Array.isArray(subWizard.errors)) {
+        //       errors = [...errors, ...subWizard.errors]
+        //     }
+        //   })
+        // }
         return super.showErrors(errors, triggerEvent);
     }
     focusOnComponent(key) {

package/lib/mjs/components/form/Form.js

@@ -470,7 +470,7 @@ export default class FormComponent extends Component {
     checkComponentValidity(data, dirty, row, options, errors = []) {
         options = options || {};
         const silentCheck = options.silentCheck || false;
-        if (this.subForm && !this.isNestedWizard) {
+        if (this.subForm) {
             return this.subForm.checkValidity(this.subFormData, dirty, null, silentCheck, errors);
         }
         return super.checkComponentValidity(data, dirty, row, options, errors);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@formio/js",
-  "version": "5.0.0-dev.5919.408636c",
+  "version": "5.0.0-dev.5920.f58ae24",
   "description": "JavaScript powered Forms with JSON Form Builder",
   "main": "lib/cjs/index.js",
   "exports": {