@formicoidea/labre-core 0.37.0 → 0.38.2

package/dist/_pkgs/data-view/core/group-by/renderer/boolean-group.js

@@ -2,21 +2,21 @@ import { CheckBoxCheckSolidIcon, CheckBoxUnIcon } from '@blocksuite/icons/lit';
 import { css, html } from 'lit';
 import { BaseGroup } from './base.js';
 export class BooleanGroupView extends BaseGroup {
-    static { this.styles = css `
-    .data-view-group-title-boolean-view {
-      display: flex;
-      align-items: center;
-    }
-    .data-view-group-title-boolean-view svg {
-      width: 20px;
-      height: 20px;
-    }
+    static { this.styles = css `
+    .data-view-group-title-boolean-view {
+      display: flex;
+      align-items: center;
+    }
+    .data-view-group-title-boolean-view svg {
+      width: 20px;
+      height: 20px;
+    }
   `; }
     render() {
-        return html ` <div class="data-view-group-title-boolean-view">
+        return html ` <div class="data-view-group-title-boolean-view">
       ${this.value
             ? CheckBoxCheckSolidIcon({ style: `color:#1E96EB` })
-            : CheckBoxUnIcon()}
+            : CheckBoxUnIcon()}
     </div>`;
     }
 }

package/dist/_pkgs/data-view/core/utils/menu-title.js

@@ -1,22 +1,22 @@
 import { ArrowLeftBigIcon } from '@blocksuite/icons/lit';
 import { html } from 'lit';
 export const menuTitle = (name, onBack) => {
-    return html `
-    <div
-      style="display:flex;align-items:center;gap: 4px;padding: 3px 3px 3px 2px"
-    >
-      <div
-        @click=${onBack}
-        class="dv-icon-20 dv-hover dv-pd-2 dv-round-4"
-        style="display:flex;"
-      >
-        ${ArrowLeftBigIcon()}
-      </div>
-      <div
-        style="font-weight:500;font-size: 14px;line-height: 22px;color: var(--affine-text-primary-color)"
-      >
-        ${name}
-      </div>
-    </div>
+    return html `
+    <div
+      style="display:flex;align-items:center;gap: 4px;padding: 3px 3px 3px 2px"
+    >
+      <div
+        @click=${onBack}
+        class="dv-icon-20 dv-hover dv-pd-2 dv-round-4"
+        style="display:flex;"
+      >
+        ${ArrowLeftBigIcon()}
+      </div>
+      <div
+        style="font-weight:500;font-size: 14px;line-height: 22px;color: var(--affine-text-primary-color)"
+      >
+        ${name}
+      </div>
+    </div>
   `;
 };

package/dist/_pkgs/data-view/view-presets/table/pc-virtual/group/top/group-title.js

@@ -19,9 +19,9 @@ export const GroupTitle = (groupData, ops) => {
     }
     const icon = groupData.value == null
         ? ''
-        : html ` <uni-lit
-          class="${groupHeaderIcon}"
-          .uni="${groupData.property.icon}"
+        : html ` <uni-lit
+          class="${groupHeaderIcon}"
+          .uni="${groupData.property.icon}"
         ></uni-lit>`;
     const props = {
         group: groupData,
@@ -29,25 +29,25 @@ export const GroupTitle = (groupData, ops) => {
     };
     const showColumnName = groupData.property.type$.value === 'checkbox';
     const columnName = showColumnName
-        ? html `<span class="${groupHeaderTitle}"
-        >${groupData.property.name$.value}</span
+        ? html `<span class="${groupHeaderTitle}"
+        >${groupData.property.name$.value}</span
       >`
         : nothing;
     const opsClass = clsx(ops.groupHover && show, groupHeaderOps);
-    return html `
-    <div class="${groupTitleRow}">
-      ${icon} ${renderUniLit(view, props)} ${columnName}
-      ${GroupHeaderCount(groupData)}
-    </div>
+    return html `
+    <div class="${groupTitleRow}">
+      ${icon} ${renderUniLit(view, props)} ${columnName}
+      ${GroupHeaderCount(groupData)}
+    </div>
     ${!ops.readonly
-        ? html ` <div class="${opsClass}">
-          <div @click="${ops.clickAdd}" class="${groupHeaderOp}">
-            ${PlusIcon()}
-          </div>
-          <div @click="${ops.clickOps}" class="${groupHeaderOp}">
-            ${MoreHorizontalIcon()}
-          </div>
+        ? html ` <div class="${opsClass}">
+          <div @click="${ops.clickAdd}" class="${groupHeaderOp}">
+            ${PlusIcon()}
+          </div>
+          <div @click="${ops.clickOps}" class="${groupHeaderOp}">
+            ${MoreHorizontalIcon()}
+          </div>
         </div>`
-        : nothing}
+        : nothing}
   `;
 };

package/dist/_pkgs/std/gfx/model/surface/surface-model.js

@@ -510,7 +510,10 @@ export class SurfaceBlockModel extends BlockModel {
                     if (isGfxGroupCompatibleModel(payload.model)) {
                         this._groupLikeModels.delete(payload.id);
                     }
-                    {
+                    // Same rule as `_watchGroupRelationChange`: the author already
+                    // dropped the block from its group, and `removeChild` is a raw
+                    // `transact` — on a readonly viewer it would be a silent write.
+                    if (payload.isLocal) {
                         const group = this.getGroup(payload.id);
                         if (group) {
                             // oxlint-disable-next-line unicorn/prefer-dom-node-remove
@@ -563,7 +566,14 @@ export class SurfaceBlockModel extends BlockModel {
     }
     _watchGroupRelationChange() {
         const isGroup = (element) => element instanceof GfxGroupLikeElementModel;
-        const disposable = this.elementUpdated.subscribe(({ id, oldValues }) => {
+        const disposable = this.elementUpdated.subscribe(({ id, oldValues, local }) => {
+            // A cascade belongs to the peer that made the change: the author's own
+            // watcher deletes the group it emptied, and that deletion arrives with
+            // the same sync. Reacting to a REMOTE update with a local write is
+            // redundant on a writeable peer and, on a readonly viewer, the
+            // production exception `Cannot remove element in readonly mode`.
+            if (!local)
+                return;
             const element = this.getElementById(id);
             if (isGroup(element) &&
                 oldValues['childIds'] &&

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@formicoidea/labre-core",
   "description": "Labre editor — the full BlockSuite-derived editor as one package.",
-  "version": "0.37.0",
+  "version": "0.38.2",
   "type": "module",
   "sideEffects": false,
   "author": "lajola",