@form8ion/javascript 13.0.0-alpha.1 → 13.0.0-alpha.3

package/README.md

@@ -74,9 +74,13 @@ const {
       babelPreset: {name: `@${accountName}`, packageName: `@${accountName}/babel-preset`},
       commitlint: {name: `@${accountName}`, packageName: `@${accountName}/commitlint-config`}
     },
-    overrides: {npmAccount: accountName},
+    plugins: {
+      unitTestFrameworks: {},
+      applicationTypes: {},
+      packageTypes: {},
+      packageBundlers: {}
+    },
     ciServices: {},
-    unitTestFrameworks: {},
     decisions: {
       [questionNames.DIALECT]: dialects.BABEL,
       [questionNames.NODE_VERSION_CATEGORY]: 'LTS',
@@ -116,8 +120,8 @@ const {
   await scaffoldUnitTesting({
     projectRoot: process.cwd(),
     frameworks: {
-      Mocha: {scaffolder: options => options},
-      Jest: {scaffolder: options => options}
+      Mocha: {scaffold: options => options},
+      Jest: {scaffold: options => options}
     },
     visibility: 'Public',
     vcs: {host: 'GitHub', owner: 'foo', name: 'bar'},

package/example.js

@@ -42,9 +42,13 @@ const {
       babelPreset: {name: `@${accountName}`, packageName: `@${accountName}/babel-preset`},
       commitlint: {name: `@${accountName}`, packageName: `@${accountName}/commitlint-config`}
     },
-    overrides: {npmAccount: accountName},
+    plugins: {
+      unitTestFrameworks: {},
+      applicationTypes: {},
+      packageTypes: {},
+      packageBundlers: {}
+    },
     ciServices: {},
-    unitTestFrameworks: {},
     decisions: {
       [questionNames.DIALECT]: dialects.BABEL,
       [questionNames.NODE_VERSION_CATEGORY]: 'LTS',
@@ -84,8 +88,8 @@ const {
   await scaffoldUnitTesting({
     projectRoot: process.cwd(),
     frameworks: {
-      Mocha: {scaffolder: options => options},
-      Jest: {scaffolder: options => options}
+      Mocha: {scaffold: options => options},
+      Jest: {scaffold: options => options}
     },
     visibility: 'Public',
     vcs: {host: 'GitHub', owner: 'foo', name: 'bar'},

package/lib/index.js

@@ -6,8 +6,8 @@ var languageScaffolderPrompts = require('@travi/language-scaffolder-prompts');
 var deepmerge = require('deepmerge');
 var core = require('@form8ion/core');
 var javascriptCore = require('@form8ion/javascript-core');
-var joi = require('joi');
 var overridablePrompts = require('@form8ion/overridable-prompts');
+var joi = require('joi');
 var codecov = require('@form8ion/codecov');
 var configFile = require('@form8ion/config-file');
 var cliMessages = require('@travi/cli-messages');
@@ -163,8 +163,6 @@ var coveragePlugin = /*#__PURE__*/Object.freeze({
   test: tester$4
 });
 
-const unitTestFrameworksSchema = joi__default["default"].object().required().pattern(/^/, core.optionsSchemas.form8ionPlugin);
-
 async function chooseFramework ({frameworks, decisions}) {
   if (!Object.keys(frameworks).length) return 'Other';
 
@@ -178,8 +176,10 @@ async function chooseFramework ({frameworks, decisions}) {
   return answers[questionNames$1.UNIT_TEST_FRAMEWORK];
 }
 
+const pluginsSchema = joi__default["default"].object().pattern(/^/, core.optionsSchemas.form8ionPlugin).default({});
+
 async function scaffoldUnitTesting ({projectRoot, frameworks, decisions, visibility, vcs, pathWithinParent, dialect}) {
-  const validatedFrameworks = core.validateOptions(unitTestFrameworksSchema, frameworks);
+  const validatedFrameworks = core.validateOptions(pluginsSchema, frameworks);
   const [framework, coverage] = await Promise.all([
     chooseFramework({frameworks: validatedFrameworks, decisions})
       .then(chosenFramework => javascriptCore.scaffoldChoice(validatedFrameworks, chosenFramework, {projectRoot, dialect})),
@@ -1198,16 +1198,6 @@ async function lift ({projectRoot, vcs, results, pathWithinParent, enhancers = {
   return enhancerResults;
 }
 
-const pluginMapSchema = joi__default["default"].object().pattern(joi__default["default"].string(), core.optionsSchemas.form8ionPlugin);
-
-const packageBundlersSchema = pluginMapSchema.default({});
-
-const applicationTypesSchema = pluginMapSchema.default({});
-
-const packageTypesSchema = pluginMapSchema.default({});
-
-const monorepoTypesSchema = pluginMapSchema.default({});
-
 function validate(options) {
   const schema = joi__default["default"].object().required()
     .keys({
@@ -1241,16 +1231,6 @@ function validate(options) {
         remark: joi__default["default"].string()
       }).default({})
     })
-    .keys({
-      overrides: joi__default["default"].object({
-        npmAccount: joi__default["default"].string(),
-        author: joi__default["default"].object({
-          name: joi__default["default"].string().required(),
-          email: joi__default["default"].string().email(),
-          url: joi__default["default"].string().uri()
-        })
-      }).default({})
-    })
     .keys({
       ciServices: joi__default["default"].object().pattern(/^/, joi__default["default"].object({
         scaffolder: joi__default["default"].func().arity(1).required(),
@@ -1258,19 +1238,14 @@ function validate(options) {
         private: joi__default["default"].boolean()
       })).default({})
     })
-    .keys({
-      hosts: joi__default["default"].object().pattern(/^/, joi__default["default"].object({
-        scaffolder: joi__default["default"].func().arity(1).required(),
-        projectTypes: joi__default["default"].array().items(joi__default["default"].string().valid('static', 'node')).default([])
-      })).default({})
-    })
     .keys({
       plugins: {
-        unitTestFrameworks: unitTestFrameworksSchema,
-        packageBundlers: packageBundlersSchema,
-        applicationTypes: applicationTypesSchema,
-        packageTypes: packageTypesSchema,
-        monorepoTypes: monorepoTypesSchema
+        unitTestFrameworks: pluginsSchema,
+        packageBundlers: pluginsSchema,
+        applicationTypes: pluginsSchema,
+        packageTypes: pluginsSchema,
+        monorepoTypes: pluginsSchema,
+        hosts: pluginsSchema
       }
     })
     .keys({
@@ -1356,7 +1331,6 @@ function authorQuestions({name, email, url}) {
 }
 
 async function prompt(
-  {npmAccount, author},
   ciServices,
   hosts,
   visibility,
@@ -1433,9 +1407,9 @@ async function prompt(
       message: 'What is the scope?',
       when: scopePromptShouldBePresentedFactory(visibility),
       validate: scope(visibility),
-      default: npmAccount || maybeLoggedInNpmUsername
+      default: maybeLoggedInNpmUsername
     },
-    ...authorQuestions(author || {
+    ...authorQuestions({
       name: npmConf.get('init.author.name'),
       email: npmConf.get('init.author.email'),
       url: npmConf.get('init.author.url')
@@ -1706,9 +1680,7 @@ async function scaffolder (options) {
     vcs,
     description,
     configs,
-    overrides,
     ciServices,
-    hosts,
     decisions,
     pathWithinParent,
     registries,
@@ -1717,7 +1689,8 @@ async function scaffolder (options) {
       packageTypes,
       monorepoTypes,
       packageBundlers,
-      unitTestFrameworks
+      unitTestFrameworks,
+      hosts
     }
   } = validate(options);
 
@@ -1733,7 +1706,7 @@ async function scaffolder (options) {
     provideExample,
     packageManager,
     dialect
-  } = await prompt(overrides, ciServices, hosts, visibility, vcs, decisions, configs, pathWithinParent);
+  } = await prompt(ciServices, hosts, visibility, vcs, decisions, configs, pathWithinParent);
 
   cliMessages.info('Writing project files', {level: 'secondary'});