@forklaunch/core 0.18.3 → 0.18.5

package/lib/http/index.js

@@ -514,7 +514,12 @@ function hasPermissionChecks(maybePermissionedAuth) {
 
 // src/http/guards/hasRoleChecks.ts
 function hasRoleChecks(maybeRoledAuth) {
-  return typeof maybeRoledAuth === "object" && maybeRoledAuth !== null && ("allowedRoles" in maybeRoledAuth || "forbiddenRoles" in maybeRoledAuth);
+  if (typeof maybeRoledAuth !== "object" || maybeRoledAuth === null) {
+    return false;
+  }
+  const hasAllowedRoles = "allowedRoles" in maybeRoledAuth && maybeRoledAuth.allowedRoles instanceof Set && maybeRoledAuth.allowedRoles.size > 0;
+  const hasForbiddenRoles = "forbiddenRoles" in maybeRoledAuth && maybeRoledAuth.forbiddenRoles instanceof Set && maybeRoledAuth.forbiddenRoles.size > 0;
+  return hasAllowedRoles || hasForbiddenRoles;
 }
 
 // src/http/guards/hasScopeChecks.ts
@@ -3744,13 +3749,6 @@ function enrichExpressLikeSend(instance, req, res, originalOperation, originalSe
     originalSend.call(instance, data);
     return;
   }
-  if (res.statusCode === 404) {
-    res.type("text/plain");
-    res.status(404);
-    req.openTelemetryCollector?.error("Not Found");
-    originalSend.call(instance, "Not Found");
-    errorSent = true;
-  }
   let responses;
   if (req.contractDetails.responses == null && (req.contractDetails.versions == null || Object.values(req.contractDetails.versions).some(
     (version) => version?.responses == null