@forgesworn/shamir-words 1.0.0 → 1.0.2

package/dist/index.js

@@ -1,7 +1,6 @@
 // Shamir's Secret Sharing over GF(256)
 // Split secrets into threshold-of-n shares using polynomial interpolation
 // Shares can be encoded as BIP-39 words for human-readable exchange
-import { randomBytes } from '@noble/hashes/utils.js';
 import { sha256 } from '@noble/hashes/sha2.js';
 import { wordlist as BIP39_WORDLIST } from '@scure/bip39/wordlists/english.js';
 /** O(1) word-to-index lookup, built once at module load */
@@ -140,7 +139,8 @@ export function splitSecret(secret, threshold, shares) {
         // coeffs[0] = secret byte, coeffs[1..threshold-1] = random
         const coeffs = new Uint8Array(threshold);
         coeffs[0] = secret[byteIdx];
-        const rand = randomBytes(threshold - 1);
+        const rand = new Uint8Array(threshold - 1);
+        crypto.getRandomValues(rand);
         for (let j = 1; j < threshold; j++) {
             coeffs[j] = rand[j - 1];
         }
@@ -184,6 +184,9 @@ export function reconstructSecret(shares, threshold) {
         if (ids.has(share.id)) {
             throw new ShamirValidationError('Duplicate share IDs detected — each share must have a unique ID');
         }
+        if (Number.isInteger(share.threshold) && share.threshold !== threshold) {
+            throw new ShamirValidationError(`Share threshold (${share.threshold}) does not match supplied threshold (${threshold})`);
+        }
         ids.add(share.id);
     }
     const secretLen = used[0].data.length;
@@ -334,6 +337,12 @@ export function wordsToShare(words) {
     if (totalExpected > byteList.length) {
         throw new ShamirValidationError('Word list too short for encoded data length');
     }
+    // Verify phantom bytes (decoded from padding bits) are zero — ensures canonical encoding
+    for (let i = totalExpected; i < byteList.length; i++) {
+        if (byteList[i] !== 0) {
+            throw new ShamirValidationError('Non-zero padding bits detected — word list may be corrupted');
+        }
+    }
     // Enforce canonical encoding: word count must match expected
     const expectedWords = Math.ceil(totalExpected * 8 / 11);
     if (words.length !== expectedWords) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@forgesworn/shamir-words",
-  "version": "1.0.0",
+  "version": "1.0.2",
   "description": "Shamir's Secret Sharing over GF(256) with BIP-39 word encoding for human-readable share exchange",
   "type": "module",
   "main": "./dist/index.js",
@@ -53,6 +53,7 @@
   "devDependencies": {
     "@semantic-release/changelog": "^6.0.3",
     "@semantic-release/git": "^10.0.1",
+    "@types/node": "^25.5.0",
     "semantic-release": "^25.0.3",
     "typescript": "^5.7.0",
     "vitest": "^3.0.0"

package/src/index.ts

@@ -2,7 +2,6 @@
 // Split secrets into threshold-of-n shares using polynomial interpolation
 // Shares can be encoded as BIP-39 words for human-readable exchange
 
-import { randomBytes } from '@noble/hashes/utils.js';
 import { sha256 } from '@noble/hashes/sha2.js';
 import { wordlist as BIP39_WORDLIST } from '@scure/bip39/wordlists/english.js';
 
@@ -172,7 +171,8 @@ export function splitSecret(
     const coeffs = new Uint8Array(threshold);
     coeffs[0] = secret[byteIdx]!;
 
-    const rand = randomBytes(threshold - 1);
+    const rand = new Uint8Array(threshold - 1);
+    crypto.getRandomValues(rand);
     for (let j = 1; j < threshold; j++) {
       coeffs[j] = rand[j - 1]!;
     }
@@ -225,6 +225,11 @@ export function reconstructSecret(
     if (ids.has(share.id)) {
       throw new ShamirValidationError('Duplicate share IDs detected — each share must have a unique ID');
     }
+    if (Number.isInteger(share.threshold) && share.threshold !== threshold) {
+      throw new ShamirValidationError(
+        `Share threshold (${share.threshold}) does not match supplied threshold (${threshold})`,
+      );
+    }
     ids.add(share.id);
   }
 
@@ -398,6 +403,13 @@ export function wordsToShare(words: string[]): ShamirShare {
     throw new ShamirValidationError('Word list too short for encoded data length');
   }
 
+  // Verify phantom bytes (decoded from padding bits) are zero — ensures canonical encoding
+  for (let i = totalExpected; i < byteList.length; i++) {
+    if (byteList[i] !== 0) {
+      throw new ShamirValidationError('Non-zero padding bits detected — word list may be corrupted');
+    }
+  }
+
   // Enforce canonical encoding: word count must match expected
   const expectedWords = Math.ceil(totalExpected * 8 / 11);
   if (words.length !== expectedWords) {