@forgesworn/moneyer 0.7.0 → 0.8.0

package/CHANGELOG.md

@@ -1,5 +1,18 @@
 # Changelog
 
+## 0.8.0 - 2026-08-30
+
+**`MONEYER_REQUIRE_COMMENT` (default off).** Refuses a mint quote that names
+no output, rather than falling back to a note keyed by the payment preimage.
+Off by default because LUD-25 line 80 still asks for that fallback; on, the
+refusal happens before any invoice is issued, so a wallet never pays for a
+quote the mint was always going to reject. A quote naming its output by
+either spelling (`comment` or `h`) is unaffected.
+
+Worth knowing: `lnurlcash-conformance` now grades the mandate as required, so
+moneyer fails that suite in its default configuration and passes with the
+flag on. See that repo's `docs/COMMENT-IS-MANDATORY.md`.
+
 ## [0.7.0] - 2026-08-26
 
 - **The published node capacity is the announced one.** `nodeCapacity` in

package/README.md

@@ -105,6 +105,7 @@ default, and a variable set to an empty string counts as unset.
 | `MONEYER_MIN_SENDABLE_MSAT` | `1000` | smallest payment the mint advertises |
 | `MONEYER_MAX_SENDABLE_MSAT` | `100000000` | largest payment the mint advertises |
 | `MONEYER_MIN_MINT_MSAT` | `1000` | dust floor: the smallest note the mint will strike |
+| `MONEYER_REQUIRE_COMMENT` | `false` | refuse a mint quote that names no output, instead of falling back to a note keyed by the payment preimage. See [comment protection](#comment-protection) |
 | `MONEYER_MAX_K1S` | `21` | most notes one callback may name |
 | `MONEYER_VERIFY` | `true` | the LUD-21 `verify` endpoint. Off means 404 |
 | `MONEYER_WALLET_URL` | | a companion web wallet the mint's site links notes into |
@@ -667,3 +668,34 @@ in [awesome-lnurlcash](https://github.com/TheCryptoDonkey/awesome-lnurlcash).
 ## Licence
 
 MIT.
+
+
+## Comment protection
+
+A LUD-25 mint quote may carry a LUD-12 `comment` holding
+`hex(sha256(secret))`, naming the note the payment will mint. The note is
+then keyed by the wallet's own `secret`, and the payment preimage redeems
+nothing.
+
+With no such comment, LUD-25 line 80 says the mint MUST fall back to keying
+the note by the payment preimage itself. That fallback is the default here,
+and it is what the draft currently requires.
+
+`MONEYER_REQUIRE_COMMENT=true` refuses an unnamed quote instead, before any
+invoice is issued. Two reasons to want it:
+
+- A preimage-keyed note is only as safe as the discretion of every routing
+  hop on the payment. Each one learns the preimage as it settles its own
+  HTLC, often before the payer has finished processing the payment.
+- A funding source that settles without producing a preimage - a Spark
+  backend, say - has nothing to key a fallback note by at all.
+
+The cost is backward compatibility: a wallet that has never heard of
+LNURLcash sends a bare LUD-06 request and gets an error rather than an
+invoice. `dni/lnurl-mint` made this behaviour unconditional in `b257d58`;
+the draft has not yet followed, which is why it is opt-in here. See
+`lnurlcash-conformance/docs/COMMENT-IS-MANDATORY.md`.
+
+Note that `lnurlcash-conformance` now grades the mandate as required, so
+this mint **fails that suite in its default configuration** and passes with
+`MONEYER_REQUIRE_COMMENT=true`.

package/dist/backends/lnd.js

@@ -6,8 +6,11 @@ import { PaymentAlreadyKnownError, PaymentFailedError, PaymentPendingError } fro
 // one (r_preimage), which is what lets it back a mint. Payment send/track
 // are chunked NDJSON streams read line by line to a terminal status.
 //
-// Not yet exercised against a live node - the semantics are a direct port
-// of the reference mint's lnd backend, which is.
+// This is what backs the public mint, so the invoice and payment paths run
+// against a live node continuously; the semantics started as a direct port
+// of the reference mint's lnd backend. The exception is nodeInfo's graph
+// self-lookup, which is newer than the running deployment - it is covered
+// by test/lnd-node-info.test.ts and by nothing else yet.
 //
 // TLS: for lnd's self-signed cert, point NODE_EXTRA_CA_CERTS at it.
 const FAILURE_REASONS = {

package/dist/config.d.ts

@@ -32,6 +32,7 @@ export type MoneyerConfig = {
     maxSendableMsat: number;
     minMintMsat: number;
     mintFee: MintFee | null;
+    requireComment: boolean;
     roundFeeToSat?: boolean;
     signingKey?: string;
     previousSigningPubkeys?: string[];

package/dist/config.js

@@ -84,6 +84,7 @@ const contactFromEnv = (env) => {
 // that starts with a half-understood configuration is holding other
 // people's money on a misunderstanding.
 export const configFromEnv = (env = process.env) => {
+    const requireComment = flag(env.MONEYER_REQUIRE_COMMENT, false);
     const baseFeeMsat = int(env.MONEYER_BASE_FEE_MSAT, 0);
     const feePpm = int(env.MONEYER_FEE_PPM, 0);
     if (feePpm >= 1_000_000) {
@@ -211,6 +212,7 @@ export const configFromEnv = (env = process.env) => {
         maxSendableMsat,
         minMintMsat: int(env.MONEYER_MIN_MINT_MSAT, DEFAULTS.minMintMsat),
         mintFee: baseFeeMsat === 0 && feePpm === 0 ? null : { baseFeeMsat, feePpm },
+        requireComment,
         roundFeeToSat: flag(env.MONEYER_ROUND_FEE_TO_SAT, DEFAULTS.roundFeeToSat),
         ...(signingKey ? { signingKey: signingKey.toLowerCase() } : {}),
         ...(previousSigningPubkeys.length ? { previousSigningPubkeys } : {}),

package/dist/server.js

@@ -627,6 +627,16 @@ export const createMoneyer = async (config, deps = {}) => {
                 return fail('comment and h name different outputs');
             }
             const outputId = commentOutputId ?? askedOutputId;
+            // MONEYER_REQUIRE_COMMENT: refuse a quote that names no output at all,
+            // rather than minting a note keyed by the payment preimage. Off by
+            // default - LUD-25 line 80 still asks for that fallback - but the
+            // fallback note is only as safe as every routing hop's discretion, and
+            // a funding source that settles without a preimage has nothing to key
+            // one by. Refused here, before any invoice exists, so a wallet never
+            // pays for a quote this mint was always going to reject.
+            if (config.requireComment && outputId === null) {
+                return fail('a mint quote must name its output with a LUD-12 comment carrying hex(sha256(secret))');
+            }
             if (outputId !== null && store.outputIdInUse(outputId)) {
                 return fail('Invalid or already spent k1.');
             }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@forgesworn/moneyer",
-  "version": "0.7.0",
+  "version": "0.8.0",
   "description": "An LNURLcash (LUD-25) mint - strikes Lightning bearer notes. Independent implementation, cln/lnd funding sources, SQLite, zero HTTP framework.",
   "author": "TheCryptoDonkey",
   "license": "MIT",