@forgesworn/moneyer 0.3.0 → 0.3.2

package/CHANGELOG.md

@@ -1,5 +1,39 @@
 # Changelog
 
+## [0.3.2] - 2026-08-22
+
+- **A note with a melt in flight is no longer advertised as withdrawable.**
+  The mutating callback already refused a pending note; the informational
+  GET did not, so the check LUD-25 points a careful holder at was the one
+  that lied. That is the exact gap a sell-during-melt needs: start a melt,
+  show the buyer a healthy GET, take payment out of band, let the melt
+  settle. `fetchNoteInfo` on a pending note now fails the same way the
+  callback does, and lnurlcash-kit classifies it as `PendingNoteError`, so
+  a wallet parks the note rather than writing it off as unknown. Found by
+  re-reading LUD-25 against dni's lnurl-mint, which has had this guard.
+- A flake in the melt suite: `leaves an unconfirmable outcome pending`
+  slept a fixed 100 ms, which was waiting for an in-flight melt to finish
+  exhausting its confirmations rather than for any state, and reconcile
+  deliberately skips a melt this process still has in flight. It now
+  retries reconcile until it can act.
+
+## [0.3.1] - 2026-08-22
+
+- **Rounding the fee to a whole sat now really is the default.** 0.3.0
+  documented `roundFeeToSat` as on unless turned off, and made it so for a
+  mint started from the CLI, where the environment reader fills the
+  default in. A mint built by calling `createMoneyer` with a config object
+  passes the field through as absent, and the server read absent as off -
+  so an embedder got a mint that kept fractions of a sat while the same
+  mint from the binary rounded them away. Absent now means on in both,
+  and only an explicit `false` opts out.
+
+  It hid because every test that cared about rounding set the flag
+  explicitly, so nothing exercised the default through the library at all.
+  Found from the other side: notecase's cross-implementation suite began
+  asserting what a wallet is actually credited, and the mint it builds in
+  process disagreed with the mint on the wire.
+
 ## [0.3.0] - 2026-08-22
 
 - **The mint fee is now ceilinged to a whole sat by default.**

package/dist/server.js

@@ -92,7 +92,13 @@ export const createMoneyer = async (config, deps = {}) => {
         const exact = grossMsat - applyMintFee(grossMsat, config.mintFee);
         // Both readings sit inside lnurlcash-kit's mintFeeBand, so a wallet
         // is not misled either way - it is told the range up front.
-        return config.roundFeeToSat === true ? Math.ceil(exact / 1000) * 1000 : exact;
+        //
+        // Absent means ON, the same as DEFAULTS and MONEYER_ROUND_FEE_TO_SAT:
+        // only an explicit false opts out. Reading it as `=== true` made the
+        // library default differ from the binary's, so a mint built by calling
+        // createMoneyer kept fractions of a sat that the same mint started from
+        // the CLI would have rounded.
+        return config.roundFeeToSat !== false ? Math.ceil(exact / 1000) * 1000 : exact;
     };
     // Every quote and every credit goes through here, so the fee posture
     // cannot drift between what is advertised and what is withheld.
@@ -116,7 +122,7 @@ export const createMoneyer = async (config, deps = {}) => {
     const mintFeeLine = config.mintFee ? `Mint fees: ${config.mintFee.baseFeeMsat},${config.mintFee.feePpm}` : null;
     // The same fee for a person: "Mint fees: 5000,1000" is for wallets that
     // parse LUD-25, and reads as nonsense to anyone who does not.
-    const feeInWords = config.mintFee ? describeFee(config.mintFee, config.roundFeeToSat === true) : null;
+    const feeInWords = config.mintFee ? describeFee(config.mintFee, config.roundFeeToSat !== false) : null;
     const nostr = config.zap ? (deps.nostr ?? poolTransport()) : null;
     const zap = config.zap && nostr
         ? createZapBridge({
@@ -670,6 +676,16 @@ export const createMoneyer = async (config, deps = {}) => {
                 return fail('Unknown note.');
             if (note.state === 'burned')
                 return fail('Note already spent.');
+            // A note reserved by an in-flight melt is not withdrawable, and must
+            // not be advertised as though it were. LUD-25 makes this GET the way
+            // anyone checks what a note is worth, so answering "live, worth all
+            // of it" about a note halfway out of the door is the exact lie a
+            // sell-during-melt needs: the seller starts a melt, shows the buyer a
+            // healthy GET, takes payment out of band, and the melt settles. Same
+            // reason the mutating callback already gives, and the same one dni's
+            // lnurl-mint gives here.
+            if (note.state === 'pending')
+                return fail('pending');
             // maxWithdrawable states the note's value, as the reference does.
             // minWithdrawable is that value floored to a whole sat: most Lightning
             // wallets can only invoice whole sats, and a note of 94.9 sat that

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@forgesworn/moneyer",
-  "version": "0.3.0",
+  "version": "0.3.2",
   "description": "An LNURLcash (LUD-25) mint - strikes Lightning bearer notes. Independent implementation, cln/lnd funding sources, SQLite, zero HTTP framework.",
   "author": "TheCryptoDonkey",
   "license": "MIT",