@forgesworn/moneyer 0.2.1 → 0.3.1

package/CHANGELOG.md

@@ -1,5 +1,45 @@
 # Changelog
 
+## [0.3.1] - 2026-08-22
+
+- **Rounding the fee to a whole sat now really is the default.** 0.3.0
+  documented `roundFeeToSat` as on unless turned off, and made it so for a
+  mint started from the CLI, where the environment reader fills the
+  default in. A mint built by calling `createMoneyer` with a config object
+  passes the field through as absent, and the server read absent as off -
+  so an embedder got a mint that kept fractions of a sat while the same
+  mint from the binary rounded them away. Absent now means on in both,
+  and only an explicit `false` opts out.
+
+  It hid because every test that cared about rounding set the flag
+  explicitly, so nothing exercised the default through the library at all.
+  Found from the other side: notecase's cross-implementation suite began
+  asserting what a wallet is actually credited, and the mint it builds in
+  process disagreed with the mint on the wire.
+
+## [0.3.0] - 2026-08-22
+
+- **The mint fee is now ceilinged to a whole sat by default.**
+  `MONEYER_ROUND_FEE_TO_SAT` defaults to `true`, matching dni's
+  lnurl-mint, the reference. **An operator upgrading into this withholds
+  slightly more per mint than before** - up to one sat, whatever the ppm
+  cut worked out to - so it is called out here rather than changed
+  quietly. `MONEYER_ROUND_FEE_TO_SAT=false` restores the old behaviour.
+
+  Why: a mint that deals in fractions of a sat issues notes nothing
+  downstream can spend. An msat-exact fee makes notes like 94.9 sat, and
+  most Lightning wallets can only invoice whole sats, so such a note
+  cannot be withdrawn by them at all. The mint already covered that by
+  advertising `minWithdrawable` as the whole-sat floor and keeping the
+  remainder as dust; rounding at mint time means it never arises. Every
+  note this mint issues for a whole-sat payment is now worth a whole
+  number of sats, on both the pay callback and the zap path, which share
+  one fee function.
+
+  LUD-25 says nothing about rounding and `lnurlcash-kit`'s `mintFeeBand`
+  accepts either, so this is a posture change and not a compliance one.
+  The conformance grader passed both before and passes this now.
+
 ## [0.2.1] - 2026-08-22
 
 - `moneyer --dev` settles its invoices a moment after issuing them rather

package/README.md

@@ -87,7 +87,7 @@ default, and a variable set to an empty string counts as unset.
 | `MONEYER_PREVIOUS_SIGNING_PUBKEYS` | | compressed pubkeys this mint signed under before, comma separated (see below) |
 | `MONEYER_BASE_FEE_MSAT` | `0` | flat mint fee |
 | `MONEYER_FEE_PPM` | `0` | proportional mint fee, parts per million |
-| `MONEYER_ROUND_FEE_TO_SAT` | `false` | ceiling the mint fee to a whole sat (see below) |
+| `MONEYER_ROUND_FEE_TO_SAT` | `true` | ceiling the mint fee to a whole sat (see below) |
 | `MONEYER_MIN_SENDABLE_MSAT` | `1000` | smallest payment the mint advertises |
 | `MONEYER_MAX_SENDABLE_MSAT` | `100000000` | largest payment the mint advertises |
 | `MONEYER_MIN_MINT_MSAT` | `1000` | dust floor: the smallest note the mint will strike |
@@ -269,16 +269,20 @@ the msat-exact amount. Neither is out of spec - lnurlcash-kit's
 `mintFeeBand` treats anything between the two as the mint keeping its
 word, and the conformance grader accepts both.
 
-`MONEYER_ROUND_FEE_TO_SAT=true` switches this mint to the reference's
-behaviour. Off by default: turning it on raises what the mint withholds,
-and that is not a change to make behind an operator's back on a redeploy.
-
-Why you probably want it on anyway: msat-exact fees make notes like 94.9
-sat, and most Lightning wallets can only invoice whole sats, so such a
-note cannot be withdrawn by them. moneyer covers the notes already out
-there by advertising `minWithdrawable` as the note floored to a whole sat
-and accepting a melt for that; the sub-sat remainder is dust the mint
-keeps. Rounding at mint time means it never comes up.
+**moneyer rounds, by default.** A mint that deals in fractions of a sat
+issues notes nothing downstream can spend: msat-exact fees make notes like
+94.9 sat, and most Lightning wallets can only invoice whole sats, so such
+a note cannot be withdrawn by them at all. moneyer covers the notes
+already out there by advertising `minWithdrawable` as the note floored to
+a whole sat and accepting a melt for that, keeping the sub-sat remainder
+as dust - a wart it should not need. Rounding at mint time means it never
+comes up, and every note this mint issues for a whole-sat payment is worth
+a whole number of sats.
+
+`MONEYER_ROUND_FEE_TO_SAT=false` restores the msat-exact fee. An operator
+upgrading into this default withholds slightly more per mint than before,
+which is why the changelog says so plainly rather than letting a redeploy
+change it quietly.
 
 ## Melting to an invoice with no amount
 

package/dist/config.d.ts

@@ -65,7 +65,7 @@ export declare const DEFAULTS: {
     readonly verify: true;
     readonly maxK1s: 21;
     readonly sunset: false;
-    readonly roundFeeToSat: false;
+    readonly roundFeeToSat: true;
     readonly stats: true;
     readonly statsRatioOnly: false;
     readonly statsPublish: false;

package/dist/config.js

@@ -14,7 +14,7 @@ export const DEFAULTS = {
     verify: true,
     maxK1s: 21,
     sunset: false,
-    roundFeeToSat: false,
+    roundFeeToSat: true,
     stats: true,
     statsRatioOnly: false,
     statsPublish: false,

package/dist/server.js

@@ -92,7 +92,13 @@ export const createMoneyer = async (config, deps = {}) => {
         const exact = grossMsat - applyMintFee(grossMsat, config.mintFee);
         // Both readings sit inside lnurlcash-kit's mintFeeBand, so a wallet
         // is not misled either way - it is told the range up front.
-        return config.roundFeeToSat === true ? Math.ceil(exact / 1000) * 1000 : exact;
+        //
+        // Absent means ON, the same as DEFAULTS and MONEYER_ROUND_FEE_TO_SAT:
+        // only an explicit false opts out. Reading it as `=== true` made the
+        // library default differ from the binary's, so a mint built by calling
+        // createMoneyer kept fractions of a sat that the same mint started from
+        // the CLI would have rounded.
+        return config.roundFeeToSat !== false ? Math.ceil(exact / 1000) * 1000 : exact;
     };
     // Every quote and every credit goes through here, so the fee posture
     // cannot drift between what is advertised and what is withheld.
@@ -116,7 +122,7 @@ export const createMoneyer = async (config, deps = {}) => {
     const mintFeeLine = config.mintFee ? `Mint fees: ${config.mintFee.baseFeeMsat},${config.mintFee.feePpm}` : null;
     // The same fee for a person: "Mint fees: 5000,1000" is for wallets that
     // parse LUD-25, and reads as nonsense to anyone who does not.
-    const feeInWords = config.mintFee ? describeFee(config.mintFee, config.roundFeeToSat === true) : null;
+    const feeInWords = config.mintFee ? describeFee(config.mintFee, config.roundFeeToSat !== false) : null;
     const nostr = config.zap ? (deps.nostr ?? poolTransport()) : null;
     const zap = config.zap && nostr
         ? createZapBridge({

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@forgesworn/moneyer",
-  "version": "0.2.1",
+  "version": "0.3.1",
   "description": "An LNURLcash (LUD-25) mint - strikes Lightning bearer notes. Independent implementation, cln/lnd funding sources, SQLite, zero HTTP framework.",
   "author": "TheCryptoDonkey",
   "license": "MIT",