@forgesworn/moneyer 0.1.1 → 0.1.2

package/CHANGELOG.md

@@ -1,5 +1,21 @@
 # Changelog
 
+## [0.1.2] - 2026-08-21
+
+- `MONEYER_ROUND_FEE_TO_SAT` ceilings the mint fee to a whole sat, as
+  dni's lnurl-mint does on purpose so the mint is "never short a sat".
+  LUD-25 says nothing about rounding and `lnurlcash-kit`'s `mintFeeBand`
+  accepts both readings, so this is a posture choice rather than a
+  compliance one. **Off by default**: turning it on raises what the mint
+  withholds, which is not a change to make on a redeploy.
+- The mint path called `applyMintFee` directly rather than the fee helper,
+  so it would have ignored that setting entirely - advertising one fee and
+  withholding another. Every fee site now goes through one
+  `netAfterMintFee`.
+- `roundFeeToSat` is optional on `MoneyerConfig`: that type is public API,
+  and an embedder constructing a config should not have to name a field it
+  does not care about.
+
 ## [0.1.1] - 2026-08-21
 
 - `withdrawLink` is now the plain URL (`https://host/w`), the form

package/README.md

@@ -97,6 +97,19 @@ import {createMoneyer, configFromEnv} from '@forgesworn/moneyer'
 const mint = await createMoneyer(configFromEnv())
 ```
 
+## The mint fee, and the rounding question
+
+LUD-25 gives the fee as a flat `base_fee_msat` plus a ppm cut and says
+nothing about rounding. dni's lnurl-mint, the reference, ceilings it to a
+whole sat on purpose so the mint is never short a sat; moneyer withholds
+the msat-exact amount. Neither is out of spec - lnurlcash-kit's
+`mintFeeBand` treats anything between the two as the mint keeping its
+word, and the conformance grader accepts both.
+
+`MONEYER_ROUND_FEE_TO_SAT=true` switches this mint to the reference's
+behaviour. Off by default: turning it on raises what the mint withholds,
+and that is not a change to make behind an operator's back on a redeploy.
+
 ## Endpoints
 
 | | |

package/dist/config.d.ts

@@ -20,6 +20,7 @@ export type MoneyerConfig = {
     maxSendableMsat: number;
     minMintMsat: number;
     mintFee: MintFee | null;
+    roundFeeToSat?: boolean;
     signingKey?: string;
     dbPath: string;
     backend: BackendConfig;
@@ -40,5 +41,6 @@ export declare const DEFAULTS: {
     readonly verify: true;
     readonly maxK1s: 21;
     readonly sunset: false;
+    readonly roundFeeToSat: false;
 };
 export declare const configFromEnv: (env?: NodeJS.ProcessEnv) => MoneyerConfig;

package/dist/config.js

@@ -9,7 +9,8 @@ export const DEFAULTS = {
     dbPath: 'moneyer.sqlite',
     verify: true,
     maxK1s: 21,
-    sunset: false
+    sunset: false,
+    roundFeeToSat: false
 };
 const int = (value, fallback) => {
     if (value === undefined || value === '')
@@ -89,6 +90,7 @@ export const configFromEnv = (env = process.env) => {
         maxSendableMsat,
         minMintMsat: int(env.MONEYER_MIN_MINT_MSAT, DEFAULTS.minMintMsat),
         mintFee: baseFeeMsat === 0 && feePpm === 0 ? null : { baseFeeMsat, feePpm },
+        roundFeeToSat: flag(env.MONEYER_ROUND_FEE_TO_SAT, DEFAULTS.roundFeeToSat),
         ...(signingKey ? { signingKey: signingKey.toLowerCase() } : {}),
         dbPath: env.MONEYER_DB ?? DEFAULTS.dbPath,
         backend,

package/dist/server.js

@@ -40,7 +40,17 @@ export const createMoneyer = async (config, deps = {}) => {
     // Melt payment hashes with a live attempt in this process. Reconcile
     // skips these - see melt.ts.
     const inFlight = new Set();
-    const mintFeeMsat = (grossMsat) => config.mintFee ? grossMsat - applyMintFee(grossMsat, config.mintFee) : 0;
+    const mintFeeMsat = (grossMsat) => {
+        if (!config.mintFee)
+            return 0;
+        const exact = grossMsat - applyMintFee(grossMsat, config.mintFee);
+        // Both readings sit inside lnurlcash-kit's mintFeeBand, so a wallet
+        // is not misled either way - it is told the range up front.
+        return config.roundFeeToSat === true ? Math.ceil(exact / 1000) * 1000 : exact;
+    };
+    // Every quote and every credit goes through here, so the fee posture
+    // cannot drift between what is advertised and what is withheld.
+    const netAfterMintFee = (grossMsat) => Math.max(0, grossMsat - mintFeeMsat(grossMsat));
     // What the mint advertises as its minimum must survive its own fee: a
     // payRequest whose minSendable nets below the dust floor invites a
     // payment it would then refuse.
@@ -164,7 +174,7 @@ export const createMoneyer = async (config, deps = {}) => {
                 callback: `${origin}/w`,
                 minWithdrawable: config.minMintMsat,
                 maxWithdrawable: config.mintFee
-                    ? applyMintFee(config.maxSendableMsat, config.mintFee)
+                    ? netAfterMintFee(config.maxSendableMsat)
                     : config.maxSendableMsat,
                 defaultDescription: config.description,
                 payLink: `${origin}/.well-known/lnurlp/${lnurlwMatch[1]}`,
@@ -187,7 +197,7 @@ export const createMoneyer = async (config, deps = {}) => {
             if (amount < effectiveMinSendableMsat || amount > config.maxSendableMsat) {
                 return fail('Amount out of range.');
             }
-            const net = config.mintFee ? applyMintFee(amount, config.mintFee) : amount;
+            const net = netAfterMintFee(amount);
             if (net < config.minMintMsat)
                 return fail('Amount too small to mint a note.');
             // The preimage is the future note's spend secret; its hash is the

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@forgesworn/moneyer",
-  "version": "0.1.1",
+  "version": "0.1.2",
   "description": "An LNURLcash (LUD-25) mint - strikes Lightning bearer notes. Independent implementation, cln/lnd funding sources, SQLite, zero HTTP framework.",
   "author": "TheCryptoDonkey",
   "license": "MIT",
@@ -45,7 +45,7 @@
     "test:watch": "vitest",
     "typecheck": "tsc --noEmit",
     "dev": "node --experimental-strip-types src/cli.ts --dev",
-    "conform": "node test/run-grader.mjs",
+    "conform": "vitest run test/conformance.test.ts",
     "check": "npm run typecheck && npm run typecheck:web && npm test && npm run build && npm run web:build && npm pack --dry-run",
     "web:dev": "vite web",
     "web:build": "vite build web",