@forgeax/engine-runtime 0.1.21 → 0.1.24

package/src/__tests__/pass-selector.cases.unit.test.ts

@@ -0,0 +1,376 @@
+// @ts-nocheck — merged file: cross-source node:fs/node:path imports outside @types/node coverage in runtime tsconfig
+// Consolidated by feat-20260609-test-pool-startup-reduction-merge-tiny-test-files
+// biome-ignore-all lint/complexity/noUselessLoneBlockStatements: block-scope isolation between merged source files (consolidation paradigm)
+//
+// Source files (N=33):
+//   - packages/runtime/__tests__/create-renderer-fallback.test.ts
+//   - packages/runtime/src/__tests__/cluster-binner.test.ts
+//   - packages/runtime/src/__tests__/create-renderer-fallback-shader-manifest.test.ts
+//   - packages/runtime/src/__tests__/create-renderer-uniform-fallback.test.ts
+//   - packages/runtime/src/__tests__/createRenderer.test.ts
+//   - packages/runtime/src/__tests__/dispatch-sort.test.ts
+//   - packages/runtime/src/__tests__/engine-metrics.test.ts
+//   - packages/runtime/src/__tests__/device/gpu-residency-caps-guard.test.ts
+//   - packages/runtime/src/__tests__/pass-selector.test.ts
+//   - packages/runtime/src/__tests__/pipeline-builder.test.ts
+//   - packages/runtime/src/__tests__/pipeline-cache-key-topology.test.ts
+//   - packages/runtime/src/__tests__/pipeline-rename-grep-gate.test.ts
+//   - packages/runtime/src/__tests__/pipeline-vertex-stride-branch.test.ts
+//   - packages/runtime/src/__tests__/post-process-register.test.ts
+//   - packages/runtime/src/__tests__/record-all-topology.test.ts
+//   - packages/runtime/src/__tests__/record-draw-branch.test.ts
+//   - packages/runtime/src/__tests__/record-strip-index-format.test.ts
+//   - packages/runtime/src/__tests__/render-query-regression.test.ts
+//   - packages/runtime/src/__tests__/renderer-draw-world.test.ts
+//   - packages/runtime/src/__tests__/renderer-input-snapshot.test.ts
+//   - packages/runtime/src/__tests__/renderer-read-pixels.test.ts
+//   - packages/runtime/src/__tests__/renderer-ready.test.ts
+//   - packages/runtime/src/__tests__/renderstate-pipeline-cache.test.ts
+//   - packages/runtime/src/__tests__/storage-buffer-caps.test.ts
+//   - packages/runtime/src/__tests__/device/gpu-residency.test.ts
+//   - packages/runtime/src/__tests__/render-data.test.ts
+//   - packages/runtime/src/__tests__/hdrp-bgl-slots.test.ts
+//   - packages/runtime/src/__tests__/hdrp-caps-gate.test.ts
+//   - packages/runtime/src/__tests__/hdrp-grid-invalid.test.ts
+//   - packages/runtime/src/__tests__/hdrp-index-list-overflow-once.test.ts
+//   - packages/runtime/src/__tests__/hdrp-light-budget.test.ts
+//   - packages/runtime/src/__tests__/hdrp-pipeline-asset-config.test.ts
+//   - packages/runtime/src/__tests__/m7-hdrp-demo-shape.test.ts
+//
+// Paradigm: each block-scope wraps a source file. ancestorTitles[0] is the
+// source-preserved inner describe (NOT the source filename for these 3 files
+// — recovery path: vitest report ancestorTitles -> grep this file -> upstream
+// `// ─── from <name>.test.ts ───` block separator -> source filename).
+// Top-level imports merged + deduped.
+
+import { existsSync, readFileSync } from 'node:fs';
+import { dirname, resolve } from 'node:path';
+import { fileURLToPath } from 'node:url';
+import { HANDLE_CUBE, HANDLE_TRIANGLE, resolveAssetHandle } from '@forgeax/engine-assets-runtime';
+import type { World as WorldType } from '@forgeax/engine-ecs';
+import { defineComponent, World } from '@forgeax/engine-ecs';
+import {
+  buildMeshAttributeMapForUvSets,
+  createBoxGeometry,
+  createConeGeometry,
+  createCylinderGeometry,
+  createPlaneGeometry,
+  createSphereGeometry,
+  createTorusGeometry,
+  PROCEDURAL_FLOATS_PER_VERTEX,
+} from '@forgeax/engine-geometry';
+import { type Mat4, mat4, type Vec3, vec3 } from '@forgeax/engine-math';
+import type { Renderer as RendererType } from '@forgeax/engine-render';
+import { Camera, MeshFilter, MeshRenderer } from '@forgeax/engine-render';
+import {
+  err,
+  ok,
+  type PipelineLayout,
+  type RenderPipeline,
+  type Result,
+  type RhiCaps,
+  type RhiDevice,
+  RhiError,
+  ok as rhiOk,
+  type ShaderModule,
+} from '@forgeax/engine-rhi';
+import {
+  acquireCanvasContext as acquireNullCanvasContext,
+  createShaderModule as createNullShaderModule,
+  RhiNullAdapter,
+} from '@forgeax/engine-rhi-null';
+import { ChildOf, Transform } from '@forgeax/engine-scene';
+import {
+  findVariantByKey,
+  type MaterialShaderEntry,
+  type MaterialShaderManifestEntry,
+  type MaterialShaderManifestVariant,
+} from '@forgeax/engine-shader';
+import {
+  type AssetError,
+  type EquirectAsset,
+  type Handle,
+  type MaterialRenderState,
+  type MeshAsset,
+  type PassSelector,
+  type PrimitiveTopology,
+  type RenderPipelineAsset,
+  type TextureAsset,
+  toShared,
+} from '@forgeax/engine-types';
+import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';
+import {
+  bin,
+  type ClusterBinError,
+  calculateSphereClusterBounds,
+  clusterSpaceObjectAabb,
+  deriveCullingRadius,
+  ndcPositionToCluster,
+  viewZToZSlice,
+} from '../../../render/src/cluster-binner';
+import { GpuResidencyCache } from '../../../render/src/device/gpu-residency';
+import { createEngineMetrics } from '../../../render/src/engine-metrics';
+import { assertStorageBufferCap } from '../../../render/src/light-buffer-layout';
+import {
+  buildPbrPipelineLayouts,
+  buildPbrViewBglEntries,
+  type PbrCaps,
+} from '../../../render/src/pbr-pipeline';
+import {
+  HdrpInstallError,
+  validateClusterGrid,
+} from '../../../render/src/pipeline/standard-pipeline';
+import {
+  buildPipelineForMaterialShader,
+  type PipelineBuilderContext,
+  type PipelineBuilderShaderModuleFactory,
+} from '../../../render/src/pipeline-builder';
+import {
+  cacheKeyOf,
+  createHdrpBindGroupLayoutDescriptor,
+  type PipelineSpec,
+} from '../../../render/src/pipeline-spec';
+import {
+  deriveRenderDataCubemap,
+  deriveRenderDataMesh,
+  deriveRenderDataTexture,
+} from '../../../render/src/render-data';
+import { extractFrame, prepareExtractContext } from '../../../render/src/render-system-extract';
+import { matchPass } from '../../../render/src/systems/pass-selector';
+import { makeMockShaderRegistry } from './helpers/mock-shader-registry';
+import { standardMaterialShaderVariants } from './helpers/standard-material-manifest';
+
+function makeExplicitNullRhi(spies: {
+  setIndexBuffer: ReturnType<typeof vi.fn>;
+  setVertexBuffer: ReturnType<typeof vi.fn>;
+  draw: ReturnType<typeof vi.fn>;
+  drawIndexed: ReturnType<typeof vi.fn>;
+}): unknown {
+  const adapter = new RhiNullAdapter();
+  const requestDevice = adapter.requestDevice.bind(adapter);
+  adapter.requestDevice = async () => {
+    const result = await requestDevice();
+    if (result.ok) {
+      const device = result.value;
+      const createCommandEncoder = device.createCommandEncoder.bind(device);
+      device.createCommandEncoder = (desc) => {
+        const encoderResult = createCommandEncoder(desc);
+        if (!encoderResult.ok) return encoderResult;
+        const encoder = encoderResult.value;
+        const beginRenderPass = encoder.beginRenderPass.bind(encoder);
+        encoder.beginRenderPass = (passDesc) => {
+          const pass = beginRenderPass(passDesc);
+          const draw = pass.draw.bind(pass);
+          const drawIndexed = pass.drawIndexed.bind(pass);
+          const setIndexBuffer = pass.setIndexBuffer.bind(pass);
+          const setVertexBuffer = pass.setVertexBuffer.bind(pass);
+          pass.draw = (...args) => {
+            spies.draw(...args);
+            draw(...args);
+          };
+          pass.drawIndexed = (...args) => {
+            spies.drawIndexed(...args);
+            drawIndexed(...args);
+          };
+          pass.setIndexBuffer = (...args) => {
+            spies.setIndexBuffer(...args);
+            setIndexBuffer(...args);
+          };
+          pass.setVertexBuffer = (...args) => {
+            spies.setVertexBuffer(...args);
+            setVertexBuffer(...args);
+          };
+          return pass;
+        };
+        return { ok: true, value: encoder };
+      };
+    }
+    return result;
+  };
+  return {
+    requestAdapter: async () => ({ ok: true, value: adapter }),
+    acquireCanvasContext: acquireNullCanvasContext,
+    createShaderModule: (device: unknown, desc: { code: string; label?: string }) =>
+      createNullShaderModule(device as never, desc),
+  };
+}
+
+vi.mock('@forgeax/engine-rhi-wgpu', () => {
+  return {
+    rhi: {
+      requestAdapter: async () => ({
+        ok: false,
+        error: {
+          code: 'adapter-unavailable',
+          expected: 'adapter available',
+          hint: 'default mock fail',
+        },
+      }),
+      getPreferredCanvasFormat: () => 'bgra8unorm',
+      acquireCanvasContext: () => ({
+        ok: false,
+        error: {
+          code: 'webgpu-runtime-error',
+          expected: 'context available',
+          hint: 'default mock fail',
+        },
+      }),
+    },
+    ensureReady: async () => undefined,
+  };
+});
+
+void [
+  Camera,
+  ChildOf,
+  GpuResidencyCache,
+  HANDLE_CUBE,
+  HANDLE_TRIANGLE,
+  HdrpInstallError,
+  MeshFilter,
+  MeshRenderer,
+  PROCEDURAL_FLOATS_PER_VERTEX,
+  RhiError,
+  RhiNullAdapter,
+  Transform,
+  World,
+  acquireNullCanvasContext,
+  afterEach,
+  assertStorageBufferCap,
+  beforeEach,
+  bin,
+  buildMeshAttributeMapForUvSets,
+  buildPbrPipelineLayouts,
+  buildPbrViewBglEntries,
+  buildPipelineForMaterialShader,
+  cacheKeyOf,
+  calculateSphereClusterBounds,
+  clusterSpaceObjectAabb,
+  createBoxGeometry,
+  createConeGeometry,
+  createCylinderGeometry,
+  createEngineMetrics,
+  createHdrpBindGroupLayoutDescriptor,
+  createNullShaderModule,
+  createPlaneGeometry,
+  createSphereGeometry,
+  createTorusGeometry,
+  defineComponent,
+  deriveCullingRadius,
+  deriveRenderDataCubemap,
+  deriveRenderDataMesh,
+  deriveRenderDataTexture,
+  describe,
+  dirname,
+  err,
+  existsSync,
+  expect,
+  extractFrame,
+  fileURLToPath,
+  findVariantByKey,
+  it,
+  makeExplicitNullRhi,
+  makeMockShaderRegistry,
+  mat4,
+  matchPass,
+  ndcPositionToCluster,
+  ok,
+  prepareExtractContext,
+  readFileSync,
+  resolve,
+  resolveAssetHandle,
+  rhiOk,
+  standardMaterialShaderVariants,
+  toShared,
+  validateClusterGrid,
+  vec3,
+  vi,
+  viewZToZSlice,
+];
+type __MergedKeep =
+  | AssetError
+  | ClusterBinError
+  | EquirectAsset
+  | Handle
+  | Mat4
+  | MaterialRenderState
+  | MaterialShaderEntry
+  | MaterialShaderManifestEntry
+  | MaterialShaderManifestVariant
+  | MeshAsset
+  | PassSelector
+  | PbrCaps
+  | PipelineBuilderContext
+  | PipelineBuilderShaderModuleFactory
+  | PipelineLayout
+  | PipelineSpec
+  | PrimitiveTopology
+  | RenderPipeline
+  | RenderPipelineAsset
+  | RendererType
+  | Result
+  | RhiCaps
+  | RhiDevice
+  | ShaderModule
+  | TextureAsset
+  | Vec3
+  | WorldType;
+
+{
+  // --- from pass-selector.test.ts ---
+  describe('matchPass', () => {
+    it('empty selector matches all pass tags', () => {
+      const selector: PassSelector = {};
+      expect(matchPass({ LightMode: 'Forward' }, selector)).toBe(true);
+      expect(matchPass({}, selector)).toBe(true);
+      expect(matchPass({ Queue: 'Background', RenderType: 'Opaque' }, selector)).toBe(true);
+    });
+
+    it('single key match — pass tags contain key and value is in selector list', () => {
+      const selector: PassSelector = { LightMode: ['Forward', 'ShadowCaster'] };
+      expect(matchPass({ LightMode: 'Forward' }, selector)).toBe(true);
+      expect(matchPass({ LightMode: 'ShadowCaster' }, selector)).toBe(true);
+    });
+
+    it('single key no match — pass tags do not contain the key', () => {
+      const selector: PassSelector = { LightMode: ['Forward'] };
+      expect(matchPass({ Queue: 'Geometry' }, selector)).toBe(false);
+    });
+
+    it('single key no match — key exists but value not in selector list', () => {
+      const selector: PassSelector = { LightMode: ['Forward'] };
+      expect(matchPass({ LightMode: 'ShadowCaster' }, selector)).toBe(false);
+    });
+
+    it('multi-key all match', () => {
+      const selector: PassSelector = {
+        LightMode: ['Forward'],
+        RenderType: ['Opaque', 'AlphaTest'],
+      };
+      expect(matchPass({ LightMode: 'Forward', RenderType: 'Opaque' }, selector)).toBe(true);
+      expect(matchPass({ LightMode: 'Forward', RenderType: 'AlphaTest' }, selector)).toBe(true);
+    });
+
+    it('multi-key partial match — overall no match when any key fails', () => {
+      const selector: PassSelector = {
+        LightMode: ['Forward'],
+        RenderType: ['Opaque'],
+      };
+      // RenderType key missing
+      expect(matchPass({ LightMode: 'Forward' }, selector)).toBe(false);
+      // RenderType value not in list
+      expect(matchPass({ LightMode: 'Forward', RenderType: 'Transparent' }, selector)).toBe(false);
+    });
+
+    it('selector value is empty array — no match', () => {
+      const selector: PassSelector = { LightMode: [] };
+      expect(matchPass({ LightMode: 'Forward' }, selector)).toBe(false);
+      expect(matchPass({}, selector)).toBe(false);
+    });
+
+    it('pass has extra tags beyond selector — still matches', () => {
+      const selector: PassSelector = { LightMode: ['Forward'] };
+      expect(matchPass({ LightMode: 'Forward', ExtraTag: 'whatever' }, selector)).toBe(true);
+    });
+  });
+}

package/src/__tests__/pbr-pipeline.unit.test.ts

@@ -10,6 +10,7 @@
 // must be replaced by buildBindGroupLayoutDescriptor calls without changing
 // what the device sees.
 
+import { STANDARD_PIPELINE_PARAM_SCHEMA } from '@forgeax/engine-shader';
 import { describe, expect, it } from 'vitest';
 import {
   appendInjection,
@@ -44,34 +45,29 @@ function makeSpec(): PipelineSpec {
 
 describe('buildBindGroupLayoutDescriptor — pbr-pipeline 6 sites byte-equiv', () => {
   describe('pbr-view', () => {
-    it('storageBuffer=true: 12 entries with read-only-storage on bindings 1+2 and projector bindings 11+12', () => {
+    it('storageBuffer=true: 10 entries with projector bindings 11+12', () => {
       const spec = makeSpec();
       const out = buildBindGroupLayoutDescriptor(spec, {
         kind: 'pbr-view',
-        caps: { storageBuffer: true },
+        caps: { storageBuffer: true, extendedLighting: false },
       });
       const expected = {
         label: 'pbr-view-bgl',
-        entries: buildPbrViewBglEntries({ storageBuffer: true }),
+        entries: buildPbrViewBglEntries({ storageBuffer: true, extendedLighting: false }),
       };
       expect(out).toEqual(expected);
-      // feat-20260625-spot-light-shadow-mapping: binding 8 (spot shadow atlas,
-      // w14) raised the view BGL to 9 entries (always-on, D-5). The
-      // Points/Lines viewport UBO occupies binding 10, while w25 (scope-amend
-      // webkit-fallback) folded the former binding 9 spotLightViewProj matrices
-      // UBO into the View UBO (`view.spotLightViewProj`), so the BGL stays at 9
-      // entries (bindings 0..8 plus optional projector 11+12 and binding 10)
-      // — keeping the WebGL2 fallback fragment uniform-buffer count <= 11
-      // (GLES 3.0), while the projector remains available on the default
-      // WebGPU path.
-      expect(out.entries.length).toBe(12);
+      // Binding 8 is the always-on spot shadow atlas, binding 10 is the
+      // Points/Lines viewport UBO, and bindings 11/12 are the optional
+      // projector resources. Local lights are exclusively carried by the
+      // Standard Cluster group(2), so the view group has no point/spot slots.
+      expect(out.entries.length).toBe(10);
       expect(out.entries.find((entry) => entry.binding === 9)).toBeUndefined();
       expect(out.entries.find((entry) => entry.binding === 10)?.buffer?.type).toBe('uniform');
       expect(out.entries.find((entry) => entry.binding === 11)?.texture?.viewDimension).toBe('2d');
       expect(out.entries.find((entry) => entry.binding === 12)?.sampler?.type).toBe('filtering');
     });
 
-    it('storageBuffer=false: bindings 1+2 fall back to uniform', () => {
+    it('storageBuffer=false: view group still has no local-light bindings', () => {
       const spec = makeSpec();
       const out = buildBindGroupLayoutDescriptor(spec, {
         kind: 'pbr-view',
@@ -82,17 +78,22 @@ describe('buildBindGroupLayoutDescriptor — pbr-pipeline 6 sites byte-equiv', (
         entries: buildPbrViewBglEntries({ storageBuffer: false }),
       };
       expect(out).toEqual(expected);
+      expect(out.entries.some((entry) => entry.binding === 1 || entry.binding === 2)).toBe(false);
     });
 
     it('projectorAvailable=false: omits optional projector bindings for the 16-texture limit', () => {
       const spec = makeSpec();
       const out = buildBindGroupLayoutDescriptor(spec, {
         kind: 'pbr-view',
-        caps: { storageBuffer: true, projectorAvailable: false },
+        caps: { storageBuffer: true, projectorAvailable: false, extendedLighting: false },
       });
       expect(out).toEqual({
         label: 'pbr-view-bgl',
-        entries: buildPbrViewBglEntries({ storageBuffer: true, projectorAvailable: false }),
+        entries: buildPbrViewBglEntries({
+          storageBuffer: true,
+          projectorAvailable: false,
+          extendedLighting: false,
+        }),
       });
       expect(out.entries.find((entry) => entry.binding === 11)).toBeUndefined();
       expect(out.entries.find((entry) => entry.binding === 12)).toBeUndefined();
@@ -101,13 +102,13 @@ describe('buildBindGroupLayoutDescriptor — pbr-pipeline 6 sites byte-equiv', (
   });
 
   describe('pbr-material-merged', () => {
-    it('26 entries: user-region 17 (derived) + ibl 7 + transmission 2', () => {
+    it('24 entries: user-region 15 (derived) + ibl 7 + transmission 2', () => {
       const spec = makeSpec();
       const out = buildBindGroupLayoutDescriptor(spec, {
         kind: 'pbr-material-merged',
       });
       // Post-M2 (D-1): user-region comes from derive(paramSchema).bglEntries
-      // (built-in standard-PBR 8-texture contract), then IBL + transmission
+      // (built-in standard-PBR 7-user-texture contract), then IBL + transmission
       // are appended at start = userRegion.length.
       const userRegion = buildPbrMaterialUserRegionEntries();
       const afterIbl = [...userRegion, ...appendInjection(userRegion, 'ibl')];
@@ -116,7 +117,24 @@ describe('buildBindGroupLayoutDescriptor — pbr-pipeline 6 sites byte-equiv', (
         entries: [...afterIbl, ...appendInjection(afterIbl, 'transmission')],
       };
       expect(out).toEqual(expected);
-      expect(out.entries.length).toBe(26);
+      expect(out.entries.length).toBe(24);
+    });
+
+    it('adds only authored physical map pairs after the canonical injection chain', () => {
+      const schema = [
+        ...STANDARD_PIPELINE_PARAM_SCHEMA,
+        { name: 'clearcoat', type: 'f32' as const },
+        { name: 'clearcoatTexture', type: 'texture2d' as const },
+        { name: 'clearcoatNormalTexture', type: 'texture2d' as const },
+      ];
+      const out = buildBindGroupLayoutDescriptor(makeSpec(), {
+        kind: 'pbr-material-merged',
+        materialParamSchema: schema,
+      });
+      expect(out.entries.map((entry) => entry.binding)).toEqual([
+        ...Array.from({ length: 28 }, (_, index) => index),
+      ]);
+      expect(out.entries.slice(24).map((entry) => entry.binding)).toEqual([24, 25, 26, 27]);
     });
   });
 
@@ -209,7 +227,7 @@ describe('buildBindGroupLayoutDescriptor — pbr-pipeline 6 sites byte-equiv', (
   });
 
   describe('unlit-material', () => {
-    it('17 entries: base PBR material only (no skylight injection)', () => {
+    it('15 entries: base PBR material only (no skylight injection)', () => {
       const spec = makeSpec();
       const out = buildBindGroupLayoutDescriptor(spec, {
         kind: 'unlit-material',
@@ -218,7 +236,7 @@ describe('buildBindGroupLayoutDescriptor — pbr-pipeline 6 sites byte-equiv', (
         label: 'unlit-material-bgl',
         entries: buildPbrMaterialUserRegionEntries(),
       });
-      expect(out.entries.length).toBe(17);
+      expect(out.entries.length).toBe(15);
     });
   });
 });