@forgeax/engine-geometry 0.1.23 → 0.1.25

package/dist/__tests__/physical-tangent.unit.test.d.ts

@@ -0,0 +1,2 @@
+export {};
+//# sourceMappingURL=physical-tangent.unit.test.d.ts.map

package/dist/__tests__/physical-tangent.unit.test.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"physical-tangent.unit.test.d.ts","sourceRoot":"","sources":["../../src/__tests__/physical-tangent.unit.test.ts"],"names":[],"mappings":""}

package/dist/index.mjs

@@ -1,6 +1,6 @@
 import { decodeMeshBinHeader, MESH_BIN_HEADER_V4_BYTES, MESH_BIN_VERSION } from '@forgeax/engine-pack';
 import { box3, circle2, box2 } from '@forgeax/engine-math';
-import { ok, countUvSets, AssetError, ASSET_ERROR_HINTS, err } from '@forgeax/engine-types';
+import { err, ok, countUvSets, AssetError, ASSET_ERROR_HINTS } from '@forgeax/engine-types';
 
 // src/assets/mesh-binary.ts
 var EPSILON = 1e-8;
@@ -82,6 +82,7 @@ function computeTangentVec4(positions, normals, uvs, indices) {
   const vertexCount = preflight.value;
   const accumT = new Float32Array(vertexCount * 3);
   const accumSign = new Float32Array(vertexCount);
+  let validTriangleCount = 0;
   const triangleCount = indices !== void 0 ? indices.length / 3 : vertexCount / 3;
   for (let tri = 0; tri < triangleCount; tri++) {
     const i0 = indices !== void 0 ? indices[tri * 3] ?? 0 : tri * 3;
@@ -125,6 +126,7 @@ function computeTangentVec4(positions, normals, uvs, indices) {
     const cz = dP1x * dP2y - dP1y * dP2x;
     const faceArea = 0.5 * Math.sqrt(cx * cx + cy * cy + cz * cz);
     if (faceArea < EPSILON) continue;
+    validTriangleCount += 1;
     const signDet = det >= 0 ? 1 : -1;
     const signedWeight = faceArea * signDet;
     for (const vi of [i0, i1, i2]) {
@@ -134,6 +136,15 @@ function computeTangentVec4(positions, normals, uvs, indices) {
       accumSign[vi] = (accumSign[vi] ?? 0) + signedWeight;
     }
   }
+  if (validTriangleCount === 0) {
+    return err(
+      tangentInputError(
+        "tangent",
+        0,
+        "material-tangent-required: no triangle has a valid UV-derived tangent"
+      )
+    );
+  }
   const out = new Float32Array(vertexCount * 4);
   for (let v = 0; v < vertexCount; v++) {
     let tx = accumT[v * 3] ?? 0;
@@ -150,26 +161,29 @@ function computeTangentVec4(positions, normals, uvs, indices) {
       let rx = 1;
       let ry = 0;
       let rz = 0;
-      if (ax <= ay && ax <= az) {
-        rx = 1;
-        ry = 0;
-        rz = 0;
-      } else if (ay <= ax && ay <= az) {
+      if (ax > ay && ax > az) {
         rx = 0;
         ry = 1;
-        rz = 0;
-      } else {
+      } else if (ay > ax && ay > az) {
         rx = 0;
-        ry = 0;
         rz = 1;
       }
       tx = ny * rz - nz * ry;
       ty = nz * rx - nx * rz;
       tz = nx * ry - ny * rx;
-      const fLen = Math.sqrt(tx * tx + ty * ty + tz * tz) || 1;
-      tx /= fLen;
-      ty /= fLen;
-      tz /= fLen;
+      const fallbackLength = Math.sqrt(tx * tx + ty * ty + tz * tz);
+      if (fallbackLength < EPSILON) {
+        return err(
+          tangentInputError(
+            "tangent",
+            v,
+            "material-tangent-required: supplied normal cannot define a tangent frame"
+          )
+        );
+      }
+      tx /= fallbackLength;
+      ty /= fallbackLength;
+      tz /= fallbackLength;
     } else {
       tx /= tLen;
       ty /= tLen;
@@ -187,26 +201,29 @@ function computeTangentVec4(positions, normals, uvs, indices) {
       let rx = 1;
       let ry = 0;
       let rz = 0;
-      if (ax <= ay && ax <= az) {
-        rx = 1;
-        ry = 0;
-        rz = 0;
-      } else if (ay <= ax && ay <= az) {
+      if (ax > ay && ax > az) {
         rx = 0;
         ry = 1;
-        rz = 0;
-      } else {
+      } else if (ay > ax && ay > az) {
         rx = 0;
-        ry = 0;
         rz = 1;
       }
       gx = ny * rz - nz * ry;
       gy = nz * rx - nx * rz;
       gz = nx * ry - ny * rx;
-      const fLen = Math.sqrt(gx * gx + gy * gy + gz * gz) || 1;
-      gx /= fLen;
-      gy /= fLen;
-      gz /= fLen;
+      const fallbackLength = Math.sqrt(gx * gx + gy * gy + gz * gz);
+      if (fallbackLength < EPSILON) {
+        return err(
+          tangentInputError(
+            "tangent",
+            v,
+            "material-tangent-required: supplied normal cannot define a tangent frame"
+          )
+        );
+      }
+      gx /= fallbackLength;
+      gy /= fallbackLength;
+      gz /= fallbackLength;
     } else {
       gx /= gLen;
       gy /= gLen;