@forge/lint 5.2.4-next.0 → 5.3.0-next.1

package/CHANGELOG.md

@@ -1,5 +1,11 @@
 # @forge/lint
 
+## 5.3.0-next.1
+
+### Minor Changes
+
+- 8cf085b: Improve linting to check for invokeRemote compute classification
+
 ## 5.2.4-next.0
 
 ### Patch Changes

package/out/lint/linters/remote-linter/verifiers/invoke-remote-verifier.d.ts

@@ -5,6 +5,8 @@ export declare class InvokeRemoteVerifier extends BaseLintIssueVerifier implemen
     protected getLintClass(): LintClass;
     process(input: InvokeRemoteVerifierInput): Promise<LintResultRule[]>;
     private isValidCall;
+    private getRemoteForCall;
     private isRemoteKeyValid;
+    private hasComputeOperation;
 }
 //# sourceMappingURL=invoke-remote-verifier.d.ts.map

package/out/lint/linters/remote-linter/verifiers/invoke-remote-verifier.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"invoke-remote-verifier.d.ts","sourceRoot":"","sources":["../../../../../src/lint/linters/remote-linter/verifiers/invoke-remote-verifier.ts"],"names":[],"mappings":"AAEA,OAAO,EAAE,SAAS,EAAE,cAAc,EAAE,MAAM,2BAA2B,CAAC;AAEtE,OAAO,EAAE,qBAAqB,EAAE,iBAAiB,EAAE,MAAM,0BAA0B,CAAC;AACpF,OAAO,EAIL,yBAAyB,EAC1B,MAAM,4BAA4B,CAAC;AAEpC,qBAAa,oBACX,SAAQ,qBACR,YAAW,iBAAiB,CAAC,yBAAyB,CAAC;IAEvD,SAAS,CAAC,YAAY,IAAI,SAAS;IAItB,OAAO,CAAC,KAAK,EAAE,yBAAyB,GAAG,OAAO,CAAC,cAAc,EAAE,CAAC;IAgBjF,OAAO,CAAC,WAAW;IAYnB,OAAO,CAAC,gBAAgB;CASzB"}
+{"version":3,"file":"invoke-remote-verifier.d.ts","sourceRoot":"","sources":["../../../../../src/lint/linters/remote-linter/verifiers/invoke-remote-verifier.ts"],"names":[],"mappings":"AAGA,OAAO,EAAE,SAAS,EAAE,cAAc,EAAE,MAAM,2BAA2B,CAAC;AAEtE,OAAO,EAAE,qBAAqB,EAAE,iBAAiB,EAAE,MAAM,0BAA0B,CAAC;AACpF,OAAO,EAIL,yBAAyB,EAC1B,MAAM,4BAA4B,CAAC;AAEpC,qBAAa,oBACX,SAAQ,qBACR,YAAW,iBAAiB,CAAC,yBAAyB,CAAC;IAEvD,SAAS,CAAC,YAAY,IAAI,SAAS;IAItB,OAAO,CAAC,KAAK,EAAE,yBAAyB,GAAG,OAAO,CAAC,cAAc,EAAE,CAAC;IAuBjF,OAAO,CAAC,WAAW;IAcnB,OAAO,CAAC,gBAAgB;IAIxB,OAAO,CAAC,gBAAgB;IAMxB,OAAO,CAAC,mBAAmB;CAK5B"}

package/out/lint/linters/remote-linter/verifiers/invoke-remote-verifier.js

@@ -11,15 +11,19 @@ class InvokeRemoteVerifier extends verifier_interface_1.BaseLintIssueVerifier {
         return linter_interface_1.LintClass.Error;
     }
     async process(input) {
-        return input.invokeRemoteCalls
-            .filter((call) => this.isValidCall(call, input.imports))
+        const validCalls = input.invokeRemoteCalls.filter((call) => this.isValidCall(call, input.imports));
+        const missingRemotes = validCalls
             .filter((call) => !this.isRemoteKeyValid(call))
-            .map((call) => ({
+            .map((call) => ({ call, message: text_1.messages.verifiers.invokeRemoteKey }));
+        const missingComputeOperation = validCalls
+            .filter((call) => this.isRemoteKeyValid(call) && !this.hasComputeOperation(call))
+            .map((call) => ({ call, message: text_1.messages.verifiers.invokeRemoteCompute }));
+        return [...missingRemotes, ...missingComputeOperation].map(({ call, message }) => ({
             class: this.getLintClass(),
             column: call.column,
             line: call.line,
-            message: text_1.messages.verifiers.invokeRemoteKey.message(call.remoteKey),
-            reference: text_1.messages.verifiers.invokeRemoteKey.reference
+            message: message.message(call.remoteKey),
+            reference: message.reference
         }));
     }
     isValidCall(call, imports) {
@@ -29,12 +33,16 @@ class InvokeRemoteVerifier extends verifier_interface_1.BaseLintIssueVerifier {
         return imports.some((imp) => (imp.type === typescript_estree_1.AST_NODE_TYPES.ImportDefaultSpecifier || imp.type === typescript_estree_1.AST_NODE_TYPES.ImportNamespaceSpecifier) &&
             call.objectName === imp.alias);
     }
+    getRemoteForCall(call) {
+        return this.manifest.remotes?.find((remote) => remote.key === call.remoteKey);
+    }
     isRemoteKeyValid(call) {
-        const remotes = this.manifest.remotes;
-        if (!remotes) {
-            return false;
-        }
-        return remotes.some((remote) => remote.key === call.remoteKey);
+        const remote = this.getRemoteForCall(call);
+        return typeof remote !== 'undefined';
+    }
+    hasComputeOperation(call) {
+        const remote = this.getRemoteForCall(call);
+        return remote?.operations?.includes('compute') ?? false;
     }
 }
 exports.InvokeRemoteVerifier = InvokeRemoteVerifier;

package/out/lint/text/messages.d.ts

@@ -21,6 +21,10 @@ export declare const messages: {
             message: (remoteKey: string) => string;
             reference: string;
         };
+        invokeRemoteCompute: {
+            message: (remoteKey: string) => string;
+            reference: string;
+        };
         handler: {
             message: (method: string, key: string) => string;
             reference: string;

package/out/lint/text/messages.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"messages.d.ts","sourceRoot":"","sources":["../../../src/lint/text/messages.ts"],"names":[],"mappings":"AAAA,eAAO,MAAM,QAAQ;;;+BAGI,MAAM,UAAU,MAAM,SAAS,MAAM,KAAG,MAAM;;;;2BAKlD,MAAM;;;;2BAKN,MAAM;2BAER,MAAM;;;;2BAKJ,MAAM;;;;iCAKA,MAAM;;;;8BAKT,MAAM,OAAO,MAAM;;;;+BAKlB,MAAM,UAAU,MAAM,QAAQ,MAAM,GAAG,SAAS,SAAS,MAAM;;;;6BAKjE,MAAM;;;;+BAIJ,MAAM,QAAQ,MAAM,SAAS,MAAM;;;;CAK3D,CAAC"}
+{"version":3,"file":"messages.d.ts","sourceRoot":"","sources":["../../../src/lint/text/messages.ts"],"names":[],"mappings":"AAAA,eAAO,MAAM,QAAQ;;;+BAGI,MAAM,UAAU,MAAM,SAAS,MAAM,KAAG,MAAM;;;;2BAKlD,MAAM;;;;2BAKN,MAAM;2BAER,MAAM;;;;2BAKJ,MAAM;;;;iCAKA,MAAM;;;;iCAKN,MAAM;;;;8BAKT,MAAM,OAAO,MAAM;;;;+BAKlB,MAAM,UAAU,MAAM,QAAQ,MAAM,GAAG,SAAS,SAAS,MAAM;;;;6BAKjE,MAAM;;;;+BAIJ,MAAM,QAAQ,MAAM,SAAS,MAAM;;;;CAK3D,CAAC"}

package/out/lint/text/messages.js

@@ -24,6 +24,10 @@ exports.messages = {
             message: (remoteKey) => `The remote key "${remoteKey}" does not exist in the "remotes" section of your app's manifest.yml file`,
             reference: 'missing-remote-key'
         },
+        invokeRemoteCompute: {
+            message: (remoteKey) => `The remote key "${remoteKey}" does not have a compute operation defined in the "remotes" section of your app's manifest.yml file`,
+            reference: 'missing-remote-compute'
+        },
         handler: {
             message: (method, key) => `Cannot find exported function "${method}", which is required by module "${key}" handler defined in your app's manifest.yml file`,
             reference: 'valid-module-required'

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@forge/lint",
-  "version": "5.2.4-next.0",
+  "version": "5.3.0-next.1",
   "description": "Linting for forge apps",
   "main": "out/index.js",
   "license": "UNLICENSED",