@forge/lint 5.12.0-next.6 → 5.12.0-next.7-experimental-4cf7fd3

package/CHANGELOG.md

@@ -1,5 +1,37 @@
 # @forge/lint
 
+## 5.12.0-next.7-experimental-4cf7fd3
+
+### Minor Changes
+
+- 414eba9: Add LLM module to manifest if sdk in use
+- 738ce50: Add permission linter for Realtime subscribeGlobal method
+
+### Patch Changes
+
+- Updated dependencies [ee02b2c]
+- Updated dependencies [9a6d346]
+- Updated dependencies [260eb24]
+- Updated dependencies [debdb02]
+- Updated dependencies [8962080]
+- Updated dependencies [aaf8a03]
+- Updated dependencies [78efec7]
+  - @forge/csp@5.3.0-next.1-experimental-4cf7fd3
+  - @forge/manifest@11.0.0-next.3-experimental-4cf7fd3
+  - @forge/cli-shared@8.8.2-next.4-experimental-4cf7fd3
+
+## 5.12.0-next.7
+
+### Minor Changes
+
+- 414eba9: Add LLM module to manifest if sdk in use
+
+### Patch Changes
+
+- Updated dependencies [78efec7]
+  - @forge/manifest@11.0.0-next.3
+  - @forge/cli-shared@8.8.2-next.4
+
 ## 5.12.0-next.6
 
 ### Patch Changes

package/out/lint/lint.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"lint.d.ts","sourceRoot":"","sources":["../../src/lint/lint.ts"],"names":[],"mappings":"AAAA,OAAO,EAOL,cAAc,EACf,MAAM,mBAAmB,CAAC;AAC3B,OAAO,EAAE,cAAc,IAAI,QAAQ,EAAE,MAAM,iBAAiB,CAAC;AAC7D,OAAO,EAAE,MAAM,IAAI,CAAC;AAIpB,OAAO,EAAE,QAAQ,EAAE,MAAM,UAAU,CAAC;AACpC,OAAO,EAAE,eAAe,EAAE,SAAS,EAAE,UAAU,EAAE,UAAU,EAAkB,MAAM,oBAAoB,CAAC;AAcxG,MAAM,WAAW,YAAY;IAC3B,MAAM,EAAE,MAAM,CAAC;IACf,QAAQ,EAAE,MAAM,CAAC;CAClB;AAED,eAAO,MAAM,iBAAiB,WAAY,UAAU,eAAe,UAAU,EAAE,4BAAuB,IA+CrG,CAAC;AAEF,eAAO,MAAM,YAAY,gBAAiB,UAAU,EAAE,KAAG,YAQxD,CAAC;AAEF,eAAO,MAAM,eAAe,aAChB,MAAM,UACR,eAAe,oBACN,OAAO,GAAG,QAAQ,CAAC,aAAa,KAChD,QAAQ,SAAS,CAOnB,CAAC;AAEF,eAAO,MAAM,IAAI,gBACF,MAAM,EAAE,YACX,QAAQ,eACL,MAAM,UACX,UAAU,kBACF,cAAc,6BAjBpB,MAAM,UACR,eAAe,oBACN,OAAO,GAAG,QAAQ,CAAC,aAAa,KAChD,QAAQ,SAAS,CAAC,YAgBV,eAAe,EAAE,KAazB,QAAQ,UAAU,EAAE,CAyCtB,CAAC;AAwBF,eAAO,MAAM,QAAQ,WACX,UAAU,kBACF,cAAc,WACtB,eAAe,KACtB,QAAQ,UAAU,EAAE,CAGtB,CAAC"}
+{"version":3,"file":"lint.d.ts","sourceRoot":"","sources":["../../src/lint/lint.ts"],"names":[],"mappings":"AAAA,OAAO,EAOL,cAAc,EACf,MAAM,mBAAmB,CAAC;AAC3B,OAAO,EAAE,cAAc,IAAI,QAAQ,EAAE,MAAM,iBAAiB,CAAC;AAC7D,OAAO,EAAE,MAAM,IAAI,CAAC;AAIpB,OAAO,EAAE,QAAQ,EAAE,MAAM,UAAU,CAAC;AACpC,OAAO,EAAE,eAAe,EAAE,SAAS,EAAE,UAAU,EAAE,UAAU,EAAkB,MAAM,oBAAoB,CAAC;AAexG,MAAM,WAAW,YAAY;IAC3B,MAAM,EAAE,MAAM,CAAC;IACf,QAAQ,EAAE,MAAM,CAAC;CAClB;AAED,eAAO,MAAM,iBAAiB,WAAY,UAAU,eAAe,UAAU,EAAE,4BAAuB,IA+CrG,CAAC;AAEF,eAAO,MAAM,YAAY,gBAAiB,UAAU,EAAE,KAAG,YAQxD,CAAC;AAEF,eAAO,MAAM,eAAe,aAChB,MAAM,UACR,eAAe,oBACN,OAAO,GAAG,QAAQ,CAAC,aAAa,KAChD,QAAQ,SAAS,CAOnB,CAAC;AAEF,eAAO,MAAM,IAAI,gBACF,MAAM,EAAE,YACX,QAAQ,eACL,MAAM,UACX,UAAU,kBACF,cAAc,6BAjBpB,MAAM,UACR,eAAe,oBACN,OAAO,GAAG,QAAQ,CAAC,aAAa,KAChD,QAAQ,SAAS,CAAC,YAgBV,eAAe,EAAE,KAczB,QAAQ,UAAU,EAAE,CAyCtB,CAAC;AAwBF,eAAO,MAAM,QAAQ,WACX,UAAU,kBACF,cAAc,WACtB,eAAe,KACtB,QAAQ,UAAU,EAAE,CAGtB,CAAC"}

package/out/lint/lint.js

@@ -19,6 +19,7 @@ const invoke_remote_linter_1 = require("./linters/remote-linter/invoke-remote-li
 const storage_module_linter_1 = require("./linters/storage-module-linter/storage-module-linter");
 const frame_component_linter_1 = require("./linters/frame-component-linter/frame-component-linter");
 const deprecated_egress_permissions_manifest_linter_1 = require("./linters/manifest-linter/deprecated-egress-permissions-manifest-linter");
+const llm_module_linter_1 = require("./linters/llm-module-linter/llm-module-linter");
 const reportLintResults = (logger, lintResults, showSummary = true) => {
     let numErrors = 0, numWarnings = 0;
     let noProblemsFound = true;
@@ -91,6 +92,7 @@ const lint = async (filesToLint, manifest, environment, logger, statsigService,
     new invoke_remote_linter_1.InvokeRemoteLinter(environment, manifest, logger),
     new storage_module_linter_1.StorageModulesLinter(environment, manifest, logger),
     new frame_component_linter_1.FrameComponentLinter(environment, manifest, logger),
+    new llm_module_linter_1.LlmModuleLinter(environment, manifest, logger),
     new deprecated_egress_permissions_manifest_linter_1.DeprecatedEgressPermissionsManifestLinter(logger, statsigService)
 ]) => {
     const { include, exclude } = await (0, cli_shared_1.listTSConfigIncludeExclude)(new cli_shared_1.FileSystemReader());

package/out/lint/linters/llm-module-linter/llm-linter-interface.d.ts

@@ -0,0 +1,9 @@
+import { LintCriteriaMatch } from '../../linter-interface';
+export interface LLMModuleLintCriteriaMatch extends LintCriteriaMatch {
+    type: 'llm';
+}
+export interface LLMModuleMatches {
+    [key: string]: LLMModuleLintCriteriaMatch[];
+}
+export declare const LLM_SDK_PACKAGE = "@atlassian/forge-llms-sdk";
+//# sourceMappingURL=llm-linter-interface.d.ts.map

package/out/lint/linters/llm-module-linter/llm-linter-interface.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"llm-linter-interface.d.ts","sourceRoot":"","sources":["../../../../src/lint/linters/llm-module-linter/llm-linter-interface.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,iBAAiB,EAAE,MAAM,wBAAwB,CAAC;AAE3D,MAAM,WAAW,0BAA2B,SAAQ,iBAAiB;IACnE,IAAI,EAAE,KAAK,CAAC;CACb;AAED,MAAM,WAAW,gBAAgB;IAC/B,CAAC,GAAG,EAAE,MAAM,GAAG,0BAA0B,EAAE,CAAC;CAC7C;AAED,eAAO,MAAM,eAAe,8BAA8B,CAAC"}

package/out/lint/linters/llm-module-linter/llm-linter-interface.js

@@ -0,0 +1,4 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.LLM_SDK_PACKAGE = void 0;
+exports.LLM_SDK_PACKAGE = '@atlassian/forge-llms-sdk';

package/out/lint/linters/llm-module-linter/llm-module-linter.d.ts

@@ -0,0 +1,14 @@
+import { LintFixState, LintLogger, LintResultRule } from '../../linter-interface';
+import BaseLinter from '../../base-linter';
+import { ManifestSchema as Manifest } from '@forge/manifest';
+import { LLMModuleLintCriteriaMatch, LLMModuleMatches } from './llm-linter-interface';
+export declare class LlmModuleLinter extends BaseLinter<LLMModuleLintCriteriaMatch, LLMModuleMatches, LLMModuleLintCriteriaMatch[]> {
+    private manifest;
+    constructor(environment: string, manifest: Manifest, logger: LintLogger);
+    addLintCriteriaMatch(usage: LLMModuleLintCriteriaMatch, filepath: string): void;
+    bootstrap(): Promise<void>;
+    protected setupMatchesMap(filePath: string): void;
+    protected getFixer(): ((errors: LintResultRule[], warnings: LintResultRule[], state: LintFixState) => Promise<LintFixState>) | undefined;
+    applyFixes(_errors: LintResultRule[], warnings: LintResultRule[], state: LintFixState): Promise<LintFixState>;
+}
+//# sourceMappingURL=llm-module-linter.d.ts.map

package/out/lint/linters/llm-module-linter/llm-module-linter.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"llm-module-linter.d.ts","sourceRoot":"","sources":["../../../../src/lint/linters/llm-module-linter/llm-module-linter.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,YAAY,EAAE,UAAU,EAAE,cAAc,EAAE,MAAM,wBAAwB,CAAC;AAClF,OAAO,UAAU,MAAM,mBAAmB,CAAC;AAC3C,OAAO,EAAE,cAAc,IAAI,QAAQ,EAAW,MAAM,iBAAiB,CAAC;AAGtE,OAAO,EAAE,0BAA0B,EAAE,gBAAgB,EAAE,MAAM,wBAAwB,CAAC;AAItF,qBAAa,eAAgB,SAAQ,UAAU,CAC7C,0BAA0B,EAC1B,gBAAgB,EAChB,0BAA0B,EAAE,CAC7B;IAGG,OAAO,CAAC,QAAQ;gBADhB,WAAW,EAAE,MAAM,EACX,QAAQ,EAAE,QAAQ,EAC1B,MAAM,EAAE,UAAU;IAKpB,oBAAoB,CAAC,KAAK,EAAE,0BAA0B,EAAE,QAAQ,EAAE,MAAM,GAAG,IAAI;IAKlE,SAAS,IAAI,OAAO,CAAC,IAAI,CAAC;IAOvC,SAAS,CAAC,eAAe,CAAC,QAAQ,EAAE,MAAM,GAAG,IAAI;IAMjD,SAAS,CAAC,QAAQ,IACd,CAAC,CAAC,MAAM,EAAE,cAAc,EAAE,EAAE,QAAQ,EAAE,cAAc,EAAE,EAAE,KAAK,EAAE,YAAY,KAAK,OAAO,CAAC,YAAY,CAAC,CAAC,GACtG,SAAS;IAIP,UAAU,CAAC,OAAO,EAAE,cAAc,EAAE,EAAE,QAAQ,EAAE,cAAc,EAAE,EAAE,KAAK,EAAE,YAAY,GAAG,OAAO,CAAC,YAAY,CAAC;CAiBpH"}

package/out/lint/linters/llm-module-linter/llm-module-linter.js

@@ -0,0 +1,49 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.LlmModuleLinter = void 0;
+const tslib_1 = require("tslib");
+const base_linter_1 = tslib_1.__importDefault(require("../../base-linter"));
+const llm_node_visitor_1 = require("./llm-node-visitor");
+const llm_verifier_1 = require("./llm-verifier");
+const DEFAULT_LLM_MODULES = [{ key: 'llm', model: ['claude'] }];
+class LlmModuleLinter extends base_linter_1.default {
+    manifest;
+    constructor(environment, manifest, logger) {
+        super(environment, logger);
+        this.manifest = manifest;
+    }
+    addLintCriteriaMatch(usage, filepath) {
+        const criteriaMatches = this.matches.get(filepath);
+        criteriaMatches?.llm.push(usage);
+    }
+    async bootstrap() {
+        this.nodeVisitors = [new llm_node_visitor_1.LlmNodeVisitor()];
+        this.verifiers = {
+            llm: new llm_verifier_1.LlmVerifier(this.environment, this.manifest)
+        };
+    }
+    setupMatchesMap(filePath) {
+        this.matches.set(filePath, {
+            llm: []
+        });
+    }
+    getFixer() {
+        return this.applyFixes;
+    }
+    async applyFixes(_errors, warnings, state) {
+        if (warnings?.length > 0) {
+            const currentModules = (await state.configFile.readConfig())?.modules ?? {};
+            const isLLMModuleMissing = warnings.find((warning) => warning.metadata?.missingLLMModule === 'llm') !== undefined;
+            if (isLLMModuleMissing && !currentModules.llm) {
+                const newModules = {
+                    ...currentModules,
+                    llm: DEFAULT_LLM_MODULES
+                };
+                await state.configFile.writeToConfigFile('modules', newModules);
+                state.warningsFixed += 1;
+            }
+        }
+        return state;
+    }
+}
+exports.LlmModuleLinter = LlmModuleLinter;

package/out/lint/linters/llm-module-linter/llm-node-visitor.d.ts

@@ -0,0 +1,9 @@
+import { NodeVisitor } from '../node-visitor-interface';
+import { LLMModuleLintCriteriaMatch } from './llm-linter-interface';
+import { TSESTree } from '@typescript-eslint/typescript-estree';
+export declare class LlmNodeVisitor implements NodeVisitor<LLMModuleLintCriteriaMatch> {
+    visit(node: TSESTree.Node, _parent: TSESTree.Node | undefined, onMatchCallback: (llmModuleCall: LLMModuleLintCriteriaMatch) => void): void;
+    private isNodeSDKPackageImport;
+    private isImportSpecifier;
+}
+//# sourceMappingURL=llm-node-visitor.d.ts.map

package/out/lint/linters/llm-module-linter/llm-node-visitor.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"llm-node-visitor.d.ts","sourceRoot":"","sources":["../../../../src/lint/linters/llm-module-linter/llm-node-visitor.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,WAAW,EAAE,MAAM,2BAA2B,CAAC;AACxD,OAAO,EAAmB,0BAA0B,EAAE,MAAM,wBAAwB,CAAC;AACrF,OAAO,EAAkB,QAAQ,EAAE,MAAM,sCAAsC,CAAC;AAEhF,qBAAa,cAAe,YAAW,WAAW,CAAC,0BAA0B,CAAC;IACrE,KAAK,CACV,IAAI,EAAE,QAAQ,CAAC,IAAI,EACnB,OAAO,EAAE,QAAQ,CAAC,IAAI,GAAG,SAAS,EAClC,eAAe,EAAE,CAAC,aAAa,EAAE,0BAA0B,KAAK,IAAI;IAgBtE,OAAO,CAAC,sBAAsB;IAI9B,OAAO,CAAC,iBAAiB;CAM1B"}

package/out/lint/linters/llm-module-linter/llm-node-visitor.js

@@ -0,0 +1,29 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.LlmNodeVisitor = void 0;
+const llm_linter_interface_1 = require("./llm-linter-interface");
+const typescript_estree_1 = require("@typescript-eslint/typescript-estree");
+class LlmNodeVisitor {
+    visit(node, _parent, onMatchCallback) {
+        if (this.isNodeSDKPackageImport(node) && 'specifiers' in node) {
+            node.specifiers.forEach((specifier) => {
+                if (this.isImportSpecifier(specifier)) {
+                    if (specifier.loc) {
+                        onMatchCallback({
+                            type: 'llm',
+                            ...specifier.loc.start
+                        });
+                    }
+                }
+            });
+        }
+    }
+    isNodeSDKPackageImport(node) {
+        return node.type === typescript_estree_1.AST_NODE_TYPES.ImportDeclaration && node.source.value === llm_linter_interface_1.LLM_SDK_PACKAGE;
+    }
+    isImportSpecifier(specifier) {
+        return ((specifier.type === typescript_estree_1.AST_NODE_TYPES.ImportSpecifier || specifier.type === typescript_estree_1.AST_NODE_TYPES.ImportDefaultSpecifier) &&
+            specifier.local.type === typescript_estree_1.AST_NODE_TYPES.Identifier);
+    }
+}
+exports.LlmNodeVisitor = LlmNodeVisitor;

package/out/lint/linters/llm-module-linter/llm-verifier.d.ts

@@ -0,0 +1,8 @@
+import { BaseLintIssueVerifier, LintIssueVerifier } from '../verifier-interface';
+import { LintClass, LintResultRule } from '../../linter-interface';
+import { LLMModuleLintCriteriaMatch } from './llm-linter-interface';
+export declare class LlmVerifier extends BaseLintIssueVerifier implements LintIssueVerifier<LLMModuleLintCriteriaMatch[]> {
+    protected getLintClass(): LintClass;
+    process(moduleCalls: LLMModuleLintCriteriaMatch[]): Promise<LintResultRule[]>;
+}
+//# sourceMappingURL=llm-verifier.d.ts.map

package/out/lint/linters/llm-module-linter/llm-verifier.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"llm-verifier.d.ts","sourceRoot":"","sources":["../../../../src/lint/linters/llm-module-linter/llm-verifier.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,qBAAqB,EAAE,iBAAiB,EAAE,MAAM,uBAAuB,CAAC;AACjF,OAAO,EAAE,SAAS,EAAE,cAAc,EAAE,MAAM,wBAAwB,CAAC;AACnE,OAAO,EAAE,0BAA0B,EAAE,MAAM,wBAAwB,CAAC;AAGpE,qBAAa,WAAY,SAAQ,qBAAsB,YAAW,iBAAiB,CAAC,0BAA0B,EAAE,CAAC;IAC/G,SAAS,CAAC,YAAY,IAAI,SAAS;IAItB,OAAO,CAAC,WAAW,EAAE,0BAA0B,EAAE,GAAG,OAAO,CAAC,cAAc,EAAE,CAAC;CAe3F"}

package/out/lint/linters/llm-module-linter/llm-verifier.js

@@ -0,0 +1,26 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.LlmVerifier = void 0;
+const verifier_interface_1 = require("../verifier-interface");
+const linter_interface_1 = require("../../linter-interface");
+const text_1 = require("../../text");
+class LlmVerifier extends verifier_interface_1.BaseLintIssueVerifier {
+    getLintClass() {
+        return linter_interface_1.LintClass.Warning;
+    }
+    async process(moduleCalls) {
+        if (this.manifest.modules && 'llm' in this.manifest.modules) {
+            return [];
+        }
+        return moduleCalls.map((llmModuleCall) => ({
+            class: this.getLintClass(),
+            message: text_1.messages.verifiers.llm.message('llm'),
+            reference: text_1.messages.verifiers.llm.reference,
+            ...llmModuleCall,
+            metadata: {
+                missingLLMModule: 'llm'
+            }
+        }));
+    }
+}
+exports.LlmVerifier = LlmVerifier;

package/out/lint/text/messages.d.ts

@@ -45,6 +45,10 @@ export declare const messages: {
             message: (module: string) => string;
             reference: string;
         };
+        llm: {
+            message: (module: string) => string;
+            reference: string;
+        };
         frameComponentResource: {
             missing: {
                 message: () => string;

package/out/lint/text/messages.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"messages.d.ts","sourceRoot":"","sources":["../../../src/lint/text/messages.ts"],"names":[],"mappings":"AAAA,eAAO,MAAM,QAAQ;;;2BAGA,MAAM;;;;2BAKN,MAAM;2BAER,MAAM;;;;2BAKJ,MAAM;;;;iCAKA,MAAM;;;;iCAKN,MAAM;;;;8BAKT,MAAM,OAAO,MAAM;;;;+BAKlB,MAAM,UAAU,MAAM,QAAQ,MAAM,GAAG,SAAS,SAAS,MAAM;;;;6BAKjE,MAAM;;;;+BAIJ,MAAM,QAAQ,MAAM,SAAS,MAAM;;;;8BAKpC,MAAM;;;;8BAIN,MAAM;;;;;;;;;oCASF,MAAM;;;;;6BAOX,MAAM;;;;CAI5B,CAAC"}
+{"version":3,"file":"messages.d.ts","sourceRoot":"","sources":["../../../src/lint/text/messages.ts"],"names":[],"mappings":"AAAA,eAAO,MAAM,QAAQ;;;2BAGA,MAAM;;;;2BAKN,MAAM;2BAER,MAAM;;;;2BAKJ,MAAM;;;;iCAKA,MAAM;;;;iCAKN,MAAM;;;;8BAKT,MAAM,OAAO,MAAM;;;;+BAKlB,MAAM,UAAU,MAAM,QAAQ,MAAM,GAAG,SAAS,SAAS,MAAM;;;;6BAKjE,MAAM;;;;+BAIJ,MAAM,QAAQ,MAAM,SAAS,MAAM;;;;8BAKpC,MAAM;;;;8BAIN,MAAM;;;;8BAIN,MAAM;;;;;;;;;oCASF,MAAM;;;;;6BAOX,MAAM;;;;CAI5B,CAAC"}

package/out/lint/text/messages.js

@@ -48,6 +48,10 @@ exports.messages = {
             message: (module) => `OS package is used but '${module}' module is not defined in the manifest`,
             reference: 'https://developer.atlassian.com/platform/forge/manifest-reference/#modules'
         },
+        llm: {
+            message: (module) => `LLM package is used but '${module}' module is not defined in the manifest`,
+            reference: 'https://developer.atlassian.com/platform/forge/manifest-reference/#modules'
+        },
         frameComponentResource: {
             missing: {
                 message: () => 'The "resource" property is missing in the Frame component',

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@forge/lint",
-  "version": "5.12.0-next.6",
+  "version": "5.12.0-next.7-experimental-4cf7fd3",
   "description": "Linting for forge apps",
   "main": "out/index.js",
   "license": "SEE LICENSE IN LICENSE.txt",
@@ -11,7 +11,7 @@
   },
   "devDependencies": {
     "@atlassian/xen-test-util": "^4.2.0",
-    "@forge/api": "^6.1.6-next.0",
+    "@forge/api": "^6.1.6-next.0-experimental-4cf7fd3",
     "@types/array.prototype.flatmap": "^1.2.6",
     "@types/cross-spawn": "^6.0.6",
     "@types/eslint": "8.56.12",
@@ -19,10 +19,10 @@
     "eslint-plugin-import": "^2.29.1"
   },
   "dependencies": {
-    "@forge/cli-shared": "8.8.2-next.3",
-    "@forge/csp": "5.3.0-next.1",
+    "@forge/cli-shared": "8.8.2-next.4-experimental-4cf7fd3",
+    "@forge/csp": "5.3.0-next.1-experimental-4cf7fd3",
     "@forge/egress": "2.1.1",
-    "@forge/manifest": "11.0.0-next.2",
+    "@forge/manifest": "11.0.0-next.3-experimental-4cf7fd3",
     "@typescript-eslint/typescript-estree": "^5.62.0",
     "array.prototype.flatmap": "^1.3.3",
     "@atlassian/atlassian-openapi": "^1.0.6",