@forge/lint 3.4.1-next.5 → 3.5.0-next.7

package/CHANGELOG.md

@@ -1,5 +1,18 @@
 # @forge/lint
 
+## 3.5.0-next.7
+
+### Patch Changes
+
+- Updated dependencies [d94f614e]
+  - @forge/cli-shared@3.12.0-next.6
+
+## 3.5.0-next.6
+
+### Minor Changes
+
+- cf0ab7be: Add egress permissions check for Image component URLs
+
 ## 3.4.1-next.5
 
 ### Patch Changes

package/out/lint/linters/dynamic-properties-linter/verifiers/dynamic-properties-icon-verifier.d.ts

@@ -7,7 +7,6 @@ export declare class DynamicPropertiesIconVerifier extends AbstractDynamicProper
     private egressFilteringService;
     constructor(environment: string, manifest: Manifest);
     protected getLintClass(): LintClass;
-    private extractDomain;
     process(iconUrls: DynamicPropertiesIconUrl[]): Promise<LintResultRule[]>;
 }
 //# sourceMappingURL=dynamic-properties-icon-verifier.d.ts.map

package/out/lint/linters/dynamic-properties-linter/verifiers/dynamic-properties-icon-verifier.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"dynamic-properties-icon-verifier.d.ts","sourceRoot":"","sources":["../../../../../src/lint/linters/dynamic-properties-linter/verifiers/dynamic-properties-icon-verifier.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,cAAc,IAAI,QAAQ,EAAE,MAAM,iBAAiB,CAAC;AAGlE,OAAO,EAAE,SAAS,EAAE,cAAc,EAAE,MAAM,2BAA2B,CAAC;AACtE,OAAO,EAAE,iBAAiB,EAAE,MAAM,0BAA0B,CAAC;AAG7D,OAAO,EAAE,wBAAwB,EAAE,MAAM,iCAAiC,CAAC;AAC3E,OAAO,EAAE,iCAAiC,EAAE,MAAM,wCAAwC,CAAC;AAE3F,qBAAa,6BACX,SAAQ,iCACR,YAAW,iBAAiB,CAAC,wBAAwB,EAAE,CAAC;IACxD,OAAO,CAAC,sBAAsB,CAAyB;gBAE3C,WAAW,EAAE,MAAM,EAAE,QAAQ,EAAE,QAAQ;IASnD,SAAS,CAAC,YAAY,IAAI,SAAS;IAInC,OAAO,CAAC,aAAa,CAMnB;IAEW,OAAO,CAAC,QAAQ,EAAE,wBAAwB,EAAE,GAAG,OAAO,CAAC,cAAc,EAAE,CAAC;CAmBtF"}
+{"version":3,"file":"dynamic-properties-icon-verifier.d.ts","sourceRoot":"","sources":["../../../../../src/lint/linters/dynamic-properties-linter/verifiers/dynamic-properties-icon-verifier.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,cAAc,IAAI,QAAQ,EAAE,MAAM,iBAAiB,CAAC;AAGlE,OAAO,EAAE,SAAS,EAAE,cAAc,EAAE,MAAM,2BAA2B,CAAC;AACtE,OAAO,EAAE,iBAAiB,EAAE,MAAM,0BAA0B,CAAC;AAG7D,OAAO,EAAE,wBAAwB,EAAE,MAAM,iCAAiC,CAAC;AAC3E,OAAO,EAAE,iCAAiC,EAAE,MAAM,wCAAwC,CAAC;AAE3F,qBAAa,6BACX,SAAQ,iCACR,YAAW,iBAAiB,CAAC,wBAAwB,EAAE,CAAC;IACxD,OAAO,CAAC,sBAAsB,CAAyB;gBAE3C,WAAW,EAAE,MAAM,EAAE,QAAQ,EAAE,QAAQ;IASnD,SAAS,CAAC,YAAY,IAAI,SAAS;IAItB,OAAO,CAAC,QAAQ,EAAE,wBAAwB,EAAE,GAAG,OAAO,CAAC,cAAc,EAAE,CAAC;CAmBtF"}

package/out/lint/linters/dynamic-properties-linter/verifiers/dynamic-properties-icon-verifier.js

@@ -3,21 +3,13 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.DynamicPropertiesIconVerifier = void 0;
 const egress_1 = require("@forge/egress");
 const linter_interface_1 = require("../../../linter-interface");
+const utils_1 = require("../../utils");
 const text_1 = require("../../../text");
-const url_1 = require("url");
 const abstract_dynamic_properties_verifier_1 = require("./abstract-dynamic-properties-verifier");
 class DynamicPropertiesIconVerifier extends abstract_dynamic_properties_verifier_1.AbstractDynamicPropertiesVerifier {
     constructor(environment, manifest) {
         var _a, _b, _c, _d;
         super(environment, manifest);
-        this.extractDomain = (iconUrl) => {
-            try {
-                return new url_1.URL(iconUrl.url).hostname;
-            }
-            catch (e) {
-                return iconUrl.url;
-            }
-        };
         const allowList = (_d = (_c = (_b = (_a = this.manifest) === null || _a === void 0 ? void 0 : _a.permissions) === null || _b === void 0 ? void 0 : _b.external) === null || _c === void 0 ? void 0 : _c.images) !== null && _d !== void 0 ? _d : [];
         const collectedUrls = allowList.filter((item) => typeof item === 'string');
         this.egressFilteringService = new egress_1.EgressFilteringService(collectedUrls);
@@ -39,7 +31,7 @@ class DynamicPropertiesIconVerifier extends abstract_dynamic_properties_verifier
                 column: iconUrl.column,
                 line: iconUrl.line,
                 metadata: {
-                    missingExternalImagesPermission: this.extractDomain(iconUrl)
+                    missingExternalImagesPermission: (0, utils_1.extractDomain)(iconUrl)
                 }
             }))
         ];

package/out/lint/linters/permission-linter/api-call-interface.d.ts

@@ -4,7 +4,8 @@ export declare enum ApiCallTypes {
     'HOOK' = 1,
     'STORAGE' = 2,
     'EXTERNAL' = 3,
-    'CONTENT_PROPERTY' = 4
+    'CONTENT_PROPERTY' = 4,
+    'IMAGE' = 5
 }
 export interface ProductApiCall extends LintCriteriaMatch {
     type: ApiCallTypes.PRODUCT;
@@ -24,10 +25,14 @@ export interface ExternalApiCall extends LintCriteriaMatch {
     type: ApiCallTypes.EXTERNAL;
     url: string;
 }
+export interface ImageUrl extends LintCriteriaMatch {
+    type: ApiCallTypes.IMAGE;
+    url: string;
+}
 export interface ContentPropertyApiCall extends LintCriteriaMatch {
     type: ApiCallTypes.CONTENT_PROPERTY;
     context: string;
     method: string;
 }
-export declare type ApiCall = ProductApiCall | UIHookApiCall | StorageApiCall | ExternalApiCall | ContentPropertyApiCall;
+export declare type ApiCall = ProductApiCall | UIHookApiCall | StorageApiCall | ExternalApiCall | ImageUrl | ContentPropertyApiCall;
 //# sourceMappingURL=api-call-interface.d.ts.map

package/out/lint/linters/permission-linter/api-call-interface.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"api-call-interface.d.ts","sourceRoot":"","sources":["../../../../src/lint/linters/permission-linter/api-call-interface.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,iBAAiB,EAAE,MAAM,wBAAwB,CAAC;AAE3D,oBAAY,YAAY;IACtB,SAAS,IAAA;IACT,MAAM,IAAA;IACN,SAAS,IAAA;IACT,UAAU,IAAA;IACV,kBAAkB,IAAA;CACnB;AAED,MAAM,WAAW,cAAe,SAAQ,iBAAiB;IACvD,IAAI,EAAE,YAAY,CAAC,OAAO,CAAC;IAC3B,OAAO,EAAE,MAAM,GAAG,YAAY,CAAC;IAC/B,IAAI,EAAE,MAAM,CAAC;IACb,MAAM,EAAE,MAAM,CAAC;IACf,KAAK,CAAC,EAAE,MAAM,CAAC;CAChB;AAED,MAAM,WAAW,aAAc,SAAQ,iBAAiB;IACtD,IAAI,EAAE,YAAY,CAAC,IAAI,CAAC;IACxB,QAAQ,EAAE,MAAM,CAAC;CAClB;AAED,MAAM,WAAW,cAAe,SAAQ,iBAAiB;IACvD,IAAI,EAAE,YAAY,CAAC,OAAO,CAAC;CAC5B;AAED,MAAM,WAAW,eAAgB,SAAQ,iBAAiB;IACxD,IAAI,EAAE,YAAY,CAAC,QAAQ,CAAC;IAC5B,GAAG,EAAE,MAAM,CAAC;CACb;AAED,MAAM,WAAW,sBAAuB,SAAQ,iBAAiB;IAC/D,IAAI,EAAE,YAAY,CAAC,gBAAgB,CAAC;IACpC,OAAO,EAAE,MAAM,CAAC;IAChB,MAAM,EAAE,MAAM,CAAC;CAChB;AAED,oBAAY,OAAO,GAAG,cAAc,GAAG,aAAa,GAAG,cAAc,GAAG,eAAe,GAAG,sBAAsB,CAAC"}
+{"version":3,"file":"api-call-interface.d.ts","sourceRoot":"","sources":["../../../../src/lint/linters/permission-linter/api-call-interface.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,iBAAiB,EAAE,MAAM,wBAAwB,CAAC;AAE3D,oBAAY,YAAY;IACtB,SAAS,IAAA;IACT,MAAM,IAAA;IACN,SAAS,IAAA;IACT,UAAU,IAAA;IACV,kBAAkB,IAAA;IAClB,OAAO,IAAA;CACR;AAED,MAAM,WAAW,cAAe,SAAQ,iBAAiB;IACvD,IAAI,EAAE,YAAY,CAAC,OAAO,CAAC;IAC3B,OAAO,EAAE,MAAM,GAAG,YAAY,CAAC;IAC/B,IAAI,EAAE,MAAM,CAAC;IACb,MAAM,EAAE,MAAM,CAAC;IACf,KAAK,CAAC,EAAE,MAAM,CAAC;CAChB;AAED,MAAM,WAAW,aAAc,SAAQ,iBAAiB;IACtD,IAAI,EAAE,YAAY,CAAC,IAAI,CAAC;IACxB,QAAQ,EAAE,MAAM,CAAC;CAClB;AAED,MAAM,WAAW,cAAe,SAAQ,iBAAiB;IACvD,IAAI,EAAE,YAAY,CAAC,OAAO,CAAC;CAC5B;AAED,MAAM,WAAW,eAAgB,SAAQ,iBAAiB;IACxD,IAAI,EAAE,YAAY,CAAC,QAAQ,CAAC;IAC5B,GAAG,EAAE,MAAM,CAAC;CACb;AAED,MAAM,WAAW,QAAS,SAAQ,iBAAiB;IACjD,IAAI,EAAE,YAAY,CAAC,KAAK,CAAC;IACzB,GAAG,EAAE,MAAM,CAAC;CACb;AAED,MAAM,WAAW,sBAAuB,SAAQ,iBAAiB;IAC/D,IAAI,EAAE,YAAY,CAAC,gBAAgB,CAAC;IACpC,OAAO,EAAE,MAAM,CAAC;IAChB,MAAM,EAAE,MAAM,CAAC;CAChB;AAED,oBAAY,OAAO,GACf,cAAc,GACd,aAAa,GACb,cAAc,GACd,eAAe,GACf,QAAQ,GACR,sBAAsB,CAAC"}

package/out/lint/linters/permission-linter/api-call-interface.js

@@ -8,4 +8,5 @@ var ApiCallTypes;
     ApiCallTypes[ApiCallTypes["STORAGE"] = 2] = "STORAGE";
     ApiCallTypes[ApiCallTypes["EXTERNAL"] = 3] = "EXTERNAL";
     ApiCallTypes[ApiCallTypes["CONTENT_PROPERTY"] = 4] = "CONTENT_PROPERTY";
+    ApiCallTypes[ApiCallTypes["IMAGE"] = 5] = "IMAGE";
 })(ApiCallTypes = exports.ApiCallTypes || (exports.ApiCallTypes = {}));

package/out/lint/linters/permission-linter/permission-linter.d.ts

@@ -1,7 +1,7 @@
 import type { ManifestSchema as Manifest } from '@forge/manifest';
 import BaseLinter from '../../base-linter';
 import { LintFixState, LintLogger, LintResultRule } from '../../linter-interface';
-import { ApiCall, ExternalApiCall, ProductApiCall, StorageApiCall, UIHookApiCall } from './api-call-interface';
+import { ApiCall, ExternalApiCall, ImageUrl, ProductApiCall, StorageApiCall, UIHookApiCall } from './api-call-interface';
 import { PathMethods } from './verifiers';
 interface SwaggerFormat {
     paths: {
@@ -18,6 +18,7 @@ interface PermissionLintCriteriaMatches {
     storage: StorageApiCall[];
     uiHook: UIHookApiCall[];
     external: ExternalApiCall[];
+    image: ImageUrl[];
 }
 export declare class PermissionLinter extends BaseLinter<ApiCall, PermissionLintCriteriaMatches, ApiCall[]> {
     private manifest;

package/out/lint/linters/permission-linter/permission-linter.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"permission-linter.d.ts","sourceRoot":"","sources":["../../../../src/lint/linters/permission-linter/permission-linter.ts"],"names":[],"mappings":"AACA,OAAO,KAAK,EAAE,cAAc,IAAI,QAAQ,EAAe,MAAM,iBAAiB,CAAC;AAE/E,OAAO,UAAU,MAAM,mBAAmB,CAAC;AAC3C,OAAO,EAAE,YAAY,EAAE,UAAU,EAAE,cAAc,EAAE,MAAM,wBAAwB,CAAC;AAClF,OAAO,EACL,OAAO,EAEP,eAAe,EACf,cAAc,EACd,cAAc,EACd,aAAa,EACd,MAAM,sBAAsB,CAAC;AAC9B,OAAO,EAML,WAAW,EAGZ,MAAM,aAAa,CAAC;AAUrB,UAAU,aAAa;IACrB,KAAK,EAAE;QACL,CAAC,IAAI,EAAE,MAAM,GAAG,WAAW,CAAC;KAC7B,CAAC;CACH;AAED,eAAO,MAAM,mBAAmB,eAAe,CAAC;AAKhD,eAAO,MAAM,sBAAsB,WACzB,cAAc,EAAE,YACd,cAAc,EAAE,mBAEtB,mBAAmB,GACnB,gCAAgC,GAChC,+BAA+B,GAC/B,iCAAiC,UAC7B,YAAY,KACnB,IAAI,MAAM,CAkBZ,CAAC;AAEF,eAAO,MAAM,qBAAqB,WACxB,cAAc,EAAE,YACd,cAAc,EAAE,SACnB,YAAY,KAClB,QAAQ,YAAY,CAgEtB,CAAC;AAEF,UAAU,6BAA6B;IACrC,CAAC,GAAG,EAAE,MAAM,GAAG,OAAO,EAAE,CAAC;IACzB,UAAU,EAAE,cAAc,EAAE,CAAC;IAC7B,IAAI,EAAE,cAAc,EAAE,CAAC;IACvB,OAAO,EAAE,cAAc,EAAE,CAAC;IAC1B,MAAM,EAAE,aAAa,EAAE,CAAC;IACxB,QAAQ,EAAE,eAAe,EAAE,CAAC;CAC7B;AAED,qBAAa,gBAAiB,SAAQ,UAAU,CAAC,OAAO,EAAE,6BAA6B,EAAE,OAAO,EAAE,CAAC;IAUhE,OAAO,CAAC,QAAQ;IATjD,MAAM,CAAC,cAAc,SAAgC;IACrD,MAAM,CAAC,aAAa,SAA+B;IACnD,MAAM,CAAC,aAAa,SAA+B;IACnD,MAAM,CAAC,oBAAoB,SAAsC;IAEjE,OAAO,CAAC,IAAI,CAAC,CAA0B;IACvC,OAAO,CAAC,UAAU,CAAC,CAA0B;IAC7C,OAAO,CAAC,KAAK,CAAC,CAAa;gBAEf,WAAW,EAAE,MAAM,EAAU,QAAQ,EAAE,QAAQ,EAAE,MAAM,EAAE,UAAU;IAIlE,SAAS,IAAI,OAAO,CAAC,IAAI,CAAC;IAgEvC,SAAS,CAAC,eAAe,CAAC,QAAQ,EAAE,MAAM,GAAG,IAAI;IAajD,SAAS,CAAC,QAAQ,IACd,CAAC,CAAC,MAAM,EAAE,cAAc,EAAE,EAAE,QAAQ,EAAE,cAAc,EAAE,EAAE,KAAK,EAAE,YAAY,KAAK,OAAO,CAAC,YAAY,CAAC,CAAC,GACtG,SAAS;IAIb,SAAS,CAAC,oBAAoB,CAAC,OAAO,EAAE,OAAO,EAAE,QAAQ,EAAE,MAAM,GAAG,IAAI;IAsB3D,eAAe,CAAC,QAAQ,EAAE,MAAM,EAAE,GAAG,EAAE,MAAM,GAAG,OAAO,CAAC,aAAa,CAAC;IAWtE,mBAAmB,CAAC,GAAG,EAAE,MAAM,GAAG,OAAO,CAAC,aAAa,CAAC;IAKrE,OAAO,CAAC,YAAY;CAarB"}
+{"version":3,"file":"permission-linter.d.ts","sourceRoot":"","sources":["../../../../src/lint/linters/permission-linter/permission-linter.ts"],"names":[],"mappings":"AACA,OAAO,KAAK,EAAE,cAAc,IAAI,QAAQ,EAAe,MAAM,iBAAiB,CAAC;AAE/E,OAAO,UAAU,MAAM,mBAAmB,CAAC;AAC3C,OAAO,EAAE,YAAY,EAAE,UAAU,EAAE,cAAc,EAAE,MAAM,wBAAwB,CAAC;AAClF,OAAO,EACL,OAAO,EAEP,eAAe,EACf,QAAQ,EACR,cAAc,EACd,cAAc,EACd,aAAa,EACd,MAAM,sBAAsB,CAAC;AAC9B,OAAO,EAOL,WAAW,EAGZ,MAAM,aAAa,CAAC;AAWrB,UAAU,aAAa;IACrB,KAAK,EAAE;QACL,CAAC,IAAI,EAAE,MAAM,GAAG,WAAW,CAAC;KAC7B,CAAC;CACH;AAED,eAAO,MAAM,mBAAmB,eAAe,CAAC;AAKhD,eAAO,MAAM,sBAAsB,WACzB,cAAc,EAAE,YACd,cAAc,EAAE,mBAEtB,mBAAmB,GACnB,gCAAgC,GAChC,+BAA+B,GAC/B,iCAAiC,UAC7B,YAAY,KACnB,IAAI,MAAM,CAkBZ,CAAC;AAEF,eAAO,MAAM,qBAAqB,WACxB,cAAc,EAAE,YACd,cAAc,EAAE,SACnB,YAAY,KAClB,QAAQ,YAAY,CAgEtB,CAAC;AAEF,UAAU,6BAA6B;IACrC,CAAC,GAAG,EAAE,MAAM,GAAG,OAAO,EAAE,CAAC;IACzB,UAAU,EAAE,cAAc,EAAE,CAAC;IAC7B,IAAI,EAAE,cAAc,EAAE,CAAC;IACvB,OAAO,EAAE,cAAc,EAAE,CAAC;IAC1B,MAAM,EAAE,aAAa,EAAE,CAAC;IACxB,QAAQ,EAAE,eAAe,EAAE,CAAC;IAC5B,KAAK,EAAE,QAAQ,EAAE,CAAC;CACnB;AAED,qBAAa,gBAAiB,SAAQ,UAAU,CAAC,OAAO,EAAE,6BAA6B,EAAE,OAAO,EAAE,CAAC;IAUhE,OAAO,CAAC,QAAQ;IATjD,MAAM,CAAC,cAAc,SAAgC;IACrD,MAAM,CAAC,aAAa,SAA+B;IACnD,MAAM,CAAC,aAAa,SAA+B;IACnD,MAAM,CAAC,oBAAoB,SAAsC;IAEjE,OAAO,CAAC,IAAI,CAAC,CAA0B;IACvC,OAAO,CAAC,UAAU,CAAC,CAA0B;IAC7C,OAAO,CAAC,KAAK,CAAC,CAAa;gBAEf,WAAW,EAAE,MAAM,EAAU,QAAQ,EAAE,QAAQ,EAAE,MAAM,EAAE,UAAU;IAIlE,SAAS,IAAI,OAAO,CAAC,IAAI,CAAC;IAkEvC,SAAS,CAAC,eAAe,CAAC,QAAQ,EAAE,MAAM,GAAG,IAAI;IAcjD,SAAS,CAAC,QAAQ,IACd,CAAC,CAAC,MAAM,EAAE,cAAc,EAAE,EAAE,QAAQ,EAAE,cAAc,EAAE,EAAE,KAAK,EAAE,YAAY,KAAK,OAAO,CAAC,YAAY,CAAC,CAAC,GACtG,SAAS;IAIb,SAAS,CAAC,oBAAoB,CAAC,OAAO,EAAE,OAAO,EAAE,QAAQ,EAAE,MAAM,GAAG,IAAI;IAyB3D,eAAe,CAAC,QAAQ,EAAE,MAAM,EAAE,GAAG,EAAE,MAAM,GAAG,OAAO,CAAC,aAAa,CAAC;IAWtE,mBAAmB,CAAC,GAAG,EAAE,MAAM,GAAG,OAAO,CAAC,aAAa,CAAC;IAKrE,OAAO,CAAC,YAAY;CAarB"}

package/out/lint/linters/permission-linter/permission-linter.js

@@ -109,6 +109,7 @@ class PermissionLinter extends base_linter_1.default {
             new visitors_1.UIHookNodeVisitor(),
             new visitors_1.StorageAPINodeVisitor(),
             new visitors_1.ExternalApiCallVisitor(),
+            new visitors_1.ImageUrlVisitor(),
             new visitors_1.ContentPropertyVisitor()
         ];
         const humanReadableEnvironment = (0, cli_shared_1.environmentToOption)(this.environment);
@@ -118,6 +119,7 @@ class PermissionLinter extends base_linter_1.default {
             storage: new verifiers_1.StorageAPIVerifier(humanReadableEnvironment, this.manifest),
             uiHook: new verifiers_1.UIHookVerifier(humanReadableEnvironment, this.manifest),
             external: new verifiers_1.ExternalFetchVerifier(humanReadableEnvironment, this.manifest),
+            image: new verifiers_1.ImageUrlVerifier(humanReadableEnvironment, this.manifest),
             contentProperty: new verifiers_1.ContentPropertyVerifier(humanReadableEnvironment, this.manifest)
         };
     }
@@ -130,6 +132,7 @@ class PermissionLinter extends base_linter_1.default {
             uiHook: [],
             storage: [],
             external: [],
+            image: [],
             contentProperty: []
         });
     }
@@ -151,6 +154,9 @@ class PermissionLinter extends base_linter_1.default {
             case api_call_interface_1.ApiCallTypes.EXTERNAL:
                 criteriaMatches.external.push(apiCall);
                 break;
+            case api_call_interface_1.ApiCallTypes.IMAGE:
+                criteriaMatches.image.push(apiCall);
+                break;
             case api_call_interface_1.ApiCallTypes.CONTENT_PROPERTY:
                 criteriaMatches.contentProperty.push(apiCall);
                 break;

package/out/lint/linters/permission-linter/verifiers/external-fetch-verifier.d.ts

@@ -6,7 +6,6 @@ export declare class ExternalFetchVerifier extends BaseLintIssueVerifier impleme
     private egressFilteringService;
     constructor(environment: string, manifest: Manifest);
     protected getLintClass(): LintClass;
-    private extractDomain;
     process(fetchCalls: ExternalApiCall[]): Promise<LintResultRule[]>;
 }
 //# sourceMappingURL=external-fetch-verifier.d.ts.map

package/out/lint/linters/permission-linter/verifiers/external-fetch-verifier.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"external-fetch-verifier.d.ts","sourceRoot":"","sources":["../../../../../src/lint/linters/permission-linter/verifiers/external-fetch-verifier.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,cAAc,IAAI,QAAQ,EAAE,MAAM,iBAAiB,CAAC;AAGlE,OAAO,EAAE,SAAS,EAAE,cAAc,EAAE,MAAM,2BAA2B,CAAC;AACtE,OAAO,EAAE,qBAAqB,EAAE,iBAAiB,EAAE,MAAM,0BAA0B,CAAC;AACpF,OAAO,EAAE,eAAe,EAAE,MAAM,uBAAuB,CAAC;AAIxD,qBAAa,qBAAsB,SAAQ,qBAAsB,YAAW,iBAAiB,CAAC,eAAe,EAAE,CAAC;IAC9G,OAAO,CAAC,sBAAsB,CAAyB;gBAE3C,WAAW,EAAE,MAAM,EAAE,QAAQ,EAAE,QAAQ;IAenD,SAAS,CAAC,YAAY,IAAI,SAAS;IAInC,OAAO,CAAC,aAAa,CAMnB;IAEW,OAAO,CAAC,UAAU,EAAE,eAAe,EAAE,GAAG,OAAO,CAAC,cAAc,EAAE,CAAC;CAc/E"}
+{"version":3,"file":"external-fetch-verifier.d.ts","sourceRoot":"","sources":["../../../../../src/lint/linters/permission-linter/verifiers/external-fetch-verifier.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,cAAc,IAAI,QAAQ,EAAE,MAAM,iBAAiB,CAAC;AAGlE,OAAO,EAAE,SAAS,EAAE,cAAc,EAAE,MAAM,2BAA2B,CAAC;AACtE,OAAO,EAAE,qBAAqB,EAAE,iBAAiB,EAAE,MAAM,0BAA0B,CAAC;AACpF,OAAO,EAAE,eAAe,EAAE,MAAM,uBAAuB,CAAC;AAIxD,qBAAa,qBAAsB,SAAQ,qBAAsB,YAAW,iBAAiB,CAAC,eAAe,EAAE,CAAC;IAC9G,OAAO,CAAC,sBAAsB,CAAyB;gBAE3C,WAAW,EAAE,MAAM,EAAE,QAAQ,EAAE,QAAQ;IAenD,SAAS,CAAC,YAAY,IAAI,SAAS;IAItB,OAAO,CAAC,UAAU,EAAE,eAAe,EAAE,GAAG,OAAO,CAAC,cAAc,EAAE,CAAC;CAc/E"}

package/out/lint/linters/permission-linter/verifiers/external-fetch-verifier.js

@@ -5,19 +5,11 @@ const egress_1 = require("@forge/egress");
 const linter_interface_1 = require("../../../linter-interface");
 const verifier_interface_1 = require("../../verifier-interface");
 const text_1 = require("../../../text");
-const url_1 = require("url");
+const utils_1 = require("../../utils");
 class ExternalFetchVerifier extends verifier_interface_1.BaseLintIssueVerifier {
     constructor(environment, manifest) {
         var _a, _b, _c, _d, _e, _f, _g;
         super(environment, manifest);
-        this.extractDomain = (fetchCall) => {
-            try {
-                return new url_1.URL(fetchCall.url).hostname;
-            }
-            catch (e) {
-                return fetchCall.url;
-            }
-        };
         const allowList = (_e = (_d = (_c = (_b = (_a = this.manifest) === null || _a === void 0 ? void 0 : _a.permissions) === null || _b === void 0 ? void 0 : _b.external) === null || _c === void 0 ? void 0 : _c.fetch) === null || _d === void 0 ? void 0 : _d.backend) !== null && _e !== void 0 ? _e : [];
         const remoteList = (_g = (_f = this.manifest) === null || _f === void 0 ? void 0 : _f.remotes) !== null && _g !== void 0 ? _g : [];
         const collectedUrls = allowList.filter((item) => typeof item === 'string');
@@ -39,7 +31,7 @@ class ExternalFetchVerifier extends verifier_interface_1.BaseLintIssueVerifier {
             column: fetchCall.column,
             line: fetchCall.line,
             metadata: {
-                missingExternalFetchPermission: this.extractDomain(fetchCall)
+                missingExternalFetchPermission: (0, utils_1.extractDomain)(fetchCall)
             }
         }));
     }

package/out/lint/linters/permission-linter/verifiers/image-url-verifier.d.ts

@@ -0,0 +1,11 @@
+import type { ManifestSchema as Manifest } from '@forge/manifest';
+import { LintClass, LintResultRule } from '../../../linter-interface';
+import { BaseLintIssueVerifier, LintIssueVerifier } from '../../verifier-interface';
+import { ImageUrl } from '../api-call-interface';
+export declare class ImageUrlVerifier extends BaseLintIssueVerifier implements LintIssueVerifier<ImageUrl[]> {
+    private egressFilteringService;
+    constructor(environment: string, manifest: Manifest);
+    protected getLintClass(): LintClass;
+    process(imageUrls: ImageUrl[]): Promise<LintResultRule[]>;
+}
+//# sourceMappingURL=image-url-verifier.d.ts.map

package/out/lint/linters/permission-linter/verifiers/image-url-verifier.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"image-url-verifier.d.ts","sourceRoot":"","sources":["../../../../../src/lint/linters/permission-linter/verifiers/image-url-verifier.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,cAAc,IAAI,QAAQ,EAAE,MAAM,iBAAiB,CAAC;AAGlE,OAAO,EAAE,SAAS,EAAE,cAAc,EAAE,MAAM,2BAA2B,CAAC;AACtE,OAAO,EAAE,qBAAqB,EAAE,iBAAiB,EAAE,MAAM,0BAA0B,CAAC;AACpF,OAAO,EAAE,QAAQ,EAAE,MAAM,uBAAuB,CAAC;AAIjD,qBAAa,gBAAiB,SAAQ,qBAAsB,YAAW,iBAAiB,CAAC,QAAQ,EAAE,CAAC;IAClG,OAAO,CAAC,sBAAsB,CAAyB;gBAE3C,WAAW,EAAE,MAAM,EAAE,QAAQ,EAAE,QAAQ;IAUnD,SAAS,CAAC,YAAY,IAAI,SAAS;IAItB,OAAO,CAAC,SAAS,EAAE,QAAQ,EAAE,GAAG,OAAO,CAAC,cAAc,EAAE,CAAC;CAcvE"}

package/out/lint/linters/permission-linter/verifiers/image-url-verifier.js

@@ -0,0 +1,35 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.ImageUrlVerifier = void 0;
+const egress_1 = require("@forge/egress");
+const linter_interface_1 = require("../../../linter-interface");
+const verifier_interface_1 = require("../../verifier-interface");
+const text_1 = require("../../../text");
+const utils_1 = require("../../utils");
+class ImageUrlVerifier extends verifier_interface_1.BaseLintIssueVerifier {
+    constructor(environment, manifest) {
+        var _a, _b, _c, _d;
+        super(environment, manifest);
+        const allowList = (_d = (_c = (_b = (_a = this.manifest) === null || _a === void 0 ? void 0 : _a.permissions) === null || _b === void 0 ? void 0 : _b.external) === null || _c === void 0 ? void 0 : _c.images) !== null && _d !== void 0 ? _d : [];
+        const collectedUrls = allowList.filter((item) => typeof item === 'string');
+        this.egressFilteringService = new egress_1.EgressFilteringService(collectedUrls);
+    }
+    getLintClass() {
+        return linter_interface_1.LintClass.Error;
+    }
+    async process(imageUrls) {
+        return imageUrls
+            .filter(({ url }) => !this.egressFilteringService.isValidUrl(url))
+            .map((imageUrl) => ({
+            class: this.getLintClass(),
+            message: text_1.messages.verifiers.imageUrl.message(imageUrl.url),
+            reference: text_1.messages.verifiers.imageUrl.reference,
+            column: imageUrl.column,
+            line: imageUrl.line,
+            metadata: {
+                missingExternalImagesPermission: (0, utils_1.extractDomain)(imageUrl)
+            }
+        }));
+    }
+}
+exports.ImageUrlVerifier = ImageUrlVerifier;

package/out/lint/linters/permission-linter/verifiers/index.d.ts

@@ -3,4 +3,5 @@ export * from './storage-api-verifier';
 export * from './ui-hook-verifier';
 export * from './external-fetch-verifier';
 export * from './content-property-verifier';
+export * from './image-url-verifier';
 //# sourceMappingURL=index.d.ts.map

package/out/lint/linters/permission-linter/verifiers/index.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"index.d.ts","sourceRoot":"","sources":["../../../../../src/lint/linters/permission-linter/verifiers/index.ts"],"names":[],"mappings":"AAAA,cAAc,oBAAoB,CAAC;AACnC,cAAc,wBAAwB,CAAC;AACvC,cAAc,oBAAoB,CAAC;AACnC,cAAc,2BAA2B,CAAC;AAC1C,cAAc,6BAA6B,CAAC"}
+{"version":3,"file":"index.d.ts","sourceRoot":"","sources":["../../../../../src/lint/linters/permission-linter/verifiers/index.ts"],"names":[],"mappings":"AAAA,cAAc,oBAAoB,CAAC;AACnC,cAAc,wBAAwB,CAAC;AACvC,cAAc,oBAAoB,CAAC;AACnC,cAAc,2BAA2B,CAAC;AAC1C,cAAc,6BAA6B,CAAC;AAC5C,cAAc,sBAAsB,CAAC"}

package/out/lint/linters/permission-linter/verifiers/index.js

@@ -6,3 +6,4 @@ tslib_1.__exportStar(require("./storage-api-verifier"), exports);
 tslib_1.__exportStar(require("./ui-hook-verifier"), exports);
 tslib_1.__exportStar(require("./external-fetch-verifier"), exports);
 tslib_1.__exportStar(require("./content-property-verifier"), exports);
+tslib_1.__exportStar(require("./image-url-verifier"), exports);

package/out/lint/linters/permission-linter/visitors/image-url-visitor.d.ts

@@ -0,0 +1,11 @@
+import { TSESTree } from '@typescript-eslint/typescript-estree';
+import { NodeVisitor } from '../../node-visitor-interface';
+import { ApiCall } from '../api-call-interface';
+export declare class ImageUrlVisitor implements NodeVisitor<ApiCall> {
+    static ABSOLUTE_URL_REGEX: RegExp;
+    visit(node: TSESTree.Node, _parent: TSESTree.Node | undefined, callback: (apiCall: ApiCall) => void): void;
+    private getImageUrlNode;
+    private isBundledUri;
+    private isAbsoluteUrl;
+}
+//# sourceMappingURL=image-url-visitor.d.ts.map

package/out/lint/linters/permission-linter/visitors/image-url-visitor.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"image-url-visitor.d.ts","sourceRoot":"","sources":["../../../../../src/lint/linters/permission-linter/visitors/image-url-visitor.ts"],"names":[],"mappings":"AAAA,OAAO,EAAkB,QAAQ,EAAE,MAAM,sCAAsC,CAAC;AAEhF,OAAO,EAAE,WAAW,EAAE,MAAM,8BAA8B,CAAC;AAC3D,OAAO,EAAE,OAAO,EAA0B,MAAM,uBAAuB,CAAC;AAExE,qBAAa,eAAgB,YAAW,WAAW,CAAC,OAAO,CAAC;IAC1D,MAAM,CAAC,kBAAkB,SAAyB;IAE3C,KAAK,CAAC,IAAI,EAAE,QAAQ,CAAC,IAAI,EAAE,OAAO,EAAE,QAAQ,CAAC,IAAI,GAAG,SAAS,EAAE,QAAQ,EAAE,CAAC,OAAO,EAAE,OAAO,KAAK,IAAI,GAAG,IAAI;IAgCjH,OAAO,CAAC,eAAe;IAoBvB,OAAO,CAAC,YAAY;IAIpB,OAAO,CAAC,aAAa;CAGtB"}

package/out/lint/linters/permission-linter/visitors/image-url-visitor.js

@@ -0,0 +1,57 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.ImageUrlVisitor = void 0;
+const typescript_estree_1 = require("@typescript-eslint/typescript-estree");
+const api_call_interface_1 = require("../api-call-interface");
+class ImageUrlVisitor {
+    visit(node, _parent, callback) {
+        const imageUrlNode = this.getImageUrlNode(node);
+        if (!imageUrlNode) {
+            return undefined;
+        }
+        if ((imageUrlNode === null || imageUrlNode === void 0 ? void 0 : imageUrlNode.type) === typescript_estree_1.AST_NODE_TYPES.JSXAttribute) {
+            const imageUrlAttribute = imageUrlNode.value;
+            if (imageUrlAttribute &&
+                imageUrlAttribute.type === typescript_estree_1.AST_NODE_TYPES.Literal &&
+                typeof imageUrlAttribute.value === 'string') {
+                if (imageUrlAttribute.value.trim() !== '' &&
+                    !this.isBundledUri(imageUrlAttribute.value) &&
+                    this.isAbsoluteUrl(imageUrlAttribute.value)) {
+                    const imageUrl = {
+                        type: api_call_interface_1.ApiCallTypes.IMAGE,
+                        url: imageUrlAttribute.value,
+                        line: imageUrlAttribute.loc.start.line,
+                        column: imageUrlAttribute.loc.start.column
+                    };
+                    callback(imageUrl);
+                }
+            }
+        }
+    }
+    getImageUrlNode(node) {
+        if (node.type !== typescript_estree_1.AST_NODE_TYPES.JSXOpeningElement) {
+            return undefined;
+        }
+        const { name, attributes } = node;
+        if (name.type === typescript_estree_1.AST_NODE_TYPES.JSXIdentifier && name.name === 'Image') {
+            return attributes.find((attribute) => {
+                if (attribute.type !== typescript_estree_1.AST_NODE_TYPES.JSXAttribute) {
+                    return false;
+                }
+                if (attribute.name.type === typescript_estree_1.AST_NODE_TYPES.JSXIdentifier && attribute.name.name === 'src') {
+                    return true;
+                }
+                return false;
+            });
+        }
+        return undefined;
+    }
+    isBundledUri(imageUri) {
+        return imageUri.startsWith('resource:') || imageUri.startsWith('data:image');
+    }
+    isAbsoluteUrl(url) {
+        return ImageUrlVisitor.ABSOLUTE_URL_REGEX.test(url);
+    }
+}
+exports.ImageUrlVisitor = ImageUrlVisitor;
+ImageUrlVisitor.ABSOLUTE_URL_REGEX = /^(?:[a-z+]+:)?\/\//i;

package/out/lint/linters/permission-linter/visitors/index.d.ts

@@ -3,4 +3,5 @@ export * from './storage-api-node-visitor';
 export * from './ui-hook-node-visitor';
 export * from './external-fetch-call-visitor';
 export * from './content-property-visitor';
+export * from './image-url-visitor';
 //# sourceMappingURL=index.d.ts.map

package/out/lint/linters/permission-linter/visitors/index.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"index.d.ts","sourceRoot":"","sources":["../../../../../src/lint/linters/permission-linter/visitors/index.ts"],"names":[],"mappings":"AAAA,cAAc,wBAAwB,CAAC;AACvC,cAAc,4BAA4B,CAAC;AAC3C,cAAc,wBAAwB,CAAC;AACvC,cAAc,+BAA+B,CAAC;AAC9C,cAAc,4BAA4B,CAAC"}
+{"version":3,"file":"index.d.ts","sourceRoot":"","sources":["../../../../../src/lint/linters/permission-linter/visitors/index.ts"],"names":[],"mappings":"AAAA,cAAc,wBAAwB,CAAC;AACvC,cAAc,4BAA4B,CAAC;AAC3C,cAAc,wBAAwB,CAAC;AACvC,cAAc,+BAA+B,CAAC;AAC9C,cAAc,4BAA4B,CAAC;AAC3C,cAAc,qBAAqB,CAAC"}

package/out/lint/linters/permission-linter/visitors/index.js

@@ -6,3 +6,4 @@ tslib_1.__exportStar(require("./storage-api-node-visitor"), exports);
 tslib_1.__exportStar(require("./ui-hook-node-visitor"), exports);
 tslib_1.__exportStar(require("./external-fetch-call-visitor"), exports);
 tslib_1.__exportStar(require("./content-property-visitor"), exports);
+tslib_1.__exportStar(require("./image-url-visitor"), exports);

package/out/lint/linters/utils.d.ts

@@ -0,0 +1,4 @@
+export declare const extractDomain: (urlAstNode: {
+    url: string;
+}) => string;
+//# sourceMappingURL=utils.d.ts.map

package/out/lint/linters/utils.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"utils.d.ts","sourceRoot":"","sources":["../../../src/lint/linters/utils.ts"],"names":[],"mappings":"AAAA,eAAO,MAAM,aAAa,eAAgB;IAAE,GAAG,EAAE,MAAM,CAAA;CAAE,WAMxD,CAAC"}

package/out/lint/linters/utils.js

@@ -0,0 +1,12 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.extractDomain = void 0;
+const extractDomain = (urlAstNode) => {
+    try {
+        return new URL(urlAstNode.url).hostname;
+    }
+    catch (e) {
+        return urlAstNode.url;
+    }
+};
+exports.extractDomain = extractDomain;

package/out/lint/text/messages.d.ts

@@ -13,6 +13,10 @@ export declare const messages: {
             warning: () => string;
             reference: string;
         };
+        imageUrl: {
+            message: (url: string) => string;
+            reference: string;
+        };
         handler: {
             message: (method: string, key: string) => string;
             reference: string;

package/out/lint/text/messages.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"messages.d.ts","sourceRoot":"","sources":["../../../src/lint/text/messages.ts"],"names":[],"mappings":"AAAA,eAAO,MAAM,QAAQ;;;+BAGI,MAAM,UAAU,MAAM,SAAS,MAAM,KAAG,MAAM;;;;2BAKlD,MAAM;;;;2BAIN,MAAM;2BAER,MAAM;;;;8BAKD,MAAM,OAAO,MAAM;;;;+BAKlB,MAAM,UAAU,MAAM,QAAQ,MAAM,GAAG,SAAS,SAAS,MAAM;;;;6BAKjE,MAAM;;;;+BAIJ,MAAM,QAAQ,MAAM,SAAS,MAAM;;;;CAK3D,CAAC"}
+{"version":3,"file":"messages.d.ts","sourceRoot":"","sources":["../../../src/lint/text/messages.ts"],"names":[],"mappings":"AAAA,eAAO,MAAM,QAAQ;;;+BAGI,MAAM,UAAU,MAAM,SAAS,MAAM,KAAG,MAAM;;;;2BAKlD,MAAM;;;;2BAIN,MAAM;2BAER,MAAM;;;;2BAKJ,MAAM;;;;8BAKH,MAAM,OAAO,MAAM;;;;+BAKlB,MAAM,UAAU,MAAM,QAAQ,MAAM,GAAG,SAAS,SAAS,MAAM;;;;6BAKjE,MAAM;;;;+BAIJ,MAAM,QAAQ,MAAM,SAAS,MAAM;;;;CAK3D,CAAC"}

package/out/lint/text/messages.js

@@ -16,6 +16,10 @@ exports.messages = {
             warning: () => `When using dynamic content properties along with icons, make sure to add the icon URL into the external images permissions of your app manifest. Otherwise, the icon will not be rendered.`,
             reference: 'egress-permission-required'
         },
+        imageUrl: {
+            message: (url) => `The domain ${url} is not included in the external images permissions of your app manifest`,
+            reference: 'egress-permission-required'
+        },
         handler: {
             message: (method, key) => `Cannot find exported function '${method}', which is required by module '${key}' handler defined in the manifest`,
             reference: 'valid-module-required'

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@forge/lint",
-  "version": "3.4.1-next.5",
+  "version": "3.5.0-next.7",
   "description": "Linting for forge apps",
   "main": "out/index.js",
   "license": "UNLICENSED",
@@ -17,7 +17,7 @@
     "@types/node-fetch": "^2.5.7"
   },
   "dependencies": {
-    "@forge/cli-shared": "3.12.0-next.5",
+    "@forge/cli-shared": "3.12.0-next.6",
     "@forge/egress": "1.2.1",
     "@forge/manifest": "4.13.0-next.3",
     "@typescript-eslint/typescript-estree": "^5.40.0",