@forge/lint 3.2.22-next.4 → 3.3.0-next.5

package/CHANGELOG.md

@@ -1,10 +1,22 @@
 # @forge/lint
 
-## 3.2.22-next.4
+## 3.3.0-next.5
 
 ### Patch Changes
 
-- Updated dependencies [9c3f9e4]
+- 2da63a57: Bumping dependencies via Renovate:
+
+  - atlassian-openapi
+
+## 3.3.0-next.4
+
+### Minor Changes
+
+- d50d90b8: Add ability to detect missing image permissions when using Confluence contentByLineItem modules with dynamic properties
+
+### Patch Changes
+
+- Updated dependencies [9c3f9e47]
   - @forge/manifest@4.10.0-next.2
   - @forge/cli-shared@3.11.0-next.4
 

package/out/lint/linters/permission-linter/api-call-interface.d.ts

@@ -4,7 +4,8 @@ export declare enum ApiCallTypes {
     'HOOK' = 1,
     'STORAGE' = 2,
     'EXTERNAL' = 3,
-    'CONTENT_PROPERTY' = 4
+    'CONTENT_PROPERTY' = 4,
+    'DYNAMIC_PROPERTIES_ICON' = 5
 }
 export interface ProductApiCall extends LintCriteriaMatch {
     type: ApiCallTypes.PRODUCT;
@@ -24,10 +25,14 @@ export interface ExternalApiCall extends LintCriteriaMatch {
     type: ApiCallTypes.EXTERNAL;
     url: string;
 }
+export interface DynamicPropertiesIconUrl extends LintCriteriaMatch {
+    type: ApiCallTypes.DYNAMIC_PROPERTIES_ICON;
+    url: string;
+}
 export interface ContentPropertyApiCall extends LintCriteriaMatch {
     type: ApiCallTypes.CONTENT_PROPERTY;
     context: string;
     method: string;
 }
-export declare type ApiCall = ProductApiCall | UIHookApiCall | StorageApiCall | ExternalApiCall | ContentPropertyApiCall;
+export declare type ApiCall = ProductApiCall | UIHookApiCall | StorageApiCall | ExternalApiCall | ContentPropertyApiCall | DynamicPropertiesIconUrl;
 //# sourceMappingURL=api-call-interface.d.ts.map

package/out/lint/linters/permission-linter/api-call-interface.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"api-call-interface.d.ts","sourceRoot":"","sources":["../../../../src/lint/linters/permission-linter/api-call-interface.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,iBAAiB,EAAE,MAAM,wBAAwB,CAAC;AAE3D,oBAAY,YAAY;IACtB,SAAS,IAAA;IACT,MAAM,IAAA;IACN,SAAS,IAAA;IACT,UAAU,IAAA;IACV,kBAAkB,IAAA;CACnB;AAED,MAAM,WAAW,cAAe,SAAQ,iBAAiB;IACvD,IAAI,EAAE,YAAY,CAAC,OAAO,CAAC;IAC3B,OAAO,EAAE,MAAM,GAAG,YAAY,CAAC;IAC/B,IAAI,EAAE,MAAM,CAAC;IACb,MAAM,EAAE,MAAM,CAAC;IACf,KAAK,CAAC,EAAE,MAAM,CAAC;CAChB;AAED,MAAM,WAAW,aAAc,SAAQ,iBAAiB;IACtD,IAAI,EAAE,YAAY,CAAC,IAAI,CAAC;IACxB,QAAQ,EAAE,MAAM,CAAC;CAClB;AAED,MAAM,WAAW,cAAe,SAAQ,iBAAiB;IACvD,IAAI,EAAE,YAAY,CAAC,OAAO,CAAC;CAC5B;AAED,MAAM,WAAW,eAAgB,SAAQ,iBAAiB;IACxD,IAAI,EAAE,YAAY,CAAC,QAAQ,CAAC;IAC5B,GAAG,EAAE,MAAM,CAAC;CACb;AAED,MAAM,WAAW,sBAAuB,SAAQ,iBAAiB;IAC/D,IAAI,EAAE,YAAY,CAAC,gBAAgB,CAAC;IACpC,OAAO,EAAE,MAAM,CAAC;IAChB,MAAM,EAAE,MAAM,CAAC;CAChB;AAED,oBAAY,OAAO,GAAG,cAAc,GAAG,aAAa,GAAG,cAAc,GAAG,eAAe,GAAG,sBAAsB,CAAC"}
+{"version":3,"file":"api-call-interface.d.ts","sourceRoot":"","sources":["../../../../src/lint/linters/permission-linter/api-call-interface.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,iBAAiB,EAAE,MAAM,wBAAwB,CAAC;AAE3D,oBAAY,YAAY;IACtB,SAAS,IAAA;IACT,MAAM,IAAA;IACN,SAAS,IAAA;IACT,UAAU,IAAA;IACV,kBAAkB,IAAA;IAClB,yBAAyB,IAAA;CAC1B;AAED,MAAM,WAAW,cAAe,SAAQ,iBAAiB;IACvD,IAAI,EAAE,YAAY,CAAC,OAAO,CAAC;IAC3B,OAAO,EAAE,MAAM,GAAG,YAAY,CAAC;IAC/B,IAAI,EAAE,MAAM,CAAC;IACb,MAAM,EAAE,MAAM,CAAC;IACf,KAAK,CAAC,EAAE,MAAM,CAAC;CAChB;AAED,MAAM,WAAW,aAAc,SAAQ,iBAAiB;IACtD,IAAI,EAAE,YAAY,CAAC,IAAI,CAAC;IACxB,QAAQ,EAAE,MAAM,CAAC;CAClB;AAED,MAAM,WAAW,cAAe,SAAQ,iBAAiB;IACvD,IAAI,EAAE,YAAY,CAAC,OAAO,CAAC;CAC5B;AAED,MAAM,WAAW,eAAgB,SAAQ,iBAAiB;IACxD,IAAI,EAAE,YAAY,CAAC,QAAQ,CAAC;IAC5B,GAAG,EAAE,MAAM,CAAC;CACb;AAED,MAAM,WAAW,wBAAyB,SAAQ,iBAAiB;IACjE,IAAI,EAAE,YAAY,CAAC,uBAAuB,CAAC;IAC3C,GAAG,EAAE,MAAM,CAAC;CACb;AAED,MAAM,WAAW,sBAAuB,SAAQ,iBAAiB;IAC/D,IAAI,EAAE,YAAY,CAAC,gBAAgB,CAAC;IACpC,OAAO,EAAE,MAAM,CAAC;IAChB,MAAM,EAAE,MAAM,CAAC;CAChB;AAED,oBAAY,OAAO,GACf,cAAc,GACd,aAAa,GACb,cAAc,GACd,eAAe,GACf,sBAAsB,GACtB,wBAAwB,CAAC"}

package/out/lint/linters/permission-linter/api-call-interface.js

@@ -8,4 +8,5 @@ var ApiCallTypes;
     ApiCallTypes[ApiCallTypes["STORAGE"] = 2] = "STORAGE";
     ApiCallTypes[ApiCallTypes["EXTERNAL"] = 3] = "EXTERNAL";
     ApiCallTypes[ApiCallTypes["CONTENT_PROPERTY"] = 4] = "CONTENT_PROPERTY";
+    ApiCallTypes[ApiCallTypes["DYNAMIC_PROPERTIES_ICON"] = 5] = "DYNAMIC_PROPERTIES_ICON";
 })(ApiCallTypes = exports.ApiCallTypes || (exports.ApiCallTypes = {}));

package/out/lint/linters/permission-linter/permission-linter.d.ts

@@ -1,7 +1,7 @@
 import type { ManifestSchema as Manifest } from '@forge/manifest';
 import BaseLinter from '../../base-linter';
 import { LintFixState, LintLogger, LintResultRule } from '../../linter-interface';
-import { ApiCall, ExternalApiCall, ProductApiCall, StorageApiCall, UIHookApiCall } from './api-call-interface';
+import { ApiCall, DynamicPropertiesIconUrl, ExternalApiCall, ProductApiCall, StorageApiCall, UIHookApiCall } from './api-call-interface';
 import { PathMethods } from './verifiers';
 interface SwaggerFormat {
     paths: {
@@ -9,7 +9,7 @@ interface SwaggerFormat {
     };
 }
 export declare const NON_FWD_SLASH_REGEX = "[^\\/\\s]*";
-export declare const findMissingPermissions: (errors: LintResultRule[], warnings: LintResultRule[], permissionsType: 'missingPermission' | 'missingExternalFetchPermission' | 'missingContentStylePermission', state?: LintFixState) => Set<string>;
+export declare const findMissingPermissions: (errors: LintResultRule[], warnings: LintResultRule[], permissionsType: 'missingPermission' | 'missingExternalFetchPermission' | 'missingContentStylePermission' | 'missingExternalImagesPermission', state?: LintFixState) => Set<string>;
 export declare const fixMissingPermissions: (errors: LintResultRule[], warnings: LintResultRule[], state: LintFixState) => Promise<LintFixState>;
 interface PermissionLintCriteriaMatches {
     [key: string]: ApiCall[];
@@ -18,6 +18,7 @@ interface PermissionLintCriteriaMatches {
     storage: StorageApiCall[];
     uiHook: UIHookApiCall[];
     external: ExternalApiCall[];
+    dynamicPropertiesIcon: DynamicPropertiesIconUrl[];
 }
 export declare class PermissionLinter extends BaseLinter<ApiCall, PermissionLintCriteriaMatches, ApiCall[]> {
     private manifest;

package/out/lint/linters/permission-linter/permission-linter.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"permission-linter.d.ts","sourceRoot":"","sources":["../../../../src/lint/linters/permission-linter/permission-linter.ts"],"names":[],"mappings":"AACA,OAAO,KAAK,EAAE,cAAc,IAAI,QAAQ,EAAe,MAAM,iBAAiB,CAAC;AAE/E,OAAO,UAAU,MAAM,mBAAmB,CAAC;AAC3C,OAAO,EAAE,YAAY,EAAE,UAAU,EAAE,cAAc,EAAE,MAAM,wBAAwB,CAAC;AAClF,OAAO,EACL,OAAO,EAEP,eAAe,EACf,cAAc,EACd,cAAc,EACd,aAAa,EACd,MAAM,sBAAsB,CAAC;AAC9B,OAAO,EAML,WAAW,EAGZ,MAAM,aAAa,CAAC;AAUrB,UAAU,aAAa;IACrB,KAAK,EAAE;QACL,CAAC,IAAI,EAAE,MAAM,GAAG,WAAW,CAAC;KAC7B,CAAC;CACH;AAED,eAAO,MAAM,mBAAmB,eAAe,CAAC;AAKhD,eAAO,MAAM,sBAAsB,WACzB,cAAc,EAAE,YACd,cAAc,EAAE,mBACT,mBAAmB,GAAG,gCAAgC,GAAG,+BAA+B,UACjG,YAAY,KACnB,IAAI,MAAM,CAkBZ,CAAC;AAEF,eAAO,MAAM,qBAAqB,WACxB,cAAc,EAAE,YACd,cAAc,EAAE,SACnB,YAAY,KAClB,QAAQ,YAAY,CAsEtB,CAAC;AAEF,UAAU,6BAA6B;IACrC,CAAC,GAAG,EAAE,MAAM,GAAG,OAAO,EAAE,CAAC;IACzB,UAAU,EAAE,cAAc,EAAE,CAAC;IAC7B,IAAI,EAAE,cAAc,EAAE,CAAC;IACvB,OAAO,EAAE,cAAc,EAAE,CAAC;IAC1B,MAAM,EAAE,aAAa,EAAE,CAAC;IACxB,QAAQ,EAAE,eAAe,EAAE,CAAC;CAC7B;AAED,qBAAa,gBAAiB,SAAQ,UAAU,CAAC,OAAO,EAAE,6BAA6B,EAAE,OAAO,EAAE,CAAC;IAUhE,OAAO,CAAC,QAAQ;IATjD,MAAM,CAAC,cAAc,SAAgC;IACrD,MAAM,CAAC,aAAa,SAA+B;IACnD,MAAM,CAAC,aAAa,SAA+B;IACnD,MAAM,CAAC,oBAAoB,SAAsC;IAEjE,OAAO,CAAC,IAAI,CAAC,CAA0B;IACvC,OAAO,CAAC,UAAU,CAAC,CAA0B;IAC7C,OAAO,CAAC,KAAK,CAAC,CAAa;gBAEf,WAAW,EAAE,MAAM,EAAU,QAAQ,EAAE,QAAQ,EAAE,MAAM,EAAE,UAAU;IAIlE,SAAS,IAAI,OAAO,CAAC,IAAI,CAAC;IAgEvC,SAAS,CAAC,eAAe,CAAC,QAAQ,EAAE,MAAM,GAAG,IAAI;IAajD,SAAS,CAAC,QAAQ,IACd,CAAC,CAAC,MAAM,EAAE,cAAc,EAAE,EAAE,QAAQ,EAAE,cAAc,EAAE,EAAE,KAAK,EAAE,YAAY,KAAK,OAAO,CAAC,YAAY,CAAC,CAAC,GACtG,SAAS;IAIb,SAAS,CAAC,oBAAoB,CAAC,OAAO,EAAE,OAAO,EAAE,QAAQ,EAAE,MAAM,GAAG,IAAI;IAsB3D,eAAe,CAAC,QAAQ,EAAE,MAAM,EAAE,GAAG,EAAE,MAAM,GAAG,OAAO,CAAC,aAAa,CAAC;IAWtE,mBAAmB,CAAC,GAAG,EAAE,MAAM,GAAG,OAAO,CAAC,aAAa,CAAC;IAKrE,OAAO,CAAC,YAAY;CAarB"}
+{"version":3,"file":"permission-linter.d.ts","sourceRoot":"","sources":["../../../../src/lint/linters/permission-linter/permission-linter.ts"],"names":[],"mappings":"AACA,OAAO,KAAK,EAAE,cAAc,IAAI,QAAQ,EAAe,MAAM,iBAAiB,CAAC;AAE/E,OAAO,UAAU,MAAM,mBAAmB,CAAC;AAC3C,OAAO,EAAE,YAAY,EAAE,UAAU,EAAE,cAAc,EAAE,MAAM,wBAAwB,CAAC;AAClF,OAAO,EACL,OAAO,EAEP,wBAAwB,EACxB,eAAe,EACf,cAAc,EACd,cAAc,EACd,aAAa,EACd,MAAM,sBAAsB,CAAC;AAC9B,OAAO,EAML,WAAW,EAGZ,MAAM,aAAa,CAAC;AAYrB,UAAU,aAAa;IACrB,KAAK,EAAE;QACL,CAAC,IAAI,EAAE,MAAM,GAAG,WAAW,CAAC;KAC7B,CAAC;CACH;AAED,eAAO,MAAM,mBAAmB,eAAe,CAAC;AAKhD,eAAO,MAAM,sBAAsB,WACzB,cAAc,EAAE,YACd,cAAc,EAAE,mBAEtB,mBAAmB,GACnB,gCAAgC,GAChC,+BAA+B,GAC/B,iCAAiC,UAC7B,YAAY,KACnB,IAAI,MAAM,CAkBZ,CAAC;AAEF,eAAO,MAAM,qBAAqB,WACxB,cAAc,EAAE,YACd,cAAc,EAAE,SACnB,YAAY,KAClB,QAAQ,YAAY,CAgEtB,CAAC;AAEF,UAAU,6BAA6B;IACrC,CAAC,GAAG,EAAE,MAAM,GAAG,OAAO,EAAE,CAAC;IACzB,UAAU,EAAE,cAAc,EAAE,CAAC;IAC7B,IAAI,EAAE,cAAc,EAAE,CAAC;IACvB,OAAO,EAAE,cAAc,EAAE,CAAC;IAC1B,MAAM,EAAE,aAAa,EAAE,CAAC;IACxB,QAAQ,EAAE,eAAe,EAAE,CAAC;IAC5B,qBAAqB,EAAE,wBAAwB,EAAE,CAAC;CACnD;AAED,qBAAa,gBAAiB,SAAQ,UAAU,CAAC,OAAO,EAAE,6BAA6B,EAAE,OAAO,EAAE,CAAC;IAUhE,OAAO,CAAC,QAAQ;IATjD,MAAM,CAAC,cAAc,SAAgC;IACrD,MAAM,CAAC,aAAa,SAA+B;IACnD,MAAM,CAAC,aAAa,SAA+B;IACnD,MAAM,CAAC,oBAAoB,SAAsC;IAEjE,OAAO,CAAC,IAAI,CAAC,CAA0B;IACvC,OAAO,CAAC,UAAU,CAAC,CAA0B;IAC7C,OAAO,CAAC,KAAK,CAAC,CAAa;gBAEf,WAAW,EAAE,MAAM,EAAU,QAAQ,EAAE,QAAQ,EAAE,MAAM,EAAE,UAAU;IAIlE,SAAS,IAAI,OAAO,CAAC,IAAI,CAAC;IAkEvC,SAAS,CAAC,eAAe,CAAC,QAAQ,EAAE,MAAM,GAAG,IAAI;IAcjD,SAAS,CAAC,QAAQ,IACd,CAAC,CAAC,MAAM,EAAE,cAAc,EAAE,EAAE,QAAQ,EAAE,cAAc,EAAE,EAAE,KAAK,EAAE,YAAY,KAAK,OAAO,CAAC,YAAY,CAAC,CAAC,GACtG,SAAS;IAIb,SAAS,CAAC,oBAAoB,CAAC,OAAO,EAAE,OAAO,EAAE,QAAQ,EAAE,MAAM,GAAG,IAAI;IAyB3D,eAAe,CAAC,QAAQ,EAAE,MAAM,EAAE,GAAG,EAAE,MAAM,GAAG,OAAO,CAAC,aAAa,CAAC;IAWtE,mBAAmB,CAAC,GAAG,EAAE,MAAM,GAAG,OAAO,CAAC,aAAa,CAAC;IAKrE,OAAO,CAAC,YAAY;CAarB"}

package/out/lint/linters/permission-linter/permission-linter.js

@@ -9,6 +9,8 @@ const api_call_interface_1 = require("./api-call-interface");
 const verifiers_1 = require("./verifiers");
 const visitors_1 = require("./visitors");
 const fs_1 = tslib_1.__importDefault(require("fs"));
+const dynamic_properties_icon_verifier_1 = require("./verifiers/dynamic-properties-icon-verifier");
+const dynamic_properties_icon_visitor_1 = require("./visitors/dynamic-properties-icon-visitor");
 exports.NON_FWD_SLASH_REGEX = '[^\\/\\s]*';
 const CACHE_KEY = 'PERMISSIONS_LINTER';
 const ONE_HOUR_MS = 1000 * 60 * 60;
@@ -32,10 +34,11 @@ const findMissingPermissions = (errors, warnings, permissionsType, state) => {
 };
 exports.findMissingPermissions = findMissingPermissions;
 const fixMissingPermissions = async (errors, warnings, state) => {
-    var _a, _b, _c, _d, _e, _f, _g, _h, _j, _k;
+    var _a, _b, _c, _d, _e, _f, _g, _h, _j, _k, _l, _m, _o;
     const missingScopes = (0, exports.findMissingPermissions)(errors, warnings, 'missingPermission', state);
     const missingExternalFetchBackend = (0, exports.findMissingPermissions)(errors, warnings, 'missingExternalFetchPermission', state);
     const missingContentStyle = (0, exports.findMissingPermissions)(errors, warnings, 'missingContentStylePermission', state);
+    const missingExternalImage = (0, exports.findMissingPermissions)(errors, warnings, 'missingExternalImagesPermission', state);
     const currentPermissions = (_b = (_a = (await state.configFile.readConfig())) === null || _a === void 0 ? void 0 : _a.permissions) !== null && _b !== void 0 ? _b : {};
     const currentRemotes = (_d = (_c = (await state.configFile.readConfig())) === null || _c === void 0 ? void 0 : _c.remotes) !== null && _d !== void 0 ? _d : [];
     const currentScopes = (_e = currentPermissions === null || currentPermissions === void 0 ? void 0 : currentPermissions.scopes) !== null && _e !== void 0 ? _e : [];
@@ -54,26 +57,20 @@ const fixMissingPermissions = async (errors, warnings, state) => {
     const currentContentStyles = (_k = (_j = currentPermissions === null || currentPermissions === void 0 ? void 0 : currentPermissions.content) === null || _j === void 0 ? void 0 : _j.styles) !== null && _k !== void 0 ? _k : [];
     currentContentStyles.forEach((e) => missingContentStyle.add(e));
     const arrayMissingContentStyles = [...missingContentStyle];
-    await state.configFile.writeToConfigFile('permissions', Object.assign(Object.assign(Object.assign(Object.assign({}, currentPermissions), { scopes: [...missingScopes] }), (arrayMissingExternalFetchBackend.length > 0
-        ? {
-            external: currentPermissions.external
-                ? Object.assign(Object.assign({}, currentPermissions.external), { fetch: currentPermissions.external.fetch
-                        ? Object.assign(Object.assign({}, currentPermissions.external.fetch), { backend: arrayMissingExternalFetchBackend }) : {
-                        backend: arrayMissingExternalFetchBackend
-                    } }) : {
-                fetch: {
-                    backend: arrayMissingExternalFetchBackend
-                }
-            }
-        }
-        : {})), (arrayMissingContentStyles.length > 0
-        ? {
-            content: currentPermissions.content
-                ? Object.assign(Object.assign({}, currentPermissions.content), { styles: arrayMissingContentStyles }) : {
-                styles: arrayMissingContentStyles
-            }
-        }
-        : {})));
+    const currentExternalImages = (_m = (_l = currentPermissions === null || currentPermissions === void 0 ? void 0 : currentPermissions.external) === null || _l === void 0 ? void 0 : _l.images) !== null && _m !== void 0 ? _m : [];
+    currentExternalImages.forEach((e) => missingExternalImage.add(e));
+    const arrayMissingExternalImages = [...missingExternalImage];
+    const config = Object.assign(Object.assign({}, currentPermissions), { scopes: [...missingScopes] });
+    if (arrayMissingExternalFetchBackend.length > 0) {
+        config.external = Object.assign(Object.assign({}, config.external), { fetch: Object.assign(Object.assign({}, (_o = config.external) === null || _o === void 0 ? void 0 : _o.fetch), { backend: arrayMissingExternalFetchBackend }) });
+    }
+    if (arrayMissingExternalImages.length > 0) {
+        config.external = Object.assign(Object.assign({}, config.external), { images: arrayMissingExternalImages });
+    }
+    if (arrayMissingContentStyles.length > 0) {
+        config.content = Object.assign(Object.assign({}, config.content), { styles: arrayMissingContentStyles });
+    }
+    await state.configFile.writeToConfigFile('permissions', config);
     return state;
 };
 exports.fixMissingPermissions = fixMissingPermissions;
@@ -114,7 +111,8 @@ class PermissionLinter extends base_linter_1.default {
             new visitors_1.UIHookNodeVisitor(),
             new visitors_1.StorageAPINodeVisitor(),
             new visitors_1.ExternalApiCallVisitor(),
-            new visitors_1.ContentPropertyVisitor()
+            new visitors_1.ContentPropertyVisitor(),
+            new dynamic_properties_icon_visitor_1.DynamicPropertiesIconVisitor()
         ];
         const humanReadableEnvironment = (0, cli_shared_1.environmentToOption)(this.environment);
         this.verifiers = {
@@ -123,7 +121,8 @@ class PermissionLinter extends base_linter_1.default {
             storage: new verifiers_1.StorageAPIVerifier(humanReadableEnvironment, this.manifest),
             uiHook: new verifiers_1.UIHookVerifier(humanReadableEnvironment, this.manifest),
             external: new verifiers_1.ExternalFetchVerifier(humanReadableEnvironment, this.manifest),
-            contentProperty: new verifiers_1.ContentPropertyVerifier(humanReadableEnvironment, this.manifest)
+            contentProperty: new verifiers_1.ContentPropertyVerifier(humanReadableEnvironment, this.manifest),
+            dynamicPropertiesIcon: new dynamic_properties_icon_verifier_1.DynamicPropertiesIconVerifier(humanReadableEnvironment, this.manifest)
         };
     }
     setupMatchesMap(filepath) {
@@ -135,7 +134,8 @@ class PermissionLinter extends base_linter_1.default {
             uiHook: [],
             storage: [],
             external: [],
-            contentProperty: []
+            contentProperty: [],
+            dynamicPropertiesIcon: []
         });
     }
     getFixer() {
@@ -159,6 +159,9 @@ class PermissionLinter extends base_linter_1.default {
             case api_call_interface_1.ApiCallTypes.CONTENT_PROPERTY:
                 criteriaMatches.contentProperty.push(apiCall);
                 break;
+            case api_call_interface_1.ApiCallTypes.DYNAMIC_PROPERTIES_ICON:
+                criteriaMatches.dynamicPropertiesIcon.push(apiCall);
+                break;
         }
     }
     async getProductPaths(cacheKey, url) {

package/out/lint/linters/permission-linter/verifiers/dynamic-properties-icon-verifier.d.ts

@@ -0,0 +1,13 @@
+import type { ManifestSchema as Manifest } from '@forge/manifest';
+import { LintClass, LintResultRule } from '../../../linter-interface';
+import { BaseLintIssueVerifier, LintIssueVerifier } from '../../verifier-interface';
+import { DynamicPropertiesIconUrl } from '../api-call-interface';
+export declare class DynamicPropertiesIconVerifier extends BaseLintIssueVerifier implements LintIssueVerifier<DynamicPropertiesIconUrl[]> {
+    private egressFilteringService;
+    private readonly shouldRunCheck;
+    constructor(environment: string, manifest: Manifest);
+    protected getLintClass(): LintClass;
+    private extractDomain;
+    process(iconUrls: DynamicPropertiesIconUrl[]): Promise<LintResultRule[]>;
+}
+//# sourceMappingURL=dynamic-properties-icon-verifier.d.ts.map

package/out/lint/linters/permission-linter/verifiers/dynamic-properties-icon-verifier.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"dynamic-properties-icon-verifier.d.ts","sourceRoot":"","sources":["../../../../../src/lint/linters/permission-linter/verifiers/dynamic-properties-icon-verifier.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,cAAc,IAAI,QAAQ,EAAE,MAAM,iBAAiB,CAAC;AAGlE,OAAO,EAAE,SAAS,EAAE,cAAc,EAAE,MAAM,2BAA2B,CAAC;AACtE,OAAO,EAAE,qBAAqB,EAAE,iBAAiB,EAAE,MAAM,0BAA0B,CAAC;AACpF,OAAO,EAAE,wBAAwB,EAAE,MAAM,uBAAuB,CAAC;AAIjE,qBAAa,6BACX,SAAQ,qBACR,YAAW,iBAAiB,CAAC,wBAAwB,EAAE,CAAC;IACxD,OAAO,CAAC,sBAAsB,CAAyB;IACvD,OAAO,CAAC,QAAQ,CAAC,cAAc,CAAU;gBAE7B,WAAW,EAAE,MAAM,EAAE,QAAQ,EAAE,QAAQ;IAcnD,SAAS,CAAC,YAAY,IAAI,SAAS;IAInC,OAAO,CAAC,aAAa,CAMnB;IAEW,OAAO,CAAC,QAAQ,EAAE,wBAAwB,EAAE,GAAG,OAAO,CAAC,cAAc,EAAE,CAAC;CAiBtF"}

package/out/lint/linters/permission-linter/verifiers/dynamic-properties-icon-verifier.js

@@ -0,0 +1,50 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.DynamicPropertiesIconVerifier = void 0;
+const egress_1 = require("@forge/egress");
+const linter_interface_1 = require("../../../linter-interface");
+const verifier_interface_1 = require("../../verifier-interface");
+const text_1 = require("../../../text");
+const url_1 = require("url");
+class DynamicPropertiesIconVerifier extends verifier_interface_1.BaseLintIssueVerifier {
+    constructor(environment, manifest) {
+        var _a, _b, _c, _d, _e, _f;
+        super(environment, manifest);
+        this.extractDomain = (iconUrl) => {
+            try {
+                return new url_1.URL(iconUrl.url).hostname;
+            }
+            catch (e) {
+                return iconUrl.url;
+            }
+        };
+        this.shouldRunCheck = false;
+        const allowList = (_d = (_c = (_b = (_a = this.manifest) === null || _a === void 0 ? void 0 : _a.permissions) === null || _b === void 0 ? void 0 : _b.external) === null || _c === void 0 ? void 0 : _c.images) !== null && _d !== void 0 ? _d : [];
+        const collectedUrls = allowList.filter((item) => typeof item === 'string');
+        this.egressFilteringService = new egress_1.EgressFilteringService(collectedUrls);
+        if ((_f = (_e = this.manifest.modules) === null || _e === void 0 ? void 0 : _e['confluence:contentBylineItem']) === null || _f === void 0 ? void 0 : _f.find((module) => { var _a; return (_a = module.dynamicProperties) === null || _a === void 0 ? void 0 : _a.function; })) {
+            this.shouldRunCheck = true;
+        }
+    }
+    getLintClass() {
+        return linter_interface_1.LintClass.Error;
+    }
+    async process(iconUrls) {
+        if (!this.shouldRunCheck) {
+            return [];
+        }
+        return iconUrls
+            .filter(({ url }) => !this.egressFilteringService.isValidUrl(url))
+            .map((iconUrl) => ({
+            class: this.getLintClass(),
+            message: text_1.messages.verifiers.dynamicPropertiesIcon.message(iconUrl.url),
+            reference: text_1.messages.verifiers.dynamicPropertiesIcon.reference,
+            column: iconUrl.column,
+            line: iconUrl.line,
+            metadata: {
+                missingExternalImagesPermission: this.extractDomain(iconUrl)
+            }
+        }));
+    }
+}
+exports.DynamicPropertiesIconVerifier = DynamicPropertiesIconVerifier;

package/out/lint/linters/permission-linter/visitors/dynamic-properties-icon-visitor.d.ts

@@ -0,0 +1,10 @@
+import { TSESTree } from '@typescript-eslint/typescript-estree';
+import { NodeVisitor } from '../../node-visitor-interface';
+import { ApiCall } from '../api-call-interface';
+export declare class DynamicPropertiesIconVisitor implements NodeVisitor<ApiCall> {
+    visit(node: TSESTree.Node, parent: TSESTree.Node | undefined, callback: (iconUrl: ApiCall) => void): void;
+    private isIconPropertyDefinition;
+    private handleIconNode;
+    private transformArgsToIconUrl;
+}
+//# sourceMappingURL=dynamic-properties-icon-visitor.d.ts.map

package/out/lint/linters/permission-linter/visitors/dynamic-properties-icon-visitor.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"dynamic-properties-icon-visitor.d.ts","sourceRoot":"","sources":["../../../../../src/lint/linters/permission-linter/visitors/dynamic-properties-icon-visitor.ts"],"names":[],"mappings":"AAAA,OAAO,EAAkB,QAAQ,EAAE,MAAM,sCAAsC,CAAC;AAEhF,OAAO,EAAE,WAAW,EAAE,MAAM,8BAA8B,CAAC;AAC3D,OAAO,EAAE,OAAO,EAAgB,MAAM,uBAAuB,CAAC;AAE9D,qBAAa,4BAA6B,YAAW,WAAW,CAAC,OAAO,CAAC;IAChE,KAAK,CAAC,IAAI,EAAE,QAAQ,CAAC,IAAI,EAAE,MAAM,EAAE,QAAQ,CAAC,IAAI,GAAG,SAAS,EAAE,QAAQ,EAAE,CAAC,OAAO,EAAE,OAAO,KAAK,IAAI,GAAG,IAAI;IA4BhH,OAAO,CAAC,wBAAwB,CAI9B;IAEF,OAAO,CAAC,cAAc,CAOpB;IAEF,OAAO,CAAC,sBAAsB,CAK3B;CACJ"}

package/out/lint/linters/permission-linter/visitors/dynamic-properties-icon-visitor.js

@@ -0,0 +1,44 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.DynamicPropertiesIconVisitor = void 0;
+const typescript_estree_1 = require("@typescript-eslint/typescript-estree");
+const api_call_interface_1 = require("../api-call-interface");
+class DynamicPropertiesIconVisitor {
+    constructor() {
+        this.isIconPropertyDefinition = (node) => {
+            return (node.type === typescript_estree_1.AST_NODE_TYPES.Property && node.key.type === typescript_estree_1.AST_NODE_TYPES.Identifier && node.key.name === 'icon');
+        };
+        this.handleIconNode = (iconNode, callback) => {
+            if ((iconNode === null || iconNode === void 0 ? void 0 : iconNode.type) === typescript_estree_1.AST_NODE_TYPES.Literal && typeof (iconNode === null || iconNode === void 0 ? void 0 : iconNode.value) === 'string') {
+                if (iconNode.value.trim() !== '') {
+                    const iconUrl = this.transformArgsToIconUrl(iconNode);
+                    callback(iconUrl);
+                }
+            }
+        };
+        this.transformArgsToIconUrl = (iconNode) => ({
+            type: api_call_interface_1.ApiCallTypes.DYNAMIC_PROPERTIES_ICON,
+            url: iconNode.value,
+            line: iconNode.loc.start.line,
+            column: iconNode.loc.start.column
+        });
+    }
+    visit(node, parent, callback) {
+        var _a, _b, _c, _d;
+        switch (node.type) {
+            case typescript_estree_1.AST_NODE_TYPES.ArrowFunctionExpression:
+                if (((_a = node.body) === null || _a === void 0 ? void 0 : _a.type) === typescript_estree_1.AST_NODE_TYPES.ObjectExpression) {
+                    const iconDefinitionNode = (_b = node.body) === null || _b === void 0 ? void 0 : _b.properties.find(this.isIconPropertyDefinition);
+                    this.handleIconNode(iconDefinitionNode === null || iconDefinitionNode === void 0 ? void 0 : iconDefinitionNode.value, callback);
+                }
+                break;
+            case typescript_estree_1.AST_NODE_TYPES.ReturnStatement:
+                if (((_c = node.argument) === null || _c === void 0 ? void 0 : _c.type) === typescript_estree_1.AST_NODE_TYPES.ObjectExpression) {
+                    const iconDefinitionNode = (_d = node.argument) === null || _d === void 0 ? void 0 : _d.properties.find(this.isIconPropertyDefinition);
+                    this.handleIconNode(iconDefinitionNode === null || iconDefinitionNode === void 0 ? void 0 : iconDefinitionNode.value, callback);
+                }
+                break;
+        }
+    }
+}
+exports.DynamicPropertiesIconVisitor = DynamicPropertiesIconVisitor;

package/out/lint/text/messages.d.ts

@@ -8,6 +8,10 @@ export declare const messages: {
             message: (url: string) => string;
             reference: string;
         };
+        dynamicPropertiesIcon: {
+            message: (url: string) => string;
+            reference: string;
+        };
         handler: {
             message: (method: string, key: string) => string;
             reference: string;

package/out/lint/text/messages.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"messages.d.ts","sourceRoot":"","sources":["../../../src/lint/text/messages.ts"],"names":[],"mappings":"AAAA,eAAO,MAAM,QAAQ;;;+BAGI,MAAM,UAAU,MAAM,SAAS,MAAM,KAAG,MAAM;;;;2BAKlD,MAAM;;;;8BAIH,MAAM,OAAO,MAAM;;;;+BAKlB,MAAM,UAAU,MAAM,QAAQ,MAAM,GAAG,SAAS,SAAS,MAAM;;;;6BAKjE,MAAM;;;;+BAIJ,MAAM,QAAQ,MAAM,SAAS,MAAM;;;;CAK3D,CAAC"}
+{"version":3,"file":"messages.d.ts","sourceRoot":"","sources":["../../../src/lint/text/messages.ts"],"names":[],"mappings":"AAAA,eAAO,MAAM,QAAQ;;;+BAGI,MAAM,UAAU,MAAM,SAAS,MAAM,KAAG,MAAM;;;;2BAKlD,MAAM;;;;2BAIN,MAAM;;;;8BAKH,MAAM,OAAO,MAAM;;;;+BAKlB,MAAM,UAAU,MAAM,QAAQ,MAAM,GAAG,SAAS,SAAS,MAAM;;;;6BAKjE,MAAM;;;;+BAIJ,MAAM,QAAQ,MAAM,SAAS,MAAM;;;;CAK3D,CAAC"}

package/out/lint/text/messages.js

@@ -11,6 +11,10 @@ exports.messages = {
             message: (url) => `The domain ${url} is not included in the external permissions of your app manifest`,
             reference: 'egress-permission-required'
         },
+        dynamicPropertiesIcon: {
+            message: (url) => `The domain ${url} is not included in the external images permissions of your app manifest`,
+            reference: 'egress-permission-required'
+        },
         handler: {
             message: (method, key) => `Cannot find exported function '${method}', which is required by module '${key}' handler defined in the manifest`,
             reference: 'valid-module-required'

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@forge/lint",
-  "version": "3.2.22-next.4",
+  "version": "3.3.0-next.5",
   "description": "Linting for forge apps",
   "main": "out/index.js",
   "license": "UNLICENSED",
@@ -22,7 +22,7 @@
     "@forge/manifest": "4.10.0-next.2",
     "@typescript-eslint/typescript-estree": "^5.40.0",
     "array.prototype.flatmap": "^1.2.3",
-    "atlassian-openapi": "^1.0.13",
+    "atlassian-openapi": "^1.0.17",
     "cross-spawn": "^7.0.3",
     "node-fetch": "2.6.7"
   }