@forge/lint 3.2.2-next.1 → 3.2.2-next.4
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/CHANGELOG.md +24 -0
- package/out/lint/linters/manifest-linter/abstract-manifest-linter.d.ts.map +1 -1
- package/out/lint/linters/manifest-linter/abstract-manifest-linter.js +3 -3
- package/out/lint/linters/permission-linter/verifiers/content-property-verifier.d.ts.map +1 -1
- package/out/lint/linters/permission-linter/verifiers/content-property-verifier.js +17 -14
- package/out/lint/linters/permission-linter/verifiers/product-verifier.d.ts.map +1 -1
- package/out/lint/linters/permission-linter/verifiers/product-verifier.js +14 -11
- package/out/lint/linters/permission-linter/verifiers/ui-hook-verifier.js +1 -1
- package/package.json +3 -3
package/CHANGELOG.md
CHANGED
|
@@ -1,5 +1,29 @@
|
|
|
1
1
|
# @forge/lint
|
|
2
2
|
|
|
3
|
+
## 3.2.2-next.4
|
|
4
|
+
|
|
5
|
+
### Patch Changes
|
|
6
|
+
|
|
7
|
+
- Updated dependencies [b1684fd]
|
|
8
|
+
- @forge/manifest@4.0.0-next.4
|
|
9
|
+
- @forge/cli-shared@2.6.2-next.4
|
|
10
|
+
|
|
11
|
+
## 3.2.2-next.3
|
|
12
|
+
|
|
13
|
+
### Patch Changes
|
|
14
|
+
|
|
15
|
+
- Updated dependencies [6728c67]
|
|
16
|
+
- @forge/manifest@4.0.0-next.3
|
|
17
|
+
- @forge/cli-shared@2.6.2-next.3
|
|
18
|
+
|
|
19
|
+
## 3.2.2-next.2
|
|
20
|
+
|
|
21
|
+
### Patch Changes
|
|
22
|
+
|
|
23
|
+
- Updated dependencies [0da5775]
|
|
24
|
+
- @forge/manifest@3.11.0-next.2
|
|
25
|
+
- @forge/cli-shared@2.6.2-next.2
|
|
26
|
+
|
|
3
27
|
## 3.2.2-next.1
|
|
4
28
|
|
|
5
29
|
### Patch Changes
|
|
@@ -1 +1 @@
|
|
|
1
|
-
{"version":3,"file":"abstract-manifest-linter.d.ts","sourceRoot":"","sources":["../../../../src/lint/linters/manifest-linter/abstract-manifest-linter.ts"],"names":[],"mappings":"AAAA,OAAO,EACL,eAAe,EAGf,wBAAwB,EACxB,kBAAkB,EAClB,qBAAqB,EACtB,MAAM,iBAAiB,CAAC;AACzB,OAAO,EAAE,UAAU,EAAE,cAAc,EAAE,YAAY,EAAa,UAAU,EAAE,MAAM,wBAAwB,CAAC;AACzG,OAAO,EAAE,cAAc,EAAE,MAAM,uBAAuB,CAAC;AAEvD,qBAAa,sBAAuB,SAAQ,cAAc;IAG5C,OAAO,CAAC,QAAQ,CAAC,IAAI;IAFjC,OAAO,CAAC,SAAS,CAAsC;gBAE1B,IAAI,EAAE,eAAe,EAAE,MAAM,EAAE,UAAU;IAItE,OAAO,CAAC,mBAAmB;IAmB3B,YAAY,IAAI,kBAAkB,CAAC,GAAG,CAAC,GAAG,SAAS;
|
|
1
|
+
{"version":3,"file":"abstract-manifest-linter.d.ts","sourceRoot":"","sources":["../../../../src/lint/linters/manifest-linter/abstract-manifest-linter.ts"],"names":[],"mappings":"AAAA,OAAO,EACL,eAAe,EAGf,wBAAwB,EACxB,kBAAkB,EAClB,qBAAqB,EACtB,MAAM,iBAAiB,CAAC;AACzB,OAAO,EAAE,UAAU,EAAE,cAAc,EAAE,YAAY,EAAa,UAAU,EAAE,MAAM,wBAAwB,CAAC;AACzG,OAAO,EAAE,cAAc,EAAE,MAAM,uBAAuB,CAAC;AAEvD,qBAAa,sBAAuB,SAAQ,cAAc;IAG5C,OAAO,CAAC,QAAQ,CAAC,IAAI;IAFjC,OAAO,CAAC,SAAS,CAAsC;gBAE1B,IAAI,EAAE,eAAe,EAAE,MAAM,EAAE,UAAU;IAItE,OAAO,CAAC,mBAAmB;IAmB3B,YAAY,IAAI,kBAAkB,CAAC,GAAG,CAAC,GAAG,SAAS;IAI7C,gBAAgB,IAAI,OAAO,CAAC,UAAU,EAAE,CAAC;IAU/C,SAAS,IAAI,OAAO,CAAC,IAAI,CAAC;IAK1B,SAAS,CAAC,QAAQ,IACd,CAAC,CAAC,MAAM,EAAE,cAAc,EAAE,EAAE,QAAQ,EAAE,cAAc,EAAE,EAAE,KAAK,EAAE,YAAY,KAAK,OAAO,CAAC,YAAY,CAAC,CAAC,GACtG,SAAS;IAIb,SAAS,CAAC,kBAAkB,CAAC,OAAO,EAAE,wBAAwB,CAAC,GAAG,CAAC,GAAG,qBAAqB,EAAE;CAG9F"}
|
|
@@ -27,12 +27,12 @@ class AbstractManifestLinter extends abstract_linter_1.AbstractLinter {
|
|
|
27
27
|
getProcessor() {
|
|
28
28
|
return this.processor;
|
|
29
29
|
}
|
|
30
|
-
batchExecuteImpl() {
|
|
30
|
+
async batchExecuteImpl() {
|
|
31
31
|
if (!this.processor) {
|
|
32
32
|
throw new Error('Bootstrap failed');
|
|
33
33
|
}
|
|
34
|
-
const results = this.processor.process();
|
|
35
|
-
return
|
|
34
|
+
const results = await this.processor.process();
|
|
35
|
+
return [this.mapManifestResponse(results, this.getFixer())];
|
|
36
36
|
}
|
|
37
37
|
bootstrap() {
|
|
38
38
|
this.processor = manifest_1.ProcessorBuilder.instance().withValidation(this.type).build();
|
|
@@ -1 +1 @@
|
|
|
1
|
-
{"version":3,"file":"content-property-verifier.d.ts","sourceRoot":"","sources":["../../../../../src/lint/linters/permission-linter/verifiers/content-property-verifier.ts"],"names":[],"mappings":"
|
|
1
|
+
{"version":3,"file":"content-property-verifier.d.ts","sourceRoot":"","sources":["../../../../../src/lint/linters/permission-linter/verifiers/content-property-verifier.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,SAAS,EAAE,cAAc,EAAE,MAAM,2BAA2B,CAAC;AAEtE,OAAO,EAAE,qBAAqB,EAAE,iBAAiB,EAAE,MAAM,0BAA0B,CAAC;AACpF,OAAO,EAAE,sBAAsB,EAAE,MAAM,uBAAuB,CAAC;AAC/D,OAAO,EAAoB,cAAc,EAAE,MAAM,iBAAiB,CAAC;AAEnE,eAAO,MAAM,gCAAgC,EAAE,MAAM,CAAC,MAAM,EAAE,MAAM,CAAC,MAAM,EAAE,cAAc,CAAC,CAyD3F,CAAC;AAEF,qBAAa,uBACX,SAAQ,qBACR,YAAW,iBAAiB,CAAC,sBAAsB,EAAE,CAAC;IACtD,SAAS,CAAC,YAAY,IAAI,SAAS;IAItB,OAAO,CAAC,QAAQ,EAAE,sBAAsB,EAAE,GAAG,OAAO,CAAC,cAAc,EAAE,CAAC;IAsBnF,OAAO,CAAC,gBAAgB;CAKzB"}
|
|
@@ -1,7 +1,6 @@
|
|
|
1
1
|
"use strict";
|
|
2
2
|
Object.defineProperty(exports, "__esModule", { value: true });
|
|
3
3
|
exports.ContentPropertyVerifier = exports.CONTENT_PROPERTY_PERMISSIONS_MAP = void 0;
|
|
4
|
-
const cli_shared_1 = require("@forge/cli-shared");
|
|
5
4
|
const linter_interface_1 = require("../../../linter-interface");
|
|
6
5
|
const text_1 = require("../../../text");
|
|
7
6
|
const verifier_interface_1 = require("../../verifier-interface");
|
|
@@ -69,20 +68,24 @@ class ContentPropertyVerifier extends verifier_interface_1.BaseLintIssueVerifier
|
|
|
69
68
|
return linter_interface_1.LintClass.Error;
|
|
70
69
|
}
|
|
71
70
|
async process(apiCalls) {
|
|
72
|
-
const lintErrors =
|
|
73
|
-
|
|
74
|
-
|
|
75
|
-
|
|
76
|
-
|
|
77
|
-
|
|
78
|
-
|
|
79
|
-
|
|
80
|
-
|
|
81
|
-
|
|
82
|
-
|
|
71
|
+
const lintErrors = [];
|
|
72
|
+
for (const apiCall of apiCalls) {
|
|
73
|
+
const missingScopes = await this.getMissingScopes(apiCall);
|
|
74
|
+
for (const missingScope of missingScopes) {
|
|
75
|
+
const { context, method, line, column } = apiCall;
|
|
76
|
+
lintErrors.push({
|
|
77
|
+
class: this.getLintClass(),
|
|
78
|
+
message: text_1.messages.verifiers.contentProperty.message(context, method, missingScope),
|
|
79
|
+
reference: text_1.messages.verifiers.contentProperty.reference,
|
|
80
|
+
column,
|
|
81
|
+
line,
|
|
82
|
+
metadata: {
|
|
83
|
+
missingPermission: missingScope
|
|
84
|
+
}
|
|
85
|
+
});
|
|
83
86
|
}
|
|
84
|
-
}
|
|
85
|
-
return
|
|
87
|
+
}
|
|
88
|
+
return lintErrors;
|
|
86
89
|
}
|
|
87
90
|
getMissingScopes({ context, method }) {
|
|
88
91
|
var _a, _b;
|
|
@@ -1 +1 @@
|
|
|
1
|
-
{"version":3,"file":"product-verifier.d.ts","sourceRoot":"","sources":["../../../../../src/lint/linters/permission-linter/verifiers/product-verifier.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,cAAc,EAAE,SAAS,EAAE,MAAM,2BAA2B,CAAC;AACtE,OAAO,EAAE,OAAO,EAAE,cAAc,EAAE,MAAM,uBAAuB,CAAC;AAChE,OAAO,EAAE,iBAAiB,EAAE,qBAAqB,EAAE,MAAM,0BAA0B,CAAC;AAGpF,OAAO,EAAE,cAAc,IAAI,QAAQ,EAAoB,MAAM,iBAAiB,CAAC;AAE/E,OAAO,EAAE,OAAO,EAAE,MAAM,mBAAmB,CAAC;AAC5C,OAAO,qBAAqB,GAAG,OAAO,CAAC,qBAAqB,CAAC;AAE7D,MAAM,WAAW,aAAa;IAC5B,YAAY,EAAE,MAAM,CAAC;IACrB,OAAO,EAAE,WAAW,CAAC;CACtB;AAED,MAAM,WAAW,WAAW;IAC1B,CAAC,MAAM,EAAE,MAAM,GAAG;QAChB,QAAQ,EAAE,aAAa,EAAE,CAAC;QAC1B,2BAA2B,CAAC,EAAE,qBAAqB,EAAE,CAAC;KACvD,CAAC;CACH;AAED,UAAU,aAAa;IACrB,CAAC,QAAQ,EAAE,MAAM,GAAG,MAAM,EAAE,CAAC;CAC9B;AAED,oBAAY,uBAAuB,GAAG,GAAG,CAAC,MAAM,EAAE,aAAa,CAAC,CAAC;AAEjE,qBAAa,eAAgB,SAAQ,qBAAsB,YAAW,iBAAiB,CAAC,OAAO,EAAE,CAAC;IAI9F,OAAO,CAAC,QAAQ,CAAC,OAAO;IACxB,OAAO,CAAC,QAAQ,CAAC,OAAO;gBAHxB,WAAW,EAAE,MAAM,EACnB,QAAQ,EAAE,QAAQ,EACD,OAAO,EAAE,uBAAuB,EAChC,OAAO,EAAE,MAAM;IAKlC,SAAS,CAAC,YAAY,IAAI,SAAS;IAItB,OAAO,CAAC,QAAQ,EAAE,cAAc,EAAE,GAAG,OAAO,CAAC,cAAc,EAAE,CAAC;
|
|
1
|
+
{"version":3,"file":"product-verifier.d.ts","sourceRoot":"","sources":["../../../../../src/lint/linters/permission-linter/verifiers/product-verifier.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,cAAc,EAAE,SAAS,EAAE,MAAM,2BAA2B,CAAC;AACtE,OAAO,EAAE,OAAO,EAAE,cAAc,EAAE,MAAM,uBAAuB,CAAC;AAChE,OAAO,EAAE,iBAAiB,EAAE,qBAAqB,EAAE,MAAM,0BAA0B,CAAC;AAGpF,OAAO,EAAE,cAAc,IAAI,QAAQ,EAAoB,MAAM,iBAAiB,CAAC;AAE/E,OAAO,EAAE,OAAO,EAAE,MAAM,mBAAmB,CAAC;AAC5C,OAAO,qBAAqB,GAAG,OAAO,CAAC,qBAAqB,CAAC;AAE7D,MAAM,WAAW,aAAa;IAC5B,YAAY,EAAE,MAAM,CAAC;IACrB,OAAO,EAAE,WAAW,CAAC;CACtB;AAED,MAAM,WAAW,WAAW;IAC1B,CAAC,MAAM,EAAE,MAAM,GAAG;QAChB,QAAQ,EAAE,aAAa,EAAE,CAAC;QAC1B,2BAA2B,CAAC,EAAE,qBAAqB,EAAE,CAAC;KACvD,CAAC;CACH;AAED,UAAU,aAAa;IACrB,CAAC,QAAQ,EAAE,MAAM,GAAG,MAAM,EAAE,CAAC;CAC9B;AAED,oBAAY,uBAAuB,GAAG,GAAG,CAAC,MAAM,EAAE,aAAa,CAAC,CAAC;AAEjE,qBAAa,eAAgB,SAAQ,qBAAsB,YAAW,iBAAiB,CAAC,OAAO,EAAE,CAAC;IAI9F,OAAO,CAAC,QAAQ,CAAC,OAAO;IACxB,OAAO,CAAC,QAAQ,CAAC,OAAO;gBAHxB,WAAW,EAAE,MAAM,EACnB,QAAQ,EAAE,QAAQ,EACD,OAAO,EAAE,uBAAuB,EAChC,OAAO,EAAE,MAAM;IAKlC,SAAS,CAAC,YAAY,IAAI,SAAS;IAItB,OAAO,CAAC,QAAQ,EAAE,cAAc,EAAE,GAAG,OAAO,CAAC,cAAc,EAAE,CAAC;IAuC3E,OAAO,CAAC,aAAa;IAerB,OAAO,CAAC,0BAA0B;IAOlC,OAAO,CAAC,iBAAiB;IAqBzB,OAAO,CAAC,aAAa;CAWtB"}
|
|
@@ -18,18 +18,21 @@ class ProductVerifier extends verifier_interface_1.BaseLintIssueVerifier {
|
|
|
18
18
|
return linter_interface_1.LintClass.Error;
|
|
19
19
|
}
|
|
20
20
|
async process(apiCalls) {
|
|
21
|
+
var _a;
|
|
21
22
|
const rules = [];
|
|
22
23
|
const lintCriteriaMatches = new Set();
|
|
23
|
-
|
|
24
|
+
for (const apiCall of apiCalls) {
|
|
24
25
|
const apiCallLookupResult = this.lookupApiCall(apiCall);
|
|
25
|
-
|
|
26
|
-
|
|
27
|
-
|
|
28
|
-
|
|
29
|
-
|
|
30
|
-
|
|
31
|
-
|
|
32
|
-
|
|
26
|
+
if (apiCallLookupResult) {
|
|
27
|
+
lintCriteriaMatches.add(apiCallLookupResult);
|
|
28
|
+
}
|
|
29
|
+
}
|
|
30
|
+
for (const apiCall of lintCriteriaMatches) {
|
|
31
|
+
if (!(apiCall === null || apiCall === void 0 ? void 0 : apiCall.regex)) {
|
|
32
|
+
continue;
|
|
33
|
+
}
|
|
34
|
+
const missingScopes = await this.getMissingPermissionScopes(apiCall);
|
|
35
|
+
for (const permission of missingScopes) {
|
|
33
36
|
rules.push({
|
|
34
37
|
class: this.getLintClass(),
|
|
35
38
|
message: text_1.messages.verifiers.product.message(cli_shared_1.capitalise(this.product), apiCall.method.toUpperCase(), (_a = this.pathMap.get(apiCall.regex)) === null || _a === void 0 ? void 0 : _a.originalPath, permission),
|
|
@@ -40,8 +43,8 @@ class ProductVerifier extends verifier_interface_1.BaseLintIssueVerifier {
|
|
|
40
43
|
missingPermission: permission
|
|
41
44
|
}
|
|
42
45
|
});
|
|
43
|
-
}
|
|
44
|
-
}
|
|
46
|
+
}
|
|
47
|
+
}
|
|
45
48
|
return rules;
|
|
46
49
|
}
|
|
47
50
|
lookupApiCall(apiCall) {
|
|
@@ -30,7 +30,7 @@ class UIHookVerifier extends verifier_interface_1.BaseLintIssueVerifier {
|
|
|
30
30
|
const requiredPermissions = FORGE_UI_HOOK_PERMISSIONS[apiCall.hookName];
|
|
31
31
|
if (!requiredPermissions)
|
|
32
32
|
return rules;
|
|
33
|
-
const missingPermissions = manifest_1.getMissingScopes((_a = this.manifest.permissions) === null || _a === void 0 ? void 0 : _a.scopes, requiredPermissions);
|
|
33
|
+
const missingPermissions = await manifest_1.getMissingScopes((_a = this.manifest.permissions) === null || _a === void 0 ? void 0 : _a.scopes, requiredPermissions);
|
|
34
34
|
missingPermissions.forEach((perm) => rules.push(this.getHookRule(apiCall, perm)));
|
|
35
35
|
}
|
|
36
36
|
return rules;
|
package/package.json
CHANGED
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
{
|
|
2
2
|
"name": "@forge/lint",
|
|
3
|
-
"version": "3.2.2-next.
|
|
3
|
+
"version": "3.2.2-next.4",
|
|
4
4
|
"description": "Linting for forge apps",
|
|
5
5
|
"main": "out/index.js",
|
|
6
6
|
"license": "UNLICENSED",
|
|
@@ -15,9 +15,9 @@
|
|
|
15
15
|
"@types/node-fetch": "^2.5.7"
|
|
16
16
|
},
|
|
17
17
|
"dependencies": {
|
|
18
|
-
"@forge/cli-shared": "2.6.2-next.
|
|
18
|
+
"@forge/cli-shared": "2.6.2-next.4",
|
|
19
19
|
"@forge/csp": "1.11.0",
|
|
20
|
-
"@forge/manifest": "
|
|
20
|
+
"@forge/manifest": "4.0.0-next.4",
|
|
21
21
|
"@typescript-eslint/typescript-estree": "^3.5.0",
|
|
22
22
|
"cross-spawn": "^7.0.1",
|
|
23
23
|
"node-fetch": "2.6.1",
|