@forge/lint 2.0.1-next.5 → 2.1.0-fix.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/CHANGELOG.md +11 -46
- package/out/lint/linters/permission-linter/permission-linter.d.ts +1 -0
- package/out/lint/linters/permission-linter/permission-linter.d.ts.map +1 -1
- package/out/lint/linters/permission-linter/permission-linter.js +19 -4
- package/out/lint/linters/permission-linter/verifiers/product-verifier.js +5 -5
- package/package.json +3 -3
package/CHANGELOG.md
CHANGED
|
@@ -1,56 +1,21 @@
|
|
|
1
1
|
# @forge/lint
|
|
2
2
|
|
|
3
|
-
## 2.0
|
|
3
|
+
## 2.1.0-fix.0
|
|
4
4
|
|
|
5
|
-
###
|
|
6
|
-
|
|
7
|
-
- Updated dependencies [f6901fd]
|
|
8
|
-
- @forge/manifest@3.1.0-next.5
|
|
9
|
-
- @forge/cli-shared@2.2.1-next.5
|
|
10
|
-
|
|
11
|
-
## 2.0.1-next.4
|
|
12
|
-
|
|
13
|
-
### Patch Changes
|
|
14
|
-
|
|
15
|
-
- 2e70a0b: Accept both granular and deprecated scopes when verifying scopes required for Content Properties.
|
|
16
|
-
- Updated dependencies [d3ccc04]
|
|
17
|
-
- @forge/manifest@3.1.0-next.4
|
|
18
|
-
- @forge/cli-shared@2.2.1-next.4
|
|
19
|
-
|
|
20
|
-
## 2.0.1-next.3
|
|
21
|
-
|
|
22
|
-
### Patch Changes
|
|
23
|
-
|
|
24
|
-
- 1f7c428: Accept both deprecated scopes and granular scopes when verifying scopes required for REST product endpoints.
|
|
25
|
-
- Updated dependencies [debe251]
|
|
26
|
-
- @forge/manifest@3.1.0-next.3
|
|
27
|
-
- @forge/cli-shared@2.2.1-next.3
|
|
28
|
-
|
|
29
|
-
## 2.0.1-next.2
|
|
30
|
-
|
|
31
|
-
### Patch Changes
|
|
32
|
-
|
|
33
|
-
- ffa0050: Accept both deprecated scopes and granular scopes when verifying scopes required for Forge UI hooks.
|
|
34
|
-
- Updated dependencies [14102be]
|
|
35
|
-
- @forge/manifest@3.1.0-next.2
|
|
36
|
-
- @forge/cli-shared@2.2.1-next.2
|
|
37
|
-
|
|
38
|
-
## 2.0.1-next.1
|
|
39
|
-
|
|
40
|
-
### Patch Changes
|
|
41
|
-
|
|
42
|
-
- Updated dependencies [8ee1c58]
|
|
43
|
-
- @forge/manifest@3.1.0-next.1
|
|
44
|
-
- @forge/cli-shared@2.2.1-next.1
|
|
5
|
+
### Minor Changes
|
|
45
6
|
|
|
46
|
-
|
|
7
|
+
- 23a68cf: Adding environment variables to override production swagger with local files.
|
|
47
8
|
|
|
48
9
|
### Patch Changes
|
|
49
10
|
|
|
50
|
-
-
|
|
51
|
-
-
|
|
52
|
-
|
|
53
|
-
|
|
11
|
+
- cf6b98b: Accept both deprecated scopes and granular scopes when verifying scopes required for Forge UI hooks.
|
|
12
|
+
- ab8af10: Fix unhandled error when invalid method used for Product REST API endpoint.
|
|
13
|
+
- 7cd92e9: Accept both deprecated scopes and granular scopes when verifying scopes required for REST product endpoints.
|
|
14
|
+
- c2cecf3: Accept both granular and deprecated scopes when verifying scopes required for Content Properties.
|
|
15
|
+
- Updated dependencies [0954b2f]
|
|
16
|
+
- Updated dependencies [2c77951]
|
|
17
|
+
- @forge/manifest@3.0.1-fix.0
|
|
18
|
+
- @forge/cli-shared@2.2.1-fix.0
|
|
54
19
|
|
|
55
20
|
## 2.0.0
|
|
56
21
|
|
|
@@ -32,6 +32,7 @@ export declare class PermissionLinter extends BaseLinter<ApiCall, PermissionLint
|
|
|
32
32
|
protected getFixer(): ((errors: LintResultRule[], warnings: LintResultRule[], state: LintFixState) => Promise<LintFixState>) | undefined;
|
|
33
33
|
protected addLintCriteriaMatch(apiCall: ApiCall, filepath: string): void;
|
|
34
34
|
getProductPaths(cacheKey: string, url: string): Promise<SwaggerFormat>;
|
|
35
|
+
getProductPathsFile(url: string): Promise<SwaggerFormat>;
|
|
35
36
|
private processPaths;
|
|
36
37
|
}
|
|
37
38
|
export {};
|
|
@@ -1 +1 @@
|
|
|
1
|
-
{"version":3,"file":"permission-linter.d.ts","sourceRoot":"","sources":["../../../../src/lint/linters/permission-linter/permission-linter.ts"],"names":[],"mappings":"AACA,OAAO,KAAK,EAAE,cAAc,IAAI,QAAQ,EAAe,MAAM,iBAAiB,CAAC;AAE/E,OAAO,UAAU,MAAM,mBAAmB,CAAC;AAC3C,OAAO,EAAE,YAAY,EAAE,UAAU,EAAE,cAAc,EAAE,MAAM,wBAAwB,CAAC;AAClF,OAAO,EACL,OAAO,EAEP,eAAe,EACf,cAAc,EACd,cAAc,EACd,aAAa,EACd,MAAM,sBAAsB,CAAC;AAC9B,OAAO,EAML,WAAW,EAGZ,MAAM,aAAa,CAAC;
|
|
1
|
+
{"version":3,"file":"permission-linter.d.ts","sourceRoot":"","sources":["../../../../src/lint/linters/permission-linter/permission-linter.ts"],"names":[],"mappings":"AACA,OAAO,KAAK,EAAE,cAAc,IAAI,QAAQ,EAAe,MAAM,iBAAiB,CAAC;AAE/E,OAAO,UAAU,MAAM,mBAAmB,CAAC;AAC3C,OAAO,EAAE,YAAY,EAAE,UAAU,EAAE,cAAc,EAAE,MAAM,wBAAwB,CAAC;AAClF,OAAO,EACL,OAAO,EAEP,eAAe,EACf,cAAc,EACd,cAAc,EACd,aAAa,EACd,MAAM,sBAAsB,CAAC;AAC9B,OAAO,EAML,WAAW,EAGZ,MAAM,aAAa,CAAC;AAUrB,UAAU,aAAa;IACrB,KAAK,EAAE;QACL,CAAC,IAAI,EAAE,MAAM,GAAG,WAAW,CAAC;KAC7B,CAAC;CACH;AAED,eAAO,MAAM,mBAAmB,eAAe,CAAC;AAKhD,eAAO,MAAM,sBAAsB,WACzB,cAAc,EAAE,YACd,cAAc,EAAE,mBACT,mBAAmB,GAAG,gCAAgC,GAAG,+BAA+B,uCAExG,GAAG,CAAC,MAAM,CAkBZ,CAAC;AAEF,eAAO,MAAM,qBAAqB,WACxB,cAAc,EAAE,YACd,cAAc,EAAE,SACnB,YAAY,KAClB,OAAO,CAAC,YAAY,CAsEtB,CAAC;AAEF,UAAU,6BAA6B;IACrC,CAAC,GAAG,EAAE,MAAM,GAAG,OAAO,EAAE,CAAC;IACzB,UAAU,EAAE,cAAc,EAAE,CAAC;IAC7B,IAAI,EAAE,cAAc,EAAE,CAAC;IACvB,OAAO,EAAE,cAAc,EAAE,CAAC;IAC1B,MAAM,EAAE,aAAa,EAAE,CAAC;IACxB,QAAQ,EAAE,eAAe,EAAE,CAAC;CAC7B;AAED,qBAAa,gBAAiB,SAAQ,UAAU,CAAC,OAAO,EAAE,6BAA6B,EAAE,OAAO,EAAE,CAAC;IAQhE,OAAO,CAAC,QAAQ;IAPjD,MAAM,CAAC,cAAc,SAAgC;IACrD,MAAM,CAAC,oBAAoB,SAAsC;IAEjE,OAAO,CAAC,IAAI,CAAC,CAA0B;IACvC,OAAO,CAAC,UAAU,CAAC,CAA0B;IAC7C,OAAO,CAAC,KAAK,CAAC,CAAa;gBAEf,WAAW,EAAE,MAAM,EAAU,QAAQ,EAAE,QAAQ,EAAE,MAAM,EAAE,UAAU;IAIlE,SAAS,IAAI,OAAO,CAAC,IAAI,CAAC;IA4CvC,SAAS,CAAC,eAAe,CAAC,QAAQ,EAAE,MAAM,GAAG,IAAI;IAajD,SAAS,CAAC,QAAQ,IACd,CAAC,CAAC,MAAM,EAAE,cAAc,EAAE,EAAE,QAAQ,EAAE,cAAc,EAAE,EAAE,KAAK,EAAE,YAAY,KAAK,OAAO,CAAC,YAAY,CAAC,CAAC,GACtG,SAAS;IAIb,SAAS,CAAC,oBAAoB,CAAC,OAAO,EAAE,OAAO,EAAE,QAAQ,EAAE,MAAM,GAAG,IAAI;IAsB3D,eAAe,CAAC,QAAQ,EAAE,MAAM,EAAE,GAAG,EAAE,MAAM,GAAG,OAAO,CAAC,aAAa,CAAC;IAWtE,mBAAmB,CAAC,GAAG,EAAE,MAAM,GAAG,OAAO,CAAC,aAAa,CAAC;IAKrE,OAAO,CAAC,YAAY;CAarB"}
|
|
@@ -8,6 +8,7 @@ const base_linter_1 = tslib_1.__importDefault(require("../../base-linter"));
|
|
|
8
8
|
const api_call_interface_1 = require("./api-call-interface");
|
|
9
9
|
const verifiers_1 = require("./verifiers");
|
|
10
10
|
const visitors_1 = require("./visitors");
|
|
11
|
+
const fs_1 = tslib_1.__importDefault(require("fs"));
|
|
11
12
|
exports.NON_FWD_SLASH_REGEX = '[^\\/\\s]*';
|
|
12
13
|
const CACHE_KEY = 'PERMISSIONS_LINTER';
|
|
13
14
|
const ONE_HOUR_MS = 1000 * 60 * 60;
|
|
@@ -81,10 +82,20 @@ class PermissionLinter extends base_linter_1.default {
|
|
|
81
82
|
}
|
|
82
83
|
async bootstrap() {
|
|
83
84
|
this.cache = cli_shared_1.CachedConf.getCache(CACHE_KEY);
|
|
84
|
-
const
|
|
85
|
-
|
|
86
|
-
|
|
87
|
-
|
|
85
|
+
const LOCAL_CONF_SWAGGER = process.env.LOCAL_CONF_SWAGGER;
|
|
86
|
+
const LOCAL_JIRA_SWAGGER = process.env.LOCAL_JIRA_SWAGGER;
|
|
87
|
+
const USE_LOCAL_SWAGGER = process.env.USE_LOCAL_SWAGGER;
|
|
88
|
+
let swaggerFiles;
|
|
89
|
+
if (USE_LOCAL_SWAGGER && LOCAL_CONF_SWAGGER && LOCAL_JIRA_SWAGGER) {
|
|
90
|
+
swaggerFiles = [this.getProductPathsFile(LOCAL_JIRA_SWAGGER), this.getProductPathsFile(LOCAL_CONF_SWAGGER)];
|
|
91
|
+
}
|
|
92
|
+
else {
|
|
93
|
+
swaggerFiles = [
|
|
94
|
+
this.getProductPaths(PermissionLinter.JIRA_CACHE_KEY, 'https://developer.atlassian.com/cloud/jira/platform/swagger-v3.v3.json'),
|
|
95
|
+
this.getProductPaths(PermissionLinter.CONFLUENCE_CACHE_KEY, 'https://developer.atlassian.com/cloud/confluence/swagger.v3.json')
|
|
96
|
+
];
|
|
97
|
+
}
|
|
98
|
+
const [jira, confluence] = await Promise.all(swaggerFiles);
|
|
88
99
|
this.jira = this.processPaths(jira.paths);
|
|
89
100
|
this.confluence = this.processPaths(confluence.paths);
|
|
90
101
|
this.nodeVisitors = [
|
|
@@ -150,6 +161,10 @@ class PermissionLinter extends base_linter_1.default {
|
|
|
150
161
|
}
|
|
151
162
|
return cached;
|
|
152
163
|
}
|
|
164
|
+
async getProductPathsFile(url) {
|
|
165
|
+
const response = fs_1.default.readFileSync(url);
|
|
166
|
+
return JSON.parse(response.toString());
|
|
167
|
+
}
|
|
153
168
|
processPaths(paths) {
|
|
154
169
|
const pathMap = new Map();
|
|
155
170
|
Object.keys(paths).forEach((path) => {
|
|
@@ -73,23 +73,23 @@ class ProductVerifier extends verifier_interface_1.BaseLintIssueVerifier {
|
|
|
73
73
|
return missingCurrentScopes;
|
|
74
74
|
}
|
|
75
75
|
getRequiredScopes({ regex, method }) {
|
|
76
|
-
var _a, _b, _c;
|
|
76
|
+
var _a, _b, _c, _d;
|
|
77
77
|
if (!regex)
|
|
78
78
|
return [];
|
|
79
|
-
const oAuth2Scopes = (_a = this.pathMap.get(regex)) === null || _a === void 0 ? void 0 : _a.methods[method]['x-atlassian-oauth2-scopes'];
|
|
79
|
+
const oAuth2Scopes = (_b = (_a = this.pathMap.get(regex)) === null || _a === void 0 ? void 0 : _a.methods[method]) === null || _b === void 0 ? void 0 : _b['x-atlassian-oauth2-scopes'];
|
|
80
80
|
if (oAuth2Scopes) {
|
|
81
81
|
return array_prototype_flatmap_1.default(oAuth2Scopes.filter((scope) => scope.state === 'Current').map((scope) => scope.scopes), (x) => x);
|
|
82
82
|
}
|
|
83
|
-
const swaggerEntries = (
|
|
83
|
+
const swaggerEntries = (_d = (_c = this.pathMap.get(regex)) === null || _c === void 0 ? void 0 : _c.methods[method]) === null || _d === void 0 ? void 0 : _d.security;
|
|
84
84
|
if (!swaggerEntries)
|
|
85
85
|
return [];
|
|
86
86
|
return swaggerEntries === null || swaggerEntries === void 0 ? void 0 : swaggerEntries.reduce((prev, curr) => [...prev, ...(curr['OAuth2'] || []), ...(curr['oAuthDefinitions'] || [])], []);
|
|
87
87
|
}
|
|
88
88
|
getRequiredDeprecatedScopes({ regex, method }) {
|
|
89
|
-
var _a;
|
|
89
|
+
var _a, _b;
|
|
90
90
|
if (!regex)
|
|
91
91
|
return [];
|
|
92
|
-
const oAuth2Scopes = (_a = this.pathMap.get(regex)) === null || _a === void 0 ? void 0 : _a.methods[method]['x-atlassian-oauth2-scopes'];
|
|
92
|
+
const oAuth2Scopes = (_b = (_a = this.pathMap.get(regex)) === null || _a === void 0 ? void 0 : _a.methods[method]) === null || _b === void 0 ? void 0 : _b['x-atlassian-oauth2-scopes'];
|
|
93
93
|
if (!oAuth2Scopes)
|
|
94
94
|
return [];
|
|
95
95
|
return array_prototype_flatmap_1.default(oAuth2Scopes.filter((scope) => scope.state === 'Deprecated').map((scope) => scope.scopes), (x) => x);
|
package/package.json
CHANGED
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
{
|
|
2
2
|
"name": "@forge/lint",
|
|
3
|
-
"version": "2.0
|
|
3
|
+
"version": "2.1.0-fix.0",
|
|
4
4
|
"description": "Linting for forge apps",
|
|
5
5
|
"main": "out/index.js",
|
|
6
6
|
"license": "UNLICENSED",
|
|
@@ -15,9 +15,9 @@
|
|
|
15
15
|
"@types/node-fetch": "^2.5.7"
|
|
16
16
|
},
|
|
17
17
|
"dependencies": {
|
|
18
|
-
"@forge/cli-shared": "2.2.1-
|
|
18
|
+
"@forge/cli-shared": "2.2.1-fix.0",
|
|
19
19
|
"@forge/csp": "1.9.0",
|
|
20
|
-
"@forge/manifest": "3.1.0
|
|
20
|
+
"@forge/manifest": "3.0.1-fix.0",
|
|
21
21
|
"@typescript-eslint/typescript-estree": "^3.5.0",
|
|
22
22
|
"cross-spawn": "^7.0.1",
|
|
23
23
|
"node-fetch": "^2.6.1",
|