@forge/lint 0.0.0-experimental-e3032d7 → 0.0.0-experimental-9489df9

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (12) hide show
  1. package/CHANGELOG.md +123 -4
  2. package/out/lint/linters/manifest-linter/abstract-manifest-linter.d.ts.map +1 -1
  3. package/out/lint/linters/manifest-linter/abstract-manifest-linter.js +3 -3
  4. package/out/lint/linters/permission-linter/verifiers/content-property-verifier.d.ts.map +1 -1
  5. package/out/lint/linters/permission-linter/verifiers/content-property-verifier.js +17 -14
  6. package/out/lint/linters/permission-linter/verifiers/external-fetch-verifier.d.ts +1 -0
  7. package/out/lint/linters/permission-linter/verifiers/external-fetch-verifier.d.ts.map +1 -1
  8. package/out/lint/linters/permission-linter/verifiers/external-fetch-verifier.js +12 -1
  9. package/out/lint/linters/permission-linter/verifiers/product-verifier.d.ts.map +1 -1
  10. package/out/lint/linters/permission-linter/verifiers/product-verifier.js +14 -11
  11. package/out/lint/linters/permission-linter/verifiers/ui-hook-verifier.js +1 -1
  12. package/package.json +4 -3
package/CHANGELOG.md CHANGED
@@ -1,13 +1,132 @@
1
1
  # @forge/lint
2
2
 
3
- ## 0.0.0-experimental-e3032d7
3
+ ## 0.0.0-experimental-9489df9
4
+
5
+ ### Patch Changes
6
+
7
+ - Updated dependencies [acf78b5]
8
+ - Updated dependencies [0da5775]
9
+ - Updated dependencies [6728c67]
10
+ - Updated dependencies [c1c93a4]
11
+ - Updated dependencies [b1684fd]
12
+ - @forge/manifest@0.0.0-experimental-9489df9
13
+ - @forge/cli-shared@0.0.0-experimental-9489df9
14
+
15
+ ## 3.2.2-next.4
16
+
17
+ ### Patch Changes
18
+
19
+ - Updated dependencies [b1684fd]
20
+ - @forge/manifest@4.0.0-next.4
21
+ - @forge/cli-shared@2.6.2-next.4
22
+
23
+ ## 3.2.2-next.3
24
+
25
+ ### Patch Changes
26
+
27
+ - Updated dependencies [6728c67]
28
+ - @forge/manifest@4.0.0-next.3
29
+ - @forge/cli-shared@2.6.2-next.3
30
+
31
+ ## 3.2.2-next.2
32
+
33
+ ### Patch Changes
34
+
35
+ - Updated dependencies [0da5775]
36
+ - @forge/manifest@3.11.0-next.2
37
+ - @forge/cli-shared@2.6.2-next.2
38
+
39
+ ## 3.2.2-next.1
40
+
41
+ ### Patch Changes
42
+
43
+ - Updated dependencies [acf78b58]
44
+ - @forge/manifest@3.11.0-next.1
45
+ - @forge/cli-shared@2.6.2-next.1
46
+
47
+ ## 3.2.2-next.0
48
+
49
+ ### Patch Changes
50
+
51
+ - Updated dependencies [c1c93a4]
52
+ - @forge/manifest@3.10.1-next.0
53
+ - @forge/cli-shared@2.6.2-next.0
54
+
55
+ ## 3.2.1
56
+
57
+ ### Patch Changes
58
+
59
+ - Updated dependencies [02aefee]
60
+ - Updated dependencies [d486898]
61
+ - Updated dependencies [f890e0e]
62
+ - Updated dependencies [9298536]
63
+ - Updated dependencies [ee8d860]
64
+ - Updated dependencies [2ae0afe]
65
+ - Updated dependencies [91daffc]
66
+ - Updated dependencies [7558a5d]
67
+ - Updated dependencies [f543a47]
68
+ - Updated dependencies [8876b96]
69
+ - @forge/manifest@3.10.0
70
+ - @forge/cli-shared@2.6.1
71
+
72
+ ## 3.2.1-next.6
73
+
74
+ ### Patch Changes
75
+
76
+ - Updated dependencies [ee8d860]
77
+ - @forge/manifest@3.10.0-next.6
78
+ - @forge/cli-shared@2.6.1-next.6
79
+
80
+ ## 3.2.1-next.5
81
+
82
+ ### Patch Changes
83
+
84
+ - Updated dependencies [8876b96]
85
+ - @forge/manifest@3.10.0-next.5
86
+ - @forge/cli-shared@2.6.1-next.5
87
+
88
+ ## 3.2.1-next.4
89
+
90
+ ### Patch Changes
91
+
92
+ - Updated dependencies [9298536]
93
+ - @forge/manifest@3.10.0-next.4
94
+ - @forge/cli-shared@2.6.1-next.4
95
+
96
+ ## 3.2.1-next.3
97
+
98
+ ### Patch Changes
99
+
100
+ - Updated dependencies [d486898]
101
+ - Updated dependencies [f890e0e]
102
+ - Updated dependencies [91daffc]
103
+ - @forge/manifest@3.10.0-next.3
104
+ - @forge/cli-shared@2.6.1-next.3
105
+
106
+ ## 3.2.1-next.2
107
+
108
+ ### Patch Changes
109
+
110
+ - Updated dependencies [7558a5d9]
111
+ - @forge/manifest@3.9.1-next.2
112
+ - @forge/cli-shared@2.6.1-next.2
113
+
114
+ ## 3.2.1-next.1
115
+
116
+ ### Patch Changes
117
+
118
+ - Updated dependencies [02aefee]
119
+ - Updated dependencies [f543a47]
120
+ - @forge/manifest@3.9.1-next.1
121
+ - @forge/cli-shared@2.6.1-next.1
122
+
123
+ ## 3.2.1-next.0
4
124
 
5
125
  ### Patch Changes
6
126
 
7
- - Updated dependencies [ebb857c]
8
127
  - Updated dependencies [2ae0afe]
9
- - @forge/cli-shared@0.0.0-experimental-e3032d7
10
- - @forge/manifest@0.0.0-experimental-e3032d7
128
+ - @forge/manifest@3.9.1-next.0
129
+ - @forge/cli-shared@2.6.1-next.0
11
130
 
12
131
  ## 3.2.0
13
132
 
package/out/lint/linters/manifest-linter/abstract-manifest-linter.d.ts.map CHANGED
@@ -1 +1 @@
1
- {"version":3,"file":"abstract-manifest-linter.d.ts","sourceRoot":"","sources":["../../../../src/lint/linters/manifest-linter/abstract-manifest-linter.ts"],"names":[],"mappings":"AAAA,OAAO,EACL,eAAe,EAGf,wBAAwB,EACxB,kBAAkB,EAClB,qBAAqB,EACtB,MAAM,iBAAiB,CAAC;AACzB,OAAO,EAAE,UAAU,EAAE,cAAc,EAAE,YAAY,EAAa,UAAU,EAAE,MAAM,wBAAwB,CAAC;AACzG,OAAO,EAAE,cAAc,EAAE,MAAM,uBAAuB,CAAC;AAEvD,qBAAa,sBAAuB,SAAQ,cAAc;IAG5C,OAAO,CAAC,QAAQ,CAAC,IAAI;IAFjC,OAAO,CAAC,SAAS,CAAsC;gBAE1B,IAAI,EAAE,eAAe,EAAE,MAAM,EAAE,UAAU;IAItE,OAAO,CAAC,mBAAmB;IAmB3B,YAAY,IAAI,kBAAkB,CAAC,GAAG,CAAC,GAAG,SAAS;IAInD,gBAAgB,IAAI,OAAO,CAAC,UAAU,EAAE,CAAC;IAUzC,SAAS,IAAI,OAAO,CAAC,IAAI,CAAC;IAK1B,SAAS,CAAC,QAAQ,IACd,CAAC,CAAC,MAAM,EAAE,cAAc,EAAE,EAAE,QAAQ,EAAE,cAAc,EAAE,EAAE,KAAK,EAAE,YAAY,KAAK,OAAO,CAAC,YAAY,CAAC,CAAC,GACtG,SAAS;IAIb,SAAS,CAAC,kBAAkB,CAAC,OAAO,EAAE,wBAAwB,CAAC,GAAG,CAAC,GAAG,qBAAqB,EAAE;CAG9F"}
1
+ {"version":3,"file":"abstract-manifest-linter.d.ts","sourceRoot":"","sources":["../../../../src/lint/linters/manifest-linter/abstract-manifest-linter.ts"],"names":[],"mappings":"AAAA,OAAO,EACL,eAAe,EAGf,wBAAwB,EACxB,kBAAkB,EAClB,qBAAqB,EACtB,MAAM,iBAAiB,CAAC;AACzB,OAAO,EAAE,UAAU,EAAE,cAAc,EAAE,YAAY,EAAa,UAAU,EAAE,MAAM,wBAAwB,CAAC;AACzG,OAAO,EAAE,cAAc,EAAE,MAAM,uBAAuB,CAAC;AAEvD,qBAAa,sBAAuB,SAAQ,cAAc;IAG5C,OAAO,CAAC,QAAQ,CAAC,IAAI;IAFjC,OAAO,CAAC,SAAS,CAAsC;gBAE1B,IAAI,EAAE,eAAe,EAAE,MAAM,EAAE,UAAU;IAItE,OAAO,CAAC,mBAAmB;IAmB3B,YAAY,IAAI,kBAAkB,CAAC,GAAG,CAAC,GAAG,SAAS;IAI7C,gBAAgB,IAAI,OAAO,CAAC,UAAU,EAAE,CAAC;IAU/C,SAAS,IAAI,OAAO,CAAC,IAAI,CAAC;IAK1B,SAAS,CAAC,QAAQ,IACd,CAAC,CAAC,MAAM,EAAE,cAAc,EAAE,EAAE,QAAQ,EAAE,cAAc,EAAE,EAAE,KAAK,EAAE,YAAY,KAAK,OAAO,CAAC,YAAY,CAAC,CAAC,GACtG,SAAS;IAIb,SAAS,CAAC,kBAAkB,CAAC,OAAO,EAAE,wBAAwB,CAAC,GAAG,CAAC,GAAG,qBAAqB,EAAE;CAG9F"}
package/out/lint/linters/manifest-linter/abstract-manifest-linter.js CHANGED
@@ -27,12 +27,12 @@ class AbstractManifestLinter extends abstract_linter_1.AbstractLinter {
27
27
  getProcessor() {
28
28
  return this.processor;
29
29
  }
30
- batchExecuteImpl() {
30
+ async batchExecuteImpl() {
31
31
  if (!this.processor) {
32
32
  throw new Error('Bootstrap failed');
33
33
  }
34
- const results = this.processor.process();
35
- return Promise.resolve([this.mapManifestResponse(results, this.getFixer())]);
34
+ const results = await this.processor.process();
35
+ return [this.mapManifestResponse(results, this.getFixer())];
36
36
  }
37
37
  bootstrap() {
38
38
  this.processor = manifest_1.ProcessorBuilder.instance().withValidation(this.type).build();
package/out/lint/linters/permission-linter/verifiers/content-property-verifier.d.ts.map CHANGED
@@ -1 +1 @@
1
- {"version":3,"file":"content-property-verifier.d.ts","sourceRoot":"","sources":["../../../../../src/lint/linters/permission-linter/verifiers/content-property-verifier.ts"],"names":[],"mappings":"AAEA,OAAO,EAAE,SAAS,EAAE,cAAc,EAAE,MAAM,2BAA2B,CAAC;AAEtE,OAAO,EAAE,qBAAqB,EAAE,iBAAiB,EAAE,MAAM,0BAA0B,CAAC;AACpF,OAAO,EAAE,sBAAsB,EAAE,MAAM,uBAAuB,CAAC;AAC/D,OAAO,EAAoB,cAAc,EAAE,MAAM,iBAAiB,CAAC;AAEnE,eAAO,MAAM,gCAAgC,EAAE,MAAM,CAAC,MAAM,EAAE,MAAM,CAAC,MAAM,EAAE,cAAc,CAAC,CAyD3F,CAAC;AAEF,qBAAa,uBACX,SAAQ,qBACR,YAAW,iBAAiB,CAAC,sBAAsB,EAAE,CAAC;IACtD,SAAS,CAAC,YAAY,IAAI,SAAS;IAItB,OAAO,CAAC,QAAQ,EAAE,sBAAsB,EAAE,GAAG,OAAO,CAAC,cAAc,EAAE,CAAC;IAuBnF,OAAO,CAAC,gBAAgB;CAKzB"}
1
+ {"version":3,"file":"content-property-verifier.d.ts","sourceRoot":"","sources":["../../../../../src/lint/linters/permission-linter/verifiers/content-property-verifier.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,SAAS,EAAE,cAAc,EAAE,MAAM,2BAA2B,CAAC;AAEtE,OAAO,EAAE,qBAAqB,EAAE,iBAAiB,EAAE,MAAM,0BAA0B,CAAC;AACpF,OAAO,EAAE,sBAAsB,EAAE,MAAM,uBAAuB,CAAC;AAC/D,OAAO,EAAoB,cAAc,EAAE,MAAM,iBAAiB,CAAC;AAEnE,eAAO,MAAM,gCAAgC,EAAE,MAAM,CAAC,MAAM,EAAE,MAAM,CAAC,MAAM,EAAE,cAAc,CAAC,CAyD3F,CAAC;AAEF,qBAAa,uBACX,SAAQ,qBACR,YAAW,iBAAiB,CAAC,sBAAsB,EAAE,CAAC;IACtD,SAAS,CAAC,YAAY,IAAI,SAAS;IAItB,OAAO,CAAC,QAAQ,EAAE,sBAAsB,EAAE,GAAG,OAAO,CAAC,cAAc,EAAE,CAAC;IAsBnF,OAAO,CAAC,gBAAgB;CAKzB"}
package/out/lint/linters/permission-linter/verifiers/content-property-verifier.js CHANGED
@@ -1,7 +1,6 @@
1
1
  "use strict";
2
2
  Object.defineProperty(exports, "__esModule", { value: true });
3
3
  exports.ContentPropertyVerifier = exports.CONTENT_PROPERTY_PERMISSIONS_MAP = void 0;
4
- const cli_shared_1 = require("@forge/cli-shared");
5
4
  const linter_interface_1 = require("../../../linter-interface");
6
5
  const text_1 = require("../../../text");
7
6
  const verifier_interface_1 = require("../../verifier-interface");
@@ -69,20 +68,24 @@ class ContentPropertyVerifier extends verifier_interface_1.BaseLintIssueVerifier
69
68
  return linter_interface_1.LintClass.Error;
70
69
  }
71
70
  async process(apiCalls) {
72
- const lintErrors = apiCalls
73
- .map((apiCall) => (Object.assign(Object.assign({}, apiCall), { missingScopes: this.getMissingScopes(apiCall) })))
74
- .filter(({ missingScopes }) => missingScopes.length)
75
- .map(({ context, method, line, column, missingScopes }) => missingScopes.map((missingScope) => ({
76
- class: this.getLintClass(),
77
- message: text_1.messages.verifiers.contentProperty.message(context, method, missingScope),
78
- reference: text_1.messages.verifiers.contentProperty.reference,
79
- column,
80
- line,
81
- metadata: {
82
- missingPermission: missingScope
71
+ const lintErrors = [];
72
+ for (const apiCall of apiCalls) {
73
+ const missingScopes = await this.getMissingScopes(apiCall);
74
+ for (const missingScope of missingScopes) {
75
+ const { context, method, line, column } = apiCall;
76
+ lintErrors.push({
77
+ class: this.getLintClass(),
78
+ message: text_1.messages.verifiers.contentProperty.message(context, method, missingScope),
79
+ reference: text_1.messages.verifiers.contentProperty.reference,
80
+ column,
81
+ line,
82
+ metadata: {
83
+ missingPermission: missingScope
84
+ }
85
+ });
83
86
  }
84
- })));
85
- return cli_shared_1.flat(lintErrors);
87
+ }
88
+ return lintErrors;
86
89
  }
87
90
  getMissingScopes({ context, method }) {
88
91
  var _a, _b;
package/out/lint/linters/permission-linter/verifiers/external-fetch-verifier.d.ts CHANGED
@@ -3,6 +3,7 @@ import { LintClass, LintResultRule } from '../../../linter-interface';
3
3
  import { BaseLintIssueVerifier, LintIssueVerifier } from '../../verifier-interface';
4
4
  import { ExternalApiCall } from '../api-call-interface';
5
5
  export declare class ExternalFetchVerifier extends BaseLintIssueVerifier implements LintIssueVerifier<ExternalApiCall[]> {
6
+ private egressFilteringService;
6
7
  constructor(environment: string, manifest: Manifest);
7
8
  protected getLintClass(): LintClass;
8
9
  private extractDomain;
package/out/lint/linters/permission-linter/verifiers/external-fetch-verifier.d.ts.map CHANGED
@@ -1 +1 @@
1
- {"version":3,"file":"external-fetch-verifier.d.ts","sourceRoot":"","sources":["../../../../../src/lint/linters/permission-linter/verifiers/external-fetch-verifier.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,cAAc,IAAI,QAAQ,EAAE,MAAM,iBAAiB,CAAC;AAElE,OAAO,EAAE,SAAS,EAAE,cAAc,EAAE,MAAM,2BAA2B,CAAC;AACtE,OAAO,EAAE,qBAAqB,EAAE,iBAAiB,EAAE,MAAM,0BAA0B,CAAC;AACpF,OAAO,EAAE,eAAe,EAAE,MAAM,uBAAuB,CAAC;AAIxD,qBAAa,qBAAsB,SAAQ,qBAAsB,YAAW,iBAAiB,CAAC,eAAe,EAAE,CAAC;gBAClG,WAAW,EAAE,MAAM,EAAE,QAAQ,EAAE,QAAQ;IAInD,SAAS,CAAC,YAAY,IAAI,SAAS;IAInC,OAAO,CAAC,aAAa,CAMnB;IAEW,OAAO,CAAC,UAAU,EAAE,eAAe,EAAE,GAAG,OAAO,CAAC,cAAc,EAAE,CAAC;CAY/E"}
1
+ {"version":3,"file":"external-fetch-verifier.d.ts","sourceRoot":"","sources":["../../../../../src/lint/linters/permission-linter/verifiers/external-fetch-verifier.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,cAAc,IAAI,QAAQ,EAAE,MAAM,iBAAiB,CAAC;AAGlE,OAAO,EAAE,SAAS,EAAE,cAAc,EAAE,MAAM,2BAA2B,CAAC;AACtE,OAAO,EAAE,qBAAqB,EAAE,iBAAiB,EAAE,MAAM,0BAA0B,CAAC;AACpF,OAAO,EAAE,eAAe,EAAE,MAAM,uBAAuB,CAAC;AAIxD,qBAAa,qBAAsB,SAAQ,qBAAsB,YAAW,iBAAiB,CAAC,eAAe,EAAE,CAAC;IAC9G,OAAO,CAAC,sBAAsB,CAAyB;gBAE3C,WAAW,EAAE,MAAM,EAAE,QAAQ,EAAE,QAAQ;IAenD,SAAS,CAAC,YAAY,IAAI,SAAS;IAInC,OAAO,CAAC,aAAa,CAMnB;IAEW,OAAO,CAAC,UAAU,EAAE,eAAe,EAAE,GAAG,OAAO,CAAC,cAAc,EAAE,CAAC;CAc/E"}
package/out/lint/linters/permission-linter/verifiers/external-fetch-verifier.js CHANGED
@@ -1,12 +1,14 @@
1
1
  "use strict";
2
2
  Object.defineProperty(exports, "__esModule", { value: true });
3
3
  exports.ExternalFetchVerifier = void 0;
4
+ const csp_1 = require("@forge/csp");
4
5
  const linter_interface_1 = require("../../../linter-interface");
5
6
  const verifier_interface_1 = require("../../verifier-interface");
6
7
  const text_1 = require("../../../text");
7
8
  const url_1 = require("url");
8
9
  class ExternalFetchVerifier extends verifier_interface_1.BaseLintIssueVerifier {
9
10
  constructor(environment, manifest) {
11
+ var _a, _b, _c, _d, _e, _f, _g;
10
12
  super(environment, manifest);
11
13
  this.extractDomain = (fetchCall) => {
12
14
  try {
@@ -16,12 +18,21 @@ class ExternalFetchVerifier extends verifier_interface_1.BaseLintIssueVerifier {
16
18
  return fetchCall.url;
17
19
  }
18
20
  };
21
+ const allowList = (_e = (_d = (_c = (_b = (_a = this.manifest) === null || _a === void 0 ? void 0 : _a.permissions) === null || _b === void 0 ? void 0 : _b.external) === null || _c === void 0 ? void 0 : _c.fetch) === null || _d === void 0 ? void 0 : _d.backend) !== null && _e !== void 0 ? _e : [];
22
+ const remoteList = (_g = (_f = this.manifest) === null || _f === void 0 ? void 0 : _f.remotes) !== null && _g !== void 0 ? _g : [];
23
+ const collectedUrls = allowList.filter((item) => typeof item === 'string');
24
+ const collectedRemotes = allowList
25
+ .map((item) => { var _a; return typeof item !== 'string' && ((_a = remoteList.find((remoteItem) => remoteItem.key === item.remote)) === null || _a === void 0 ? void 0 : _a.baseUrl); })
26
+ .filter((x) => typeof x === 'string');
27
+ this.egressFilteringService = new csp_1.EgressFilteringService(collectedUrls.concat(collectedRemotes));
19
28
  }
20
29
  getLintClass() {
21
30
  return linter_interface_1.LintClass.Error;
22
31
  }
23
32
  async process(fetchCalls) {
24
- return fetchCalls.map((fetchCall) => ({
33
+ return fetchCalls
34
+ .filter(({ url }) => !this.egressFilteringService.isValidUrl(url))
35
+ .map((fetchCall) => ({
25
36
  class: this.getLintClass(),
26
37
  message: text_1.messages.verifiers.externalFetch.message(fetchCall.url),
27
38
  reference: text_1.messages.verifiers.externalFetch.reference,
package/out/lint/linters/permission-linter/verifiers/product-verifier.d.ts.map CHANGED
@@ -1 +1 @@
1
- {"version":3,"file":"product-verifier.d.ts","sourceRoot":"","sources":["../../../../../src/lint/linters/permission-linter/verifiers/product-verifier.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,cAAc,EAAE,SAAS,EAAE,MAAM,2BAA2B,CAAC;AACtE,OAAO,EAAE,OAAO,EAAE,cAAc,EAAE,MAAM,uBAAuB,CAAC;AAChE,OAAO,EAAE,iBAAiB,EAAE,qBAAqB,EAAE,MAAM,0BAA0B,CAAC;AAGpF,OAAO,EAAE,cAAc,IAAI,QAAQ,EAAoB,MAAM,iBAAiB,CAAC;AAE/E,OAAO,EAAE,OAAO,EAAE,MAAM,mBAAmB,CAAC;AAC5C,OAAO,qBAAqB,GAAG,OAAO,CAAC,qBAAqB,CAAC;AAE7D,MAAM,WAAW,aAAa;IAC5B,YAAY,EAAE,MAAM,CAAC;IACrB,OAAO,EAAE,WAAW,CAAC;CACtB;AAED,MAAM,WAAW,WAAW;IAC1B,CAAC,MAAM,EAAE,MAAM,GAAG;QAChB,QAAQ,EAAE,aAAa,EAAE,CAAC;QAC1B,2BAA2B,CAAC,EAAE,qBAAqB,EAAE,CAAC;KACvD,CAAC;CACH;AAED,UAAU,aAAa;IACrB,CAAC,QAAQ,EAAE,MAAM,GAAG,MAAM,EAAE,CAAC;CAC9B;AAED,oBAAY,uBAAuB,GAAG,GAAG,CAAC,MAAM,EAAE,aAAa,CAAC,CAAC;AAEjE,qBAAa,eAAgB,SAAQ,qBAAsB,YAAW,iBAAiB,CAAC,OAAO,EAAE,CAAC;IAI9F,OAAO,CAAC,QAAQ,CAAC,OAAO;IACxB,OAAO,CAAC,QAAQ,CAAC,OAAO;gBAHxB,WAAW,EAAE,MAAM,EACnB,QAAQ,EAAE,QAAQ,EACD,OAAO,EAAE,uBAAuB,EAChC,OAAO,EAAE,MAAM;IAKlC,SAAS,CAAC,YAAY,IAAI,SAAS;IAItB,OAAO,CAAC,QAAQ,EAAE,cAAc,EAAE,GAAG,OAAO,CAAC,cAAc,EAAE,CAAC;IAoC3E,OAAO,CAAC,aAAa;IAerB,OAAO,CAAC,0BAA0B;IAOlC,OAAO,CAAC,iBAAiB;IAqBzB,OAAO,CAAC,aAAa;CAWtB"}
1
+ {"version":3,"file":"product-verifier.d.ts","sourceRoot":"","sources":["../../../../../src/lint/linters/permission-linter/verifiers/product-verifier.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,cAAc,EAAE,SAAS,EAAE,MAAM,2BAA2B,CAAC;AACtE,OAAO,EAAE,OAAO,EAAE,cAAc,EAAE,MAAM,uBAAuB,CAAC;AAChE,OAAO,EAAE,iBAAiB,EAAE,qBAAqB,EAAE,MAAM,0BAA0B,CAAC;AAGpF,OAAO,EAAE,cAAc,IAAI,QAAQ,EAAoB,MAAM,iBAAiB,CAAC;AAE/E,OAAO,EAAE,OAAO,EAAE,MAAM,mBAAmB,CAAC;AAC5C,OAAO,qBAAqB,GAAG,OAAO,CAAC,qBAAqB,CAAC;AAE7D,MAAM,WAAW,aAAa;IAC5B,YAAY,EAAE,MAAM,CAAC;IACrB,OAAO,EAAE,WAAW,CAAC;CACtB;AAED,MAAM,WAAW,WAAW;IAC1B,CAAC,MAAM,EAAE,MAAM,GAAG;QAChB,QAAQ,EAAE,aAAa,EAAE,CAAC;QAC1B,2BAA2B,CAAC,EAAE,qBAAqB,EAAE,CAAC;KACvD,CAAC;CACH;AAED,UAAU,aAAa;IACrB,CAAC,QAAQ,EAAE,MAAM,GAAG,MAAM,EAAE,CAAC;CAC9B;AAED,oBAAY,uBAAuB,GAAG,GAAG,CAAC,MAAM,EAAE,aAAa,CAAC,CAAC;AAEjE,qBAAa,eAAgB,SAAQ,qBAAsB,YAAW,iBAAiB,CAAC,OAAO,EAAE,CAAC;IAI9F,OAAO,CAAC,QAAQ,CAAC,OAAO;IACxB,OAAO,CAAC,QAAQ,CAAC,OAAO;gBAHxB,WAAW,EAAE,MAAM,EACnB,QAAQ,EAAE,QAAQ,EACD,OAAO,EAAE,uBAAuB,EAChC,OAAO,EAAE,MAAM;IAKlC,SAAS,CAAC,YAAY,IAAI,SAAS;IAItB,OAAO,CAAC,QAAQ,EAAE,cAAc,EAAE,GAAG,OAAO,CAAC,cAAc,EAAE,CAAC;IAuC3E,OAAO,CAAC,aAAa;IAerB,OAAO,CAAC,0BAA0B;IAOlC,OAAO,CAAC,iBAAiB;IAqBzB,OAAO,CAAC,aAAa;CAWtB"}
package/out/lint/linters/permission-linter/verifiers/product-verifier.js CHANGED
@@ -18,18 +18,21 @@ class ProductVerifier extends verifier_interface_1.BaseLintIssueVerifier {
18
18
  return linter_interface_1.LintClass.Error;
19
19
  }
20
20
  async process(apiCalls) {
21
+ var _a;
21
22
  const rules = [];
22
23
  const lintCriteriaMatches = new Set();
23
- apiCalls.forEach((apiCall) => {
24
+ for (const apiCall of apiCalls) {
24
25
  const apiCallLookupResult = this.lookupApiCall(apiCall);
25
- apiCallLookupResult && lintCriteriaMatches.add(apiCallLookupResult);
26
- });
27
- lintCriteriaMatches.forEach((apiCall) => {
28
- const missingScopes = this.getMissingPermissionScopes(apiCall);
29
- missingScopes.forEach((permission) => {
30
- var _a;
31
- if (!(apiCall === null || apiCall === void 0 ? void 0 : apiCall.regex))
32
- return;
26
+ if (apiCallLookupResult) {
27
+ lintCriteriaMatches.add(apiCallLookupResult);
28
+ }
29
+ }
30
+ for (const apiCall of lintCriteriaMatches) {
31
+ if (!(apiCall === null || apiCall === void 0 ? void 0 : apiCall.regex)) {
32
+ continue;
33
+ }
34
+ const missingScopes = await this.getMissingPermissionScopes(apiCall);
35
+ for (const permission of missingScopes) {
33
36
  rules.push({
34
37
  class: this.getLintClass(),
35
38
  message: text_1.messages.verifiers.product.message(cli_shared_1.capitalise(this.product), apiCall.method.toUpperCase(), (_a = this.pathMap.get(apiCall.regex)) === null || _a === void 0 ? void 0 : _a.originalPath, permission),
@@ -40,8 +43,8 @@ class ProductVerifier extends verifier_interface_1.BaseLintIssueVerifier {
40
43
  missingPermission: permission
41
44
  }
42
45
  });
43
- });
44
- });
46
+ }
47
+ }
45
48
  return rules;
46
49
  }
47
50
  lookupApiCall(apiCall) {
package/out/lint/linters/permission-linter/verifiers/ui-hook-verifier.js CHANGED
@@ -30,7 +30,7 @@ class UIHookVerifier extends verifier_interface_1.BaseLintIssueVerifier {
30
30
  const requiredPermissions = FORGE_UI_HOOK_PERMISSIONS[apiCall.hookName];
31
31
  if (!requiredPermissions)
32
32
  return rules;
33
- const missingPermissions = manifest_1.getMissingScopes((_a = this.manifest.permissions) === null || _a === void 0 ? void 0 : _a.scopes, requiredPermissions);
33
+ const missingPermissions = await manifest_1.getMissingScopes((_a = this.manifest.permissions) === null || _a === void 0 ? void 0 : _a.scopes, requiredPermissions);
34
34
  missingPermissions.forEach((perm) => rules.push(this.getHookRule(apiCall, perm)));
35
35
  }
36
36
  return rules;
package/package.json CHANGED
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "@forge/lint",
3
- "version": "0.0.0-experimental-e3032d7",
3
+ "version": "0.0.0-experimental-9489df9",
4
4
  "description": "Linting for forge apps",
5
5
  "main": "out/index.js",
6
6
  "license": "UNLICENSED",
@@ -15,8 +15,9 @@
15
15
  "@types/node-fetch": "^2.5.7"
16
16
  },
17
17
  "dependencies": {
18
- "@forge/cli-shared": "0.0.0-experimental-e3032d7",
19
- "@forge/manifest": "0.0.0-experimental-e3032d7",
18
+ "@forge/cli-shared": "0.0.0-experimental-9489df9",
19
+ "@forge/csp": "1.11.0",
20
+ "@forge/manifest": "0.0.0-experimental-9489df9",
20
21
  "@typescript-eslint/typescript-estree": "^3.5.0",
21
22
  "cross-spawn": "^7.0.1",
22
23
  "node-fetch": "2.6.1",