@forge/lint 0.0.0-experimental-c3effe3 → 0.0.0-experimental-fbe27f8

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (12) hide show
  1. package/CHANGELOG.md +138 -4
  2. package/out/lint/linters/manifest-linter/abstract-manifest-linter.d.ts.map +1 -1
  3. package/out/lint/linters/manifest-linter/abstract-manifest-linter.js +3 -3
  4. package/out/lint/linters/permission-linter/verifiers/content-property-verifier.d.ts.map +1 -1
  5. package/out/lint/linters/permission-linter/verifiers/content-property-verifier.js +17 -14
  6. package/out/lint/linters/permission-linter/verifiers/external-fetch-verifier.d.ts +1 -0
  7. package/out/lint/linters/permission-linter/verifiers/external-fetch-verifier.d.ts.map +1 -1
  8. package/out/lint/linters/permission-linter/verifiers/external-fetch-verifier.js +12 -1
  9. package/out/lint/linters/permission-linter/verifiers/product-verifier.d.ts.map +1 -1
  10. package/out/lint/linters/permission-linter/verifiers/product-verifier.js +14 -11
  11. package/out/lint/linters/permission-linter/verifiers/ui-hook-verifier.js +1 -1
  12. package/package.json +4 -3
package/CHANGELOG.md CHANGED
@@ -1,6 +1,141 @@
1
1
  # @forge/lint
2
2
 
3
- ## 0.0.0-experimental-c3effe3
3
+ ## 0.0.0-experimental-fbe27f8
4
+
5
+ ### Patch Changes
6
+
7
+ - Updated dependencies [c0c88f0]
8
+ - Updated dependencies [6728c67]
9
+ - Updated dependencies [c1c93a4]
10
+ - Updated dependencies [b1684fd]
11
+ - @forge/manifest@0.0.0-experimental-fbe27f8
12
+ - @forge/cli-shared@0.0.0-experimental-fbe27f8
13
+
14
+ ## 3.2.2-next.5
15
+
16
+ ### Patch Changes
17
+
18
+ - Updated dependencies [c0c88f09]
19
+ - @forge/manifest@4.0.0-next.5
20
+ - @forge/cli-shared@2.6.2-next.5
21
+
22
+ ## 3.2.2-next.4
23
+
24
+ ### Patch Changes
25
+
26
+ - Updated dependencies [b1684fd]
27
+ - @forge/manifest@4.0.0-next.4
28
+ - @forge/cli-shared@2.6.2-next.4
29
+
30
+ ## 3.2.2-next.3
31
+
32
+ ### Patch Changes
33
+
34
+ - Updated dependencies [6728c67]
35
+ - @forge/manifest@4.0.0-next.3
36
+ - @forge/cli-shared@2.6.2-next.3
37
+
38
+ ## 3.2.2-next.2
39
+
40
+ ### Patch Changes
41
+
42
+ - Updated dependencies [0da5775]
43
+ - @forge/manifest@3.11.0-next.2
44
+ - @forge/cli-shared@2.6.2-next.2
45
+
46
+ ## 3.2.2-next.1
47
+
48
+ ### Patch Changes
49
+
50
+ - Updated dependencies [acf78b58]
51
+ - @forge/manifest@3.11.0-next.1
52
+ - @forge/cli-shared@2.6.2-next.1
53
+
54
+ ## 3.2.2-next.0
55
+
56
+ ### Patch Changes
57
+
58
+ - Updated dependencies [c1c93a4]
59
+ - @forge/manifest@3.10.1-next.0
60
+ - @forge/cli-shared@2.6.2-next.0
61
+
62
+ ## 3.2.1
63
+
64
+ ### Patch Changes
65
+
66
+ - Updated dependencies [02aefee]
67
+ - Updated dependencies [d486898]
68
+ - Updated dependencies [f890e0e]
69
+ - Updated dependencies [9298536]
70
+ - Updated dependencies [ee8d860]
71
+ - Updated dependencies [2ae0afe]
72
+ - Updated dependencies [91daffc]
73
+ - Updated dependencies [7558a5d]
74
+ - Updated dependencies [f543a47]
75
+ - Updated dependencies [8876b96]
76
+ - @forge/manifest@3.10.0
77
+ - @forge/cli-shared@2.6.1
78
+
79
+ ## 3.2.1-next.6
80
+
81
+ ### Patch Changes
82
+
83
+ - Updated dependencies [ee8d860]
84
+ - @forge/manifest@3.10.0-next.6
85
+ - @forge/cli-shared@2.6.1-next.6
86
+
87
+ ## 3.2.1-next.5
88
+
89
+ ### Patch Changes
90
+
91
+ - Updated dependencies [8876b96]
92
+ - @forge/manifest@3.10.0-next.5
93
+ - @forge/cli-shared@2.6.1-next.5
94
+
95
+ ## 3.2.1-next.4
96
+
97
+ ### Patch Changes
98
+
99
+ - Updated dependencies [9298536]
100
+ - @forge/manifest@3.10.0-next.4
101
+ - @forge/cli-shared@2.6.1-next.4
102
+
103
+ ## 3.2.1-next.3
104
+
105
+ ### Patch Changes
106
+
107
+ - Updated dependencies [d486898]
108
+ - Updated dependencies [f890e0e]
109
+ - Updated dependencies [91daffc]
110
+ - @forge/manifest@3.10.0-next.3
111
+ - @forge/cli-shared@2.6.1-next.3
112
+
113
+ ## 3.2.1-next.2
114
+
115
+ ### Patch Changes
116
+
117
+ - Updated dependencies [7558a5d9]
118
+ - @forge/manifest@3.9.1-next.2
119
+ - @forge/cli-shared@2.6.1-next.2
120
+
121
+ ## 3.2.1-next.1
122
+
123
+ ### Patch Changes
124
+
125
+ - Updated dependencies [02aefee]
126
+ - Updated dependencies [f543a47]
127
+ - @forge/manifest@3.9.1-next.1
128
+ - @forge/cli-shared@2.6.1-next.1
129
+
130
+ ## 3.2.1-next.0
131
+
132
+ ### Patch Changes
133
+
134
+ - Updated dependencies [2ae0afe]
135
+ - @forge/manifest@3.9.1-next.0
136
+ - @forge/cli-shared@2.6.1-next.0
137
+
138
+ ## 3.2.0
4
139
 
5
140
  ### Minor Changes
6
141
 
@@ -11,11 +146,10 @@
11
146
  - 7fe19b4: More resilient linting against handler exports
12
147
  - Updated dependencies [69f42bd]
13
148
  - Updated dependencies [b447be2]
14
- - Updated dependencies [189ba71]
15
149
  - Updated dependencies [4285fc3]
16
150
  - Updated dependencies [74e00c8]
17
- - @forge/cli-shared@0.0.0-experimental-c3effe3
18
- - @forge/manifest@0.0.0-experimental-c3effe3
151
+ - @forge/cli-shared@2.6.0
152
+ - @forge/manifest@3.9.0
19
153
 
20
154
  ## 3.2.0-next.5
21
155
 
package/out/lint/linters/manifest-linter/abstract-manifest-linter.d.ts.map CHANGED
@@ -1 +1 @@
1
- {"version":3,"file":"abstract-manifest-linter.d.ts","sourceRoot":"","sources":["../../../../src/lint/linters/manifest-linter/abstract-manifest-linter.ts"],"names":[],"mappings":"AAAA,OAAO,EACL,eAAe,EAGf,wBAAwB,EACxB,kBAAkB,EAClB,qBAAqB,EACtB,MAAM,iBAAiB,CAAC;AACzB,OAAO,EAAE,UAAU,EAAE,cAAc,EAAE,YAAY,EAAa,UAAU,EAAE,MAAM,wBAAwB,CAAC;AACzG,OAAO,EAAE,cAAc,EAAE,MAAM,uBAAuB,CAAC;AAEvD,qBAAa,sBAAuB,SAAQ,cAAc;IAG5C,OAAO,CAAC,QAAQ,CAAC,IAAI;IAFjC,OAAO,CAAC,SAAS,CAAsC;gBAE1B,IAAI,EAAE,eAAe,EAAE,MAAM,EAAE,UAAU;IAItE,OAAO,CAAC,mBAAmB;IAmB3B,YAAY,IAAI,kBAAkB,CAAC,GAAG,CAAC,GAAG,SAAS;IAInD,gBAAgB,IAAI,OAAO,CAAC,UAAU,EAAE,CAAC;IAUzC,SAAS,IAAI,OAAO,CAAC,IAAI,CAAC;IAK1B,SAAS,CAAC,QAAQ,IACd,CAAC,CAAC,MAAM,EAAE,cAAc,EAAE,EAAE,QAAQ,EAAE,cAAc,EAAE,EAAE,KAAK,EAAE,YAAY,KAAK,OAAO,CAAC,YAAY,CAAC,CAAC,GACtG,SAAS;IAIb,SAAS,CAAC,kBAAkB,CAAC,OAAO,EAAE,wBAAwB,CAAC,GAAG,CAAC,GAAG,qBAAqB,EAAE;CAG9F"}
1
+ {"version":3,"file":"abstract-manifest-linter.d.ts","sourceRoot":"","sources":["../../../../src/lint/linters/manifest-linter/abstract-manifest-linter.ts"],"names":[],"mappings":"AAAA,OAAO,EACL,eAAe,EAGf,wBAAwB,EACxB,kBAAkB,EAClB,qBAAqB,EACtB,MAAM,iBAAiB,CAAC;AACzB,OAAO,EAAE,UAAU,EAAE,cAAc,EAAE,YAAY,EAAa,UAAU,EAAE,MAAM,wBAAwB,CAAC;AACzG,OAAO,EAAE,cAAc,EAAE,MAAM,uBAAuB,CAAC;AAEvD,qBAAa,sBAAuB,SAAQ,cAAc;IAG5C,OAAO,CAAC,QAAQ,CAAC,IAAI;IAFjC,OAAO,CAAC,SAAS,CAAsC;gBAE1B,IAAI,EAAE,eAAe,EAAE,MAAM,EAAE,UAAU;IAItE,OAAO,CAAC,mBAAmB;IAmB3B,YAAY,IAAI,kBAAkB,CAAC,GAAG,CAAC,GAAG,SAAS;IAI7C,gBAAgB,IAAI,OAAO,CAAC,UAAU,EAAE,CAAC;IAU/C,SAAS,IAAI,OAAO,CAAC,IAAI,CAAC;IAK1B,SAAS,CAAC,QAAQ,IACd,CAAC,CAAC,MAAM,EAAE,cAAc,EAAE,EAAE,QAAQ,EAAE,cAAc,EAAE,EAAE,KAAK,EAAE,YAAY,KAAK,OAAO,CAAC,YAAY,CAAC,CAAC,GACtG,SAAS;IAIb,SAAS,CAAC,kBAAkB,CAAC,OAAO,EAAE,wBAAwB,CAAC,GAAG,CAAC,GAAG,qBAAqB,EAAE;CAG9F"}
package/out/lint/linters/manifest-linter/abstract-manifest-linter.js CHANGED
@@ -27,12 +27,12 @@ class AbstractManifestLinter extends abstract_linter_1.AbstractLinter {
27
27
  getProcessor() {
28
28
  return this.processor;
29
29
  }
30
- batchExecuteImpl() {
30
+ async batchExecuteImpl() {
31
31
  if (!this.processor) {
32
32
  throw new Error('Bootstrap failed');
33
33
  }
34
- const results = this.processor.process();
35
- return Promise.resolve([this.mapManifestResponse(results, this.getFixer())]);
34
+ const results = await this.processor.process();
35
+ return [this.mapManifestResponse(results, this.getFixer())];
36
36
  }
37
37
  bootstrap() {
38
38
  this.processor = manifest_1.ProcessorBuilder.instance().withValidation(this.type).build();
package/out/lint/linters/permission-linter/verifiers/content-property-verifier.d.ts.map CHANGED
@@ -1 +1 @@
1
- {"version":3,"file":"content-property-verifier.d.ts","sourceRoot":"","sources":["../../../../../src/lint/linters/permission-linter/verifiers/content-property-verifier.ts"],"names":[],"mappings":"AAEA,OAAO,EAAE,SAAS,EAAE,cAAc,EAAE,MAAM,2BAA2B,CAAC;AAEtE,OAAO,EAAE,qBAAqB,EAAE,iBAAiB,EAAE,MAAM,0BAA0B,CAAC;AACpF,OAAO,EAAE,sBAAsB,EAAE,MAAM,uBAAuB,CAAC;AAC/D,OAAO,EAAoB,cAAc,EAAE,MAAM,iBAAiB,CAAC;AAEnE,eAAO,MAAM,gCAAgC,EAAE,MAAM,CAAC,MAAM,EAAE,MAAM,CAAC,MAAM,EAAE,cAAc,CAAC,CAyD3F,CAAC;AAEF,qBAAa,uBACX,SAAQ,qBACR,YAAW,iBAAiB,CAAC,sBAAsB,EAAE,CAAC;IACtD,SAAS,CAAC,YAAY,IAAI,SAAS;IAItB,OAAO,CAAC,QAAQ,EAAE,sBAAsB,EAAE,GAAG,OAAO,CAAC,cAAc,EAAE,CAAC;IAuBnF,OAAO,CAAC,gBAAgB;CAKzB"}
1
+ {"version":3,"file":"content-property-verifier.d.ts","sourceRoot":"","sources":["../../../../../src/lint/linters/permission-linter/verifiers/content-property-verifier.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,SAAS,EAAE,cAAc,EAAE,MAAM,2BAA2B,CAAC;AAEtE,OAAO,EAAE,qBAAqB,EAAE,iBAAiB,EAAE,MAAM,0BAA0B,CAAC;AACpF,OAAO,EAAE,sBAAsB,EAAE,MAAM,uBAAuB,CAAC;AAC/D,OAAO,EAAoB,cAAc,EAAE,MAAM,iBAAiB,CAAC;AAEnE,eAAO,MAAM,gCAAgC,EAAE,MAAM,CAAC,MAAM,EAAE,MAAM,CAAC,MAAM,EAAE,cAAc,CAAC,CAyD3F,CAAC;AAEF,qBAAa,uBACX,SAAQ,qBACR,YAAW,iBAAiB,CAAC,sBAAsB,EAAE,CAAC;IACtD,SAAS,CAAC,YAAY,IAAI,SAAS;IAItB,OAAO,CAAC,QAAQ,EAAE,sBAAsB,EAAE,GAAG,OAAO,CAAC,cAAc,EAAE,CAAC;IAsBnF,OAAO,CAAC,gBAAgB;CAKzB"}
package/out/lint/linters/permission-linter/verifiers/content-property-verifier.js CHANGED
@@ -1,7 +1,6 @@
1
1
  "use strict";
2
2
  Object.defineProperty(exports, "__esModule", { value: true });
3
3
  exports.ContentPropertyVerifier = exports.CONTENT_PROPERTY_PERMISSIONS_MAP = void 0;
4
- const cli_shared_1 = require("@forge/cli-shared");
5
4
  const linter_interface_1 = require("../../../linter-interface");
6
5
  const text_1 = require("../../../text");
7
6
  const verifier_interface_1 = require("../../verifier-interface");
@@ -69,20 +68,24 @@ class ContentPropertyVerifier extends verifier_interface_1.BaseLintIssueVerifier
69
68
  return linter_interface_1.LintClass.Error;
70
69
  }
71
70
  async process(apiCalls) {
72
- const lintErrors = apiCalls
73
- .map((apiCall) => (Object.assign(Object.assign({}, apiCall), { missingScopes: this.getMissingScopes(apiCall) })))
74
- .filter(({ missingScopes }) => missingScopes.length)
75
- .map(({ context, method, line, column, missingScopes }) => missingScopes.map((missingScope) => ({
76
- class: this.getLintClass(),
77
- message: text_1.messages.verifiers.contentProperty.message(context, method, missingScope),
78
- reference: text_1.messages.verifiers.contentProperty.reference,
79
- column,
80
- line,
81
- metadata: {
82
- missingPermission: missingScope
71
+ const lintErrors = [];
72
+ for (const apiCall of apiCalls) {
73
+ const missingScopes = await this.getMissingScopes(apiCall);
74
+ for (const missingScope of missingScopes) {
75
+ const { context, method, line, column } = apiCall;
76
+ lintErrors.push({
77
+ class: this.getLintClass(),
78
+ message: text_1.messages.verifiers.contentProperty.message(context, method, missingScope),
79
+ reference: text_1.messages.verifiers.contentProperty.reference,
80
+ column,
81
+ line,
82
+ metadata: {
83
+ missingPermission: missingScope
84
+ }
85
+ });
83
86
  }
84
- })));
85
- return cli_shared_1.flat(lintErrors);
87
+ }
88
+ return lintErrors;
86
89
  }
87
90
  getMissingScopes({ context, method }) {
88
91
  var _a, _b;
package/out/lint/linters/permission-linter/verifiers/external-fetch-verifier.d.ts CHANGED
@@ -3,6 +3,7 @@ import { LintClass, LintResultRule } from '../../../linter-interface';
3
3
  import { BaseLintIssueVerifier, LintIssueVerifier } from '../../verifier-interface';
4
4
  import { ExternalApiCall } from '../api-call-interface';
5
5
  export declare class ExternalFetchVerifier extends BaseLintIssueVerifier implements LintIssueVerifier<ExternalApiCall[]> {
6
+ private egressFilteringService;
6
7
  constructor(environment: string, manifest: Manifest);
7
8
  protected getLintClass(): LintClass;
8
9
  private extractDomain;
package/out/lint/linters/permission-linter/verifiers/external-fetch-verifier.d.ts.map CHANGED
@@ -1 +1 @@
1
- {"version":3,"file":"external-fetch-verifier.d.ts","sourceRoot":"","sources":["../../../../../src/lint/linters/permission-linter/verifiers/external-fetch-verifier.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,cAAc,IAAI,QAAQ,EAAE,MAAM,iBAAiB,CAAC;AAElE,OAAO,EAAE,SAAS,EAAE,cAAc,EAAE,MAAM,2BAA2B,CAAC;AACtE,OAAO,EAAE,qBAAqB,EAAE,iBAAiB,EAAE,MAAM,0BAA0B,CAAC;AACpF,OAAO,EAAE,eAAe,EAAE,MAAM,uBAAuB,CAAC;AAIxD,qBAAa,qBAAsB,SAAQ,qBAAsB,YAAW,iBAAiB,CAAC,eAAe,EAAE,CAAC;gBAClG,WAAW,EAAE,MAAM,EAAE,QAAQ,EAAE,QAAQ;IAInD,SAAS,CAAC,YAAY,IAAI,SAAS;IAInC,OAAO,CAAC,aAAa,CAMnB;IAEW,OAAO,CAAC,UAAU,EAAE,eAAe,EAAE,GAAG,OAAO,CAAC,cAAc,EAAE,CAAC;CAY/E"}
1
+ {"version":3,"file":"external-fetch-verifier.d.ts","sourceRoot":"","sources":["../../../../../src/lint/linters/permission-linter/verifiers/external-fetch-verifier.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,cAAc,IAAI,QAAQ,EAAE,MAAM,iBAAiB,CAAC;AAGlE,OAAO,EAAE,SAAS,EAAE,cAAc,EAAE,MAAM,2BAA2B,CAAC;AACtE,OAAO,EAAE,qBAAqB,EAAE,iBAAiB,EAAE,MAAM,0BAA0B,CAAC;AACpF,OAAO,EAAE,eAAe,EAAE,MAAM,uBAAuB,CAAC;AAIxD,qBAAa,qBAAsB,SAAQ,qBAAsB,YAAW,iBAAiB,CAAC,eAAe,EAAE,CAAC;IAC9G,OAAO,CAAC,sBAAsB,CAAyB;gBAE3C,WAAW,EAAE,MAAM,EAAE,QAAQ,EAAE,QAAQ;IAenD,SAAS,CAAC,YAAY,IAAI,SAAS;IAInC,OAAO,CAAC,aAAa,CAMnB;IAEW,OAAO,CAAC,UAAU,EAAE,eAAe,EAAE,GAAG,OAAO,CAAC,cAAc,EAAE,CAAC;CAc/E"}
package/out/lint/linters/permission-linter/verifiers/external-fetch-verifier.js CHANGED
@@ -1,12 +1,14 @@
1
1
  "use strict";
2
2
  Object.defineProperty(exports, "__esModule", { value: true });
3
3
  exports.ExternalFetchVerifier = void 0;
4
+ const csp_1 = require("@forge/csp");
4
5
  const linter_interface_1 = require("../../../linter-interface");
5
6
  const verifier_interface_1 = require("../../verifier-interface");
6
7
  const text_1 = require("../../../text");
7
8
  const url_1 = require("url");
8
9
  class ExternalFetchVerifier extends verifier_interface_1.BaseLintIssueVerifier {
9
10
  constructor(environment, manifest) {
11
+ var _a, _b, _c, _d, _e, _f, _g;
10
12
  super(environment, manifest);
11
13
  this.extractDomain = (fetchCall) => {
12
14
  try {
@@ -16,12 +18,21 @@ class ExternalFetchVerifier extends verifier_interface_1.BaseLintIssueVerifier {
16
18
  return fetchCall.url;
17
19
  }
18
20
  };
21
+ const allowList = (_e = (_d = (_c = (_b = (_a = this.manifest) === null || _a === void 0 ? void 0 : _a.permissions) === null || _b === void 0 ? void 0 : _b.external) === null || _c === void 0 ? void 0 : _c.fetch) === null || _d === void 0 ? void 0 : _d.backend) !== null && _e !== void 0 ? _e : [];
22
+ const remoteList = (_g = (_f = this.manifest) === null || _f === void 0 ? void 0 : _f.remotes) !== null && _g !== void 0 ? _g : [];
23
+ const collectedUrls = allowList.filter((item) => typeof item === 'string');
24
+ const collectedRemotes = allowList
25
+ .map((item) => { var _a; return typeof item !== 'string' && ((_a = remoteList.find((remoteItem) => remoteItem.key === item.remote)) === null || _a === void 0 ? void 0 : _a.baseUrl); })
26
+ .filter((x) => typeof x === 'string');
27
+ this.egressFilteringService = new csp_1.EgressFilteringService(collectedUrls.concat(collectedRemotes));
19
28
  }
20
29
  getLintClass() {
21
30
  return linter_interface_1.LintClass.Error;
22
31
  }
23
32
  async process(fetchCalls) {
24
- return fetchCalls.map((fetchCall) => ({
33
+ return fetchCalls
34
+ .filter(({ url }) => !this.egressFilteringService.isValidUrl(url))
35
+ .map((fetchCall) => ({
25
36
  class: this.getLintClass(),
26
37
  message: text_1.messages.verifiers.externalFetch.message(fetchCall.url),
27
38
  reference: text_1.messages.verifiers.externalFetch.reference,
package/out/lint/linters/permission-linter/verifiers/product-verifier.d.ts.map CHANGED
@@ -1 +1 @@
1
- {"version":3,"file":"product-verifier.d.ts","sourceRoot":"","sources":["../../../../../src/lint/linters/permission-linter/verifiers/product-verifier.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,cAAc,EAAE,SAAS,EAAE,MAAM,2BAA2B,CAAC;AACtE,OAAO,EAAE,OAAO,EAAE,cAAc,EAAE,MAAM,uBAAuB,CAAC;AAChE,OAAO,EAAE,iBAAiB,EAAE,qBAAqB,EAAE,MAAM,0BAA0B,CAAC;AAGpF,OAAO,EAAE,cAAc,IAAI,QAAQ,EAAoB,MAAM,iBAAiB,CAAC;AAE/E,OAAO,EAAE,OAAO,EAAE,MAAM,mBAAmB,CAAC;AAC5C,OAAO,qBAAqB,GAAG,OAAO,CAAC,qBAAqB,CAAC;AAE7D,MAAM,WAAW,aAAa;IAC5B,YAAY,EAAE,MAAM,CAAC;IACrB,OAAO,EAAE,WAAW,CAAC;CACtB;AAED,MAAM,WAAW,WAAW;IAC1B,CAAC,MAAM,EAAE,MAAM,GAAG;QAChB,QAAQ,EAAE,aAAa,EAAE,CAAC;QAC1B,2BAA2B,CAAC,EAAE,qBAAqB,EAAE,CAAC;KACvD,CAAC;CACH;AAED,UAAU,aAAa;IACrB,CAAC,QAAQ,EAAE,MAAM,GAAG,MAAM,EAAE,CAAC;CAC9B;AAED,oBAAY,uBAAuB,GAAG,GAAG,CAAC,MAAM,EAAE,aAAa,CAAC,CAAC;AAEjE,qBAAa,eAAgB,SAAQ,qBAAsB,YAAW,iBAAiB,CAAC,OAAO,EAAE,CAAC;IAI9F,OAAO,CAAC,QAAQ,CAAC,OAAO;IACxB,OAAO,CAAC,QAAQ,CAAC,OAAO;gBAHxB,WAAW,EAAE,MAAM,EACnB,QAAQ,EAAE,QAAQ,EACD,OAAO,EAAE,uBAAuB,EAChC,OAAO,EAAE,MAAM;IAKlC,SAAS,CAAC,YAAY,IAAI,SAAS;IAItB,OAAO,CAAC,QAAQ,EAAE,cAAc,EAAE,GAAG,OAAO,CAAC,cAAc,EAAE,CAAC;IAoC3E,OAAO,CAAC,aAAa;IAerB,OAAO,CAAC,0BAA0B;IAOlC,OAAO,CAAC,iBAAiB;IAqBzB,OAAO,CAAC,aAAa;CAWtB"}
1
+ {"version":3,"file":"product-verifier.d.ts","sourceRoot":"","sources":["../../../../../src/lint/linters/permission-linter/verifiers/product-verifier.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,cAAc,EAAE,SAAS,EAAE,MAAM,2BAA2B,CAAC;AACtE,OAAO,EAAE,OAAO,EAAE,cAAc,EAAE,MAAM,uBAAuB,CAAC;AAChE,OAAO,EAAE,iBAAiB,EAAE,qBAAqB,EAAE,MAAM,0BAA0B,CAAC;AAGpF,OAAO,EAAE,cAAc,IAAI,QAAQ,EAAoB,MAAM,iBAAiB,CAAC;AAE/E,OAAO,EAAE,OAAO,EAAE,MAAM,mBAAmB,CAAC;AAC5C,OAAO,qBAAqB,GAAG,OAAO,CAAC,qBAAqB,CAAC;AAE7D,MAAM,WAAW,aAAa;IAC5B,YAAY,EAAE,MAAM,CAAC;IACrB,OAAO,EAAE,WAAW,CAAC;CACtB;AAED,MAAM,WAAW,WAAW;IAC1B,CAAC,MAAM,EAAE,MAAM,GAAG;QAChB,QAAQ,EAAE,aAAa,EAAE,CAAC;QAC1B,2BAA2B,CAAC,EAAE,qBAAqB,EAAE,CAAC;KACvD,CAAC;CACH;AAED,UAAU,aAAa;IACrB,CAAC,QAAQ,EAAE,MAAM,GAAG,MAAM,EAAE,CAAC;CAC9B;AAED,oBAAY,uBAAuB,GAAG,GAAG,CAAC,MAAM,EAAE,aAAa,CAAC,CAAC;AAEjE,qBAAa,eAAgB,SAAQ,qBAAsB,YAAW,iBAAiB,CAAC,OAAO,EAAE,CAAC;IAI9F,OAAO,CAAC,QAAQ,CAAC,OAAO;IACxB,OAAO,CAAC,QAAQ,CAAC,OAAO;gBAHxB,WAAW,EAAE,MAAM,EACnB,QAAQ,EAAE,QAAQ,EACD,OAAO,EAAE,uBAAuB,EAChC,OAAO,EAAE,MAAM;IAKlC,SAAS,CAAC,YAAY,IAAI,SAAS;IAItB,OAAO,CAAC,QAAQ,EAAE,cAAc,EAAE,GAAG,OAAO,CAAC,cAAc,EAAE,CAAC;IAuC3E,OAAO,CAAC,aAAa;IAerB,OAAO,CAAC,0BAA0B;IAOlC,OAAO,CAAC,iBAAiB;IAqBzB,OAAO,CAAC,aAAa;CAWtB"}
package/out/lint/linters/permission-linter/verifiers/product-verifier.js CHANGED
@@ -18,18 +18,21 @@ class ProductVerifier extends verifier_interface_1.BaseLintIssueVerifier {
18
18
  return linter_interface_1.LintClass.Error;
19
19
  }
20
20
  async process(apiCalls) {
21
+ var _a;
21
22
  const rules = [];
22
23
  const lintCriteriaMatches = new Set();
23
- apiCalls.forEach((apiCall) => {
24
+ for (const apiCall of apiCalls) {
24
25
  const apiCallLookupResult = this.lookupApiCall(apiCall);
25
- apiCallLookupResult && lintCriteriaMatches.add(apiCallLookupResult);
26
- });
27
- lintCriteriaMatches.forEach((apiCall) => {
28
- const missingScopes = this.getMissingPermissionScopes(apiCall);
29
- missingScopes.forEach((permission) => {
30
- var _a;
31
- if (!(apiCall === null || apiCall === void 0 ? void 0 : apiCall.regex))
32
- return;
26
+ if (apiCallLookupResult) {
27
+ lintCriteriaMatches.add(apiCallLookupResult);
28
+ }
29
+ }
30
+ for (const apiCall of lintCriteriaMatches) {
31
+ if (!(apiCall === null || apiCall === void 0 ? void 0 : apiCall.regex)) {
32
+ continue;
33
+ }
34
+ const missingScopes = await this.getMissingPermissionScopes(apiCall);
35
+ for (const permission of missingScopes) {
33
36
  rules.push({
34
37
  class: this.getLintClass(),
35
38
  message: text_1.messages.verifiers.product.message(cli_shared_1.capitalise(this.product), apiCall.method.toUpperCase(), (_a = this.pathMap.get(apiCall.regex)) === null || _a === void 0 ? void 0 : _a.originalPath, permission),
@@ -40,8 +43,8 @@ class ProductVerifier extends verifier_interface_1.BaseLintIssueVerifier {
40
43
  missingPermission: permission
41
44
  }
42
45
  });
43
- });
44
- });
46
+ }
47
+ }
45
48
  return rules;
46
49
  }
47
50
  lookupApiCall(apiCall) {
package/out/lint/linters/permission-linter/verifiers/ui-hook-verifier.js CHANGED
@@ -30,7 +30,7 @@ class UIHookVerifier extends verifier_interface_1.BaseLintIssueVerifier {
30
30
  const requiredPermissions = FORGE_UI_HOOK_PERMISSIONS[apiCall.hookName];
31
31
  if (!requiredPermissions)
32
32
  return rules;
33
- const missingPermissions = manifest_1.getMissingScopes((_a = this.manifest.permissions) === null || _a === void 0 ? void 0 : _a.scopes, requiredPermissions);
33
+ const missingPermissions = await manifest_1.getMissingScopes((_a = this.manifest.permissions) === null || _a === void 0 ? void 0 : _a.scopes, requiredPermissions);
34
34
  missingPermissions.forEach((perm) => rules.push(this.getHookRule(apiCall, perm)));
35
35
  }
36
36
  return rules;
package/package.json CHANGED
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "@forge/lint",
3
- "version": "0.0.0-experimental-c3effe3",
3
+ "version": "0.0.0-experimental-fbe27f8",
4
4
  "description": "Linting for forge apps",
5
5
  "main": "out/index.js",
6
6
  "license": "UNLICENSED",
@@ -15,8 +15,9 @@
15
15
  "@types/node-fetch": "^2.5.7"
16
16
  },
17
17
  "dependencies": {
18
- "@forge/cli-shared": "0.0.0-experimental-c3effe3",
19
- "@forge/manifest": "0.0.0-experimental-c3effe3",
18
+ "@forge/cli-shared": "0.0.0-experimental-fbe27f8",
19
+ "@forge/csp": "1.11.0",
20
+ "@forge/manifest": "0.0.0-experimental-fbe27f8",
20
21
  "@typescript-eslint/typescript-estree": "^3.5.0",
21
22
  "cross-spawn": "^7.0.1",
22
23
  "node-fetch": "2.6.1",