@forge/lint 0.0.0-experimental-4d15129 → 0.0.0-experimental-3b4aabe

package/CHANGELOG.md

@@ -1,6 +1,6 @@
 # @forge/lint
 
-## 0.0.0-experimental-4d15129
+## 0.0.0-experimental-3b4aabe
 
 ### Minor Changes
 
@@ -14,8 +14,8 @@
 - Updated dependencies [189ba71]
 - Updated dependencies [4285fc3]
 - Updated dependencies [74e00c8]
-  - @forge/cli-shared@0.0.0-experimental-4d15129
-  - @forge/manifest@0.0.0-experimental-4d15129
+  - @forge/cli-shared@0.0.0-experimental-3b4aabe
+  - @forge/manifest@0.0.0-experimental-3b4aabe
 
 ## 3.2.0-next.5
 

package/out/lint/linters/permission-linter/verifiers/external-fetch-verifier.d.ts

@@ -3,7 +3,6 @@ import { LintClass, LintResultRule } from '../../../linter-interface';
 import { BaseLintIssueVerifier, LintIssueVerifier } from '../../verifier-interface';
 import { ExternalApiCall } from '../api-call-interface';
 export declare class ExternalFetchVerifier extends BaseLintIssueVerifier implements LintIssueVerifier<ExternalApiCall[]> {
-    private egressFilteringService;
     constructor(environment: string, manifest: Manifest);
     protected getLintClass(): LintClass;
     private extractDomain;

package/out/lint/linters/permission-linter/verifiers/external-fetch-verifier.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"external-fetch-verifier.d.ts","sourceRoot":"","sources":["../../../../../src/lint/linters/permission-linter/verifiers/external-fetch-verifier.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,cAAc,IAAI,QAAQ,EAAE,MAAM,iBAAiB,CAAC;AAGlE,OAAO,EAAE,SAAS,EAAE,cAAc,EAAE,MAAM,2BAA2B,CAAC;AACtE,OAAO,EAAE,qBAAqB,EAAE,iBAAiB,EAAE,MAAM,0BAA0B,CAAC;AACpF,OAAO,EAAE,eAAe,EAAE,MAAM,uBAAuB,CAAC;AAIxD,qBAAa,qBAAsB,SAAQ,qBAAsB,YAAW,iBAAiB,CAAC,eAAe,EAAE,CAAC;IAC9G,OAAO,CAAC,sBAAsB,CAAyB;gBAE3C,WAAW,EAAE,MAAM,EAAE,QAAQ,EAAE,QAAQ;IAenD,SAAS,CAAC,YAAY,IAAI,SAAS;IAInC,OAAO,CAAC,aAAa,CAMnB;IAEW,OAAO,CAAC,UAAU,EAAE,eAAe,EAAE,GAAG,OAAO,CAAC,cAAc,EAAE,CAAC;CAc/E"}
+{"version":3,"file":"external-fetch-verifier.d.ts","sourceRoot":"","sources":["../../../../../src/lint/linters/permission-linter/verifiers/external-fetch-verifier.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,cAAc,IAAI,QAAQ,EAAE,MAAM,iBAAiB,CAAC;AAElE,OAAO,EAAE,SAAS,EAAE,cAAc,EAAE,MAAM,2BAA2B,CAAC;AACtE,OAAO,EAAE,qBAAqB,EAAE,iBAAiB,EAAE,MAAM,0BAA0B,CAAC;AACpF,OAAO,EAAE,eAAe,EAAE,MAAM,uBAAuB,CAAC;AAIxD,qBAAa,qBAAsB,SAAQ,qBAAsB,YAAW,iBAAiB,CAAC,eAAe,EAAE,CAAC;gBAClG,WAAW,EAAE,MAAM,EAAE,QAAQ,EAAE,QAAQ;IAInD,SAAS,CAAC,YAAY,IAAI,SAAS;IAInC,OAAO,CAAC,aAAa,CAMnB;IAEW,OAAO,CAAC,UAAU,EAAE,eAAe,EAAE,GAAG,OAAO,CAAC,cAAc,EAAE,CAAC;CAY/E"}

package/out/lint/linters/permission-linter/verifiers/external-fetch-verifier.js

@@ -1,14 +1,12 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.ExternalFetchVerifier = void 0;
-const csp_1 = require("@forge/csp");
 const linter_interface_1 = require("../../../linter-interface");
 const verifier_interface_1 = require("../../verifier-interface");
 const text_1 = require("../../../text");
 const url_1 = require("url");
 class ExternalFetchVerifier extends verifier_interface_1.BaseLintIssueVerifier {
     constructor(environment, manifest) {
-        var _a, _b, _c, _d, _e, _f, _g;
         super(environment, manifest);
         this.extractDomain = (fetchCall) => {
             try {
@@ -18,21 +16,12 @@ class ExternalFetchVerifier extends verifier_interface_1.BaseLintIssueVerifier {
                 return fetchCall.url;
             }
         };
-        const allowList = (_e = (_d = (_c = (_b = (_a = this.manifest) === null || _a === void 0 ? void 0 : _a.permissions) === null || _b === void 0 ? void 0 : _b.external) === null || _c === void 0 ? void 0 : _c.fetch) === null || _d === void 0 ? void 0 : _d.backend) !== null && _e !== void 0 ? _e : [];
-        const remoteList = (_g = (_f = this.manifest) === null || _f === void 0 ? void 0 : _f.remotes) !== null && _g !== void 0 ? _g : [];
-        const collectedUrls = allowList.filter((item) => typeof item === 'string');
-        const collectedRemotes = allowList
-            .map((item) => { var _a; return typeof item !== 'string' && ((_a = remoteList.find((remoteItem) => remoteItem.key === item.remote)) === null || _a === void 0 ? void 0 : _a.baseUrl); })
-            .filter((x) => typeof x === 'string');
-        this.egressFilteringService = new csp_1.EgressFilteringService(collectedUrls.concat(collectedRemotes));
     }
     getLintClass() {
         return linter_interface_1.LintClass.Error;
     }
     async process(fetchCalls) {
-        return fetchCalls
-            .filter(({ url }) => !this.egressFilteringService.isValidUrl(url))
-            .map((fetchCall) => ({
+        return fetchCalls.map((fetchCall) => ({
             class: this.getLintClass(),
             message: text_1.messages.verifiers.externalFetch.message(fetchCall.url),
             reference: text_1.messages.verifiers.externalFetch.reference,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@forge/lint",
-  "version": "0.0.0-experimental-4d15129",
+  "version": "0.0.0-experimental-3b4aabe",
   "description": "Linting for forge apps",
   "main": "out/index.js",
   "license": "UNLICENSED",
@@ -15,9 +15,8 @@
     "@types/node-fetch": "^2.5.7"
   },
   "dependencies": {
-    "@forge/cli-shared": "0.0.0-experimental-4d15129",
-    "@forge/csp": "1.11.0",
-    "@forge/manifest": "0.0.0-experimental-4d15129",
+    "@forge/cli-shared": "0.0.0-experimental-3b4aabe",
+    "@forge/manifest": "0.0.0-experimental-3b4aabe",
     "@typescript-eslint/typescript-estree": "^3.5.0",
     "cross-spawn": "^7.0.1",
     "node-fetch": "2.6.1",