@forcecalendar/core 2.1.8 → 2.1.10

package/core/calendar/Calendar.js

@@ -731,23 +731,29 @@ export class Calendar {
    * Destroy the calendar and clean up
    */
   destroy() {
+    // Emit destroy event before clearing listeners
+    this._emit('destroy');
+
     // Clear all listeners
     this.listeners.clear();
 
     // Properly destroy EventStore (clears events, caches, and cleanup timers)
     this.eventStore.destroy();
 
-    // Clear plugins
+    // Clear plugins — wrap each uninstall in try-catch so one failure
+    // doesn't prevent cleanup of remaining plugins
     this.plugins.forEach(plugin => {
       if (typeof plugin.uninstall === 'function') {
-        plugin.uninstall(this);
+        try {
+          plugin.uninstall(this);
+        } catch (error) {
+          console.error('Error uninstalling plugin:', error);
+        }
       }
     });
     this.plugins.clear();
 
     // Clear view instances
     this.views.clear();
-
-    this._emit('destroy');
   }
 } // Test workflow

package/core/calendar/DateUtils.js

@@ -288,9 +288,13 @@ export class DateUtils {
    * @returns {number}
    */
   static getWeekNumber(date) {
-    const firstDayOfYear = new Date(date.getFullYear(), 0, 1);
-    const pastDaysOfYear = (date - firstDayOfYear) / 86400000;
-    return Math.ceil((pastDaysOfYear + firstDayOfYear.getDay() + 1) / 7);
+    // ISO 8601: week 1 is the week containing the first Thursday of the year
+    const target = new Date(date);
+    target.setHours(0, 0, 0, 0);
+    // Set to nearest Thursday (current date + 4 - current day number, with Sunday as 7)
+    target.setDate(target.getDate() + 4 - (target.getDay() || 7));
+    const yearStart = new Date(target.getFullYear(), 0, 1);
+    return Math.ceil(((target - yearStart) / 86400000 + 1) / 7);
   }
 
   /**

package/core/events/RecurrenceEngine.js

@@ -94,9 +94,56 @@ export class RecurrenceEngine {
       }
     }
 
+    // Apply BYSETPOS filtering if present and not already handled by MONTHLY+byDay
+    if (rule.bySetPos && rule.bySetPos.length > 0 && rule.freq !== 'MONTHLY') {
+      return this._applyBySetPos(occurrences, rule);
+    }
+
     return occurrences;
   }
 
+  /**
+   * Apply BYSETPOS to filter occurrences within each frequency period
+   * @param {Array} occurrences - Generated occurrences
+   * @param {Object} rule - Recurrence rule
+   * @returns {Array} Filtered occurrences
+   * @private
+   */
+  static _applyBySetPos(occurrences, rule) {
+    if (occurrences.length === 0) return occurrences;
+
+    // Group occurrences by period
+    const groups = new Map();
+    for (const occ of occurrences) {
+      let key;
+      switch (rule.freq) {
+        case 'YEARLY':
+          key = occ.start.getFullYear();
+          break;
+        case 'WEEKLY':
+          key = `${occ.start.getFullYear()}-W${DateUtils.getWeekNumber(occ.start)}`;
+          break;
+        default:
+          key = `${occ.start.getFullYear()}-${occ.start.getMonth()}`;
+      }
+      if (!groups.has(key)) groups.set(key, []);
+      groups.get(key).push(occ);
+    }
+
+    // Filter each group by BYSETPOS positions
+    const filtered = [];
+    for (const group of groups.values()) {
+      for (const pos of rule.bySetPos) {
+        const idx = pos > 0 ? pos - 1 : group.length + pos;
+        if (idx >= 0 && idx < group.length) {
+          filtered.push(group[idx]);
+        }
+      }
+    }
+
+    return filtered.sort((a, b) => a.start - b.start);
+  }
+
   /**
    * Parse an RRULE string into a rule object
    * @param {string|import('../../types.js').RecurrenceRule} ruleString - RRULE string (e.g., "FREQ=DAILY;INTERVAL=1;COUNT=10") or rule object
@@ -151,11 +198,19 @@ export class RecurrenceEngine {
           // Specific day(s) of month
           const currentMonth = next.getMonth();
           next.setMonth(currentMonth + rule.interval);
-          next.setDate(rule.byMonthDay[0]); // Use first specified day
+          // Clamp to last day of month if day doesn't exist
+          const daysInMonth = new Date(next.getFullYear(), next.getMonth() + 1, 0).getDate();
+          next.setDate(Math.min(rule.byMonthDay[0], daysInMonth));
         } else if (rule.byDay && rule.byDay.length > 0) {
           // Specific weekday of month (e.g., "2nd Tuesday")
           next.setMonth(next.getMonth() + rule.interval);
-          this.setToWeekdayOfMonth(next, rule.byDay[0], rule.bySetPos[0] || 1);
+          // Extract position from the day code itself (e.g., "2TU" -> pos=2)
+          // or fall back to bySetPos
+          const dayCode = rule.byDay[0];
+          const dayMatch = dayCode.match(/^(-?\d+)?([A-Z]{2})$/);
+          const embeddedPos = dayMatch && dayMatch[1] ? parseInt(dayMatch[1], 10) : null;
+          const pos = embeddedPos || (rule.bySetPos && rule.bySetPos[0]) || 1;
+          this.setToWeekdayOfMonth(next, rule.byDay[0], pos);
         } else {
           // Same day of month
           next.setMonth(next.getMonth() + rule.interval);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@forcecalendar/core",
-  "version": "2.1.8",
+  "version": "2.1.10",
   "type": "module",
   "private": false,
   "description": "A modern, lightweight, framework-agnostic calendar engine optimized for Salesforce",