@forcecalendar/core 2.1.52 → 2.1.54

package/core/conflicts/ConflictDetector.js

@@ -320,16 +320,11 @@ export class ConflictDetector {
       return conflicts;
     }
 
-    const conflictingAttendees = [];
-
-    for (const attendee1 of event1.attendees) {
-      for (const attendee2 of event2.attendees) {
-        if (attendee1.email === attendee2.email) {
-          // Same attendee in both events
-          conflictingAttendees.push(attendee1.email);
-        }
-      }
-    }
+    // Use Set for O(1) lookup instead of O(n*m) nested loops
+    const emails1 = new Set(event1.attendees.map(a => a.email));
+    const conflictingAttendees = event2.attendees
+      .filter(a => emails1.has(a.email))
+      .map(a => a.email);
 
     if (conflictingAttendees.length > 0) {
       // Determine severity based on attendee responses
@@ -505,13 +500,36 @@ export class ConflictDetector {
    * @private
    */
   _isWithinBusinessHours(start, end, options) {
-    // Simple implementation - can be enhanced
-    const startHour = start.getHours();
-    const endHour = end.getHours();
+    if (options.excludeWeekends) {
+      const day = start.getDay();
+      if (day === 0 || day === 6) {
+        return false;
+      }
+    }
+
+    // Business hours describe a window within a single day, so a period
+    // spanning multiple calendar days can never fit inside them
+    if (
+      start.getFullYear() !== end.getFullYear() ||
+      start.getMonth() !== end.getMonth() ||
+      start.getDate() !== end.getDate()
+    ) {
+      return false;
+    }
+
+    const [businessStartHour, businessStartMinute = 0] = options.businessHours.start
+      .split(':')
+      .map(Number);
+    const [businessEndHour, businessEndMinute = 0] = options.businessHours.end
+      .split(':')
+      .map(Number);
+
+    const businessStart = businessStartHour * 60 + businessStartMinute;
+    const businessEnd = businessEndHour * 60 + businessEndMinute;
 
-    const businessStart = parseInt(options.businessHours.start.split(':')[0]);
-    const businessEnd = parseInt(options.businessHours.end.split(':')[0]);
+    const startMinutes = start.getHours() * 60 + start.getMinutes();
+    const endMinutes = end.getHours() * 60 + end.getMinutes();
 
-    return startHour >= businessStart && endHour <= businessEnd;
+    return startMinutes >= businessStart && endMinutes <= businessEnd;
   }
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@forcecalendar/core",
-  "version": "2.1.52",
+  "version": "2.1.54",
   "type": "module",
   "private": false,
   "description": "A modern, lightweight, framework-agnostic calendar engine optimized for Salesforce",