@foray1010/eslint-config 9.0.1 → 9.2.0

package/CHANGELOG.md

@@ -3,6 +3,31 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [9.2.0](https://github.com/foray1010/common-presets/compare/@foray1010/eslint-config@9.1.0...@foray1010/eslint-config@9.2.0) (2023-02-25)
+
+### Features
+
+- **eslint-config:** avoid type imports with side effects ([ceda72a](https://github.com/foray1010/common-presets/commit/ceda72a42dab09540fe796cca7c88b82801f073d))
+
+### Bug Fixes
+
+- **deps:** update dependency eslint-plugin-jsdoc to v40 ([9d2a01e](https://github.com/foray1010/common-presets/commit/9d2a01e04880e21c2be8dd2e984ec5f01f28fcda))
+- **deps:** update dependency eslint-plugin-simple-import-sort to v10 ([5b258d7](https://github.com/foray1010/common-presets/commit/5b258d70b6c6f344645f983d6f7805edd2ee1908))
+- **deps:** update dependency eslint-plugin-simple-import-sort to v9 ([62d76f2](https://github.com/foray1010/common-presets/commit/62d76f2d2ef83ab5a909d3820a9f16acf387bbfa))
+
+## [9.1.0](https://github.com/foray1010/common-presets/compare/@foray1010/eslint-config@9.0.1...@foray1010/eslint-config@9.1.0) (2022-12-21)
+
+### Features
+
+- **eslint-config:** make sure private class members are in-use ([8d01342](https://github.com/foray1010/common-presets/commit/8d01342664696ab6bff9cc2f703bc53a81995ed5))
+- **eslint-config:** prefer `const` when the variable won't be reassigned ([e6b18a1](https://github.com/foray1010/common-presets/commit/e6b18a1dcc023ea346d96288f4c709b77578b2af))
+- **eslint-config:** prefer explicitly convert type for readability ([2b5f647](https://github.com/foray1010/common-presets/commit/2b5f64740415361173f0ca16a91c2714af72ed02))
+- **eslint-config:** require button type to avoid unexpected form submits ([891ff50](https://github.com/foray1010/common-presets/commit/891ff506217da96accd030fbbbea680569f4573b))
+
+### Bug Fixes
+
+- **deps:** update dependency eslint-plugin-unicorn to v45 ([cde868a](https://github.com/foray1010/common-presets/commit/cde868a7c95aaa4dad3acedb07a763ccc64582c9))
+
 ## [9.0.1](https://github.com/foray1010/common-presets/compare/@foray1010/eslint-config@9.0.0...@foray1010/eslint-config@9.0.1) (2022-11-07)
 
 ### Reverts

package/package.json

@@ -1,7 +1,7 @@
 {
   "$schema": "https://json.schemastore.org/package",
   "name": "@foray1010/eslint-config",
-  "version": "9.0.1",
+  "version": "9.2.0",
   "homepage": "https://github.com/foray1010/common-presets/tree/master/packages/eslint-config#readme",
   "bugs": "https://github.com/foray1010/common-presets/issues",
   "repository": {
@@ -24,8 +24,8 @@
   },
   "dependencies": {
     "@foray1010/common-presets-utils": "^6.0.0",
-    "@typescript-eslint/eslint-plugin": "^5.42.1",
-    "@typescript-eslint/parser": "^5.42.1",
+    "@typescript-eslint/eslint-plugin": "^5.51.0",
+    "@typescript-eslint/parser": "^5.51.0",
     "confusing-browser-globals": "^1.0.10",
     "eslint-config-prettier": "^8.3.0",
     "eslint-import-resolver-typescript": "^3.5.2",
@@ -36,18 +36,18 @@
     "eslint-plugin-import": "^2.22.1",
     "eslint-plugin-jest": "^27.1.3",
     "eslint-plugin-jest-dom": "^4.0.0",
-    "eslint-plugin-jsdoc": "^39.3.25",
+    "eslint-plugin-jsdoc": "^40.0.0",
     "eslint-plugin-n": "^15.3.0",
     "eslint-plugin-prettier": "^4.0.0",
     "eslint-plugin-react": "^7.31.10",
     "eslint-plugin-react-hooks": "^4.2.0",
-    "eslint-plugin-simple-import-sort": "^8.0.0",
+    "eslint-plugin-simple-import-sort": "^10.0.0",
     "eslint-plugin-testing-library": "^5.9.1",
-    "eslint-plugin-unicorn": "^44.0.2"
+    "eslint-plugin-unicorn": "^45.0.0"
   },
   "devDependencies": {
     "@types/confusing-browser-globals": "1.0.0",
-    "@types/eslint": "8.4.10"
+    "@types/eslint": "8.21.1"
   },
   "peerDependencies": {
     "eslint": "^8.0.0",
@@ -59,5 +59,5 @@
   "publishConfig": {
     "access": "public"
   },
-  "gitHead": "fb5476d1436d6a3c2295fa4753999c7e0bd00133"
+  "gitHead": "11a76b57489f7de8f08ec5cd47f8747c4c432f09"
 }

package/presets/base.cjs

@@ -137,8 +137,20 @@ module.exports = {
     'jsdoc/require-jsdoc': 'off',
     // does not work well with TypeScript https://github.com/gajus/eslint-plugin-jsdoc/issues/145
     'jsdoc/valid-types': 'off',
+    // prefer explicitly convert type for readability
+    'no-implicit-coercion': 'error',
+    // make sure private class members are in-use
+    'no-unused-private-class-members': 'error',
     // avoid assigning anonymous function to object key which is harder to trace when debug
     'object-shorthand': ['error', 'always'],
+    // prefer `const` when the variable won't be reassigned
+    'prefer-const': [
+      'error',
+      {
+        // if one of the variables will be reassigned, do not enforce `const`
+        destructuring: 'all',
+      },
+    ],
     // use with `unicorn/throw-new-error`
     // disallow builtins to be created without `new` operator, to be consistent with es6 class syntax
     'unicorn/new-for-builtins': 'error',
@@ -219,10 +231,12 @@ module.exports = {
               ],
               // separate type exports which allow certain optimizations within compilers
               '@typescript-eslint/consistent-type-exports': 'error',
-              // separate type imports which allow certain optimizations within compilers
               '@typescript-eslint/consistent-type-imports': [
                 'error',
-                { prefer: 'type-imports' },
+                {
+                  // separate type imports which allow certain optimizations within compilers
+                  prefer: 'type-imports',
+                },
               ],
               // disable the base rule as it can report incorrect errors, use @typescript-eslint/dot-notation instead
               'dot-notation': 'off',
@@ -248,6 +262,8 @@ module.exports = {
               '@typescript-eslint/no-empty-function': 'off',
               // encourage to check error type before use in catch clauses
               '@typescript-eslint/no-implicit-any-catch': 'error',
+              // when using typescript 5.0 with verbatimModuleSyntax flag on, compiler will not remove import statements with only inline type imports which lead to side effects
+              '@typescript-eslint/no-import-type-side-effects': 'error',
               // enforce correct usage of `void` type
               '@typescript-eslint/no-invalid-void-type': 'error',
               // allow using async function as event handler in frontend

package/presets/react.cjs

@@ -23,6 +23,8 @@ module.exports = {
     },
   },
   rules: {
+    // avoid unexpected form submits
+    'react/button-has-type': 'error',
     'react/jsx-no-useless-fragment': [
       'error',
       {