@foray1010/eslint-config 9.0.0 → 9.1.0

package/CHANGELOG.md

@@ -3,6 +3,25 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [9.1.0](https://github.com/foray1010/common-presets/compare/@foray1010/eslint-config@9.0.1...@foray1010/eslint-config@9.1.0) (2022-12-21)
+
+### Features
+
+- **eslint-config:** make sure private class members are in-use ([8d01342](https://github.com/foray1010/common-presets/commit/8d01342664696ab6bff9cc2f703bc53a81995ed5))
+- **eslint-config:** prefer `const` when the variable won't be reassigned ([e6b18a1](https://github.com/foray1010/common-presets/commit/e6b18a1dcc023ea346d96288f4c709b77578b2af))
+- **eslint-config:** prefer explicitly convert type for readability ([2b5f647](https://github.com/foray1010/common-presets/commit/2b5f64740415361173f0ca16a91c2714af72ed02))
+- **eslint-config:** require button type to avoid unexpected form submits ([891ff50](https://github.com/foray1010/common-presets/commit/891ff506217da96accd030fbbbea680569f4573b))
+
+### Bug Fixes
+
+- **deps:** update dependency eslint-plugin-unicorn to v45 ([cde868a](https://github.com/foray1010/common-presets/commit/cde868a7c95aaa4dad3acedb07a763ccc64582c9))
+
+## [9.0.1](https://github.com/foray1010/common-presets/compare/@foray1010/eslint-config@9.0.0...@foray1010/eslint-config@9.0.1) (2022-11-07)
+
+### Reverts
+
+- **eslint-config:** does not report error when importing ts files without extension ([faeee28](https://github.com/foray1010/common-presets/commit/faeee281cd40ba6b22835ae5b8c9cd6d69d3815e))
+
 ## [9.0.0](https://github.com/foray1010/common-presets/compare/@foray1010/eslint-config@8.0.1...@foray1010/eslint-config@9.0.0) (2022-11-07)
 
 ### ⚠ BREAKING CHANGES

package/package.json

@@ -1,7 +1,7 @@
 {
   "$schema": "https://json.schemastore.org/package",
   "name": "@foray1010/eslint-config",
-  "version": "9.0.0",
+  "version": "9.1.0",
   "homepage": "https://github.com/foray1010/common-presets/tree/master/packages/eslint-config#readme",
   "bugs": "https://github.com/foray1010/common-presets/issues",
   "repository": {
@@ -43,7 +43,7 @@
     "eslint-plugin-react-hooks": "^4.2.0",
     "eslint-plugin-simple-import-sort": "^8.0.0",
     "eslint-plugin-testing-library": "^5.9.1",
-    "eslint-plugin-unicorn": "^44.0.2"
+    "eslint-plugin-unicorn": "^45.0.0"
   },
   "devDependencies": {
     "@types/confusing-browser-globals": "1.0.0",
@@ -59,5 +59,5 @@
   "publishConfig": {
     "access": "public"
   },
-  "gitHead": "4acba77dace91746ac98872f4b8f62b410de82f5"
+  "gitHead": "7b07434790f3f2c119d1106c379ab07bd715372e"
 }

package/presets/base.cjs

@@ -71,7 +71,6 @@ module.exports = {
     'func-names': ['error', 'as-needed'],
     // this rule doesn't support commonjs, some dependencies are using commonjs
     'import/default': 'off',
-    // use with `n/file-extension-in-import`
     // enforce extensions for both cjs and esm
     'import/extensions': [
       'error',
@@ -79,7 +78,7 @@ module.exports = {
       'always',
       {
         pattern: {
-          // handled by `n/file-extension-in-import` because eslint-plugin-import does not support es modules in typescript files
+          // eslint-plugin-import does not support checking es modules in typescript files
           cts: 'never',
           mts: 'never',
           ts: 'never',
@@ -138,8 +137,20 @@ module.exports = {
     'jsdoc/require-jsdoc': 'off',
     // does not work well with TypeScript https://github.com/gajus/eslint-plugin-jsdoc/issues/145
     'jsdoc/valid-types': 'off',
+    // prefer explicitly convert type for readability
+    'no-implicit-coercion': 'error',
+    // make sure private class members are in-use
+    'no-unused-private-class-members': 'error',
     // avoid assigning anonymous function to object key which is harder to trace when debug
     'object-shorthand': ['error', 'always'],
+    // prefer `const` when the variable won't be reassigned
+    'prefer-const': [
+      'error',
+      {
+        // if one of the variables will be reassigned, do not enforce `const`
+        destructuring: 'all',
+      },
+    ],
     // use with `unicorn/throw-new-error`
     // disallow builtins to be created without `new` operator, to be consistent with es6 class syntax
     'unicorn/new-for-builtins': 'error',
@@ -205,7 +216,6 @@ module.exports = {
               '@typescript-eslint/eslint-plugin',
               'eslint-plugin-deprecation',
               'eslint-plugin-functional',
-              'eslint-plugin-n',
             ],
             rules: {
               // extend existing rule
@@ -316,8 +326,6 @@ module.exports = {
               ],
               // forbid unnecessary callback wrapper
               'functional/prefer-tacit': 'error',
-              // use with `import/extensions` because it doesn't work with TypeScript
-              'n/file-extension-in-import': ['error', 'always'],
               'no-restricted-syntax': [
                 'error',
                 {

package/presets/react.cjs

@@ -23,6 +23,8 @@ module.exports = {
     },
   },
   rules: {
+    // avoid unexpected form submits
+    'react/button-has-type': 'error',
     'react/jsx-no-useless-fragment': [
       'error',
       {