@foray1010/eslint-config 8.0.0 → 9.0.0

package/CHANGELOG.md

@@ -3,6 +3,37 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [9.0.0](https://github.com/foray1010/common-presets/compare/@foray1010/eslint-config@8.0.1...@foray1010/eslint-config@9.0.0) (2022-11-07)
+
+### ⚠ BREAKING CHANGES
+
+- drop nodejs 14.17 and 18.11
+
+### Features
+
+- **eslint-config:** disallow builtins to be created without `new` operator ([1c0c1a8](https://github.com/foray1010/common-presets/commit/1c0c1a86bbaf8a7c2bfcbd7998041418329fc8e2))
+- **eslint-config:** disallow duplicated value in enum as it is error-prone ([5795a82](https://github.com/foray1010/common-presets/commit/5795a82945eaeec967a8403e167defbe587b4583))
+- **eslint-config:** enable @typescript-eslint/no-unsafe-declaration-merging ([1b4abe2](https://github.com/foray1010/common-presets/commit/1b4abe27a5322729321b61f5d406cf9af7aaf51a))
+- **eslint-config:** make sure functions which return a promise will just return a rejected promise ([06603f4](https://github.com/foray1010/common-presets/commit/06603f42098f5492037c0114ecc50fac623a11c3))
+- **eslint-config:** prefer node protocol ([204e5c1](https://github.com/foray1010/common-presets/commit/204e5c168aacaa020d2481306489724dfd6da7bc))
+- **eslint-config:** require switch-case statements to be exhaustive with union type ([2b13aa6](https://github.com/foray1010/common-presets/commit/2b13aa60c1622a75f4a84133b3bf31b90b676057))
+- **eslint-config:** separate type exports which allow certain optimizations within compilers ([bbc6b9b](https://github.com/foray1010/common-presets/commit/bbc6b9b9a83fecf552ed85be838693ec04c8b149))
+
+### Bug Fixes
+
+- **deps:** update dependency eslint-import-resolver-typescript to v3 ([0ff474e](https://github.com/foray1010/common-presets/commit/0ff474ef79193b53a29ea0ad7026e3cc12e1227e))
+- **eslint-config:** does not report error when importing ts files without extension ([aea8307](https://github.com/foray1010/common-presets/commit/aea83079cae7967c405a38599b2ad63169cf8be6))
+
+### Miscellaneous Chores
+
+- drop nodejs 14.17 and 18.11 ([8e5c967](https://github.com/foray1010/common-presets/commit/8e5c9677b89d38c88de465f069bb5de683a8a40b))
+
+## [8.0.1](https://github.com/foray1010/common-presets/compare/@foray1010/eslint-config@8.0.0...@foray1010/eslint-config@8.0.1) (2022-10-22)
+
+### Bug Fixes
+
+- **eslint-config:** add back support for node 14.17 ([3264119](https://github.com/foray1010/common-presets/commit/3264119b95b5364cd6c952536dffce49b5f14955))
+
 ## [8.0.0](https://github.com/foray1010/common-presets/compare/@foray1010/eslint-config@7.12.0...@foray1010/eslint-config@8.0.0) (2022-10-21)
 
 ### ⚠ BREAKING CHANGES

package/{index.js → index.cjs}

@@ -2,5 +2,5 @@
 
 /** @type {import('eslint').Linter.Config} */
 module.exports = {
-  extends: ['./presets/base.js', './presets/node.js'],
+  extends: ['./presets/base.cjs', './presets/node.cjs'],
 }

package/package.json

@@ -1,7 +1,7 @@
 {
   "$schema": "https://json.schemastore.org/package",
   "name": "@foray1010/eslint-config",
-  "version": "8.0.0",
+  "version": "9.0.0",
   "homepage": "https://github.com/foray1010/common-presets/tree/master/packages/eslint-config#readme",
   "bugs": "https://github.com/foray1010/common-presets/issues",
   "repository": {
@@ -11,8 +11,8 @@
   },
   "license": "MIT",
   "exports": {
-    ".": "./index.js",
-    "./react": "./react.js"
+    ".": "./index.cjs",
+    "./react": "./react.cjs"
   },
   "files": [
     "**/*.{cjs,js,json,mjs}",
@@ -23,9 +23,9 @@
     "type:check": "tsc"
   },
   "dependencies": {
-    "@foray1010/common-presets-utils": "^5.1.0",
-    "@typescript-eslint/eslint-plugin": "^5.38.1",
-    "@typescript-eslint/parser": "^5.38.1",
+    "@foray1010/common-presets-utils": "^6.0.0",
+    "@typescript-eslint/eslint-plugin": "^5.42.1",
+    "@typescript-eslint/parser": "^5.42.1",
     "confusing-browser-globals": "^1.0.10",
     "eslint-config-prettier": "^8.3.0",
     "eslint-import-resolver-typescript": "^3.5.2",
@@ -34,30 +34,30 @@
     "eslint-plugin-eslint-comments": "^3.2.0",
     "eslint-plugin-functional": "^4.4.1",
     "eslint-plugin-import": "^2.22.1",
-    "eslint-plugin-jest": "^27.0.4",
+    "eslint-plugin-jest": "^27.1.3",
     "eslint-plugin-jest-dom": "^4.0.0",
-    "eslint-plugin-jsdoc": "^39.3.6",
+    "eslint-plugin-jsdoc": "^39.3.25",
     "eslint-plugin-n": "^15.3.0",
     "eslint-plugin-prettier": "^4.0.0",
-    "eslint-plugin-react": "^7.31.8",
+    "eslint-plugin-react": "^7.31.10",
     "eslint-plugin-react-hooks": "^4.2.0",
     "eslint-plugin-simple-import-sort": "^8.0.0",
-    "eslint-plugin-testing-library": "^5.7.0",
-    "eslint-plugin-unicorn": "^42.0.0"
+    "eslint-plugin-testing-library": "^5.9.1",
+    "eslint-plugin-unicorn": "^44.0.2"
   },
   "devDependencies": {
     "@types/confusing-browser-globals": "1.0.0",
-    "@types/eslint": "8.4.6"
+    "@types/eslint": "8.4.10"
   },
   "peerDependencies": {
     "eslint": "^8.0.0",
     "prettier": "^2.0.0"
   },
   "engines": {
-    "node": "^14.17.0 || ^16.13.0 || >=18.0.0"
+    "node": "^14.18.0 || ^16.13.0 || >=18.12.0"
   },
   "publishConfig": {
     "access": "public"
   },
-  "gitHead": "c6310f72bc0c02649d5b7fe7cdb059e1c36e8200"
+  "gitHead": "4acba77dace91746ac98872f4b8f62b410de82f5"
 }

package/presets/{base.js → base.cjs}

@@ -3,7 +3,7 @@
 // @ts-expect-error
 const { hasDep, isESM } = require('@foray1010/common-presets-utils')
 
-const { testFileGlobs } = require('./utils/testUtil.js')
+const { testFileGlobs } = require('./utils/testUtil.cjs')
 
 /** @type {import('eslint').Linter.BaseConfig} */
 const cjsConfig = {
@@ -71,6 +71,7 @@ module.exports = {
     'func-names': ['error', 'as-needed'],
     // this rule doesn't support commonjs, some dependencies are using commonjs
     'import/default': 'off',
+    // use with `n/file-extension-in-import`
     // enforce extensions for both cjs and esm
     'import/extensions': [
       'error',
@@ -78,7 +79,7 @@ module.exports = {
       'always',
       {
         pattern: {
-          // ignore cts/mts/ts/tsx because typescript uses cjs/mjs/js instead
+          // handled by `n/file-extension-in-import` because eslint-plugin-import does not support es modules in typescript files
           cts: 'never',
           mts: 'never',
           ts: 'never',
@@ -139,8 +140,15 @@ module.exports = {
     'jsdoc/valid-types': 'off',
     // avoid assigning anonymous function to object key which is harder to trace when debug
     'object-shorthand': ['error', 'always'],
+    // use with `unicorn/throw-new-error`
+    // disallow builtins to be created without `new` operator, to be consistent with es6 class syntax
+    'unicorn/new-for-builtins': 'error',
+    // prefer `import from 'node:xxx'`
+    'unicorn/prefer-node-protocol': 'error',
     // prefer Number static properties over global ones
     'unicorn/prefer-number-properties': 'error',
+    // use with `unicorn/new-for-builtins`
+    'unicorn/throw-new-error': 'error',
   },
   overrides: [
     {
@@ -197,6 +205,7 @@ module.exports = {
               '@typescript-eslint/eslint-plugin',
               'eslint-plugin-deprecation',
               'eslint-plugin-functional',
+              'eslint-plugin-n',
             ],
             rules: {
               // extend existing rule
@@ -210,6 +219,8 @@ module.exports = {
                   extendDefaults: true,
                 },
               ],
+              // separate type exports which allow certain optimizations within compilers
+              '@typescript-eslint/consistent-type-exports': 'error',
               // separate type imports which allow certain optimizations within compilers
               '@typescript-eslint/consistent-type-imports': [
                 'error',
@@ -233,6 +244,8 @@ module.exports = {
               ],
               // sometimes auto detect can provide a better and narrower type
               '@typescript-eslint/explicit-module-boundary-types': 'off',
+              // disallow duplicated value in enum as it is error-prone
+              '@typescript-eslint/no-duplicate-enum-values': 'error',
               // need empty function for react context default value
               '@typescript-eslint/no-empty-function': 'off',
               // encourage to check error type before use in catch clauses
@@ -244,6 +257,8 @@ module.exports = {
                 'error',
                 { checksVoidReturn: false },
               ],
+              // declaration merging between classes and interfaces is unsafe
+              '@typescript-eslint/no-unsafe-declaration-merging': 'error',
               // do not block functions referring to other functions
               '@typescript-eslint/no-use-before-define': [
                 'error',
@@ -265,6 +280,8 @@ module.exports = {
               // use with functional/prefer-readonly-type
               // mark class variables as readonly if it is not mutated
               '@typescript-eslint/prefer-readonly': 'error',
+              // make sure functions which return a promise will just return a rejected promise instead of throwing an error
+              '@typescript-eslint/promise-function-async': 'error',
               // allow primitive value in template string
               '@typescript-eslint/restrict-template-expressions': [
                 'error',
@@ -276,6 +293,8 @@ module.exports = {
                   allowRegExp: true,
                 },
               ],
+              // avoid missed switch-case by requiring switch-case statements to be exhaustive with union type
+              '@typescript-eslint/switch-exhaustiveness-check': 'error',
               // ignore static function as those are not supposed to use `this`
               '@typescript-eslint/unbound-method': [
                 'error',
@@ -297,6 +316,8 @@ module.exports = {
               ],
               // forbid unnecessary callback wrapper
               'functional/prefer-tacit': 'error',
+              // use with `import/extensions` because it doesn't work with TypeScript
+              'n/file-extension-in-import': ['error', 'always'],
               'no-restricted-syntax': [
                 'error',
                 {

package/presets/{node.js → node.cjs}

@@ -39,10 +39,10 @@ module.exports = {
     'n/prefer-global/text-decoder': ['error', 'always'],
     // prefer global `TextEncoder` to be isomorphic
     'n/prefer-global/text-encoder': ['error', 'always'],
-    // prefer global `URLSearchParams` to be isomorphic
-    'n/prefer-global/url-search-params': ['error', 'always'],
     // prefer global `URL` to be isomorphic
     'n/prefer-global/url': ['error', 'always'],
+    // prefer global `URLSearchParams` to be isomorphic
+    'n/prefer-global/url-search-params': ['error', 'always'],
     // make `process.exit()` expressions the same code path as `throw`
     'n/process-exit-as-throw': 'error',
     // enforce shebang on the entry bin file

package/presets/{react.js → react.cjs}

@@ -1,6 +1,6 @@
 'use strict'
 
-const { testFileGlobs } = require('./utils/testUtil.js')
+const { testFileGlobs } = require('./utils/testUtil.cjs')
 
 /** @type {import('eslint').Linter.Config} */
 module.exports = {

package/react.cjs

@@ -0,0 +1,9 @@
+'use strict'
+
+module.exports = {
+  extends: [
+    './presets/base.cjs',
+    './presets/browser.cjs',
+    './presets/react.cjs',
+  ],
+}

package/react.js

@@ -1,5 +0,0 @@
-'use strict'
-
-module.exports = {
-  extends: ['./presets/base.js', './presets/browser.js', './presets/react.js'],
-}