@foray1010/eslint-config 7.8.0 → 7.10.0

package/CHANGELOG.md

@@ -3,6 +3,23 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [7.10.0](https://github.com/foray1010/common-presets/compare/@foray1010/eslint-config@7.9.0...@foray1010/eslint-config@7.10.0) (2022-10-18)
+
+### Features
+
+- **eslint-config:** do not allow usage of deprecated code ([ed21e5e](https://github.com/foray1010/common-presets/commit/ed21e5e671a67230453a682e9f80519bdcb0e551))
+- **eslint-config:** encourage to use JS standard #private over TS private accessibility modifier ([5e913c8](https://github.com/foray1010/common-presets/commit/5e913c84e709a6d586fde790f122459170130a26))
+
+## [7.9.0](https://github.com/foray1010/common-presets/compare/@foray1010/eslint-config@7.8.0...@foray1010/eslint-config@7.9.0) (2022-10-07)
+
+### Features
+
+- use indexed syntax for accessing undefined fields ([7c1f9d6](https://github.com/foray1010/common-presets/commit/7c1f9d63349f0b34b00aa8608d6908763d964c3e))
+
+### Bug Fixes
+
+- **eslint-config:** enforce accessibility modifier in constructor in TS ([7cb3f2b](https://github.com/foray1010/common-presets/commit/7cb3f2b9f5de215255b1a541bac3cc1bd731589c))
+
 ## [7.8.0](https://github.com/foray1010/common-presets/compare/@foray1010/eslint-config@7.7.3...@foray1010/eslint-config@7.8.0) (2022-10-03)
 
 ### Features

package/package.json

@@ -1,7 +1,7 @@
 {
   "$schema": "https://json.schemastore.org/package",
   "name": "@foray1010/eslint-config",
-  "version": "7.8.0",
+  "version": "7.10.0",
   "homepage": "https://github.com/foray1010/common-presets/tree/master/packages/eslint-config#readme",
   "bugs": "https://github.com/foray1010/common-presets/issues",
   "repository": {
@@ -23,12 +23,13 @@
     "type:check": "tsc"
   },
   "dependencies": {
-    "@foray1010/common-presets-utils": "^5.0.4",
+    "@foray1010/common-presets-utils": "^5.1.0",
     "@typescript-eslint/eslint-plugin": "^5.38.1",
     "@typescript-eslint/parser": "^5.38.1",
     "confusing-browser-globals": "^1.0.10",
     "eslint-config-prettier": "^8.3.0",
     "eslint-plugin-compat": "^4.0.0",
+    "eslint-plugin-deprecation": "^1.3.2",
     "eslint-plugin-eslint-comments": "^3.2.0",
     "eslint-plugin-functional": "^4.4.1",
     "eslint-plugin-import": "^2.22.1",
@@ -57,5 +58,5 @@
   "publishConfig": {
     "access": "public"
   },
-  "gitHead": "728b8351b1895f7af4b9b476461f8a3fd6f34a60"
+  "gitHead": "95efcde57421305c554daf6fe3704e8abe10a000"
 }

package/presets/base.js

@@ -178,6 +178,7 @@ module.exports = {
             },
             plugins: [
               '@typescript-eslint/eslint-plugin',
+              'eslint-plugin-deprecation',
               'eslint-plugin-functional',
             ],
             env: {
@@ -201,15 +202,20 @@ module.exports = {
                 'error',
                 { prefer: 'type-imports' },
               ],
+              // disable the base rule as it can report incorrect errors, use @typescript-eslint/dot-notation instead
+              'dot-notation': 'off',
+              // only allow indexed syntax (e.g. `obj['key']`) for accessing undefined fields
+              '@typescript-eslint/dot-notation': [
+                'error',
+                {
+                  allowIndexSignaturePropertyAccess: true,
+                },
+              ],
               // encourage to use private accessibility modifier
               '@typescript-eslint/explicit-member-accessibility': [
                 'error',
                 {
                   accessibility: 'explicit',
-                  overrides: {
-                    // don't bother because it is always public
-                    constructors: 'off',
-                  },
                 },
               ],
               // sometimes auto detect can provide a better and narrower type
@@ -262,6 +268,8 @@ module.exports = {
                 'error',
                 { ignoreStatic: true },
               ],
+              // do not allow usage of deprecated code
+              'deprecation/deprecation': 'error',
               // use with @typescript-eslint/prefer-readonly
               'functional/prefer-readonly-type': [
                 'error',
@@ -276,6 +284,16 @@ module.exports = {
               ],
               // forbid unnecessary callback wrapper
               'functional/prefer-tacit': 'error',
+              'no-restricted-syntax': [
+                'error',
+                {
+                  // encourage to use JS standard #private over TS private accessibility modifier, but excluding constructor because it cannot be private in JS: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Classes/Private_class_fields#description
+                  selector:
+                    ':matches(PropertyDefinition, MethodDefinition)[accessibility="private"]:not([kind="constructor"])',
+                  message:
+                    'Use #private instead (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Classes/Private_class_fields)',
+                },
+              ],
               // @typescript-eslint/eslint-plugin suggests to disable it: https://github.com/typescript-eslint/typescript-eslint/blob/2588e9ea55f78352fdd6ae92a306135aabb49a1a/docs/linting/TROUBLESHOOTING.md#i-get-errors-from-the-no-undef-rule-about-global-variables-not-being-defined-even-though-there-are-no-typescript-errors
               // It is disabled in recommended config but re-enabled here to enforce a subset of global variables that supported by both node.js and browsers
               'no-undef': 'error',