@foray1010/eslint-config 7.7.3 → 7.9.0

package/CHANGELOG.md

@@ -3,6 +3,23 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [7.9.0](https://github.com/foray1010/common-presets/compare/@foray1010/eslint-config@7.8.0...@foray1010/eslint-config@7.9.0) (2022-10-07)
+
+### Features
+
+- use indexed syntax for accessing undefined fields ([7c1f9d6](https://github.com/foray1010/common-presets/commit/7c1f9d63349f0b34b00aa8608d6908763d964c3e))
+
+### Bug Fixes
+
+- **eslint-config:** enforce accessibility modifier in constructor in TS ([7cb3f2b](https://github.com/foray1010/common-presets/commit/7cb3f2b9f5de215255b1a541bac3cc1bd731589c))
+
+## [7.8.0](https://github.com/foray1010/common-presets/compare/@foray1010/eslint-config@7.7.3...@foray1010/eslint-config@7.8.0) (2022-10-03)
+
+### Features
+
+- **eslint-config:** prefer Number static properties over global ones ([532df43](https://github.com/foray1010/common-presets/commit/532df43987f464ea3f3cfe1e5507b1077e14bced))
+- **eslint-config:** re-enable functional/prefer-tacit ([9f312cc](https://github.com/foray1010/common-presets/commit/9f312cc3ac05429a969f271c46e02d915bf44e41))
+
 ## [7.7.3](https://github.com/foray1010/common-presets/compare/@foray1010/eslint-config@7.7.2...@foray1010/eslint-config@7.7.3) (2022-10-02)
 
 ### Bug Fixes

package/package.json

@@ -1,7 +1,7 @@
 {
   "$schema": "https://json.schemastore.org/package",
   "name": "@foray1010/eslint-config",
-  "version": "7.7.3",
+  "version": "7.9.0",
   "homepage": "https://github.com/foray1010/common-presets/tree/master/packages/eslint-config#readme",
   "bugs": "https://github.com/foray1010/common-presets/issues",
   "repository": {
@@ -23,14 +23,14 @@
     "type:check": "tsc"
   },
   "dependencies": {
-    "@foray1010/common-presets-utils": "^5.0.4",
+    "@foray1010/common-presets-utils": "^5.1.0",
     "@typescript-eslint/eslint-plugin": "^5.38.1",
     "@typescript-eslint/parser": "^5.38.1",
     "confusing-browser-globals": "^1.0.10",
     "eslint-config-prettier": "^8.3.0",
     "eslint-plugin-compat": "^4.0.0",
     "eslint-plugin-eslint-comments": "^3.2.0",
-    "eslint-plugin-functional": "^4.4.0",
+    "eslint-plugin-functional": "^4.4.1",
     "eslint-plugin-import": "^2.22.1",
     "eslint-plugin-jest": "^27.0.4",
     "eslint-plugin-jest-dom": "^4.0.0",
@@ -40,7 +40,8 @@
     "eslint-plugin-react": "^7.31.8",
     "eslint-plugin-react-hooks": "^4.2.0",
     "eslint-plugin-simple-import-sort": "^8.0.0",
-    "eslint-plugin-testing-library": "^5.7.0"
+    "eslint-plugin-testing-library": "^5.7.0",
+    "eslint-plugin-unicorn": "^42.0.0"
   },
   "devDependencies": {
     "@types/confusing-browser-globals": "1.0.0",
@@ -56,5 +57,5 @@
   "publishConfig": {
     "access": "public"
   },
-  "gitHead": "959a348ec7c5c2373efed4523f1da2193142f071"
+  "gitHead": "0b6e4b29bc99ab8523c726d33f5a8b8531c6ee56"
 }

package/presets/base.js

@@ -64,6 +64,7 @@ module.exports = {
     'eslint-plugin-import',
     'eslint-plugin-jsdoc',
     'eslint-plugin-prettier',
+    'eslint-plugin-unicorn',
   ],
   env: {
     // should align with parserOptions.ecmaVersion
@@ -126,6 +127,8 @@ module.exports = {
     'jsdoc/valid-types': 'off',
     // avoid assigning anonymous function to object key which is harder to trace when debug
     'object-shorthand': ['error', 'always'],
+    // prefer Number static properties over global ones
+    'unicorn/prefer-number-properties': 'error',
   },
   overrides: [
     {
@@ -198,15 +201,20 @@ module.exports = {
                 'error',
                 { prefer: 'type-imports' },
               ],
+              // disable the base rule as it can report incorrect errors, use @typescript-eslint/dot-notation instead
+              'dot-notation': 'off',
+              // only allow indexed syntax (e.g. `obj['key']`) for accessing undefined fields
+              '@typescript-eslint/dot-notation': [
+                'error',
+                {
+                  allowIndexSignaturePropertyAccess: true,
+                },
+              ],
               // encourage to use private accessibility modifier
               '@typescript-eslint/explicit-member-accessibility': [
                 'error',
                 {
                   accessibility: 'explicit',
-                  overrides: {
-                    // don't bother because it is always public
-                    constructors: 'off',
-                  },
                 },
               ],
               // sometimes auto detect can provide a better and narrower type
@@ -272,8 +280,7 @@ module.exports = {
                 },
               ],
               // forbid unnecessary callback wrapper
-              // disabled due to https://github.com/eslint-functional/eslint-plugin-functional/issues/486
-              // 'functional/prefer-tacit': 'error',
+              'functional/prefer-tacit': 'error',
               // @typescript-eslint/eslint-plugin suggests to disable it: https://github.com/typescript-eslint/typescript-eslint/blob/2588e9ea55f78352fdd6ae92a306135aabb49a1a/docs/linting/TROUBLESHOOTING.md#i-get-errors-from-the-no-undef-rule-about-global-variables-not-being-defined-even-though-there-are-no-typescript-errors
               // It is disabled in recommended config but re-enabled here to enforce a subset of global variables that supported by both node.js and browsers
               'no-undef': 'error',