@foray1010/eslint-config 7.3.3 → 7.4.0

package/CHANGELOG.md

@@ -3,6 +3,22 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [7.4.0](https://github.com/foray1010/common-presets/compare/@foray1010/eslint-config@7.3.4...@foray1010/eslint-config@7.4.0) (2022-09-22)
+
+### Features
+
+- **eslint-config:** explicitly import node.js only built-in modules ([969c1d2](https://github.com/foray1010/common-presets/commit/969c1d299a3d092eaa373ba9ceca4d7616076cfc))
+
+### Bug Fixes
+
+- **deps:** update dependency eslint-plugin-jest to v27 ([6534504](https://github.com/foray1010/common-presets/commit/65345046f6300b583d7a7b614ed4285486917e4d))
+
+## [7.3.4](https://github.com/foray1010/common-presets/compare/@foray1010/eslint-config@7.3.3...@foray1010/eslint-config@7.3.4) (2022-08-26)
+
+### Bug Fixes
+
+- **eslint-config:** allow {} type ([930a2fa](https://github.com/foray1010/common-presets/commit/930a2fa03fe5f14435890226266c8b103baa8221))
+
 ## [7.3.3](https://github.com/foray1010/common-presets/compare/@foray1010/eslint-config@7.3.2...@foray1010/eslint-config@7.3.3) (2022-08-24)
 
 **Note:** Version bump only for package @foray1010/eslint-config

package/package.json

@@ -1,7 +1,7 @@
 {
   "$schema": "https://json.schemastore.org/package",
   "name": "@foray1010/eslint-config",
-  "version": "7.3.3",
+  "version": "7.4.0",
   "homepage": "https://github.com/foray1010/common-presets/tree/master/packages/eslint-config#readme",
   "bugs": "https://github.com/foray1010/common-presets/issues",
   "repository": {
@@ -23,7 +23,7 @@
     "type:check": "tsc"
   },
   "dependencies": {
-    "@foray1010/common-presets-utils": "^5.0.2",
+    "@foray1010/common-presets-utils": "^5.0.3",
     "@typescript-eslint/eslint-plugin": "^5.13.0",
     "@typescript-eslint/parser": "^5.13.0",
     "confusing-browser-globals": "^1.0.10",
@@ -31,20 +31,20 @@
     "eslint-plugin-compat": "^4.0.0",
     "eslint-plugin-eslint-comments": "^3.2.0",
     "eslint-plugin-import": "^2.22.1",
-    "eslint-plugin-jest": "^26.0.0",
+    "eslint-plugin-jest": "^27.0.0",
     "eslint-plugin-jest-dom": "^4.0.0",
     "eslint-plugin-jsdoc": "^39.0.0",
     "eslint-plugin-n": "^15.2.2",
     "eslint-plugin-prettier": "^4.0.0",
     "eslint-plugin-react": "^7.23.2",
     "eslint-plugin-react-hooks": "^4.2.0",
-    "eslint-plugin-simple-import-sort": "^7.0.0",
+    "eslint-plugin-simple-import-sort": "^8.0.0",
     "eslint-plugin-testing-library": "^5.3.1"
   },
   "devDependencies": {
     "@types/confusing-browser-globals": "1.0.0",
     "@types/eslint": "8.4.6",
-    "typescript": "4.7.4"
+    "typescript": "4.8.3"
   },
   "peerDependencies": {
     "eslint": "^8.0.0",
@@ -56,5 +56,5 @@
   "publishConfig": {
     "access": "public"
   },
-  "gitHead": "8f4681aea3421297bffa13e0bbbf7f6dba20ca70"
+  "gitHead": "73bd0116236620e7171c9e7c5442afa50bcfbed7"
 }

package/presets/base.js

@@ -5,13 +5,28 @@ const { hasDep, isESM } = require('@foray1010/common-presets-utils')
 
 const { testFileGlobs } = require('./utils/testUtil')
 
-/** @type {import('eslint').Linter.RulesRecord} */
-const esmRules = {
-  'import/extensions': [
-    'error',
-    // https://nodejs.org/docs/latest-v14.x/api/esm.html#esm_mandatory_file_extensions
-    'always',
-  ],
+/** @type {import('eslint').Linter.BaseConfig} */
+const cjsConfig = {
+  parserOptions: {
+    sourceType: 'script',
+  },
+  env: {
+    commonjs: true,
+  },
+}
+
+/** @type {import('eslint').Linter.BaseConfig} */
+const esmConfigForJs = {
+  parserOptions: {
+    sourceType: 'module',
+  },
+  rules: {
+    'import/extensions': [
+      'error',
+      // https://nodejs.org/docs/latest-v14.x/api/esm.html#esm_mandatory_file_extensions
+      'always',
+    ],
+  },
 }
 
 /** @type {import('eslint').Linter.Config} */
@@ -26,7 +41,6 @@ module.exports = {
   ],
   parserOptions: {
     ecmaVersion: 2020,
-    sourceType: 'script',
   },
   plugins: [
     'eslint-plugin-eslint-comments',
@@ -36,7 +50,11 @@ module.exports = {
     'eslint-plugin-simple-import-sort',
   ],
   env: {
-    es6: true,
+    /* Not using `node` to explicitly import node.js only built-in modules, e.g.
+     * import { Buffer } from 'node:buffer'
+     * import process from 'node:process'
+     */
+    'shared-node-browser': true,
   },
   rules: {
     // allow disable eslint rules for whole file without re-enable it in the end of the file
@@ -100,23 +118,15 @@ module.exports = {
   overrides: [
     {
       files: ['*.js'],
-      parserOptions: {
-        sourceType: isESM() ? 'module' : 'script',
-      },
-      rules: isESM() ? esmRules : {},
+      ...(isESM() ? esmConfigForJs : cjsConfig),
     },
     {
       files: ['*.cjs'],
-      parserOptions: {
-        sourceType: 'script',
-      },
+      ...cjsConfig,
     },
     {
       files: ['*.mjs'],
-      parserOptions: {
-        sourceType: 'module',
-      },
-      rules: esmRules,
+      ...esmConfigForJs,
     },
     {
       files: testFileGlobs,
@@ -149,6 +159,17 @@ module.exports = {
             },
             plugins: ['@typescript-eslint/eslint-plugin'],
             rules: {
+              // extend existing rule
+              '@typescript-eslint/ban-types': [
+                'error',
+                {
+                  types: {
+                    // TypeScript team suggests to use `<T extends {}>` https://devblogs.microsoft.com/typescript/announcing-typescript-4-8/#unconstrained-generics-no-longer-assignable-to
+                    '{}': false,
+                  },
+                  extendDefaults: true,
+                },
+              ],
               // separate type imports which allow certain optimizations within compilers
               '@typescript-eslint/consistent-type-imports': [
                 'error',

package/presets/browser.js

@@ -9,6 +9,10 @@ module.exports = {
   env: {
     browser: true,
   },
+  globals: {
+    // keep it until webpack has an official way to define env: https://github.com/webpack/webpack/issues/15833
+    process: 'readonly',
+  },
   rules: {
     'no-restricted-globals': ['error', ...restrictedGlobals],
   },

package/presets/node.js

@@ -3,9 +3,6 @@
 /** @type {import('eslint').Linter.Config} */
 module.exports = {
   plugins: ['eslint-plugin-n'],
-  env: {
-    node: true,
-  },
   rules: {
     // disallow deprecated node APIs
     'n/no-deprecated-api': 'error',