@foray1010/eslint-config 7.11.0 → 8.0.0

package/CHANGELOG.md

@@ -3,6 +3,22 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [8.0.0](https://github.com/foray1010/common-presets/compare/@foray1010/eslint-config@7.12.0...@foray1010/eslint-config@8.0.0) (2022-10-21)
+
+### ⚠ BREAKING CHANGES
+
+- enforce file extension and use native esm typescript
+
+### Features
+
+- enforce file extension and use native esm typescript ([c885710](https://github.com/foray1010/common-presets/commit/c8857103a3f828d2cf9946885495bd92d15b8d5d))
+
+## [7.12.0](https://github.com/foray1010/common-presets/compare/@foray1010/eslint-config@7.11.0...@foray1010/eslint-config@7.12.0) (2022-10-20)
+
+### Features
+
+- **eslint-config:** add checking on circular dependency and self import ([a42e38a](https://github.com/foray1010/common-presets/commit/a42e38a0a08de73265cf70185569b45587284a2f))
+
 ## [7.11.0](https://github.com/foray1010/common-presets/compare/@foray1010/eslint-config@7.10.0...@foray1010/eslint-config@7.11.0) (2022-10-18)
 
 ### Features

package/package.json

@@ -1,7 +1,7 @@
 {
   "$schema": "https://json.schemastore.org/package",
   "name": "@foray1010/eslint-config",
-  "version": "7.11.0",
+  "version": "8.0.0",
   "homepage": "https://github.com/foray1010/common-presets/tree/master/packages/eslint-config#readme",
   "bugs": "https://github.com/foray1010/common-presets/issues",
   "repository": {
@@ -28,6 +28,7 @@
     "@typescript-eslint/parser": "^5.38.1",
     "confusing-browser-globals": "^1.0.10",
     "eslint-config-prettier": "^8.3.0",
+    "eslint-import-resolver-typescript": "^3.5.2",
     "eslint-plugin-compat": "^4.0.0",
     "eslint-plugin-deprecation": "^1.3.2",
     "eslint-plugin-eslint-comments": "^3.2.0",
@@ -58,5 +59,5 @@
   "publishConfig": {
     "access": "public"
   },
-  "gitHead": "084439e84e55f473a6f87f18f4b84c7df94d6a28"
+  "gitHead": "c6310f72bc0c02649d5b7fe7cdb059e1c36e8200"
 }

package/presets/base.js

@@ -3,7 +3,7 @@
 // @ts-expect-error
 const { hasDep, isESM } = require('@foray1010/common-presets-utils')
 
-const { testFileGlobs } = require('./utils/testUtil')
+const { testFileGlobs } = require('./utils/testUtil.js')
 
 /** @type {import('eslint').Linter.BaseConfig} */
 const cjsConfig = {
@@ -33,19 +33,6 @@ const esmConfig = {
   },
 }
 
-/** @type {import('eslint').Linter.BaseConfig} */
-const esmConfigForJs = {
-  ...esmConfig,
-  rules: {
-    ...esmConfig.rules,
-    'import/extensions': [
-      'error',
-      // https://nodejs.org/docs/latest-v14.x/api/esm.html#esm_mandatory_file_extensions
-      'always',
-    ],
-  },
-}
-
 /** @type {import('eslint').Linter.Config} */
 module.exports = {
   extends: [
@@ -84,6 +71,21 @@ module.exports = {
     'func-names': ['error', 'as-needed'],
     // this rule doesn't support commonjs, some dependencies are using commonjs
     'import/default': 'off',
+    // enforce extensions for both cjs and esm
+    'import/extensions': [
+      'error',
+      // https://nodejs.org/docs/latest-v14.x/api/esm.html#esm_mandatory_file_extensions
+      'always',
+      {
+        pattern: {
+          // ignore cts/mts/ts/tsx because typescript uses cjs/mjs/js instead
+          cts: 'never',
+          mts: 'never',
+          ts: 'never',
+          tsx: 'never',
+        },
+      },
+    ],
     // make sure import statements above the others
     'import/first': 'error',
     // separate import statements from the others
@@ -102,6 +104,14 @@ module.exports = {
         allowObject: false,
       },
     ],
+    // no circular dependency
+    'import/no-cycle': [
+      'error',
+      {
+        // speed up linting time
+        ignoreExternal: true,
+      },
+    ],
     // do not allow import packages that are not listed in dependencies or peerDependencies
     'import/no-extraneous-dependencies': [
       'error',
@@ -113,6 +123,8 @@ module.exports = {
         ],
       },
     ],
+    // forbid a module from importing itself
+    'import/no-self-import': 'error',
     // use the shortest path in import statement, but allow /index because it will be standard to omit index as default file in directory
     'import/no-useless-path-segments': [
       'error',
@@ -133,7 +145,7 @@ module.exports = {
   overrides: [
     {
       files: ['*.js'],
-      ...(isESM() ? esmConfigForJs : cjsConfig),
+      ...(isESM() ? esmConfig : cjsConfig),
     },
     {
       files: ['*.cjs'],
@@ -141,7 +153,7 @@ module.exports = {
     },
     {
       files: ['*.mjs'],
-      ...esmConfigForJs,
+      ...esmConfig,
     },
     {
       files: testFileGlobs,
@@ -176,15 +188,16 @@ module.exports = {
               // allowAutomaticSingleRunInference: true,
               project: ['./tsconfig*.json', './packages/*/tsconfig*.json'],
             },
+            settings: {
+              'import/resolver': {
+                typescript: true,
+              },
+            },
             plugins: [
               '@typescript-eslint/eslint-plugin',
               'eslint-plugin-deprecation',
               'eslint-plugin-functional',
             ],
-            env: {
-              // allow commonjs globals as we haven't moved to es modules
-              commonjs: true,
-            },
             rules: {
               // extend existing rule
               '@typescript-eslint/ban-types': [

package/presets/node.js

@@ -1,13 +1,20 @@
 'use strict'
 
+// @ts-expect-error
+const { isESM } = require('@foray1010/common-presets-utils')
+
+/** @type {import('eslint').Linter.BaseConfig} */
+const cjsConfig = {
+  globals: {
+    __dirname: 'readonly',
+    __filename: 'readonly',
+  },
+}
+
 /** @type {import('eslint').Linter.Config} */
 module.exports = {
   plugins: ['eslint-plugin-n'],
   globals: {
-    // used in commonjs and typescript
-    __dirname: 'readonly',
-    // used in commonjs and typescript
-    __filename: 'readonly',
     // hack to mute no-undef error, and show n/prefer-global/buffer error instead
     Buffer: 'readonly',
     // hack to mute no-undef error, and show n/prefer-global/process error instead
@@ -41,4 +48,14 @@ module.exports = {
     // enforce shebang on the entry bin file
     'n/shebang': 'error',
   },
+  overrides: [
+    {
+      files: ['*.js'],
+      ...(isESM() ? {} : cjsConfig),
+    },
+    {
+      files: ['*.cjs', '*.cts'],
+      ...cjsConfig,
+    },
+  ],
 }

package/presets/react.js

@@ -1,6 +1,6 @@
 'use strict'
 
-const { testFileGlobs } = require('./utils/testUtil')
+const { testFileGlobs } = require('./utils/testUtil.js')
 
 /** @type {import('eslint').Linter.Config} */
 module.exports = {