@foray1010/eslint-config 7.10.0 → 7.12.0

package/CHANGELOG.md

@@ -3,6 +3,18 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [7.12.0](https://github.com/foray1010/common-presets/compare/@foray1010/eslint-config@7.11.0...@foray1010/eslint-config@7.12.0) (2022-10-20)
+
+### Features
+
+- **eslint-config:** add checking on circular dependency and self import ([a42e38a](https://github.com/foray1010/common-presets/commit/a42e38a0a08de73265cf70185569b45587284a2f))
+
+## [7.11.0](https://github.com/foray1010/common-presets/compare/@foray1010/eslint-config@7.10.0...@foray1010/eslint-config@7.11.0) (2022-10-18)
+
+### Features
+
+- **eslint-config:** encourage to use JS standard #private in TSParameterProperty ([2f7b7f6](https://github.com/foray1010/common-presets/commit/2f7b7f6665f3fc520fc1a87878b2e5730e33b9aa))
+
 ## [7.10.0](https://github.com/foray1010/common-presets/compare/@foray1010/eslint-config@7.9.0...@foray1010/eslint-config@7.10.0) (2022-10-18)
 
 ### Features

package/package.json

@@ -1,7 +1,7 @@
 {
   "$schema": "https://json.schemastore.org/package",
   "name": "@foray1010/eslint-config",
-  "version": "7.10.0",
+  "version": "7.12.0",
   "homepage": "https://github.com/foray1010/common-presets/tree/master/packages/eslint-config#readme",
   "bugs": "https://github.com/foray1010/common-presets/issues",
   "repository": {
@@ -58,5 +58,5 @@
   "publishConfig": {
     "access": "public"
   },
-  "gitHead": "95efcde57421305c554daf6fe3704e8abe10a000"
+  "gitHead": "122e9b3aaffb9257c1c119d0f60352a8ca006414"
 }

package/presets/base.js

@@ -102,6 +102,14 @@ module.exports = {
         allowObject: false,
       },
     ],
+    // no circular dependency
+    'import/no-cycle': [
+      'error',
+      {
+        // speed up linting time
+        ignoreExternal: true,
+      },
+    ],
     // do not allow import packages that are not listed in dependencies or peerDependencies
     'import/no-extraneous-dependencies': [
       'error',
@@ -113,6 +121,8 @@ module.exports = {
         ],
       },
     ],
+    // forbid a module from importing itself
+    'import/no-self-import': 'error',
     // use the shortest path in import statement, but allow /index because it will be standard to omit index as default file in directory
     'import/no-useless-path-segments': [
       'error',
@@ -289,7 +299,7 @@ module.exports = {
                 {
                   // encourage to use JS standard #private over TS private accessibility modifier, but excluding constructor because it cannot be private in JS: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Classes/Private_class_fields#description
                   selector:
-                    ':matches(PropertyDefinition, MethodDefinition)[accessibility="private"]:not([kind="constructor"])',
+                    ':matches(PropertyDefinition, MethodDefinition, TSParameterProperty)[accessibility="private"]:not([kind="constructor"])',
                   message:
                     'Use #private instead (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Classes/Private_class_fields)',
                 },