@foray1010/eslint-config 7.1.0 → 7.3.1

package/CHANGELOG.md

@@ -3,6 +3,26 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [7.3.1](https://github.com/foray1010/common-presets/compare/@foray1010/eslint-config@7.3.0...@foray1010/eslint-config@7.3.1) (2022-07-28)
+
+### Bug Fixes
+
+- **eslint-config:** allow arrow function in object ([2b7549b](https://github.com/foray1010/common-presets/commit/2b7549ba63f8b9697300becb99504b736c833c23))
+
+## [7.3.0](https://github.com/foray1010/common-presets/compare/@foray1010/eslint-config@7.2.0...@foray1010/eslint-config@7.3.0) (2022-07-28)
+
+### Features
+
+- **eslint-config:** use jest/unbound-method for tests ([babe1d7](https://github.com/foray1010/common-presets/commit/babe1d7f9f9f208f60cb08e5ec52ac6b93136644))
+
+## [7.2.0](https://github.com/foray1010/common-presets/compare/@foray1010/eslint-config@7.1.0...@foray1010/eslint-config@7.2.0) (2022-07-27)
+
+### Features
+
+- **eslint-config:** reenable @typescript-eslint/restrict-template-expressions ([772d768](https://github.com/foray1010/common-presets/commit/772d76811189b79efc0c49dcb4225ca6741da26c))
+- **eslint-config:** reenable @typescript-eslint/unbound-method ([8451f92](https://github.com/foray1010/common-presets/commit/8451f92d0a983a84bbb7181d75652bab84e6bedc))
+- **eslint-config:** separate type imports which allow certain optimizations within compilers ([15a15c9](https://github.com/foray1010/common-presets/commit/15a15c9f57dc9b58e52109d523b95df15c725b8e))
+
 ## [7.1.0](https://github.com/foray1010/common-presets/compare/@foray1010/eslint-config@7.0.1...@foray1010/eslint-config@7.1.0) (2022-06-14)
 
 ### Features

package/package.json

@@ -1,7 +1,7 @@
 {
   "$schema": "https://json.schemastore.org/package",
   "name": "@foray1010/eslint-config",
-  "version": "7.1.0",
+  "version": "7.3.1",
   "homepage": "https://github.com/foray1010/common-presets/tree/master/packages/eslint-config#readme",
   "bugs": "https://github.com/foray1010/common-presets/issues",
   "repository": {
@@ -48,5 +48,5 @@
   "publishConfig": {
     "access": "public"
   },
-  "gitHead": "575dc4e4b5d4d3cbb4f2a66f482baffa7655c1b5"
+  "gitHead": "cc2b4de0c590bf0c168149ca38e5c49c384a9b3d"
 }

package/presets/base.js

@@ -84,13 +84,7 @@ module.exports = {
     // do not enforce JSDoc for internal methods
     'jsdoc/require-jsdoc': 'off',
     // avoid assigning anonymous function to object key which is harder to trace when debug
-    'object-shorthand': [
-      'error',
-      'always',
-      {
-        avoidExplicitReturnArrows: true,
-      },
-    ],
+    'object-shorthand': ['error', 'always'],
     // auto sort export statements
     'simple-import-sort/exports': 'error',
     // auto sort import statements
@@ -149,6 +143,11 @@ module.exports = {
             },
             plugins: ['@typescript-eslint/eslint-plugin'],
             rules: {
+              // separate type imports which allow certain optimizations within compilers
+              '@typescript-eslint/consistent-type-imports': [
+                'error',
+                { prefer: 'type-imports' },
+              ],
               // encourage to use private accessibility modifier
               '@typescript-eslint/explicit-member-accessibility': [
                 'error',
@@ -183,8 +182,6 @@ module.exports = {
               '@typescript-eslint/no-unsafe-member-access': 'off',
               // some third party packages doesn't offer typings
               '@typescript-eslint/no-unsafe-return': 'off',
-              // must remove unused variables and types
-              '@typescript-eslint/no-unused-vars': 'error',
               // do not block functions referring to other functions
               '@typescript-eslint/no-use-before-define': [
                 'error',
@@ -205,11 +202,22 @@ module.exports = {
               ],
               // fault alarms in 4.29.3
               '@typescript-eslint/restrict-plus-operands': 'off',
-              // 1. mistakenly recognize string as any in 4.29.3
-              // 2. allow `any` to be used in template string
-              '@typescript-eslint/restrict-template-expressions': 'off',
-              // redundant for composing functions
-              '@typescript-eslint/unbound-method': 'off',
+              // allow primitive value in template string
+              '@typescript-eslint/restrict-template-expressions': [
+                'error',
+                {
+                  allowNumber: true,
+                  allowBoolean: true,
+                  allowAny: true, // mistakenly recognize string as any in 4.29.3
+                  allowNullish: true,
+                  allowRegExp: true,
+                },
+              ],
+              // ignore static function as those are not supposed to use `this`
+              '@typescript-eslint/unbound-method': [
+                'error',
+                { ignoreStatic: true },
+              ],
             },
             overrides: [
               {
@@ -217,6 +225,10 @@ module.exports = {
                 rules: {
                   // doesn't work with jest.fn<void>()
                   '@typescript-eslint/no-invalid-void-type': 'off',
+                  // replace by jest/unbound-method
+                  '@typescript-eslint/unbound-method': 'off',
+                  // allow passing an unbound method to `expect` calls
+                  'jest/unbound-method': ['error', { ignoreStatic: true }],
                 },
               },
             ],