@foray1010/eslint-config 7.0.1 → 7.3.0

package/CHANGELOG.md

@@ -3,6 +3,26 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [7.3.0](https://github.com/foray1010/common-presets/compare/@foray1010/eslint-config@7.2.0...@foray1010/eslint-config@7.3.0) (2022-07-28)
+
+### Features
+
+- **eslint-config:** use jest/unbound-method for tests ([babe1d7](https://github.com/foray1010/common-presets/commit/babe1d7f9f9f208f60cb08e5ec52ac6b93136644))
+
+## [7.2.0](https://github.com/foray1010/common-presets/compare/@foray1010/eslint-config@7.1.0...@foray1010/eslint-config@7.2.0) (2022-07-27)
+
+### Features
+
+- **eslint-config:** reenable @typescript-eslint/restrict-template-expressions ([772d768](https://github.com/foray1010/common-presets/commit/772d76811189b79efc0c49dcb4225ca6741da26c))
+- **eslint-config:** reenable @typescript-eslint/unbound-method ([8451f92](https://github.com/foray1010/common-presets/commit/8451f92d0a983a84bbb7181d75652bab84e6bedc))
+- **eslint-config:** separate type imports which allow certain optimizations within compilers ([15a15c9](https://github.com/foray1010/common-presets/commit/15a15c9f57dc9b58e52109d523b95df15c725b8e))
+
+## [7.1.0](https://github.com/foray1010/common-presets/compare/@foray1010/eslint-config@7.0.1...@foray1010/eslint-config@7.1.0) (2022-06-14)
+
+### Features
+
+- avoid unnecessary closing tags ([602dd20](https://github.com/foray1010/common-presets/commit/602dd2071393ee0ee584eba06de9cb122a91b203))
+
 ## [7.0.1](https://github.com/foray1010/common-presets/compare/@foray1010/eslint-config@7.0.0...@foray1010/eslint-config@7.0.1) (2022-06-13)
 
 ### Bug Fixes

package/package.json

@@ -1,7 +1,7 @@
 {
   "$schema": "https://json.schemastore.org/package",
   "name": "@foray1010/eslint-config",
-  "version": "7.0.1",
+  "version": "7.3.0",
   "homepage": "https://github.com/foray1010/common-presets/tree/master/packages/eslint-config#readme",
   "bugs": "https://github.com/foray1010/common-presets/issues",
   "repository": {
@@ -48,5 +48,5 @@
   "publishConfig": {
     "access": "public"
   },
-  "gitHead": "162f905054a12ba6777eb746f2f440a68876463c"
+  "gitHead": "1a8bec3ae717a3e1d87041091475f3346476b1a3"
 }

package/presets/base.js

@@ -149,6 +149,11 @@ module.exports = {
             },
             plugins: ['@typescript-eslint/eslint-plugin'],
             rules: {
+              // separate type imports which allow certain optimizations within compilers
+              '@typescript-eslint/consistent-type-imports': [
+                'error',
+                { prefer: 'type-imports' },
+              ],
               // encourage to use private accessibility modifier
               '@typescript-eslint/explicit-member-accessibility': [
                 'error',
@@ -183,8 +188,6 @@ module.exports = {
               '@typescript-eslint/no-unsafe-member-access': 'off',
               // some third party packages doesn't offer typings
               '@typescript-eslint/no-unsafe-return': 'off',
-              // must remove unused variables and types
-              '@typescript-eslint/no-unused-vars': 'error',
               // do not block functions referring to other functions
               '@typescript-eslint/no-use-before-define': [
                 'error',
@@ -205,11 +208,22 @@ module.exports = {
               ],
               // fault alarms in 4.29.3
               '@typescript-eslint/restrict-plus-operands': 'off',
-              // 1. mistakenly recognize string as any in 4.29.3
-              // 2. allow `any` to be used in template string
-              '@typescript-eslint/restrict-template-expressions': 'off',
-              // redundant for composing functions
-              '@typescript-eslint/unbound-method': 'off',
+              // allow primitive value in template string
+              '@typescript-eslint/restrict-template-expressions': [
+                'error',
+                {
+                  allowNumber: true,
+                  allowBoolean: true,
+                  allowAny: true, // mistakenly recognize string as any in 4.29.3
+                  allowNullish: true,
+                  allowRegExp: true,
+                },
+              ],
+              // ignore static function as those are not supposed to use `this`
+              '@typescript-eslint/unbound-method': [
+                'error',
+                { ignoreStatic: true },
+              ],
             },
             overrides: [
               {
@@ -217,6 +231,10 @@ module.exports = {
                 rules: {
                   // doesn't work with jest.fn<void>()
                   '@typescript-eslint/no-invalid-void-type': 'off',
+                  // replace by jest/unbound-method
+                  '@typescript-eslint/unbound-method': 'off',
+                  // allow passing an unbound method to `expect` calls
+                  'jest/unbound-method': ['error', { ignoreStatic: true }],
                 },
               },
             ],

package/presets/react.js

@@ -43,6 +43,8 @@ module.exports = {
     ],
     // rely on typescript instead, and it does not work well with types that are imported from elsewhere
     'react/prop-types': 'off',
+    // avoid unnecessary closing tags
+    'react/self-closing-comp': 'error',
     'react-hooks/exhaustive-deps': [
       'error',
       {