@foray1010/eslint-config 6.2.0 → 6.4.0

package/CHANGELOG.md

@@ -3,6 +3,29 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [6.4.0](https://github.com/foray1010/common-presets/compare/@foray1010/eslint-config@6.3.1...@foray1010/eslint-config@6.4.0) (2022-04-25)
+
+### Features
+
+- **eslint-config:** add more rules for jest ([9e7b466](https://github.com/foray1010/common-presets/commit/9e7b466c332d90d56e5d41d4a006147148c3ae32))
+
+### [6.3.1](https://github.com/foray1010/common-presets/compare/@foray1010/eslint-config@6.3.0...@foray1010/eslint-config@6.3.1) (2022-04-25)
+
+### Bug Fixes
+
+- allow unnecessary fragment for single expression ([3208164](https://github.com/foray1010/common-presets/commit/320816415a3554c96a71275b0f36444bc9495259))
+
+## [6.3.0](https://github.com/foray1010/common-presets/compare/@foray1010/eslint-config@6.2.0...@foray1010/eslint-config@6.3.0) (2022-04-25)
+
+### Features
+
+- enable testing-library/no-global-regexp-flag-in-query ([6343da2](https://github.com/foray1010/common-presets/commit/6343da2038fca9c5ef03aa2ae02129f42ff00b82))
+- reenable testing-library/no-await-sync-events for fire events only ([966eb24](https://github.com/foray1010/common-presets/commit/966eb24ad9c3f7b15cb3c856de61516dace2075b))
+
+### Bug Fixes
+
+- **eslint-config:** use jsx-runtime config from react plugin ([806e1ab](https://github.com/foray1010/common-presets/commit/806e1ab25ac42b0bb5a269e01eef659bc12aa616))
+
 ## [6.2.0](https://github.com/foray1010/common-presets/compare/@foray1010/eslint-config@6.1.3...@foray1010/eslint-config@6.2.0) (2022-04-05)
 
 ### Features

package/package.json

@@ -1,7 +1,7 @@
 {
   "$schema": "https://json.schemastore.org/package",
   "name": "@foray1010/eslint-config",
-  "version": "6.2.0",
+  "version": "6.4.0",
   "homepage": "https://github.com/foray1010/common-presets/tree/master/packages/eslint-config#readme",
   "bugs": "https://github.com/foray1010/common-presets/issues",
   "repository": {
@@ -36,7 +36,7 @@
     "eslint-plugin-react": "^7.23.2",
     "eslint-plugin-react-hooks": "^4.2.0",
     "eslint-plugin-simple-import-sort": "^7.0.0",
-    "eslint-plugin-testing-library": "^5.0.0"
+    "eslint-plugin-testing-library": "^5.3.1"
   },
   "peerDependencies": {
     "eslint": ">=7.28.0 <9",
@@ -48,5 +48,5 @@
   "publishConfig": {
     "access": "public"
   },
-  "gitHead": "4ef900b508bad3ab5f5c29a904ddd9021af43310"
+  "gitHead": "d6a5e814c1bccdcdd2a8a6c5de9036ca14cac6d4"
 }

package/presets/base.js

@@ -124,8 +124,12 @@ module.exports = {
     },
     {
       files: testFileGlobs,
-      extends: ['plugin:jest/recommended'],
+      extends: ['plugin:jest/recommended', 'plugin:jest/style'],
       plugins: ['eslint-plugin-jest'],
+      rules: {
+        // make sure lifecycle hooks on the top for readability
+        'jest/prefer-hooks-on-top': 'error',
+      },
     },
     // typescript plugins are depended on `typescript` package
     ...(hasDep('typescript')

package/presets/react.js

@@ -3,7 +3,11 @@
 const { testFileGlobs } = require('./utils/testUtil')
 
 module.exports = {
-  extends: ['plugin:react/recommended', 'eslint-config-prettier'],
+  extends: [
+    'plugin:react/recommended',
+    'plugin:react/jsx-runtime',
+    'eslint-config-prettier',
+  ],
   parserOptions: {
     sourceType: 'module',
     ecmaFeatures: {
@@ -17,7 +21,13 @@ module.exports = {
     },
   },
   rules: {
-    'react/jsx-no-useless-fragment': 'error',
+    'react/jsx-no-useless-fragment': [
+      'error',
+      {
+        // allow unnecessary fragment for single expression to bypass some typescript errors (e.g. do not allow string and only allow react element)
+        allowExpressions: true,
+      },
+    ],
     'react/jsx-sort-props': [
       'error',
       {
@@ -32,8 +42,6 @@ module.exports = {
     ],
     // rely on typescript instead, and it does not work well with types that are imported from elsewhere
     'react/prop-types': 'off',
-    // because we are using automatic react runtime
-    'react/react-in-jsx-scope': 'off',
     'react-hooks/rules-of-hooks': 'error',
     'react-hooks/exhaustive-deps': [
       'error',
@@ -51,15 +59,16 @@ module.exports = {
       plugins: ['eslint-plugin-jest-dom', 'eslint-plugin-testing-library'],
       rules: {
         // avoid using unnecessary `await` as workaround for `not wrapped in act(...)` warnings
-        'testing-library/no-wait-for-empty-callback': 'error',
-        // avoid side effects inside `waitFor`
-        'testing-library/no-wait-for-snapshot': 'error',
+        'testing-library/no-await-sync-events': [
+          'error',
+          {
+            eventModules: ['fire-event'],
+          },
+        ],
+        // global flag /g holds state and might cause false-positives while querying for elements
+        'testing-library/no-global-regexp-flag-in-query': 'error',
         // explicitly assert the element to prevent reader missed the test cases
         'testing-library/prefer-explicit-assert': 'error',
-        // better error message
-        'testing-library/prefer-presence-queries': 'error',
-        // using `screen` to avoid name collision
-        'testing-library/prefer-screen-queries': 'error',
         // prefer @testing-library/user-event over fireEvent
         'testing-library/prefer-user-event': 'error',
         // as `wait` is deprecated