@foray1010/eslint-config 13.0.3 → 14.0.1

package/CHANGELOG.md

@@ -3,6 +3,31 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [14.0.1](https://github.com/foray1010/common-presets/compare/@foray1010/eslint-config@14.0.0...@foray1010/eslint-config@14.0.1) (2025-03-11)
+
+### Bug Fixes
+
+- **eslint-config:** drop eslint-plugin-functional ([fdc506c](https://github.com/foray1010/common-presets/commit/fdc506cf24792dfb55a2c39e7f96a49cd76044af))
+
+## [14.0.0](https://github.com/foray1010/common-presets/compare/@foray1010/eslint-config@13.0.3...@foray1010/eslint-config@14.0.0) (2025-03-11)
+
+### ⚠ BREAKING CHANGES
+
+- **deps:** require nodejs `^20.10.0 || >=22.11.0`
+- **deps:** require eslint `^9.21.0`
+
+### Features
+
+- **eslint-config:** forbid ts enum ([7613ca0](https://github.com/foray1010/common-presets/commit/7613ca06b492dc5f71d562a1ce5b9810b60ab46f))
+- **eslint-config:** report unused disable directives and inline configs ([7bcd4d2](https://github.com/foray1010/common-presets/commit/7bcd4d264826c2c8640c6ad6bed9083761432410))
+
+### Bug Fixes
+
+- **deps:** update dependency eslint-plugin-functional to v9 ([e1a3751](https://github.com/foray1010/common-presets/commit/e1a3751a4e14d9bde401643be837f98877898129))
+- **deps:** update dependency eslint-plugin-unicorn to v9 ([c679289](https://github.com/foray1010/common-presets/commit/c679289daa61df03cde537947a7c0f51935ff626))
+- **eslint-config:** remove duplicated typescript-eslint rules ([df34e55](https://github.com/foray1010/common-presets/commit/df34e5519ac288b552e06b6d7cd00b6fb2928085))
+- **eslint-config:** update dependencies ([b88f45c](https://github.com/foray1010/common-presets/commit/b88f45cc4cc78a45525e329c059e64940f717687))
+
 ## [13.0.3](https://github.com/foray1010/common-presets/compare/@foray1010/eslint-config@13.0.2...@foray1010/eslint-config@13.0.3) (2025-01-19)
 
 ### Bug Fixes

package/bases/base.mjs

@@ -23,9 +23,6 @@ async function generateTypeScriptConfig() {
 
   // eslint-disable-next-line import-x/no-unresolved
   const tseslint = (await import('typescript-eslint')).default
-  // eslint-disable-next-line import-x/no-unresolved
-  const eslintPluginFunctional = (await import('eslint-plugin-functional'))
-    .default
 
   return [
     // @ts-expect-error `Type 'Config' is not assignable to type 'Readonly<FlatConfig<RulesRecord>>' with 'exactOptionalPropertyTypes: true'`
@@ -50,9 +47,6 @@ async function generateTypeScriptConfig() {
           typescript: true,
         },
       },
-      plugins: {
-        functional: eslintPluginFunctional,
-      },
       rules: {
         ...eslintPluginImportX.configs['typescript']?.rules,
         // separate type exports which allow certain optimizations within compilers
@@ -87,14 +81,8 @@ async function generateTypeScriptConfig() {
             accessibility: 'explicit',
           },
         ],
-        // sometimes auto detect can provide a better and narrower type
-        '@typescript-eslint/explicit-module-boundary-types': 'off',
         // do not allow usage of deprecated code
         '@typescript-eslint/no-deprecated': 'error',
-        // disallow duplicated value in enum as it is error-prone
-        '@typescript-eslint/no-duplicate-enum-values': 'error',
-        // need empty function for react context default value
-        '@typescript-eslint/no-empty-function': 'off',
         // TypeScript team suggests to use `<T extends {}>` https://devblogs.microsoft.com/typescript/announcing-typescript-4-8/#unconstrained-generics-no-longer-assignable-to
         '@typescript-eslint/no-empty-object-type': 'off',
         // when using typescript 5.0 with verbatimModuleSyntax flag on, compiler will not remove import statements with only inline type imports which lead to side effects
@@ -106,15 +94,6 @@ async function generateTypeScriptConfig() {
           'error',
           { checksVoidReturn: false },
         ],
-        // declaration merging between classes and interfaces is unsafe
-        '@typescript-eslint/no-unsafe-declaration-merging': 'error',
-        '@typescript-eslint/no-unused-vars': [
-          'error',
-          {
-            // error is optional now
-            caughtErrors: 'all',
-          },
-        ],
         // do not block functions referring to other functions
         '@typescript-eslint/no-use-before-define': [
           'error',
@@ -126,7 +105,6 @@ async function generateTypeScriptConfig() {
             variables: true,
 
             /* options from @typescript-eslint/no-use-before-define */
-            enums: true,
             // confusing option, it will disable `typedefs`
             ignoreTypeReferences: false,
             // tsc allows types to be used before define
@@ -135,62 +113,10 @@ async function generateTypeScriptConfig() {
         ],
         // make sure functions which return a promise will just return a rejected promise instead of throwing an error
         '@typescript-eslint/promise-function-async': 'error',
-        // allow primitive value in template string
-        '@typescript-eslint/restrict-template-expressions': [
-          'error',
-          {
-            allowNumber: true,
-            allowBoolean: true,
-            allowAny: true, // mistakenly recognize string as any in 4.29.3
-            allowNullish: true,
-            allowRegExp: true,
-          },
-        ],
         // avoid missed switch-case by requiring switch-case statements to be exhaustive with union type
         '@typescript-eslint/switch-exhaustiveness-check': 'error',
         // ignore static function as those are not supposed to use `this`
         '@typescript-eslint/unbound-method': ['error', { ignoreStatic: true }],
-        // use with functional/type-declaration-immutability
-        'functional/prefer-immutable-types': [
-          'error',
-          {
-            // as there is no native way to achieve `ReadonlyDeep` in TypeScript
-            enforcement: 'ReadonlyShallow',
-            // reduce the difficult to use this rule
-            ignoreInferredTypes: true,
-            // escape hatch without using eslint-disable
-            ignoreNamePattern: /Mutable$/u.source,
-            ignoreTypePattern: [
-              /^React\./u.source, // Some React types does not work with `Readonly`
-            ],
-          },
-        ],
-        // forbid unnecessary callback wrapper
-        'functional/prefer-tacit': 'error',
-        // use with functional/prefer-immutable-types
-        'functional/type-declaration-immutability': [
-          'error',
-          {
-            rules: [
-              {
-                identifiers: '.+',
-                immutability: 'ReadonlyShallow',
-                comparator: 'AtLeast',
-                // modified from https://github.com/eslint-functional/eslint-plugin-functional/blob/main/docs/rules/type-declaration-immutability.md#preset-overrides
-                fixer: [
-                  {
-                    pattern: /^(Array|Map|Set)<(.+)>$/u.source,
-                    replace: /Readonly\$1<\$2>/u.source,
-                  },
-                  {
-                    pattern: /^(.+)$/u.source,
-                    replace: /Readonly<\$1>/u.source,
-                  },
-                ],
-              },
-            ],
-          },
-        ],
         'no-restricted-syntax': [
           'error',
           {
@@ -200,6 +126,11 @@ async function generateTypeScriptConfig() {
             message:
               'Use #private instead (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Classes/Private_class_fields)',
           },
+          {
+            selector: 'TSEnumDeclaration',
+            message:
+              '"Use string literals with unions or `as const` instead because they work with Node.js type stripping, see https://news.ycombinator.com/item?id=42767627',
+          },
         ],
         // @typescript-eslint/eslint-plugin suggests to disable it: https://github.com/typescript-eslint/typescript-eslint/blob/2588e9ea55f78352fdd6ae92a306135aabb49a1a/docs/linting/TROUBLESHOOTING.md#i-get-errors-from-the-no-undef-rule-about-global-variables-not-being-defined-even-though-there-are-no-typescript-errors
         // It is disabled in recommended config but re-enabled here to enforce a subset of global variables that supported by both node.js and browsers
@@ -331,6 +262,10 @@ const baseConfig = [
     },
   },
   {
+    linterOptions: {
+      reportUnusedDisableDirectives: 'error',
+      reportUnusedInlineConfigs: 'error',
+    },
     languageOptions: {
       ecmaVersion: 2023,
       globals: {

package/package.json

@@ -1,7 +1,7 @@
 {
   "$schema": "https://json.schemastore.org/package",
   "name": "@foray1010/eslint-config",
-  "version": "13.0.3",
+  "version": "14.0.1",
   "homepage": "https://github.com/foray1010/common-presets/tree/master/packages/eslint-config#readme",
   "bugs": "https://github.com/foray1010/common-presets/issues",
   "repository": {
@@ -20,36 +20,34 @@
     "type:check": "tsc"
   },
   "dependencies": {
-    "@eslint-community/eslint-plugin-eslint-comments": "^4.4.0",
-    "@eslint/js": "^9.9.1",
+    "@eslint-community/eslint-plugin-eslint-comments": "^4.4.1",
+    "@eslint/js": "^9.21.0",
     "@foray1010/common-presets-utils": "^8.0.0",
     "confusing-browser-globals": "^1.0.11",
-    "eslint-config-prettier": "^10.0.0",
-    "eslint-import-resolver-typescript": "^3.6.3",
-    "eslint-plugin-compat": "^6.0.0",
-    "eslint-plugin-functional": "^8.0.0",
-    "eslint-plugin-import-x": "^4.1.0",
-    "eslint-plugin-jest": "^28.8.0",
-    "eslint-plugin-jest-dom": "^5.4.0",
-    "eslint-plugin-n": "^17.10.2",
-    "eslint-plugin-prettier": "^5.2.1",
-    "eslint-plugin-react": "^7.35.0",
-    "eslint-plugin-react-hooks": "^5.0.0",
-    "eslint-plugin-regexp": "^2.6.0",
+    "eslint-config-prettier": "^10.0.2",
+    "eslint-import-resolver-typescript": "^3.8.3",
+    "eslint-plugin-compat": "^6.0.2",
+    "eslint-plugin-import-x": "^4.6.1",
+    "eslint-plugin-jest": "^28.11.0",
+    "eslint-plugin-jest-dom": "^5.5.0",
+    "eslint-plugin-n": "^17.15.1",
+    "eslint-plugin-prettier": "^5.2.3",
+    "eslint-plugin-react": "^7.37.4",
+    "eslint-plugin-react-hooks": "^5.2.0",
+    "eslint-plugin-regexp": "^2.7.0",
     "eslint-plugin-simple-import-sort": "^12.1.1",
-    "eslint-plugin-testing-library": "^7.0.0",
-    "eslint-plugin-unicorn": "^56.0.0",
-    "globals": "^15.9.0",
-    "typescript-eslint": "^8.3.0"
+    "eslint-plugin-testing-library": "^7.1.1",
+    "eslint-plugin-unicorn": "^57.0.0",
+    "globals": "^16.0.0",
+    "typescript-eslint": "^8.25.0"
   },
   "devDependencies": {
     "@types/confusing-browser-globals": "1.0.3",
-    "@types/eslint": "9.6.1",
-    "@types/eslint__js": "8.42.3"
+    "@types/eslint": "9.6.1"
   },
   "peerDependencies": {
     "@testing-library/dom": "^10.0.0",
-    "eslint": "^9.0.0",
+    "eslint": "^9.21.0",
     "prettier": "^3.0.0",
     "typescript": "^5.0.2"
   },
@@ -62,10 +60,10 @@
     }
   },
   "engines": {
-    "node": "^18.18.0 || >=20.9.0"
+    "node": "^20.10.0 || >=22.11.0"
   },
   "publishConfig": {
     "access": "public"
   },
-  "gitHead": "e5f6eec0c99af66a5a03cda9486cd3ceba8dcb06"
+  "gitHead": "c636af09fd413eaa3c2936b2e2b4d32daac1ef0c"
 }